<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98516</bug_id>
          
          <creation_ts>2012-10-05 06:53:10 -0700</creation_ts>
          <short_desc>[EFL][WK2] Avoid useless converting to WKPage</short_desc>
          <delta_ts>2012-10-08 12:10:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jinwoo Song">jinwoo7.song</reporter>
          <assigned_to name="Jinwoo Song">jinwoo7.song</assigned_to>
          <cc>cdumez</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>735610</commentid>
    <comment_count>0</comment_count>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-05 06:53:10 -0700</bug_when>
    <thetext>We do not need to convert to WKPage but can use priv-&gt;PageProxy in ewk_view.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735613</commentid>
    <comment_count>1</comment_count>
      <attachid>167322</attachid>
    <who name="Jinwoo Song">jinwoo7.song</who>
    <bug_when>2012-10-05 06:57:21 -0700</bug_when>
    <thetext>Created attachment 167322
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736886</commentid>
    <comment_count>2</comment_count>
      <attachid>167322</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-08 11:54:43 -0700</bug_when>
    <thetext>Comment on attachment 167322
Patch

rs=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736892</commentid>
    <comment_count>3</comment_count>
      <attachid>167322</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-08 11:58:11 -0700</bug_when>
    <thetext>Comment on attachment 167322
Patch

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736912</commentid>
    <comment_count>4</comment_count>
      <attachid>167322</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-08 12:10:53 -0700</bug_when>
    <thetext>Comment on attachment 167322
Patch

Clearing flags on attachment: 167322

Committed r130671: &lt;http://trac.webkit.org/changeset/130671&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>736913</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-08 12:10:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167322</attachid>
            <date>2012-10-05 06:57:21 -0700</date>
            <delta_ts>2012-10-08 12:10:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-98516-20121005225626.patch</filename>
            <type>text/plain</type>
            <size>2022</size>
            <attacher name="Jinwoo Song">jinwoo7.song</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjA4MzU1NTc2NzdlYzIz
NTMxNjhlOWZiYjU5YzNiZWU1MzkyNzM4Mi4uNTZmZWU4MzE2N2QyMjMxZTc0Zjg4MTg1NDVlN2Ni
ZWI5NjIwM2Q4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTA1ICBKaW53
b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd
IEF2b2lkIHVzZWxlc3MgY29udmVydGluZyB0byBXS1BhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHByaXYtPnBhZ2VQcm94eS0+ZmluZFN0cmlu
ZygpIGFuZCBwcml2LT5wYWdlUHJveHktPmhpZGVGaW5kVUkoKQorICAgICAgICB0byBhdm9pZCB1
c2VsZXNzIGNvbnZlcnRpbmcgdG8gV0suCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9l
d2tfdmlldy5jcHA6CisgICAgICAgIChld2tfdmlld190ZXh0X2ZpbmQpOgorICAgICAgICAoZXdr
X3ZpZXdfdGV4dF9maW5kX2hpZ2hsaWdodF9jbGVhcik6CisKIDIwMTItMTAtMDUgIEpvbmdzZW9r
IFlhbmcgIDxqczQ1LnlhbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBSZW1v
dmUgIndlYiIgd29yZCBmcm9tIGV3a193ZWJfZXJyb3IgQVBJcwpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDc0ZjVlYjk2ZWJhMTk4OTZjYzAz
MjcyZTBhN2ViOGJhMzc4YWQ2Y2EuLjg4ZDBmN2ZlNWI4NWJjMzU0MTI1OWI1NWY4MmRjMDE1MTBl
YjYzMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192
aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5j
cHAKQEAgLTE1ODYsOCArMTU4Niw3IEBAIEVpbmFfQm9vbCBld2tfdmlld190ZXh0X2ZpbmQoRXZh
c19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIHRleHQsIEV3a19GaW5kX09wCiAgICAgRVdL
X1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJpdiwgZmFsc2UpOwogICAgIEVJ
TkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCh0ZXh0LCBmYWxzZSk7CiAKLSAgICBXS1JldGFp
blB0cjxXS1N0cmluZ1JlZj4gZmluZFRleHQoQWRvcHRXSywgV0tTdHJpbmdDcmVhdGVXaXRoVVRG
OENTdHJpbmcodGV4dCkpOwotICAgIFdLUGFnZUZpbmRTdHJpbmcodG9BUEkocHJpdi0+cGFnZVBy
b3h5LmdldCgpKSwgZmluZFRleHQuZ2V0KCksIHN0YXRpY19jYXN0PFdLRmluZE9wdGlvbnM+KG9w
dGlvbnMpLCBtYXhNYXRjaENvdW50KTsKKyAgICBwcml2LT5wYWdlUHJveHktPmZpbmRTdHJpbmco
U3RyaW5nOjpmcm9tVVRGOCh0ZXh0KSwgc3RhdGljX2Nhc3Q8V2ViS2l0OjpGaW5kT3B0aW9ucz4o
b3B0aW9ucyksIG1heE1hdGNoQ291bnQpOwogCiAgICAgcmV0dXJuIHRydWU7CiB9CkBAIC0xNTk3
LDcgKzE1OTYsNyBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfdGV4dF9maW5kX2hpZ2hsaWdodF9jbGVh
cihFdmFzX09iamVjdCogZXdrVmlldykKICAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3
a1ZpZXcsIHNtYXJ0RGF0YSwgZmFsc2UpOwogICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVS
TihzbWFydERhdGEsIHByaXYsIGZhbHNlKTsKIAotICAgIFdLUGFnZUhpZGVGaW5kVUkodG9BUEko
cHJpdi0+cGFnZVByb3h5LmdldCgpKSk7CisgICAgcHJpdi0+cGFnZVByb3h5LT5oaWRlRmluZFVJ
KCk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>