98515 2012-10-05 06:40:49 -0700 [chromium] Only inflate the height of rows in a popup menu when a touch device is detected. 2012-10-05 09:15:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kevers kevers abarth rjkroege tkent webkit.review.bot oldest_to_newest 735607 0 kevers 2012-10-05 06:40:49 -0700 [chromium] Only inflate the height of rows in a popup menu when a touch device is detected. 735608 1 167319 kevers 2012-10-05 06:50:08 -0700 Created attachment 167319 Patch 735685 2 167319 webkit.review.bot 2012-10-05 09:15:27 -0700 Comment on attachment 167319 Patch Clearing flags on attachment: 167319 Committed r130513: <http://trac.webkit.org/changeset/130513> 735686 3 webkit.review.bot 2012-10-05 09:15:30 -0700 All reviewed patches have been landed. Closing bug. 167319 2012-10-05 06:50:08 -0700 2012-10-05 09:15:27 -0700 Patch bug-98515-20121005094916.patch text/plain 4776 kevers U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA2YWIwMGI1YTM2ODc2 NzdkMjBjMDQxNDM3ODQzNzVjNTljNGY0MC4uNzg1MTg3YmM2ZmRkZWNiMzA2NzA0Njc0M2VkMTU0 NmZiMjEyN2M5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEwLTA1ICBLZXZp biBFbGxpcyAgPGtldmVyc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBPbmx5 IGluZmxhdGUgdGhlIGhlaWdodCBvZiByb3dzIGluIGEgcG9wdXAgbWVudSB3aGVuIGEgdG91Y2gg ZGV2aWNlIGlzIGRldGVjdGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTg1MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBFbmZvcmNlcyBhIG1pbmltdW0gcm93IGhlaWdodCBmb3IgcG9wdXAgbWVudXMg d2hlbiBhIHRvdWNoIGRldmljZSBpcworICAgICAgICBkZXRlY3RlZC4gIEluIGEgcHJldmlvdXMg cGF0Y2ggKHIxMjc1OTcpLCB0aGUgc2l6aW5nIG9mIHBvcHVwIHdhcyAKKyAgICAgICAgY29uc29s aWRhdGVkIGZvciB0b3VjaCBhbmQgbm9uLXRvdWNoLiAgQmFzZWQgb24gdXNlciBmZWVkYmFjaywg cmV2ZXJ0aW5nCisgICAgICAgIHRvIHRoZSBvbGQgYmVoYXZpb3IgZm9yIG5vbi10b3VjaCBhbmQg b25seSBhZGRpbmcgcGFkZGluZyBmb3IgdG91Y2gKKyAgICAgICAgZGV2aWNlcyBzZWVtcyBsaWtl IGEgbXVjaCBzYWZlciBzdHJhdGVneS4gIFRoaXMgcGF0Y2ggaXMgbm90IGEgZGlyZWN0CisgICAg ICAgIHJldmVydCBvZiByMTI3NTY3IHNpbmNlIHRoZSBwYWRkaW5nIHByZXZpb3VzbHkgdXNlZCBm b3IgdG91Y2ggaXMgYSBiaXQKKyAgICAgICAgZXhjZXNzaXZlLgorCisgICAgICAgIENvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cExp c3RCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBMaXN0Qm94OjpnZXRSb3dIZWlnaHQp OgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNo cm9taXVtLmg6CisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnVDaHJvbWl1bTo6b3B0aW9uUm93 SGVpZ2h0Rm9yVG91Y2gpOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51Q2hyb21pdW06OnNl dE9wdGlvblJvd0hlaWdodEZvclRvdWNoKToKKyAgICAgICAgKFBvcHVwTWVudUNocm9taXVtKToK KwogMjAxMi0xMC0wMyAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAg ICAgICBJbXBsZW1lbnQgRGF0YUxpc3QgVUkgZm9yIGlucHV0IHR5cGUgdGltZSBvbiBjaHJvbWl1 bQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBMaXN0 Qm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTGlzdEJveC5j cHAKaW5kZXggYjhhYWQ2YjJjMzAzYWZhYzE5ZmMzMWVlYmYxOGUzMGYyZWVjODk3MS4uNWM3NmFl MTAxZjAwNjBhZGY1NmY4NmVlYWY3MWRhMTE5OGJjNDc3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBMaXN0Qm94LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cExpc3RCb3guY3BwCkBAIC02MTQsMTIgKzYxNCwx NiBAQCB2b2lkIFBvcHVwTGlzdEJveDo6c2V0T3JpZ2luYWxJbmRleChpbnQgaW5kZXgpCiAKIGlu dCBQb3B1cExpc3RCb3g6OmdldFJvd0hlaWdodChpbnQgaW5kZXgpCiB7CisgICAgaW50IG1pbmlt dW1IZWlnaHQgPSBQb3B1cE1lbnVDaHJvbWl1bTo6bWluaW11bVJvd0hlaWdodCgpOworICAgIGlm IChtX3NldHRpbmdzLmRldmljZVN1cHBvcnRzVG91Y2gpCisgICAgICAgIG1pbmltdW1IZWlnaHQg PSBtYXgobWluaW11bUhlaWdodCwgUG9wdXBNZW51Q2hyb21pdW06Om9wdGlvblJvd0hlaWdodEZv clRvdWNoKCkpOworCiAgICAgaWYgKGluZGV4IDwgMCB8fCBtX3BvcHVwQ2xpZW50LT5pdGVtU3R5 bGUoaW5kZXgpLmlzRGlzcGxheU5vbmUoKSkKLSAgICAgICAgcmV0dXJuIFBvcHVwTWVudUNocm9t aXVtOjptaW5pbXVtUm93SGVpZ2h0KCk7CisgICAgICAgIHJldHVybiBtaW5pbXVtSGVpZ2h0Owog CiAgICAgLy8gU2VwYXJhdG9yIHJvdyBoZWlnaHQgaXMgdGhlIHNhbWUgc2l6ZSBhcyBpdHNlbGYu CiAgICAgaWYgKG1fcG9wdXBDbGllbnQtPml0ZW1Jc1NlcGFyYXRvcihpbmRleCkpCi0gICAgICAg IHJldHVybiBtYXgoc2VwYXJhdG9ySGVpZ2h0LCAoUG9wdXBNZW51Q2hyb21pdW06Om1pbmltdW1S b3dIZWlnaHQoKSkpOworICAgICAgICByZXR1cm4gbWF4KHNlcGFyYXRvckhlaWdodCwgbWluaW11 bUhlaWdodCk7CiAKICAgICBTdHJpbmcgaWNvbiA9IG1fcG9wdXBDbGllbnQtPml0ZW1JY29uKGlu ZGV4KTsKICAgICBSZWZQdHI8SW1hZ2U+IGltYWdlKEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJj ZShpY29uLnV0ZjgoKS5kYXRhKCkpKTsKQEAgLTYyOSw3ICs2MzMsNyBAQCBpbnQgUG9wdXBMaXN0 Qm94OjpnZXRSb3dIZWlnaHQoaW50IGluZGV4KQogCiAgICAgaW50IGxpbmVQYWRkaW5nSGVpZ2h0 ID0gbV9wb3B1cENsaWVudC0+bWVudVN0eWxlKCkubWVudVR5cGUoKSA9PSBQb3B1cE1lbnVTdHls ZTo6QXV0b2ZpbGxQb3B1cCA/IGtMaW5lUGFkZGluZ0hlaWdodCA6IDA7CiAgICAgaW50IGNhbGN1 bGF0ZWRSb3dIZWlnaHQgPSBtYXgoZm9udEhlaWdodCwgaWNvbkhlaWdodCkgKyBsaW5lUGFkZGlu Z0hlaWdodCAqIDI7Ci0gICAgcmV0dXJuIG1heChjYWxjdWxhdGVkUm93SGVpZ2h0LCBQb3B1cE1l bnVDaHJvbWl1bTo6bWluaW11bVJvd0hlaWdodCgpKTsKKyAgICByZXR1cm4gbWF4KGNhbGN1bGF0 ZWRSb3dIZWlnaHQsIG1pbmltdW1IZWlnaHQpOwogfQogCiBJbnRSZWN0IFBvcHVwTGlzdEJveDo6 Z2V0Um93Qm91bmRzKGludCBpbmRleCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAppbmRleCA1MTllN2NhZDEzOTYzNzNm YTE5NGE1OTQxMTdmYTliMjhhNzQ5ODMwLi4wZTQ4ZmZkMGYzZDk5MGM0ODBmOTRkODYyZDM2ODY3 YmMxMjQzNzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q b3B1cE1lbnVDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21p dW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCkBAIC00MCw3ICs0MCw4IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAotaW50IFBvcHVwTWVudUNocm9taXVtOjpzX21pbmltdW1Sb3dIZWlnaHQgPSAy ODsKK2ludCBQb3B1cE1lbnVDaHJvbWl1bTo6c19taW5pbXVtUm93SGVpZ2h0ID0gMDsKK2ludCBQ b3B1cE1lbnVDaHJvbWl1bTo6c19vcHRpb25Sb3dIZWlnaHRGb3JUb3VjaCA9IDI4OwogCiAvLyBU aGUgc2V0dGluZ3MgdXNlZCBmb3IgdGhlIGRyb3AgZG93biBtZW51LgogLy8gVGhpcyBpcyB0aGUg ZGVsZWdhdGUgdXNlZCBpZiBub25lIGlzIHByb3ZpZGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmgKaW5kZXggMjBiZTZlMTUz Y2JlZDdjYWNiMzUxNmUxOTAxNDk3MjcxNTVlNGYwMS4uN2Q5MDIzZmJhY2IzYjVhOTJiMjA1Nzhk Mzk1NTNmOGQ3NGY0ZWM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCkBAIC01Niw2ICs1Niw4IEBAIHB1YmxpYzoKIAog ICAgIHN0YXRpYyBpbnQgbWluaW11bVJvd0hlaWdodCgpIHsgcmV0dXJuIHNfbWluaW11bVJvd0hl aWdodDsgfQogICAgIHN0YXRpYyB2b2lkIHNldE1pbmltdW1Sb3dIZWlnaHQoaW50IG1pbmltdW1S b3dIZWlnaHQpIHsgc19taW5pbXVtUm93SGVpZ2h0ID0gbWluaW11bVJvd0hlaWdodDsgfQorICAg IHN0YXRpYyBpbnQgb3B0aW9uUm93SGVpZ2h0Rm9yVG91Y2goKSB7IHJldHVybiBzX29wdGlvblJv d0hlaWdodEZvclRvdWNoOyB9CisgICAgc3RhdGljIHZvaWQgc2V0T3B0aW9uUm93SGVpZ2h0Rm9y VG91Y2goaW50IG9wdGlvblJvd0hlaWdodEZvclRvdWNoKSB7IHNfb3B0aW9uUm93SGVpZ2h0Rm9y VG91Y2ggPSBvcHRpb25Sb3dIZWlnaHRGb3JUb3VjaDsgfQogCiBwcml2YXRlOgogICAgIFBvcHVw TWVudUNsaWVudCogY2xpZW50KCkgY29uc3QgeyByZXR1cm4gbV9wb3B1cENsaWVudDsgfQpAQCAt NjQsNiArNjYsNyBAQCBwcml2YXRlOgogICAgIFBvcHVwTWVudVByaXZhdGUgcDsKIAogICAgIHN0 YXRpYyBpbnQgc19taW5pbXVtUm93SGVpZ2h0OworICAgIHN0YXRpYyBpbnQgc19vcHRpb25Sb3dI ZWlnaHRGb3JUb3VjaDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK