98513 2012-10-05 06:33:57 -0700 SVG classes cause layering violations in platform Font code 2012-11-02 15:59:25 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 schenney schenney d-r eric fmalita mitz pdr sam webkit.review.bot oldest_to_newest 735604 0 schenney 2012-10-05 06:33:57 -0700 The WebCore::FontFallbackList header refers to SVG classes as friends. This is a layering violation and can be fixed by making the APIs public in some way. 756659 1 171942 schenney 2012-11-01 15:07:29 -0700 Created attachment 171942 Patch 756668 2 171942 eric 2012-11-01 15:12:05 -0700 Comment on attachment 171942 Patch Much nicer. 756798 3 schenney 2012-11-01 18:37:18 -0700 Test failures might be real. I'll have to look at it. 757135 4 171942 schenney 2012-11-02 06:01:31 -0700 Comment on attachment 171942 Patch Let's try again. 757143 5 171942 webkit.review.bot 2012-11-02 06:34:20 -0700 Comment on attachment 171942 Patch Clearing flags on attachment: 171942 Committed r133290: <http://trac.webkit.org/changeset/133290> 757144 6 webkit.review.bot 2012-11-02 06:34:24 -0700 All reviewed patches have been landed. Closing bug. 757700 7 171942 darin 2012-11-02 15:59:25 -0700 Comment on attachment 171942 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171942&action=review > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:191 > + // Save data fromt he font fallback list because we may modify it later. Do this before the Typo here, "fromt he" 171942 2012-11-01 15:07:29 -0700 2012-11-02 15:59:25 -0700 Patch bug-98513-20121101180549.patch text/plain 5864 schenney SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzIyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTAxICBTdGVwaGVu IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU1ZHIGNsYXNzZXMg Y2F1c2UgbGF5ZXJpbmcgdmlvbGF0aW9ucyBpbiBwbGF0Zm9ybSBGb250IGNvZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NTEzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgY29udGFpbmVkIGNs YXNzIHRvIHNhdmUgYW5kIHJlc3RvcmUgR2xweWhQYWdlIHN0YXRlIGluIEZvbnRGYWxsYmFja0xp c3QuCisgICAgICAgIFRoaXMgYWxsb3dzIHVzIHRvIHJlbW92ZSB0aGUgbGF5ZXJpbmcgdmlvbGF0 aW9uLCBhbmQgc2V2ZXJhbCBtZXRob2RzLCB0aGF0CisgICAgICAgIHByZXZpb3VzbHkgZXhpc3Rl ZCB0byBzdXBwb3J0IFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBiZWNhdXNlIG5vIGNoYW5nZSBhdCBhbGwgaW4gZnVuY3Rpb25hbGl0eS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYWxsYmFja0xpc3QuaDoKKyAgICAgICAgKEZv bnRGYWxsYmFja0xpc3QpOgorICAgICAgICAoR2x5cGhQYWdlc1N0YXRlU2F2ZXIpOiBOZXcgc3Rh dGUgc2F2ZSBhbmQgcmVzdG9yZSBjbGFzcworICAgICAgICAoV2ViQ29yZTo6Rm9udEZhbGxiYWNr TGlzdDo6R2x5cGhQYWdlc1N0YXRlU2F2ZXI6OkdseXBoUGFnZXNTdGF0ZVNhdmVyKTogU2F2ZSBH bHlwaFBhZ2Ugc3RhdGUKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRGYWxsYmFja0xpc3Q6OkdseXBo UGFnZXNTdGF0ZVNhdmVyOjp+R2x5cGhQYWdlc1N0YXRlU2F2ZXIpOiBSZXN0b3JlIEdseXBoUGFn ZSBzdGF0ZQorICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRl eHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQ6Omds eXBoRGF0YUZvckNoYXJhY3Rlcik6IFNoaWZ0IHRvIHVzYWdlIG9mIHRoZSBuZXcgY2xhc3MuCisK IDIwMTItMTEtMDEgIFJvYiBCdWlzICA8cmJ1aXNAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gQWRkIG1vcmUgZm9ybSB2YWxpZGF0aW9uIHN0cmluZ3MKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYWxsYmFja0xpc3QuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFsbGJhY2tMaXN0LmgJKHJldmlz aW9uIDEzMzIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYWxs YmFja0xpc3QuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNiArNDEsMjkgQEAgY29uc3QgaW50IGNB bGxGYW1pbGllc1NjYW5uZWQgPSAtMTsKIGNsYXNzIEZvbnRGYWxsYmFja0xpc3QgOiBwdWJsaWMg UmVmQ291bnRlZDxGb250RmFsbGJhY2tMaXN0PiB7CiAgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUo Rm9udEZhbGxiYWNrTGlzdCk7CiBwdWJsaWM6CisgICAgdHlwZWRlZiBIYXNoTWFwPGludCwgR2x5 cGhQYWdlVHJlZU5vZGUqLCBEZWZhdWx0SGFzaDxpbnQ+OjpIYXNoPiBHbHlwaFBhZ2VzOworCisg ICAgY2xhc3MgR2x5cGhQYWdlc1N0YXRlU2F2ZXIgeworICAgIHB1YmxpYzoKKyAgICAgICAgR2x5 cGhQYWdlc1N0YXRlU2F2ZXIoRm9udEZhbGxiYWNrTGlzdCYgZmFsbGJhY2tMaXN0KQorICAgICAg ICAgICAgOiBtX2ZhbGxiYWNrTGlzdChmYWxsYmFja0xpc3QpCisgICAgICAgICAgICAsIG1fcGFn ZXMoZmFsbGJhY2tMaXN0Lm1fcGFnZXMpCisgICAgICAgICAgICAsIG1fcGFnZVplcm8oZmFsbGJh Y2tMaXN0Lm1fcGFnZVplcm8pCisgICAgICAgIHsKKyAgICAgICAgfQorCisgICAgICAgIH5HbHlw aFBhZ2VzU3RhdGVTYXZlcigpCisgICAgICAgIHsKKyAgICAgICAgICAgIG1fZmFsbGJhY2tMaXN0 Lm1fcGFnZXMgPSBtX3BhZ2VzOworICAgICAgICAgICAgbV9mYWxsYmFja0xpc3QubV9wYWdlWmVy byA9IG1fcGFnZVplcm87CisgICAgICAgIH0KKworICAgIHByaXZhdGU6CisgICAgICAgIEZvbnRG YWxsYmFja0xpc3QmIG1fZmFsbGJhY2tMaXN0OworICAgICAgICBHbHlwaFBhZ2VzJiBtX3BhZ2Vz OworICAgICAgICBHbHlwaFBhZ2VUcmVlTm9kZSogbV9wYWdlWmVybzsKKyAgICB9OworCiAgICAg c3RhdGljIFBhc3NSZWZQdHI8Rm9udEZhbGxiYWNrTGlzdD4gY3JlYXRlKCkgeyByZXR1cm4gYWRv cHRSZWYobmV3IEZvbnRGYWxsYmFja0xpc3QoKSk7IH0KIAogICAgIH5Gb250RmFsbGJhY2tMaXN0 KCkgeyByZWxlYXNlRm9udERhdGEoKTsgfQpAQCAtNTYsMTAgKzc5LDYgQEAgcHVibGljOgogICAg IHVuc2lnbmVkIGZvbnRTZWxlY3RvclZlcnNpb24oKSBjb25zdCB7IHJldHVybiBtX2ZvbnRTZWxl Y3RvclZlcnNpb247IH0KICAgICB1bnNpZ25lZCBnZW5lcmF0aW9uKCkgY29uc3QgeyByZXR1cm4g bV9nZW5lcmF0aW9uOyB9CiAKLSAgICB0eXBlZGVmIEhhc2hNYXA8aW50LCBHbHlwaFBhZ2VUcmVl Tm9kZSosIERlZmF1bHRIYXNoPGludD46Okhhc2g+IEdseXBoUGFnZXM7Ci0gICAgR2x5cGhQYWdl VHJlZU5vZGUqIGdseXBoUGFnZVplcm8oKSBjb25zdCB7IHJldHVybiBtX3BhZ2VaZXJvOyB9Ci0g ICAgY29uc3QgR2x5cGhQYWdlcyYgZ2x5cGhQYWdlcygpIGNvbnN0IHsgcmV0dXJuIG1fcGFnZXM7 IH0KLQogcHJpdmF0ZToKICAgICBGb250RmFsbGJhY2tMaXN0KCk7CiAKQEAgLTc3LDggKzk2LDYg QEAgcHJpdmF0ZToKICAgICB2b2lkIHNldFBsYXRmb3JtRm9udChjb25zdCBGb250UGxhdGZvcm1E YXRhJik7CiAKICAgICB2b2lkIHJlbGVhc2VGb250RGF0YSgpOwotICAgIHZvaWQgc2V0R2x5cGhQ YWdlWmVybyhHbHlwaFBhZ2VUcmVlTm9kZSogcGFnZVplcm8pIHsgbV9wYWdlWmVybyA9IHBhZ2Va ZXJvOyB9Ci0gICAgdm9pZCBzZXRHbHlwaFBhZ2VzKGNvbnN0IEdseXBoUGFnZXMmIHBhZ2VzKSB7 IG1fcGFnZXMgPSBwYWdlczsgfQogICAgIAogICAgIG11dGFibGUgVmVjdG9yPFJlZlB0cjxGb250 RGF0YT4sIDE+IG1fZm9udExpc3Q7CiAgICAgbXV0YWJsZSBHbHlwaFBhZ2VzIG1fcGFnZXM7CkBA IC05Miw3ICsxMDksNiBAQCBwcml2YXRlOgogICAgIG11dGFibGUgYm9vbCBtX2xvYWRpbmdDdXN0 b21Gb250cyA6IDE7CiAKICAgICBmcmllbmQgY2xhc3MgRm9udDsKLSAgICBmcmllbmQgY2xhc3Mg U1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQ7CiB9OwogCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRSdW5SZW5kZXJpbmdDb250 ZXh0LmNwcAkocmV2aXNpb24gMTMzMjA1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2 Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4OCw2 ICsxODgsMTIgQEAgR2x5cGhEYXRhIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0OjpnbAogICAg ICAgICByZXR1cm4gZ2x5cGhEYXRhOwogICAgIH0KIAorICAgIC8vIFNhdmUgZGF0YSBmcm9tdCBo ZSBmb250IGZhbGxiYWNrIGxpc3QgYmVjYXVzZSB3ZSBtYXkgbW9kaWZ5IGl0IGxhdGVyLiBEbyB0 aGlzIGJlZm9yZSB0aGUKKyAgICAvLyBwb3RlbnRpYWwgY2hhbmdlIHRvIGdseXBoRGF0YS5mb250 RGF0YSBiZWxvdy4KKyAgICBGb250RmFsbGJhY2tMaXN0KiBmb250TGlzdCA9IGZvbnQuZm9udExp c3QoKTsKKyAgICBBU1NFUlQoZm9udExpc3QpOworICAgIEZvbnRGYWxsYmFja0xpc3Q6OkdseXBo UGFnZXNTdGF0ZVNhdmVyIGdseXBoUGFnZXNTYXZlcigqZm9udExpc3QpOworCiAgICAgLy8gQ2hh cmFjdGVycyBlbmNsb3NlZCBieSBhbiA8YWx0R2x5cGg+IGVsZW1lbnQsIG1heSBub3QgYmUgcmVn aXN0ZXJlZCBpbiB0aGUgR2x5cGhQYWdlLgogICAgIGNvbnN0IFNpbXBsZUZvbnREYXRhKiBvcmln aW5hbEZvbnREYXRhID0gZ2x5cGhEYXRhLmZvbnREYXRhOwogICAgIGlmIChnbHlwaERhdGEuZm9u dERhdGEgJiYgIWdseXBoRGF0YS5mb250RGF0YS0+aXNTVkdGb250KCkpIHsKQEAgLTIyNSwxNCAr MjMxLDkgQEAgR2x5cGhEYXRhIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0OjpnbAogICAgIEds eXBoUGFnZSogcGFnZSA9IHBhaXIuc2Vjb25kOwogICAgIEFTU0VSVChwYWdlKTsKIAotICAgIEZv bnRGYWxsYmFja0xpc3QqIGZvbnRMaXN0ID0gZm9udC5mb250TGlzdCgpOwotICAgIEFTU0VSVChm b250TGlzdCk7Ci0KICAgICAvLyBObyBzdWl0YWJsZSBnbHlwaCBmb3VuZCB0aGF0IGlzIGNvbXBh dGlibGUgd2l0aCB0aGUgcmVxdWlybWVudHMgKHNhbWUgbGFuZ3VhZ2UsIGFyYWJpYy1mb3JtLCBv cmllbnRhdGlvbiBldGMuKQogICAgIC8vIEV2ZW4gdGhvdWdoIG91ciBHbHlwaFBhZ2UgY29udGFp bnMgYW4gZW50cnkgZm9yIGVnLiBnbHlwaCAiYSIsIGl0J3Mgbm90IGNvbXBhdGlibGUuIFNvIHdl IGhhdmUgdG8gdGVtcG9yYXJpbHkKICAgICAvLyByZW1vdmUgdGhlIGdseXBoIGRhdGEgaW5mb3Jt YXRpb24gZnJvbSB0aGUgR2x5cGhQYWdlLCBhbmQgcmV0cnkgdGhlIGxvb2t1cCwgd2hpY2ggaGFu ZGxlcyBmb250IGZhbGxiYWNrcyBjb3JyZWN0bHkuCi0gICAgR2x5cGhQYWdlVHJlZU5vZGUqIG9y aWdpbmFsR2x5cGhQYWdlWmVybyA9IGZvbnRMaXN0LT5nbHlwaFBhZ2VaZXJvKCk7Ci0gICAgY29u c3QgRm9udEZhbGxiYWNrTGlzdDo6R2x5cGhQYWdlcyYgb3JpZ2luYWxHbHlwaFBhZ2VzID0gZm9u dExpc3QtPmdseXBoUGFnZXMoKTsKICAgICBwYWdlLT5zZXRHbHlwaERhdGFGb3JDaGFyYWN0ZXIo Y2hhcmFjdGVyLCBnbHlwaERhdGEuZ2x5cGgsIDApOwogCiAgICAgLy8gQXNzdXJlIHRoYXQgdGhl IGZvbnQgZmFsbGJhY2sgZ2x5cGggc2VsZWN0aW9uIHdvcmtlZCwgYWthLiB0aGUgZmFsbGJhY2tH bHlwaERhdGEgZm9udCBkYXRhIGlzIG5vdCB0aGUgc2FtZSBhcyBiZWZvcmUuCkBAIC0yNDIsOCAr MjQzLDYgQEAgR2x5cGhEYXRhIFNWR1RleHRSdW5SZW5kZXJpbmdDb250ZXh0OjpnbAogICAgIC8v IFJlc3RvcmUgb3JpZ2luYWwgc3RhdGUgb2YgdGhlIFNWRyBGb250IGdseXBoIHRhYmxlIGFuZCB0 aGUgY3VycmVudCBmb250IGZhbGxiYWNrIGxpc3QsCiAgICAgLy8gdG8gYXNzdXJlIHRoZSBuZXh0 IGxvb2t1cCBvZiB0aGUgc2FtZSBnbHlwaCB3b24ndCBpbW1lZGlhdGVseSByZXR1cm4gdGhlIGZh bGxiYWNrIGdseXBoLgogICAgIHBhZ2UtPnNldEdseXBoRGF0YUZvckNoYXJhY3RlcihjaGFyYWN0 ZXIsIGdseXBoRGF0YS5nbHlwaCwgb3JpZ2luYWxGb250RGF0YSk7Ci0gICAgZm9udExpc3QtPnNl dEdseXBoUGFnZVplcm8ob3JpZ2luYWxHbHlwaFBhZ2VaZXJvKTsKLSAgICBmb250TGlzdC0+c2V0 R2x5cGhQYWdlcyhvcmlnaW5hbEdseXBoUGFnZXMpOwogICAgIEFTU0VSVChmYWxsYmFja0dseXBo RGF0YS5mb250RGF0YSk7CiAgICAgcmV0dXJuIGZhbGxiYWNrR2x5cGhEYXRhOwogfQo=