98509 2012-10-05 05:59:38 -0700 [EFL] Unskip fullscreen unit tests for EwkView 2012-10-05 09:13:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez alexander.shalamov gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 735596 0 cdumez 2012-10-05 05:59:38 -0700 2 EwkView unit tests for fullscreen functionality have been disabled recently due to the switch to Xvfb. ecore_evas_fullscreen_set() does not seems to work with Xvfb so we need to disable one check in order to unskip those tests. 735597 1 167315 cdumez 2012-10-05 06:02:46 -0700 Created attachment 167315 Patch 735682 2 167315 webkit.review.bot 2012-10-05 09:13:26 -0700 Comment on attachment 167315 Patch Clearing flags on attachment: 167315 Committed r130512: <http://trac.webkit.org/changeset/130512> 735683 3 webkit.review.bot 2012-10-05 09:13:30 -0700 All reviewed patches have been landed. Closing bug. 167315 2012-10-05 06:02:46 -0700 2012-10-05 09:13:26 -0700 Patch 98509_fullscreen_utests.patch text/plain 2806 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyMDgzNTU1Li5iYTkyNTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBVbnNraXAgZnVsbHNjcmVlbiB1bml0IHRlc3RzIGZvciBF d2tWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODUwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVw ZGF0ZSAyIGZ1bGxzY3JlZW4gdW5pdCB0ZXN0cyBmb3IgRXdrVmlldyBzbyB0aGF0CisgICAgICAg IHRoZXkgZG9uJ3QgcmVxdWlyZSBhIGNhbGwgdG8gZWNvcmVfZXZhc19mdWxsc2NyZWVuX3NldCgp CisgICAgICAgIHRvIHN1Y2NlZWQuIGVjb3JlX2V2YXNfZnVsbHNjcmVlbl9zZXQoKSBkb2VzIG5v dAorICAgICAgICBzZWVtIHRvIHdvcmsgaW4gWHZmYiBhbmQgY2F1c2VzIHRoZSB0ZXN0cyB0byBo YW5nLgorICAgICAgICBXaXRoIHRoaXMgdXBkYXRlLCB3ZSBjYW4gbm93IHJ1biB0aG9zZSB0ZXN0 cyBhZ2Fpbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92 aWV3LmNwcDoKKyAgICAgICAgKFRFU1RfRik6CisKIDIwMTItMTAtMDUgIEpvbmdzZW9rIFlhbmcg IDxqczQ1LnlhbmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBSZW1vdmUgIndl YiIgd29yZCBmcm9tIGV3a193ZWJfZXJyb3IgQVBJcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IDNj ZTVmNmQuLjQ0YzRiYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAgLTMxMCwxNyArMzEwLDcgQEAg c3RhdGljIEVpbmFfQm9vbCBmdWxsU2NyZWVuQ2FsbGJhY2soRXdrX1ZpZXdfU21hcnRfRGF0YSog c21hcnREYXRhKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotc3RhdGljIHZvaWQgY2hlY2tGdWxs U2NyZWVuUHJvcGVydHkoRXZhc19PYmplY3QqIHdlYlZpZXcsIGJvb2wgZXhwZWN0ZWRTdGF0ZSkK LXsKLSAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEgPSBzdGF0aWNfY2FzdDxFd2tf Vmlld19TbWFydF9EYXRhKj4oZXZhc19vYmplY3Rfc21hcnRfZGF0YV9nZXQod2ViVmlldykpOwot ICAgIEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoc21h cnREYXRhLT5iYXNlLmV2YXMpOwotICAgIGJvb2wgd2luZG93U3RhdGUgPSBmYWxzZTsKLSAgICB3 aGlsZSAoKCh3aW5kb3dTdGF0ZSA9IGVjb3JlX2V2YXNfZnVsbHNjcmVlbl9nZXQoZWNvcmVFdmFz KSkgIT0gZXhwZWN0ZWRTdGF0ZSkpCi0gICAgICAgIGVjb3JlX21haW5fbG9vcF9pdGVyYXRlKCk7 Ci0gICAgQVNTRVJUX1RSVUUoZXhwZWN0ZWRTdGF0ZSA9PSB3aW5kb3dTdGF0ZSk7Ci19Ci0KLVRF U1RfRihFV0syVW5pdFRlc3RCYXNlLCBESVNBQkxFRF9ld2tfdmlld19mdWxsX3NjcmVlbl9lbnRl cikKK1RFU1RfRihFV0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19mdWxsX3NjcmVlbl9lbnRlcikK IHsKICAgICBjb25zdCBjaGFyIGZ1bGxzY3JlZW5IVE1MW10gPQogICAgICAgICAiPCFkb2N0eXBl IGh0bWw+PGhlYWQ+PHNjcmlwdD5mdW5jdGlvbiBtYWtlRnVsbFNjcmVlbigpeyIKQEAgLTMzNywx MCArMzI3LDkgQEAgVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIERJU0FCTEVEX2V3a192aWV3X2Z1 bGxfc2NyZWVuX2VudGVyKQogICAgIG1vdXNlQ2xpY2soNTAsIDUwKTsKICAgICBBU1NFUlRfVFJV RSh3YWl0VW50aWxUaXRsZUNoYW5nZWRUbygiZnVsbHNjcmVlbiBlbnRlcmVkIikpOwogICAgIEFT U0VSVF9UUlVFKGZ1bGxTY3JlZW5DYWxsYmFja0NhbGxlZCk7Ci0gICAgY2hlY2tGdWxsU2NyZWVu UHJvcGVydHkod2ViVmlldygpLCB0cnVlKTsKIH0KIAotVEVTVF9GKEVXSzJVbml0VGVzdEJhc2Us IERJU0FCTEVEX2V3a192aWV3X2Z1bGxfc2NyZWVuX2V4aXQpCitURVNUX0YoRVdLMlVuaXRUZXN0 QmFzZSwgZXdrX3ZpZXdfZnVsbF9zY3JlZW5fZXhpdCkKIHsKICAgICBjb25zdCBjaGFyIGZ1bGxz Y3JlZW5IVE1MW10gPQogICAgICAgICAiPCFkb2N0eXBlIGh0bWw+PGhlYWQ+PHNjcmlwdD5mdW5j dGlvbiBtYWtlRnVsbFNjcmVlbkFuZEV4aXQoKXsiCkBAIC0zNTgsNyArMzQ3LDYgQEAgVEVTVF9G KEVXSzJVbml0VGVzdEJhc2UsIERJU0FCTEVEX2V3a192aWV3X2Z1bGxfc2NyZWVuX2V4aXQpCiAg ICAgbW91c2VDbGljayg1MCwgNTApOwogICAgIEFTU0VSVF9UUlVFKHdhaXRVbnRpbFRpdGxlQ2hh bmdlZFRvKCJmdWxsc2NyZWVuIGV4aXRlZCIpKTsKICAgICBBU1NFUlRfVFJVRShmdWxsU2NyZWVu Q2FsbGJhY2tDYWxsZWQpOwotICAgIGNoZWNrRnVsbFNjcmVlblByb3BlcnR5KHdlYlZpZXcoKSwg ZmFsc2UpOwogfQogCiBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfc2FtZV9wYWdl X25hdmlnYXRpb24pCg==