98497 2012-10-05 01:38:41 -0700 [GTK] Test /webkit2/WebKitPrintOperation/print-errors gives runtime critical warnings 2012-10-05 08:46:07 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo xan.lopez oldest_to_newest 735490 0 cgarcia 2012-10-05 01:38:41 -0700 GLib-CRITICAL **: g_io_channel_write_chars: assertion `channel->is_writeable' failed This is because GTK+ tries to write in the io channel that has already been closed. 735492 1 167280 cgarcia 2012-10-05 01:42:11 -0700 Created attachment 167280 Patch 735650 2 167280 mrobinson 2012-10-05 08:22:05 -0700 Comment on attachment 167280 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167280&action=review Looks good, but please see below before landing... > Source/WebKit2/ChangeLog:9 > + The problem is that GTK+ tries to write in the io channel that ash > + already been closed. Nit: IO channel that has > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:700 > + cairo_surface_finish(surface); Since this is a work-around for a GTK+ bug it's probably a good idea to put a comment here including a URL to the GTK+ bug in question. 735655 3 cgarcia 2012-10-05 08:29:15 -0700 (In reply to comment #2) > (From update of attachment 167280 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167280&action=review > > Looks good, but please see below before landing... > > > Source/WebKit2/ChangeLog:9 > > + The problem is that GTK+ tries to write in the io channel that ash > > + already been closed. > > Nit: IO channel that has Sure. > > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:700 > > + cairo_surface_finish(surface); > > Since this is a work-around for a GTK+ bug it's probably a good idea to put a comment here including a URL to the GTK+ bug in question. It's not exactly a workaround, it's a good idea to do that in any case even if there weren't bugs in GTK+, we are already doing it in WebPrintOperationGtkUnix::endPrint() and it's reason why it didn't fail for other printing errors. 735658 4 cgarcia 2012-10-05 08:33:17 -0700 What I mean is that it would be useful to add links to the bugs there to remove the workaround when the bugs are fixed, but it's not the case, we want to finish the surface early even if the bugs are fixed. 735662 5 cgarcia 2012-10-05 08:46:07 -0700 Committed r130509: <http://trac.webkit.org/changeset/130509> 167280 2012-10-05 01:42:11 -0700 2012-10-05 08:22:04 -0700 Patch wk2-print-test.diff text/plain 1513 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4OWJmOWRmLi42MWJkZjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2ViS2l0UHJpbnRPcGVyYXRpb24vcHJp bnQtZXJyb3JzIGdpdmVzIHJ1bnRpbWUgY3JpdGljYWwgd2FybmluZ3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NDk3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBHVEsr IHRyaWVzIHRvIHdyaXRlIGluIHRoZSBpbyBjaGFubmVsIHRoYXQgYXNoCisgICAgICAgIGFscmVh ZHkgYmVlbiBjbG9zZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBy aW50T3BlcmF0aW9uR3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJpbnRPcGVyYXRpb25H dGs6OnByaW50KTogRmluaXNoIHRoZSBzdXJmYWNlIHdoZW4KKyAgICAgICAgcHJpdGluZyBmYWls cyBiZWNhdXNlIHByaW50aW5nIGRhdGEgaXMgaW52YWxpZC4KKwogMjAxMi0xMC0wMyAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gV2Vi S2l0V2ViVmlldyBkb2Vzbid0IGVtaXQgbm90aWZ5OmZhdmljb24gd2hlbiBpdCBjaGFuZ2VzIGlu IHNvbWUgY2FzZXMgaW4gV2ViS2l0MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL2d0ay9XZWJQcmludE9wZXJhdGlvbkd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcAppbmRleCAy OWY4OTMyLi4wZjA3ZDc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlByaW50T3BlcmF0aW9uR3RrLmNwcApAQCAtNjk3LDYg KzY5Nyw3IEBAIHZvaWQgV2ViUHJpbnRPcGVyYXRpb25HdGs6OnByaW50KGNhaXJvX3N1cmZhY2Vf dCogc3VyZmFjZSwgZG91YmxlIHhEUEksIGRvdWJsZSB5CiAKICAgICBPd25QdHI8UHJpbnRQYWdl c0RhdGE+IGRhdGEgPSBhZG9wdFB0cihuZXcgUHJpbnRQYWdlc0RhdGEodGhpcykpOwogICAgIGlm ICghZGF0YS0+aXNWYWxpZCkgeworICAgICAgICBjYWlyb19zdXJmYWNlX2ZpbmlzaChzdXJmYWNl KTsKICAgICAgICAgcHJpbnREb25lKGludmFsaWRQYWdlUmFuZ2VUb1ByaW50KG1fcHJpbnRDb250 ZXh0KSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg==