98493 2012-10-05 00:56:07 -0700 [EFL][WK2] Fix mktemp() compilation warning in Minibrowser 2012-10-05 09:30:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98334 1 cdumez cdumez gyuyoung.kim kenneth ktf.kim laszlo.gombos lucas.de.marchi naginenis tonikitoo webkit.review.bot oldest_to_newest 735462 0 cdumez 2012-10-05 00:56:07 -0700 We have the following compilation warning in Minibrowser: Building C object Tools/MiniBrowser/efl/CMakeFiles/MiniBrowser.dir/main.c.o /home/chris/unencrypted/WebKit/Tools/MiniBrowser/efl/main.c: In function ‘on_download_request’: /home/chris/unencrypted/WebKit/Tools/MiniBrowser/efl/main.c:216:9: warning: passing argument 1 of ‘mktemp’ discards ‘const’ qualifier from pointer target type [enabled by default] 735464 1 167273 cdumez 2012-10-05 00:59:29 -0700 Created attachment 167273 Patch 735705 2 167273 webkit.review.bot 2012-10-05 09:29:59 -0700 Comment on attachment 167273 Patch Clearing flags on attachment: 167273 Committed r130517: <http://trac.webkit.org/changeset/130517> 735707 3 webkit.review.bot 2012-10-05 09:30:04 -0700 All reviewed patches have been landed. Closing bug. 167273 2012-10-05 00:59:29 -0700 2012-10-05 09:29:59 -0700 Patch 98493_mktemp_warning.patch text/plain 1924 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZDhj Zjg3Li4wNzQ1MjcxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTItMTAtMDUgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEZpeCBta3Rl bXAoKSBjb21waWxhdGlvbiB3YXJuaW5nIGluIE1pbmlicm93c2VyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODQ5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB3cm9uZyBta3RlbXAgdXNhZ2UgY2F1 c2luZyBhIGNvbXBpbGF0aW9uIHdhcm5pbmcKKyAgICAgICAgaW4gTWluaUJyb3dzZXIuCisKKyAg ICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAob25fZG93bmxvYWRfcmVx dWVzdCk6CisKKzIwMTItMTAtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6 QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXSBGaXggd2luZG93IHJlc2l6aW5nIC8gbW92aW5n IGluIFdLMSBhbmQgV0tUUgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTg0ODYKIApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4u YyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggMGM2ZDI3Ni4uNTFmMTdjZiAx MDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0yMDYsMTQgKzIwNiwxNSBAQCBvbl9kb3dubG9hZF9yZXF1 ZXN0KHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2lu Zm8pCiAKICAgICAvLyBGSVhNRTogVGhlIGRlc3RpbmF0aW9uIGZvbGRlciBzaG91bGQgYmUgc2Vs ZWN0ZWQgYnkgdGhlIHVzZXIgYnV0IHdlIHNldCBpdCB0byAnL3RtcCcgZm9yIG5vdy4KICAgICBF aW5hX1N0cmJ1ZiAqZGVzdGluYXRpb25fcGF0aCA9IGVpbmFfc3RyYnVmX25ldygpOwotICAgIGVp bmFfc3RyYnVmX2FwcGVuZChkZXN0aW5hdGlvbl9wYXRoLCAiL3RtcC8iKTsKIAogICAgIGNvbnN0 IGNoYXIgKnN1Z2dlc3RlZF9uYW1lID0gZXdrX2Rvd25sb2FkX2pvYl9zdWdnZXN0ZWRfZmlsZW5h bWVfZ2V0KGRvd25sb2FkKTsKICAgICBpZiAoc3VnZ2VzdGVkX25hbWUgJiYgKnN1Z2dlc3RlZF9u YW1lKQotICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmQoZGVzdGluYXRpb25fcGF0aCwgc3VnZ2Vz dGVkX25hbWUpOworICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmRfcHJpbnRmKGRlc3RpbmF0aW9u X3BhdGgsICIvdG1wLyVzIiwgc3VnZ2VzdGVkX25hbWUpOwogICAgIGVsc2UgewotICAgICAgICBl aW5hX3N0cmJ1Zl9hcHBlbmQoZGVzdGluYXRpb25fcGF0aCwgImRvd25sb2FkZWQtZmlsZS5YWFhY WFgiKTsKLSAgICAgICAgbWt0ZW1wKGVpbmFfc3RyYnVmX3N0cmluZ19nZXQoZGVzdGluYXRpb25f cGF0aCkpOworICAgICAgICAvLyBHZW5lcmF0ZSBhIHVuaXF1ZSBmaWxlIG5hbWUgc2luY2Ugbm8g bmFtZSB3YXMgc3VnZ2VzdGVkLgorICAgICAgICBjaGFyIHVuaXF1ZV9wYXRoW10gPSAiL3RtcC9k b3dubG9hZGVkLWZpbGUuWFhYWFhYIjsKKyAgICAgICAgbWt0ZW1wKHVuaXF1ZV9wYXRoKTsKKyAg ICAgICAgZWluYV9zdHJidWZfYXBwZW5kKGRlc3RpbmF0aW9uX3BhdGgsIHVuaXF1ZV9wYXRoKTsK ICAgICB9CiAKICAgICBld2tfZG93bmxvYWRfam9iX2Rlc3RpbmF0aW9uX3NldChkb3dubG9hZCwg ZWluYV9zdHJidWZfc3RyaW5nX2dldChkZXN0aW5hdGlvbl9wYXRoKSk7Cg==