98489 2012-10-04 23:52:52 -0700 [GTK] Add support for GBytes in GRefPtr 2012-10-05 03:23:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98494 98488 1 spena spena benjamin cgarcia mrobinson ossy webkit.review.bot oldest_to_newest 735414 0 spena 2012-10-04 23:52:52 -0700 GResources add support for embedding resources in the binaries, and can later be loaded as GBytes. Supporting GBytes inside GRefPtr is more consistent with the rest of the port, and makes it easier for the GResources support. 735427 1 167266 spena 2012-10-05 00:08:06 -0700 Created attachment 167266 Patch 735433 2 167266 cgarcia 2012-10-05 00:17:09 -0700 Comment on attachment 167266 Patch Perfect 735453 3 167266 webkit.review.bot 2012-10-05 00:40:09 -0700 Comment on attachment 167266 Patch Clearing flags on attachment: 167266 Committed r130478: <http://trac.webkit.org/changeset/130478> 735454 4 webkit.review.bot 2012-10-05 00:40:12 -0700 All reviewed patches have been landed. Closing bug. 735467 5 webkit.review.bot 2012-10-05 01:07:26 -0700 Re-opened since this is blocked by bug 98494 735474 6 ossy 2012-10-05 01:10:50 -0700 (In reply to comment #5) > Re-opened since this is blocked by bug 98494 Rolled out, beacuse it broke the Qt build: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function ‘T* WTF::refGPtr(T*) [with T = _GBytes]’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp:69:24: error: ‘g_bytes_ref’ was not declared in this scope /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp: In function ‘void WTF::derefGPtr(T*) [with T = _GBytes]’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/gobject/GRefPtr.cpp:76:26: error: ‘g_bytes_unref’ was not declared in this scope 735495 7 167282 spena 2012-10-05 01:50:07 -0700 Created attachment 167282 Patch 735532 8 167282 cgarcia 2012-10-05 03:04:27 -0700 Comment on attachment 167282 Patch Everything is green now, let's try again. 735541 9 167282 webkit.review.bot 2012-10-05 03:23:07 -0700 Comment on attachment 167282 Patch Clearing flags on attachment: 167282 Committed r130491: <http://trac.webkit.org/changeset/130491> 735542 10 webkit.review.bot 2012-10-05 03:23:11 -0700 All reviewed patches have been landed. Closing bug. 167266 2012-10-05 00:08:06 -0700 2012-10-05 01:50:02 -0700 Patch bug-98489-20121005090714.patch text/plain 2882 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA0MWNkOThlY2VmM2VjNjg2MTYzODc3 MzJhZGZkNTE1MGRhOTlkYjIuLjAwOTc2M2JiMDU5OWI5N2U5MWNlYWJhMjM2ZGMzZDVkYzFkNWQ5 NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMTAtMDQgIFNpbW9uIFBlbmEgIDxzcGVuYUBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBHQnl0ZXMgaW4gR1Jl ZlB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0 ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRp bmcgc3VwcG9ydCBmb3IgR0J5dGVzIGluIEdSZWZQdHIgbWFrZXMgaXQgZWFzaWVyCisgICAgICAg IGZvciB0aGVtIHRvIGJlIHVzZWQgd2hlbiBhZGRpbmcgR1Jlc291cmNlcyBzdXBwb3J0LAorICAg ICAgICBhbmQgaXMgbW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YgdGhlIHBvcnQuCisK KyAgICAgICAgVGhpcyBjYWxscyBnX2J5dGVzX3JlZiBhbmQgZ19ieXRlc191bnJlZiBpbiB0aGUg aW1wbGVtZW50YXRpb24KKyAgICAgICAgb2YgdGhlIHJlZlB0ciBhbmQgZGVyZWZQdHIgdGVtcGxh dGUgZnVuY3Rpb25zLgorCisgICAgICAgICogd3RmL2dvYmplY3QvR1JlZlB0ci5jcHA6IEltcGxl bWVudCB0ZW1wbGF0ZXMgZm9yIHJlZiBhbmQgZGVyZWYuCisgICAgICAgIChXVEY6OnJlZkdQdHIp OgorICAgICAgICAoV1RGKToKKyAgICAgICAgKFdURjo6ZGVyZWZHUHRyKToKKyAgICAgICAgKiB3 dGYvZ29iamVjdC9HUmVmUHRyLmg6CisgICAgICAgIChXVEYpOgorICAgICAgICAqIHd0Zi9nb2Jq ZWN0L0dUeXBlZGVmcy5oOiBEZWZpbmUgdGhlIEdCeXRlcyBkYXRhdHlwZS4KKwogMjAxMi0xMC0w MyAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW1JlZmFj dG9yaW5nXSBUaWR5IE5ERUJVRyBvcHRpb25pbmcgaW4gUmVmQ291bnRlZEJhc2UuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuY3BwIGIvU291cmNlL1dURi93dGYv Z29iamVjdC9HUmVmUHRyLmNwcAppbmRleCA1YWEwNjdhNjI3MmEyYjM3Y2Q2MzQyMTJiNGM4Mzdm NjhjMTk1NjgxLi5hNDRkNmFhNGQzYTdmYjM3YzQ5Y2I5NTBiMmQ4OWYxNmFiMTBiNTYyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuY3BwCisrKyBiL1NvdXJjZS9X VEYvd3RmL2dvYmplY3QvR1JlZlB0ci5jcHAKQEAgLTYzLDYgKzYzLDE5IEBAIHRlbXBsYXRlIDw+ IHZvaWQgZGVyZWZHUHRyKEdNYWluTG9vcCogcHRyKQogICAgICAgICBnX21haW5fbG9vcF91bnJl ZihwdHIpOwogfQogCit0ZW1wbGF0ZSA8PiBHQnl0ZXMqIHJlZkdQdHIoR0J5dGVzKiBwdHIpCit7 CisgICAgaWYgKHB0cikKKyAgICAgICAgZ19ieXRlc19yZWYocHRyKTsKKyAgICByZXR1cm4gcHRy OworfQorCit0ZW1wbGF0ZSA8PiB2b2lkIGRlcmVmR1B0cihHQnl0ZXMqIHB0cikKK3sKKyAgICBp ZiAocHRyKQorICAgICAgICBnX2J5dGVzX3VucmVmKHB0cik7Cit9CisKICNpZiBHTElCX0NIRUNL X1ZFUlNJT04oMiwgMjQsIDApCiB0ZW1wbGF0ZSA8PiBHVmFyaWFudCogcmVmR1B0cihHVmFyaWFu dCogcHRyKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuaAppbmRleCBkZjY4ODhjMDY1YzFhNmNj MmY5NTk3ZDMwNzk3NGMyZDYzOWJmMDljLi5iMDkwOWI2NzkwM2I2NTRmNzEzZmY1ZjI3YzlkZTRh YjZhMDBhNzQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuaApAQCAtMjEyLDYgKzIxMiw4IEBA IHRlbXBsYXRlIDw+IEdQdHJBcnJheSogcmVmR1B0cihHUHRyQXJyYXkqKTsKIHRlbXBsYXRlIDw+ IHZvaWQgZGVyZWZHUHRyKEdQdHJBcnJheSopOwogdGVtcGxhdGUgPD4gR0J5dGVBcnJheSogcmVm R1B0cihHQnl0ZUFycmF5Kik7CiB0ZW1wbGF0ZSA8PiB2b2lkIGRlcmVmR1B0cihHQnl0ZUFycmF5 Kik7Cit0ZW1wbGF0ZSA8PiBHQnl0ZXMqIHJlZkdQdHIoR0J5dGVzKik7Cit0ZW1wbGF0ZSA8PiB2 b2lkIGRlcmVmR1B0cihHQnl0ZXMqKTsKIAogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IGlubGluZSBU KiByZWZHUHRyKFQqIHB0cikKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2dvYmplY3Qv R1R5cGVkZWZzLmggYi9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dUeXBlZGVmcy5oCmluZGV4IDc3 ODU4ZDVlOWNkODgwNmY2OTQ1MDMwNTBkZGMzOTlmZjUyN2YxYWYuLjY0YzNjNTg4M2QzMjJiMGQ0 NTliNGFlNzE4OGQ3YjcyZmI3MDYwMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2dvYmpl Y3QvR1R5cGVkZWZzLmgKKysrIGIvU291cmNlL1dURi93dGYvZ29iamVjdC9HVHlwZWRlZnMuaApA QCAtNjUsNiArNjUsNyBAQCB0eXBlZGVmIHN0cnVjdCBfR1RpbWVyIEdUaW1lcjsKIHR5cGVkZWYg c3RydWN0IF9HS2V5RmlsZSBHS2V5RmlsZTsKIHR5cGVkZWYgc3RydWN0IF9HUHRyQXJyYXkgR1B0 ckFycmF5OwogdHlwZWRlZiBzdHJ1Y3QgX0dCeXRlQXJyYXkgR0J5dGVBcnJheTsKK3R5cGVkZWYg c3RydWN0IF9HQnl0ZXMgR0J5dGVzOwogCiAjaWYgVVNFKENBSVJPKQogdHlwZWRlZiBzdHJ1Y3Qg X2NhaXJvX3N1cmZhY2UgY2Fpcm9fc3VyZmFjZV90Owo= 167282 2012-10-05 01:50:07 -0700 2012-10-05 03:23:07 -0700 Patch bug-98489-20121005104915.patch text/plain 3177 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA0MWNkOThlY2VmM2VjNjg2MTYzODc3 MzJhZGZkNTE1MGRhOTlkYjIuLjBjNGEzNTg2OTY1YjUzNTk3ZTE3OWFlMmM2ZjBhZTU4YjNkNjky NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTItMTAtMDQgIFNpbW9uIFBlbmEgIDxzcGVuYUBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciBHQnl0ZXMgaW4gR1Jl ZlB0cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0 ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRp bmcgc3VwcG9ydCBmb3IgR0J5dGVzIGluIEdSZWZQdHIgbWFrZXMgaXQgZWFzaWVyCisgICAgICAg IGZvciB0aGVtIHRvIGJlIHVzZWQgd2hlbiBhZGRpbmcgR1Jlc291cmNlcyBzdXBwb3J0LAorICAg ICAgICBhbmQgaXMgbW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YgdGhlIHBvcnQuCisK KyAgICAgICAgVGhpcyBjYWxscyBnX2J5dGVzX3JlZiBhbmQgZ19ieXRlc191bnJlZiBpbiB0aGUg aW1wbGVtZW50YXRpb24KKyAgICAgICAgb2YgdGhlIHJlZlB0ciBhbmQgZGVyZWZQdHIgdGVtcGxh dGUgZnVuY3Rpb25zLCBpbiBjYXNlIHRoZSBHTGliCisgICAgICAgIHZlcnNpb24gaXMgbWV0LiBP dGhlcndpc2UsIGl0IGRvZXMgbm90aGluZy4KKworICAgICAgICAqIHd0Zi9nb2JqZWN0L0dSZWZQ dHIuY3BwOiBJbXBsZW1lbnQgdGVtcGxhdGVzIGZvciByZWYgYW5kIGRlcmVmLgorICAgICAgICAo V1RGOjpyZWZHUHRyKToKKyAgICAgICAgKFdURik6CisgICAgICAgIChXVEY6OmRlcmVmR1B0cik6 CisgICAgICAgICogd3RmL2dvYmplY3QvR1JlZlB0ci5oOgorICAgICAgICAoV1RGKToKKyAgICAg ICAgKiB3dGYvZ29iamVjdC9HVHlwZWRlZnMuaDogRGVmaW5lIHRoZSBHQnl0ZXMgZGF0YXR5cGUu CisKIDIwMTItMTAtMDMgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtSZWZhY3RvcmluZ10gVGlkeSBOREVCVUcgb3B0aW9uaW5nIGluIFJlZkNvdW50ZWRC YXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmNwcCBiL1Nv dXJjZS9XVEYvd3RmL2dvYmplY3QvR1JlZlB0ci5jcHAKaW5kZXggNWFhMDY3YTYyNzJhMmIzN2Nk NjM0MjEyYjRjODM3ZjY4YzE5NTY4MS4uNzllOTY3YzI1MzViMDI1OWFjZWExMDg4MDJhZmQxZGM5 YTczNjM3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmNwcAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9nb2JqZWN0L0dSZWZQdHIuY3BwCkBAIC02Myw2ICs2MywzNyBA QCB0ZW1wbGF0ZSA8PiB2b2lkIGRlcmVmR1B0cihHTWFpbkxvb3AqIHB0cikKICAgICAgICAgZ19t YWluX2xvb3BfdW5yZWYocHRyKTsKIH0KIAorI2lmIEdMSUJfQ0hFQ0tfVkVSU0lPTigyLCAzMiwg MCkKK3RlbXBsYXRlIDw+IEdCeXRlcyogcmVmR1B0cihHQnl0ZXMqIHB0cikKK3sKKyAgICBpZiAo cHRyKQorICAgICAgICBnX2J5dGVzX3JlZihwdHIpOworICAgIHJldHVybiBwdHI7Cit9CisKK3Rl bXBsYXRlIDw+IHZvaWQgZGVyZWZHUHRyKEdCeXRlcyogcHRyKQoreworICAgIGlmIChwdHIpCisg ICAgICAgIGdfYnl0ZXNfdW5yZWYocHRyKTsKK30KKworIyBlbHNlCisKK3R5cGVkZWYgc3RydWN0 IF9HQnl0ZXMgeworICAgIGJvb2wgZmFrZTsKK30gR0J5dGVzOworCit0ZW1wbGF0ZSA8PiBHQnl0 ZXMqIHJlZkdQdHIoR0J5dGVzKiBwdHIpCit7CisgICAgcmV0dXJuIHB0cjsKK30KKwordGVtcGxh dGUgPD4gdm9pZCBkZXJlZkdQdHIoR0J5dGVzKiBwdHIpCit7Cit9CisKKyNlbmRpZgorCiAjaWYg R0xJQl9DSEVDS19WRVJTSU9OKDIsIDI0LCAwKQogdGVtcGxhdGUgPD4gR1ZhcmlhbnQqIHJlZkdQ dHIoR1ZhcmlhbnQqIHB0cikKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL2dvYmplY3Qv R1JlZlB0ci5oIGIvU291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmgKaW5kZXggZGY2ODg4 YzA2NWMxYTZjYzJmOTU5N2QzMDc5NzRjMmQ2MzliZjA5Yy4uYjA5MDliNjc5MDNiNjU0ZjcxM2Zm NWYyN2M5ZGU0YWI2YTAwYTc0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvZ29iamVjdC9H UmVmUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvZ29iamVjdC9HUmVmUHRyLmgKQEAgLTIxMiw2 ICsyMTIsOCBAQCB0ZW1wbGF0ZSA8PiBHUHRyQXJyYXkqIHJlZkdQdHIoR1B0ckFycmF5Kik7CiB0 ZW1wbGF0ZSA8PiB2b2lkIGRlcmVmR1B0cihHUHRyQXJyYXkqKTsKIHRlbXBsYXRlIDw+IEdCeXRl QXJyYXkqIHJlZkdQdHIoR0J5dGVBcnJheSopOwogdGVtcGxhdGUgPD4gdm9pZCBkZXJlZkdQdHIo R0J5dGVBcnJheSopOwordGVtcGxhdGUgPD4gR0J5dGVzKiByZWZHUHRyKEdCeXRlcyopOwordGVt cGxhdGUgPD4gdm9pZCBkZXJlZkdQdHIoR0J5dGVzKik7CiAKIHRlbXBsYXRlIDx0eXBlbmFtZSBU PiBpbmxpbmUgVCogcmVmR1B0cihUKiBwdHIpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9nb2JqZWN0L0dUeXBlZGVmcy5oIGIvU291cmNlL1dURi93dGYvZ29iamVjdC9HVHlwZWRlZnMu aAppbmRleCA3Nzg1OGQ1ZTljZDg4MDZmNjk0NTAzMDUwZGRjMzk5ZmY1MjdmMWFmLi42NGMzYzU4 ODNkMzIyYjBkNDU5YjRhZTcxODhkN2I3MmZiNzA2MDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9nb2JqZWN0L0dUeXBlZGVmcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL2dvYmplY3QvR1R5 cGVkZWZzLmgKQEAgLTY1LDYgKzY1LDcgQEAgdHlwZWRlZiBzdHJ1Y3QgX0dUaW1lciBHVGltZXI7 CiB0eXBlZGVmIHN0cnVjdCBfR0tleUZpbGUgR0tleUZpbGU7CiB0eXBlZGVmIHN0cnVjdCBfR1B0 ckFycmF5IEdQdHJBcnJheTsKIHR5cGVkZWYgc3RydWN0IF9HQnl0ZUFycmF5IEdCeXRlQXJyYXk7 Cit0eXBlZGVmIHN0cnVjdCBfR0J5dGVzIEdCeXRlczsKIAogI2lmIFVTRShDQUlSTykKIHR5cGVk ZWYgc3RydWN0IF9jYWlyb19zdXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsK