98486 2012-10-04 23:34:52 -0700 [EFL] Fix window resizing / moving in WK1 and WKTR 2012-10-05 00:16:44 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 735399 0 cdumez 2012-10-04 23:34:52 -0700 Window resizing in WK1 should be improved so that the following tests can pass: fast/dom/Window/window-resize.html fast/dom/Window/window-resize-and-move-arguments.html The Window resizing / moving code in EFL's WKTR is wrong. It resizes / moves the view, not the window. We need to use ecore_evas API, not evas_object API. 735410 1 167263 cdumez 2012-10-04 23:43:13 -0700 Created attachment 167263 Patch 735411 2 ryuan.choi 2012-10-04 23:46:56 -0700 (In reply to comment #1) > Created an attachment (id=167263) [details] > Patch LGTM. 735431 3 167263 webkit.review.bot 2012-10-05 00:16:39 -0700 Comment on attachment 167263 Patch Clearing flags on attachment: 167263 Committed r130473: <http://trac.webkit.org/changeset/130473> 735432 4 webkit.review.bot 2012-10-05 00:16:44 -0700 All reviewed patches have been landed. Closing bug. 167263 2012-10-04 23:43:13 -0700 2012-10-05 00:16:39 -0700 Patch 98486_window_resizing.patch text/plain 6005 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMmUyN2Q2Li5hYjEwZjA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSBGaXggd2luZG93IHJlc2l6aW5nIC8gbW92aW5nIGluIFdLMSBhbmQgV0tUUgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0ODYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgMiB3 aW5kb3cgcmVzaXppbmcgLyBtb3ZpbmcgdGVzdHMgbm93IHRoYXQKKyAgICAgICAgdGhlIGltcGxl bWVudGF0aW9uIGZvciB0aG9zZSBoYXMgYmVlbiBmaXhlZCBpbgorICAgICAgICBXZWJLaXQxIEVG TC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx Mi0xMC0wNCAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFR1 cm4gQ29tcG9zaXRpbmcgb24gYnkgZGVmYXVsdCBpbiBXZWJLaXQgYnVpbGQKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC13azEvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxYzcyYzVhLi41MGM3 NmNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sxL1Rlc3RFeHBlY3Rh dGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMS9UZXN0RXhwZWN0YXRpb25z CkBAIC0xMDgsMTAgKzEwOCw2IEBAIHdlYmtpdC5vcmcvYi84NjE4MiBmYXN0L2ZyYW1lcy9zZWFt bGVzcy9zZWFtbGVzcy1pbmhlcml0ZWQtZG9jdW1lbnQtc3R5bGUuaHRtbCBbCiAjIFBhc3NlcyBp biBzb21lIG1hY2hpbmVzIGFuZCBmYWlscyBvbiBvdGhlciAoc3VjaCBhcyB0aGUgYm90cykuCiB3 ZWJraXQub3JnL2IvOTcwMjEgZmFzdC9ldmVudHMvZG9udC1sb29zZS1sYXN0LWV2ZW50Lmh0bWwg WyBGYWlsdXJlIF0KIAotIyBOZXcgd2luZG93cyBhcmUgY3JlYXRlZCB3aXRoIHdyb25nIHNpemUK LXdlYmtpdC5vcmcvYi81Mzk1OSBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXJlc2l6ZS5odG1sIFsg RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvNTM5NTkgZmFzdC9kb20vV2luZG93L3dpbmRvdy1yZXNp emUtYW5kLW1vdmUtYXJndW1lbnRzLmh0bWwgWyBGYWlsdXJlIF0KLQogIyBGZWF0dXJlIG5vdCBt YXR1cmUgeWV0IGFuZCBkaXNhYmxlZCBieSBkZWZhdWx0IG9uIFdlYkNvcmUKIHdlYmtpdC5vcmcv Yi84NzA4OCBmYXN0L2pzL25hbWVzLmh0bWwgWyBGYWlsdXJlIF0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmlu ZGV4IDQ0MGRjYTIuLjhhMDlhNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAor MjAxMi0xMC0wNCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29t PgorCisgICAgICAgIFtFRkxdIEZpeCB3aW5kb3cgcmVzaXppbmcgLyBtb3ZpbmcgaW4gV0sxIGFu ZCBXS1RSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODQ4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKSBjb2RlIHRvIHVzZQorICAgICAgICBlY29y ZV9ldmFzX3JlcXVlc3RfZ2VvbWV0cnlfZ2V0KCkgaW5zdGVhZCBvZgorICAgICAgICBldmFzX29i amVjdF9nZW9tZXRyeV9nZXQoKSBhbmQgdGhlcmVmb3JlIGF2b2lkCisgICAgICAgIHJldHVybmlu ZyBpbmNvcnJlY3QgdmFsdWVzIHdoZW4gdGhlIGVuZ2luZSBoYXMKKyAgICAgICAgbm90IHByb2Nl c3NlZCBhIGNhbGwgdG8gZWNvcmVfZXZhc19tb3ZlX3Jlc2l6ZSgpCisgICAgICAgIHlldC4gVGhp cyBmaXhlcyBhIGNvdXBsZSBvZiBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgVGhlIGNvZGUgd2Fz IGFsc28gcmVmYWN0b3JlZCBhIGJpdCBmb3IKKyAgICAgICAgY29uc2lzdGVuY3kgd2l0aCB0aGUg V2ViS2l0MiBFRkwgaW1wbGVtZW50YXRpb24uCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lQ2xpZW50RWZsOjp3 aW5kb3dSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6c2V0V2luZG93 UmVjdCk6CisKIDIwMTItMTAtMDQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgRmluYWwgcGFydCBvZiAic3luYyIgdG8gImZsdXNoIiByZW5hbWluZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVm bC5jcHAKaW5kZXggYjMzYmZlZS4uZDRiNmQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9l ZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCkBAIC0xMTgsMTIgKzExOCwx MiBAQCB2b2lkIENocm9tZUNsaWVudEVmbDo6Zm9jdXNlZEZyYW1lQ2hhbmdlZChGcmFtZSopCiAK IEZsb2F0UmVjdCBDaHJvbWVDbGllbnRFZmw6OndpbmRvd1JlY3QoKQogewotICAgIEVjb3JlX0V2 YXMqIGVlID0gMDsKLSAgICBpbnQgeCwgeSwgdywgaDsKKyAgICBpbnQgeCwgeSwgd2lkdGgsIGhl aWdodDsKIAotICAgIGVlID0gZWNvcmVfZXZhc19lY29yZV9ldmFzX2dldChldmFzX29iamVjdF9l dmFzX2dldChtX3ZpZXcpKTsKLSAgICBlY29yZV9ldmFzX2dlb21ldHJ5X2dldChlZSwgJngsICZ5 LCAmdywgJmgpOwotICAgIHJldHVybiBGbG9hdFJlY3QoeCwgeSwgdywgaCk7CisgICAgRWNvcmVf RXZhcyogZWUgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0 KG1fdmlldykpOworICAgIGVjb3JlX2V2YXNfcmVxdWVzdF9nZW9tZXRyeV9nZXQoZWUsICZ4LCAm eSwgJndpZHRoLCAmaGVpZ2h0KTsKKworICAgIHJldHVybiBGbG9hdFJlY3QoeCwgeSwgd2lkdGgs IGhlaWdodCk7CiB9CiAKIHZvaWQgQ2hyb21lQ2xpZW50RWZsOjpzZXRXaW5kb3dSZWN0KGNvbnN0 IEZsb2F0UmVjdCYgcmVjdCkKQEAgLTEzMSwxMiArMTMxLDggQEAgdm9pZCBDaHJvbWVDbGllbnRF Zmw6OnNldFdpbmRvd1JlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgIGlmICghZXdrX3Zp ZXdfc2V0dGluZ19lbmFibGVfYXV0b19yZXNpemVfd2luZG93X2dldChtX3ZpZXcpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBFY29yZV9FdmFzKiBlZSA9IDA7Ci0gICAgSW50UmVjdCBpbnRyZWN0 ID0gSW50UmVjdChyZWN0KTsKLQotICAgIGVlID0gZWNvcmVfZXZhc19lY29yZV9ldmFzX2dldChl dmFzX29iamVjdF9ldmFzX2dldChtX3ZpZXcpKTsKLSAgICBlY29yZV9ldmFzX21vdmUoZWUsIGlu dHJlY3QueCgpLCBpbnRyZWN0LnkoKSk7Ci0gICAgZWNvcmVfZXZhc19yZXNpemUoZWUsIGludHJl Y3Qud2lkdGgoKSwgaW50cmVjdC5oZWlnaHQoKSk7CisgICAgRWNvcmVfRXZhcyogZWUgPSBlY29y ZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KG1fdmlldykpOworICAg IGVjb3JlX2V2YXNfbW92ZV9yZXNpemUoZWUsIHJlY3QueCgpLCByZWN0LnkoKSwgcmVjdC53aWR0 aCgpLCByZWN0LmhlaWdodCgpKTsKIH0KIAogRmxvYXRSZWN0IENocm9tZUNsaWVudEVmbDo6cGFn ZVJlY3QoKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGE1MjY0YzMuLjQ1ZGI2MTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMC0wNCAgQ2hyaXN0b3BoZSBE dW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEZpeCB3 aW5kb3cgcmVzaXppbmcgLyBtb3ZpbmcgaW4gV0sxIGFuZCBXS1RSCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODQ4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBQbGF0Zm9ybVdlYlZpZXc6OndpbmRv d0ZyYW1lKCkgYW5kCisgICAgICAgIFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93RnJhbWUoKSBp biBFRkwncyBXS1RSIHNvCisgICAgICAgIHRoYXQgaXQgcmVzaXplcyAvIG1vdmVzIHRoZSB3aW5k b3csIG5vdCB0aGUgdmlldy4KKworICAgICAgICBUaGUgbmV3IGNvZGUgbWF0Y2hlcyB0aGUgaW1w bGVtZW50YXRpb24gaW4gRXdrVmlldydzCisgICAgICAgIFVJQ2xpZW50LgorCisgICAgICAgICog V2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcDoKKyAgICAgICAgKFdU Ujo6UGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dGcmFtZSk6CisgICAgICAgIChXVFI6OlBsYXRmb3Jt V2ViVmlldzo6c2V0V2luZG93RnJhbWUpOgorCiAyMDEyLTEwLTA0ICBSaWsgQ2FiYW5pZXIgIDxj YWJhbmllckBhZG9iZS5jb20+CiAKICAgICAgICAgVHVybiBDb21wb3NpdGluZyBvbiBieSBkZWZh dWx0IGluIFdlYktpdCBidWlsZApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9l ZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZWZsL1Bs YXRmb3JtV2ViVmlld0VmbC5jcHAKaW5kZXggZjQzMDBkYy4uMDYxODdhMCAxMDA2NDQKLS0tIGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvUGxhdGZvcm1XZWJWaWV3RWZsLmNwcAorKysgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL2VmbC9QbGF0Zm9ybVdlYlZpZXdFZmwuY3BwCkBAIC03NCwx NiArNzQsMTggQEAgdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OmZvY3VzKCkKIAogV0tSZWN0IFBsYXRm b3JtV2ViVmlldzo6d2luZG93RnJhbWUoKQogewotICAgIEV2YXNfQ29vcmQgeCwgeSwgd2lkdGgs IGhlaWdodDsKLSAgICBldmFzX29iamVjdF9nZW9tZXRyeV9nZXQobV92aWV3LCAmeCwgJnksICZ3 aWR0aCwgJmhlaWdodCk7CisgICAgaW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisKKyAgICBFY29y ZV9FdmFzKiBlZSA9IGVjb3JlX2V2YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19n ZXQobV92aWV3KSk7CisgICAgZWNvcmVfZXZhc19yZXF1ZXN0X2dlb21ldHJ5X2dldChlZSwgJngs ICZ5LCAmd2lkdGgsICZoZWlnaHQpOwogCiAgICAgcmV0dXJuIFdLUmVjdE1ha2UoeCwgeSwgd2lk dGgsIGhlaWdodCk7CiB9CiAKIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjpzZXRXaW5kb3dGcmFtZShX S1JlY3QgZnJhbWUpCiB7Ci0gICAgZXZhc19vYmplY3RfbW92ZShtX3ZpZXcsIGZyYW1lLm9yaWdp bi54LCBmcmFtZS5vcmlnaW4ueSk7Ci0gICAgcmVzaXplVG8oZnJhbWUuc2l6ZS53aWR0aCwgZnJh bWUuc2l6ZS5oZWlnaHQpOworICAgIEVjb3JlX0V2YXMqIGVlID0gZWNvcmVfZXZhc19lY29yZV9l dmFzX2dldChldmFzX29iamVjdF9ldmFzX2dldChtX3ZpZXcpKTsKKyAgICBlY29yZV9ldmFzX21v dmVfcmVzaXplKGVlLCBmcmFtZS5vcmlnaW4ueCwgZnJhbWUub3JpZ2luLnksIGZyYW1lLnNpemUu d2lkdGgsIGZyYW1lLnNpemUuaGVpZ2h0KTsKIH0KIAogdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OmFk ZENocm9tZUlucHV0RmllbGQoKQo=