98473 2012-10-04 18:51:53 -0700 SVGAttributeHashTranslator does not need to copy QualifiedName in the common case 2012-10-05 17:14:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98467 1 eric eric abarth darin fmalita pdr schenney webkit.review.bot oldest_to_newest 735218 0 eric 2012-10-04 18:51:53 -0700 SVGAttributeHashTranslator does not need to copy QualifiedName in the common case 735219 1 167220 eric 2012-10-04 18:52:07 -0700 Created attachment 167220 Patch 735220 2 eric 2012-10-04 18:52:44 -0700 This makes SVG animation (and anything that changes SVG attributes) much slower than necessary. 735221 3 eric 2012-10-04 18:53:36 -0700 I found this while working on another bug. I sampled my test case and found this code to be super-hot. This patch made the most of the samples in this area go away. :) 735223 4 167222 eric 2012-10-04 18:56:13 -0700 Created attachment 167222 Patch 735300 5 167222 webkit.review.bot 2012-10-04 21:22:22 -0700 Comment on attachment 167222 Patch Clearing flags on attachment: 167222 Committed r130456: <http://trac.webkit.org/changeset/130456> 735301 6 webkit.review.bot 2012-10-04 21:22:25 -0700 All reviewed patches have been landed. Closing bug. 736110 7 darin 2012-10-05 17:14:52 -0700 Oh my god! Good one. 167220 2012-10-04 18:52:07 -0700 2012-10-04 18:56:11 -0700 Patch bug-98473-20121004185116.patch text/plain 1839 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgzZGM4NmFmMjcyODZl OWU5M2IwZWYzMjQwYWI1ZGE0NDM2MjFlZi4uOGIyZDc4MTc5ODE2NWUxZDkxMzhhMjYwMzRmNTI0 YmY0MWY3MjZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA0ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBTVkdBdHRyaWJ1dGVIYXNoVHJh bnNsYXRvciBkb2VzIG5vdCBuZWVkIHRvIGNvcHkgUXVhbGlmaWVkTmFtZSBpbiB0aGUgY29tbW9u IGNhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 NDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRk aXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlv bmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25zIGJlbG93IChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvU1ZHRWxl bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQXR0cmlidXRlSGFzaFRyYW5zbGF0b3I6Omhh c2gpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQXR0cmlidXRlSGFzaFRyYW5zbGF0b3I6OmVxdWFs KToKKwogMjAxMi0xMC0wMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgTWFrZSB0YWJsZXMgd2hpY2ggZG9uJ3QgdXNlIGNvbC9yb3cgc3BhbiBtdWNoIGZhc3RlciB0 byBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmggYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5oCmluZGV4IGYzMzFhOTYyNjk1NzFjNzVjOTcw MDRkMzk0ZmVhNjgzYTA5OTAwNDYuLmMzZTZiNjFmNzFjNjY4YTYwNDdkZDE1NjlmNDVhMDllOWU1 NTIxZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaApAQCAtMTU3LDEyICsxNTcsMTMgQEAgcHJp dmF0ZToKIH07CiAKIHN0cnVjdCBTVkdBdHRyaWJ1dGVIYXNoVHJhbnNsYXRvciB7Ci0gICAgc3Rh dGljIHVuc2lnbmVkIGhhc2goUXVhbGlmaWVkTmFtZSBrZXkpCisgICAgc3RhdGljIHVuc2lnbmVk IGhhc2goY29uc3QgUXVhbGlmaWVkTmFtZSYga2V5KQogICAgIHsKLSAgICAgICAga2V5LnNldFBy ZWZpeChudWxsQXRvbSk7CisgICAgICAgIGlmIChrZXkuaGFzUHJlZml4KCkpCisgICAgICAgICAg ICByZXR1cm4gRGVmYXVsdEhhc2g8UXVhbGlmaWVkTmFtZT46Okhhc2g6Omhhc2goUXVhbGlmaWVk TmFtZShudWxsQXRvbSwga2V5LmxvY2FsTmFtZSgpLCBrZXkubmFtZXNwYWNlVVJJKCkpKTsKICAg ICAgICAgcmV0dXJuIERlZmF1bHRIYXNoPFF1YWxpZmllZE5hbWU+OjpIYXNoOjpoYXNoKGtleSk7 CiAgICAgfQotICAgIHN0YXRpYyBib29sIGVxdWFsKFF1YWxpZmllZE5hbWUgYSwgUXVhbGlmaWVk TmFtZSBiKSB7IHJldHVybiBhLm1hdGNoZXMoYik7IH0KKyAgICBzdGF0aWMgYm9vbCBlcXVhbChj b25zdCBRdWFsaWZpZWROYW1lJiBhLCBjb25zdCBRdWFsaWZpZWROYW1lJiBiKSB7IHJldHVybiBh Lm1hdGNoZXMoYik7IH0KIH07CiAKIGlubGluZSBTVkdFbGVtZW50KiB0b1NWR0VsZW1lbnQoRWxl bWVudCogZWxlbWVudCkK 167222 2012-10-04 18:56:13 -0700 2012-10-04 21:22:22 -0700 Patch bug-98473-20121004185522.patch text/plain 2039 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgzZGM4NmFmMjcyODZl OWU5M2IwZWYzMjQwYWI1ZGE0NDM2MjFlZi4uZDQ3MjJlNDIyZjE4YmFiM2VkNTRjNTdmOWFhNzc2 ZjU3OWU1ZTMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTA0ICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBTVkdBdHRyaWJ1dGVIYXNoVHJh bnNsYXRvciBkb2VzIG5vdCBuZWVkIHRvIGNvcHkgUXVhbGlmaWVkTmFtZSBpbiB0aGUgY29tbW9u IGNhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 NDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSB0 ZXN0ZWQgdGhpcyB1c2luZyBpbnN0cnVtZW50cyBvbiBhIHRlc3QgY2FzZSB3aGljaCBtb2RpZmll ZCBTVkcgYXR0cmlidXRlcyBpbiBhIGxvb3AuCisgICAgICAgIEkgYmVsaWV2ZSBwZHIgaGFzIHNv bWUgcGVyZi10ZXN0cyBpbiB0aGlzIGFyZWEsIGJ1dCB0aGV5IHdlcmVuJ3QgbmVlZGVkIGhlcmUu ICBBIHNpbXBsZSBzYW1wbGUgc2hvd2VkIHRoaXMgYXMgYSBodWdlIHdpbiwKKyAgICAgICAgc2lu Y2Ugd2UncmUgbm8gbG9uZ2VyIGNyZWF0aW5nIGEgUXVhbGlmaWVkTmFtZSAoYW5kIHRodXMgYWRk aW5nIGl0IHRvIHRoZSBoYXNoKSBvbiBlYWNoIFF1YWxpZmllZE5hbWUtYmFzZWQgbG9va3VwIGlu IFNWRy4KKworICAgICAgICAqIHN2Zy9TVkdFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpT VkdBdHRyaWJ1dGVIYXNoVHJhbnNsYXRvcjo6aGFzaCk6CisgICAgICAgIChXZWJDb3JlOjpTVkdB dHRyaWJ1dGVIYXNoVHJhbnNsYXRvcjo6ZXF1YWwpOgorCiAyMDEyLTEwLTAzICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIHRhYmxlcyB3aGljaCBkb24ndCB1 c2UgY29sL3JvdyBzcGFuIG11Y2ggZmFzdGVyIHRvIGxheW91dApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50 LmgKaW5kZXggZjMzMWE5NjI2OTU3MWM3NWM5NzAwNGQzOTRmZWE2ODNhMDk5MDA0Ni4uYzNlNmI2 MWY3MWM2NjhhNjA0N2RkMTU2OWY0NWEwOWU5ZTU1MjFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvc3ZnL1NWR0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVu dC5oCkBAIC0xNTcsMTIgKzE1NywxMyBAQCBwcml2YXRlOgogfTsKIAogc3RydWN0IFNWR0F0dHJp YnV0ZUhhc2hUcmFuc2xhdG9yIHsKLSAgICBzdGF0aWMgdW5zaWduZWQgaGFzaChRdWFsaWZpZWRO YW1lIGtleSkKKyAgICBzdGF0aWMgdW5zaWduZWQgaGFzaChjb25zdCBRdWFsaWZpZWROYW1lJiBr ZXkpCiAgICAgewotICAgICAgICBrZXkuc2V0UHJlZml4KG51bGxBdG9tKTsKKyAgICAgICAgaWYg KGtleS5oYXNQcmVmaXgoKSkKKyAgICAgICAgICAgIHJldHVybiBEZWZhdWx0SGFzaDxRdWFsaWZp ZWROYW1lPjo6SGFzaDo6aGFzaChRdWFsaWZpZWROYW1lKG51bGxBdG9tLCBrZXkubG9jYWxOYW1l KCksIGtleS5uYW1lc3BhY2VVUkkoKSkpOwogICAgICAgICByZXR1cm4gRGVmYXVsdEhhc2g8UXVh bGlmaWVkTmFtZT46Okhhc2g6Omhhc2goa2V5KTsKICAgICB9Ci0gICAgc3RhdGljIGJvb2wgZXF1 YWwoUXVhbGlmaWVkTmFtZSBhLCBRdWFsaWZpZWROYW1lIGIpIHsgcmV0dXJuIGEubWF0Y2hlcyhi KTsgfQorICAgIHN0YXRpYyBib29sIGVxdWFsKGNvbnN0IFF1YWxpZmllZE5hbWUmIGEsIGNvbnN0 IFF1YWxpZmllZE5hbWUmIGIpIHsgcmV0dXJuIGEubWF0Y2hlcyhiKTsgfQogfTsKIAogaW5saW5l IFNWR0VsZW1lbnQqIHRvU1ZHRWxlbWVudChFbGVtZW50KiBlbGVtZW50KQo=