98468 2012-10-04 17:21:36 -0700 [chromium] Scale plugin container by frameScaleFactor 2012-10-04 21:14:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aelias aelias abarth aelias qinmin webkit.review.bot oldest_to_newest 735158 0 aelias 2012-10-04 17:21:36 -0700 [chromium] Scale plugin container by frameScaleFactor 735160 1 167212 aelias 2012-10-04 17:22:55 -0700 Created attachment 167212 Patch 735168 2 167212 abarth 2012-10-04 17:31:53 -0700 Comment on attachment 167212 Patch Have you checked that this is still an issue? 735169 3 aelias 2012-10-04 17:33:15 -0700 Yes. I was going to delete it but it turned out to still be needed. 735170 4 167212 abarth 2012-10-04 17:33:20 -0700 Comment on attachment 167212 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167212&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:121 > + scaledDamageRect.scale(frameScaleFactor); > + scaledDamageRect.move(-frameRect().x() * (frameScaleFactor - 1), -frameRect().y() * (frameScaleFactor - 1)); Is there a function on mainFrame that can do this math for us? It seems strange for everyone who needs to transform a rect by the frame scale factor to do all this work. 735171 5 167212 abarth 2012-10-04 17:34:10 -0700 Comment on attachment 167212 Patch Thanks for the patch. Please consider the comment above before landing. 735187 6 167212 aelias 2012-10-04 17:44:40 -0700 Comment on attachment 167212 Patch This is the only instance of this pattern because it's a non-absolute coordinate, so I don't think it's worth a general method. Thanks, submitting. 735293 7 167212 webkit.review.bot 2012-10-04 21:14:30 -0700 Comment on attachment 167212 Patch Clearing flags on attachment: 167212 Committed r130455: <http://trac.webkit.org/changeset/130455> 735294 8 webkit.review.bot 2012-10-04 21:14:34 -0700 All reviewed patches have been landed. Closing bug. 167212 2012-10-04 17:22:55 -0700 2012-10-04 21:14:30 -0700 Patch bug-98468-20121004172205.patch text/plain 2347 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGYyYWY3YjExY2Q3Yjc4NTc5NjJiODMyZDJlZDEzM2Y1ODg5YWI3ZGEuLmE5YmU2OWFmMGE2M2My MTEyY2U5NWI2MjA5YzI0M2ZkY2M1MWFjMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDQgIEFsZXhhbmRyZSBFbGlhcyAgPGFlbGlhc0BjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTY2FsZSBwbHVnaW4gY29udGFpbmVyIGJ5 IGZyYW1lU2NhbGVGYWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk4NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUGx1Z2luIGNvbnRhaW5lcnMgKGZvciBpbnZhbGlkIHBsdWdpbnMpIHdlcmVuJ3Qg dGFraW5nIGludG8gYWNjb3VudAorICAgICAgICBmcmFtZVNjYWxlRmFjdG9yLCBsb29raW5nIGN1 dCBvZmYgd2hlbiB0aGF0IHdhcyBub24tMS4KKworICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250 YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6 cGFpbnQpOgorCiAyMDEyLTEwLTAzICBKZWZmIFRpbWFudXMgIDx0d2l6QGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSBzZXR0aW5ncyB2YWx1ZSB0byBjb25kaXRpb25h bGx5IGVuYWJsZSBwaW5jaC16b29tIHNjYWxpbmcgaW4gdGhlIENocm9taXVtIGNvbXBvc2l0b3Iu ICBUaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNv bnRhaW5lckltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29u dGFpbmVySW1wbC5jcHAKaW5kZXggZTNjNGJlZmI4M2YyMWFjZTllODA3YTViMGZmMzEyNGJjNTNm ODI3Ni4uNWU5OTVlYjMyZjUwNzgzZDQ2YzY0ZTkzODFjODNhNzEzNDM1OWU1OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5j cHAKQEAgLTExNSw4ICsxMTUsMTMgQEAgdm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpwYWlu dChHcmFwaGljc0NvbnRleHQqIGdjLCBjb25zdCBJbnRSZWN0JiBkYW1hZ2VSZWMKICAgICBpZiAo IXBhcmVudCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBGbG9hdFJlY3Qgc2NhbGVkRGFtYWdl UmVjdCA9IGRhbWFnZVJlY3Q7CisgICAgZmxvYXQgZnJhbWVTY2FsZUZhY3RvciA9IG1fZWxlbWVu dC0+ZG9jdW1lbnQoKS0+cGFnZSgpLT5tYWluRnJhbWUoKS0+ZnJhbWVTY2FsZUZhY3RvcigpOwor ICAgIHNjYWxlZERhbWFnZVJlY3Quc2NhbGUoZnJhbWVTY2FsZUZhY3Rvcik7CisgICAgc2NhbGVk RGFtYWdlUmVjdC5tb3ZlKC1mcmFtZVJlY3QoKS54KCkgKiAoZnJhbWVTY2FsZUZhY3RvciAtIDEp LCAtZnJhbWVSZWN0KCkueSgpICogKGZyYW1lU2NhbGVGYWN0b3IgLSAxKSk7CisKICAgICAvLyBE b24ndCBwYWludCBhbnl0aGluZyBpZiB0aGUgcGx1Z2luIGRvZXNuJ3QgaW50ZXJzZWN0IHRoZSBk YW1hZ2UgcmVjdC4KLSAgICBpZiAoIWZyYW1lUmVjdCgpLmludGVyc2VjdHMoZGFtYWdlUmVjdCkp CisgICAgaWYgKCFmcmFtZVJlY3QoKS5pbnRlcnNlY3RzKGVuY2xvc2luZ0ludFJlY3Qoc2NhbGVk RGFtYWdlUmVjdCkpKQogICAgICAgICByZXR1cm47CiAKICAgICBnYy0+c2F2ZSgpOwpAQCAtMTMy LDcgKzEzNyw3IEBAIHZvaWQgV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6cGFpbnQoR3JhcGhpY3ND b250ZXh0KiBnYywgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjCiAgICAgV2ViQ2FudmFzKiBjYW52 YXMgPSBnYy0+cGxhdGZvcm1Db250ZXh0KCktPmNhbnZhcygpOwogCiAgICAgSW50UmVjdCB3aW5k b3dSZWN0ID0KLSAgICAgICAgSW50UmVjdCh2aWV3LT5jb250ZW50c1RvV2luZG93KGRhbWFnZVJl Y3QubG9jYXRpb24oKSksIGRhbWFnZVJlY3Quc2l6ZSgpKTsKKyAgICAgICAgSW50UmVjdCh2aWV3 LT5jb250ZW50c1RvV2luZG93KGVuY2xvc2luZ0ludFJlY3Qoc2NhbGVkRGFtYWdlUmVjdCkpKTsK ICAgICBtX3dlYlBsdWdpbi0+cGFpbnQoY2FudmFzLCB3aW5kb3dSZWN0KTsKIAogICAgIGdjLT5y ZXN0b3JlKCk7Cg==