98459 2012-10-04 16:00:40 -0700 [Chromium] Improve SocketStreamHandle::send() stability 2012-10-04 23:39:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi webkit.review.bot yutak oldest_to_newest 735094 0 bashi 2012-10-04 16:00:40 -0700 It's not often, but it seems that m_socket can be null in SocketStreamHandle::send(). It should not be NULL there, but for stability, we are going to add a null check. See http://code.google.com/p/chromium/issues/detail?id=153440 more details. 735097 1 167195 bashi 2012-10-04 16:06:25 -0700 Created attachment 167195 Patch 735240 2 167195 yutak 2012-10-04 19:17:11 -0700 Comment on attachment 167195 Patch Looks OK. 735245 3 167195 bashi 2012-10-04 19:22:24 -0700 Comment on attachment 167195 Patch Thank you for review! 735282 4 167195 webkit.review.bot 2012-10-04 20:57:35 -0700 Comment on attachment 167195 Patch Rejecting attachment 167195 from commit-queue. New failing tests: fast/images/paint-subrect-grid.html Full output: http://queues.webkit.org/results/14176352 735403 5 167195 webkit.review.bot 2012-10-04 23:39:11 -0700 Comment on attachment 167195 Patch Clearing flags on attachment: 167195 Committed r130468: <http://trac.webkit.org/changeset/130468> 735404 6 webkit.review.bot 2012-10-04 23:39:14 -0700 All reviewed patches have been landed. Closing bug. 167195 2012-10-04 16:06:25 -0700 2012-10-04 23:39:11 -0700 Patch bug-98459-20121005080534.patch text/plain 1818 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVhOWQ0YmM1YWE2OWU4OWQyODAxMDIzN2JiNjRiZTU3NDMyMTVlMjguLjM0MTA0MmYwYzM2N2Uw ZDkzMmRjYjZlYjY0MDJkODhmNzMwZDk3NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDQgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gSW1wcm92ZSBTb2NrZXRTdHJlYW1IYW5k bGU6OnNlbmQoKSBzdGFiaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk4NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQXZvaWQgbnVsbCBkZXJlZmVyZW5jZSBpbiBTb2NrZXRTdHJlYW1IYW5kbGVJ bnRlcm5hbDo6c2VuZCgpLgorICAgICAgICBObyBjaGFuZ2VzIGluIGJlaGF2aW9yLgorCisgICAg ICAgICogc3JjL1NvY2tldFN0cmVhbUhhbmRsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb2Nr ZXRTdHJlYW1IYW5kbGVJbnRlcm5hbDo6c2VuZCk6CisKIDIwMTItMTAtMDQgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU3RhbmRhcmRpemUgb24gImZs dXNoIiB0ZXJtaW5vbG9neSBmb3IgY29tcG9zaXRpbmcgbGF5ZXIgZmx1c2hpbmcvc3luY2luZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU29ja2V0U3RyZWFtSGFuZGxl LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NvY2tldFN0cmVhbUhhbmRsZS5jcHAK aW5kZXggYjM1MTQyMGMxZmJmY2I3YmVmY2ZiNWQ5Mzc2YjE5ODVlNDE1OTVkMC4uYjE2NzBiZjY0 NWE1OTQzZjlmMzg2MTMwYjhjYTJmYzNmMjk2MzZiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvU29ja2V0U3RyZWFtSGFuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9Tb2NrZXRTdHJlYW1IYW5kbGUuY3BwCkBAIC03Miw3ICs3MiwxMyBAQCB2 b2lkIFNvY2tldFN0cmVhbUhhbmRsZUludGVybmFsOjpjb25uZWN0KGNvbnN0IEtVUkwmIHVybCkK IGludCBTb2NrZXRTdHJlYW1IYW5kbGVJbnRlcm5hbDo6c2VuZChjb25zdCBjaGFyKiBkYXRhLCBp bnQgbGVuKQogewogICAgIExPRyhOZXR3b3JrLCAic2VuZCBsZW49JWQiLCBsZW4pOwotICAgIEFT U0VSVChtX3NvY2tldCk7CisgICAgLy8gRklYTUU6IHxtX3NvY2tldHwgc2hvdWxkIG5vdCBiZSBu dWxsIGhlcmUsIGJ1dCBpdCBzZWVtcyB0aGF0IHRoZXJlIGlzIHRoZQorICAgIC8vIGNhc2UuIFdl IHNob3VsZCBmaWd1cmUgb3V0IHN1Y2ggYSBwYXRoIGFuZCBmaXggaXQgcmF0aGVyIHRoYW4gY2hl Y2tpbmcKKyAgICAvLyBudWxsIGhlcmUuCisgICAgaWYgKCFtX3NvY2tldCkgeworICAgICAgICBM T0coTmV0d29yaywgIm1fc29ja2V0IGlzIG51bGwgd2hlbiBzZW5kaW5nLiBJdCBzaG91bGQgbm90 IGJlLiIpOworICAgICAgICByZXR1cm4gMDsKKyAgICB9CiAgICAgaWYgKG1fcGVuZGluZ0Ftb3Vu dFNlbnQgKyBsZW4gPj0gbV9tYXhQZW5kaW5nU2VuZEFsbG93ZWQpCiAgICAgICAgIGxlbiA9IG1f bWF4UGVuZGluZ1NlbmRBbGxvd2VkIC0gbV9wZW5kaW5nQW1vdW50U2VudCAtIDE7CiAK