98445 2012-10-04 13:25:02 -0700 [V8] NotificationCenter leaks because it uses buggy custom bindings 2012-10-04 19:18:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet ojan tony webkit.review.bot oldest_to_newest 734961 0 abarth 2012-10-04 13:25:02 -0700 [V8] NotificationCenter leaks because it uses buggy custom bindings 734963 1 167164 abarth 2012-10-04 13:25:35 -0700 Created attachment 167164 Patch 735180 2 167164 webkit.review.bot 2012-10-04 17:36:59 -0700 Comment on attachment 167164 Patch Rejecting attachment 167164 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ng Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Unreviewed, rolling out r130419. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14178263 735234 3 167164 webkit.review.bot 2012-10-04 19:05:39 -0700 Comment on attachment 167164 Patch Rejecting attachment 167164 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hangeLog Failed to merge in the changes. Patch failed at 0001 Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14181198 735241 4 167164 abarth 2012-10-04 19:18:25 -0700 Comment on attachment 167164 Patch Clearing flags on attachment: 167164 Committed r130446: <http://trac.webkit.org/changeset/130446> 735242 5 abarth 2012-10-04 19:18:27 -0700 All reviewed patches have been landed. Closing bug. 167164 2012-10-04 13:25:35 -0700 2012-10-04 19:18:25 -0700 Patch bug-98445-20121004132445.patch text/plain 3763 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVmOWIzZDRhODM2OTI3 MjU1MDA1OWQxZmRkYjg4NTJlZTk5ZDViZi4uNDVmOTZkOGZhNWVjMGU5NDk2ZmViYTc5MWFhMzQw NGFlMjE1MGRmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBOb3RpZmljYXRpb25D ZW50ZXIgbGVha3MgYmVjYXVzZSBpdCB1c2VzIGJ1Z2d5IGN1c3RvbSBiaW5kaW5ncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0NDUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIHJlYXNv biB0byB1c2UgY3VzdG9tIGJpbmRpbmdzIGhlcmUuIEFsbCB0aGV5IGRvIGlzIGNhdXNlIGxlYWtz Li4KKworICAgICAgICAqIE1vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIu aWRsOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlmaWNhdGlvbkNlbnRlckN1 c3RvbS5jcHA6CisKIDIwMTItMTAtMDQgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4K IAogICAgICAgICBGaXggPGlucHV0IHR5cGU9Im1vbnRoIj4gdGVzdHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaWRs IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRl ci5pZGwKaW5kZXggNjA2NTFkYTRjZDkxZDU0ZjY1ZjAwZTVkZGE1ZmQwMTMwMjgyYWQ3Yi4uODMx YmYyNjU5NmY1MzZkODA1MDg4ZWZkZjAyOWQ2MWU4ODhmMDY0NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRl ci5pZGwKQEAgLTM3LDkgKzM3LDkgQEAgbW9kdWxlIHRocmVhZHMgewogICAgICAgICBPbWl0Q29u c3RydWN0b3IKICAgICBdIE5vdGlmaWNhdGlvbkNlbnRlciB7CiAjaWYgIWRlZmluZWQoRU5BQkxF X1RFWFRfTk9USUZJQ0FUSU9OU19PTkxZKSB8fCAhRU5BQkxFX1RFWFRfTk9USUZJQ0FUSU9OU19P TkxZCi0gICAgICAgW1Y4Q3VzdG9tLCBWOEVuYWJsZWRQZXJDb250ZXh0PWh0bWxOb3RpZmljYXRp b25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNhdGlvbihpbiBET01TdHJpbmcgdXJs KSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKKyAgICAgICBbVjhFbmFibGVkUGVyQ29udGV4dD1odG1s Tm90aWZpY2F0aW9uc10gTm90aWZpY2F0aW9uIGNyZWF0ZUhUTUxOb3RpZmljYXRpb24oaW4gRE9N U3RyaW5nIHVybCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAjZW5kaWYKLSAgICAgICBbVjhDdXN0 b21dIE5vdGlmaWNhdGlvbiBjcmVhdGVOb3RpZmljYXRpb24oaW4gRE9NU3RyaW5nIGljb25Vcmws IGluIERPTVN0cmluZyB0aXRsZSwgaW4gRE9NU3RyaW5nIGJvZHkpIHJhaXNlcyhET01FeGNlcHRp b24pOworICAgICAgIE5vdGlmaWNhdGlvbiBjcmVhdGVOb3RpZmljYXRpb24oaW4gRE9NU3RyaW5n IGljb25VcmwsIGluIERPTVN0cmluZyB0aXRsZSwgaW4gRE9NU3RyaW5nIGJvZHkpIHJhaXNlcyhE T01FeGNlcHRpb24pOwogCiAgICAgICAgaW50IGNoZWNrUGVybWlzc2lvbigpOwogICAgICAgIFtD dXN0b21dIHZvaWQgcmVxdWVzdFBlcm1pc3Npb24oaW4gVm9pZENhbGxiYWNrIGNhbGxiYWNrKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlmaWNh dGlvbkNlbnRlckN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhOb3RpZmljYXRpb25DZW50ZXJDdXN0b20uY3BwCmluZGV4IDA5OTFmYjE4OGJjNDY5MGE2OTQy OTU4YTEyYjk1Zjk4NmZkODExYTguLjczZWQzNDNkMWI2N2YwMTFjYTBlNzJhYzEyYjg4M2MxZTQ2 YTZlNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5v dGlmaWNhdGlvbkNlbnRlckN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4Tm90aWZpY2F0aW9uQ2VudGVyQ3VzdG9tLmNwcApAQCAtNDYsMzcgKzQ2LDYg QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhOb3Rp ZmljYXRpb25DZW50ZXI6OmNyZWF0ZUhUTUxOb3RpZmljYXRpb25DYWxsYmFjayhjb25zdCB2ODo6 QXJndW1lbnRzJiBhcmdzKQotewotICAgIElOQ19TVEFUUygiRE9NLk5vdGlmaWNhdGlvbkNlbnRl ci5DcmVhdGVIVE1MTm90aWZpY2F0aW9uKCkiKTsKLSAgICBOb3RpZmljYXRpb25DZW50ZXIqIG5v dGlmaWNhdGlvbkNlbnRlciA9IFY4Tm90aWZpY2F0aW9uQ2VudGVyOjp0b05hdGl2ZShhcmdzLkhv bGRlcigpKTsKLQotICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIFN0cmluZyB1cmwgPSB0 b1dlYkNvcmVTdHJpbmcoYXJnc1swXSk7Ci0gICAgUmVmUHRyPE5vdGlmaWNhdGlvbj4gbm90aWZp Y2F0aW9uID0gbm90aWZpY2F0aW9uQ2VudGVyLT5jcmVhdGVIVE1MTm90aWZpY2F0aW9uKHVybCwg ZWMpOwotCi0gICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gc2V0RE9NRXhjZXB0aW9uKGVjLCBh cmdzLkdldElzb2xhdGUoKSk7Ci0KLSAgICBub3RpZmljYXRpb24tPnJlZigpOwotICAgIHJldHVy biB0b1Y4KG5vdGlmaWNhdGlvbi5nZXQoKSwgYXJncy5Ib2xkZXIoKSwgYXJncy5HZXRJc29sYXRl KCkpOwotfQotCi12ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhOb3RpZmljYXRpb25DZW50ZXI6OmNy ZWF0ZU5vdGlmaWNhdGlvbkNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCi17Ci0g ICAgSU5DX1NUQVRTKCJET00uTm90aWZpY2F0aW9uQ2VudGVyLkNyZWF0ZU5vdGlmaWNhdGlvbigp Iik7Ci0gICAgTm90aWZpY2F0aW9uQ2VudGVyKiBub3RpZmljYXRpb25DZW50ZXIgPSBWOE5vdGlm aWNhdGlvbkNlbnRlcjo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7Ci0KLSAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKLSAgICBSZWZQdHI8Tm90aWZpY2F0aW9uPiBub3RpZmljYXRpb24gPSBub3Rp ZmljYXRpb25DZW50ZXItPmNyZWF0ZU5vdGlmaWNhdGlvbih0b1dlYkNvcmVTdHJpbmcoYXJnc1sw XSksIHRvV2ViQ29yZVN0cmluZyhhcmdzWzFdKSwgdG9XZWJDb3JlU3RyaW5nKGFyZ3NbMl0pLCBl Yyk7Ci0KLSAgICBpZiAoZWMpCi0gICAgICAgIHJldHVybiBzZXRET01FeGNlcHRpb24oZWMsIGFy Z3MuR2V0SXNvbGF0ZSgpKTsKLQotICAgIG5vdGlmaWNhdGlvbi0+cmVmKCk7Ci0gICAgcmV0dXJu IHRvVjgobm90aWZpY2F0aW9uLmdldCgpLCBhcmdzLkhvbGRlcigpLCBhcmdzLkdldElzb2xhdGUo KSk7Ci19Ci0KIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOE5vdGlmaWNhdGlvbkNlbnRlcjo6cmVx dWVzdFBlcm1pc3Npb25DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogewogICAg IElOQ19TVEFUUygiRE9NLk5vdGlmaWNhdGlvbkNlbnRlci5SZXF1ZXN0UGVybWlzc2lvbigpIik7 Cg==