98444 2012-10-04 13:24:33 -0700 Removing the unused member variable m_wasMalformed from HTMLFormElement class and its related code frgment. 2012-10-04 21:59:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 1 pravind.2k4 pravind.2k4 darin eric jchaffraix mifenton tkent webkit.review.bot oldest_to_newest 734960 0 pravind.2k4 2012-10-04 13:24:33 -0700 HTMLFormElement class contains a private member m_wasMalformed. Initial botton margin was supposed to be handled separately for malformed <form> tags. However currently this variable is not being set(effectly not used by any code). Also HTML5 spec does mention anything regarding bottom margin handling for malformed <form>. Also see https://bugs.webkit.org/show_bug.cgi?id=86746#c9 https://bugs.webkit.org/show_bug.cgi?id=86746#c10 As the code related to m_wasMalformed currently does not have any notable use it can be safely removed. 735110 1 167199 pravind.2k4 2012-10-04 16:27:20 -0700 Created attachment 167199 Patch 735287 2 167199 webkit.review.bot 2012-10-04 21:08:09 -0700 Comment on attachment 167199 Patch Rejecting attachment 167199 from commit-queue. New failing tests: fast/images/paint-subrect-grid.html Full output: http://queues.webkit.org/results/14175376 735327 3 167199 webkit.review.bot 2012-10-04 21:59:39 -0700 Comment on attachment 167199 Patch Clearing flags on attachment: 167199 Committed r130461: <http://trac.webkit.org/changeset/130461> 735328 4 webkit.review.bot 2012-10-04 21:59:42 -0700 All reviewed patches have been landed. Closing bug. 167199 2012-10-04 16:27:20 -0700 2012-10-04 21:59:39 -0700 Patch bug-98444-20121005045759.patch text/plain 3662 pravind.2k4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDQzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEwLTA0ICBQcmF2aW4g RCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICBSZW1vdmluZyB0aGUgdW51c2Vk IG1lbWJlciB2YXJpYWJsZSBtX3dhc01hbGZvcm1lZCBmcm9tIEhUTUxGb3JtRWxlbWVudCBjbGFz cyBhbmQgaXRzIHJlbGF0ZWQgY29kZSBmcmdtZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWVtYmVyIHZhcmlhYmxlIG1fd2FzTWFsZm9ybWVk IG9mIEhUTUxGb3JtRWxlbWVudCBjbGFzcyB3YXMgdXNlZCB0byBkZXRlcm1pbmUgaWYgdGhlIDxm b3JtPiB0YWcgd2FzIG1hbGZvcm1lZCBvciBub3QuCisgICAgICAgIFRoaXMgaW5mb3JtYXRpb24g d2FzIHVzZWQgZWxzZXdoZXJlIHRvIGRlY2lkZSBpZiBib3R0b20gbWFyZ2lucyBoYXZlIHRvIGJl IGluY2x1ZGVkIGZvciBzdWNoIGEgPGZvcm0+LgorICAgICAgICBIb3dldmVyIGN1cnJlbnRseSB0 aGlzIG1lbWJlciB2YXJpYWJsZSBpcyBub3QgYmVpbmcgc2V0IGJ5IGFueSBjb2RlIGZvbGxvd2lu ZyBjb2RlIHJlZmFjdG9yaW5nIGluIEhUTUwgcGFyc2VyIGNsYXNzLgorCisgICAgICAgIENvZGUg Y2xlYW51cCBwYXRjaC4gTm8gbmV3IHRlc3RzIHJlcXVpcmVkLgorCisgICAgICAgICogaHRtbC9I VE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1FbGVtZW50OjpI VE1MRm9ybUVsZW1lbnQpOgorICAgICAgICAgIFJlbW92ZWQgbV93YXNNYWxmb3JtZWQgaW5pdGlh bGl6YXRpb24uCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5oOgorICAgICAgICAo SFRNTEZvcm1FbGVtZW50KToKKyAgICAgICAgIFJlbW92ZWQgbV93YXNNYWxmb3JtZWQgdmFyaWFi bGUuCisgICAgICAgICBSZW1vdmVkIG1fd2FzTWFsZm9ybWVkIHZhcmlhYmxlJ3Mgc2V0dGVyIGFu ZCBnZXR0ZXIgZnVuY3Rpb25zLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXRCbG9jayk6CisgICAgICAg ICBSZW1vdmVkIGNvZGUgZnJhZ21lbnQgdXNpbmcvZGVwZW5kZW50IG9uIG1fd2FzTWFsZm9ybWVk LgorCiAyMDEyLTEwLTA0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIEJ1aWxkIGZpeCBhZnRlciByMTMwNDExLiBBZGQgdGhlIHJpZ2h0IG9mZnNldC4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5jcHAJKHJldmlzaW9uIDEzMDQyNCkK KysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzQsNyArNzQsNiBAQCBIVE1MRm9ybUVsZW1lbnQ6OkhUTUxGb3JtRWxlbWVudChjb25z dCBRCiAgICAgLCBtX2lzU3VibWl0dGluZ09yUHJlcGFyaW5nRm9yU3VibWlzc2lvbihmYWxzZSkK ICAgICAsIG1fc2hvdWxkU3VibWl0KGZhbHNlKQogICAgICwgbV9pc0luUmVzZXRGdW5jdGlvbihm YWxzZSkKLSAgICAsIG1fd2FzTWFsZm9ybWVkKGZhbHNlKQogICAgICwgbV93YXNEZW1vdGVkKGZh bHNlKQogewogICAgIEFTU0VSVChoYXNUYWdOYW1lKGZvcm1UYWcpKTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuaAkocmV2aXNpb24gMTMwNDI0KQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNzMsMTEgKzcz LDYgQEAgcHVibGljOgogICAgIHZvaWQgc3VibWl0RnJvbUphdmFTY3JpcHQoKTsKICAgICB2b2lk IHJlc2V0KCk7CiAKLSAgICAvLyBVc2VkIHRvIGluZGljYXRlIGEgbWFsZm9ybWVkIHN0YXRlIHRv IGtlZXAgZnJvbSBhcHBseWluZyB0aGUgYm90dG9tIG1hcmdpbiBvZiB0aGUgZm9ybS4KLSAgICAv LyBGSVhNRTogV291bGQgcHJvYmFibHkgYmUgYmV0dGVyIHRvIGNhbGwgdGhpcyB3YXNVbmNsb3Nl ZDsgdGhhdCdzIG1vcmUgc3BlY2lmaWMuCi0gICAgdm9pZCBzZXRNYWxmb3JtZWQoYm9vbCBtYWxm b3JtZWQpIHsgbV93YXNNYWxmb3JtZWQgPSBtYWxmb3JtZWQ7IH0KLSAgICBib29sIGlzTWFsZm9y bWVkKCkgY29uc3QgeyByZXR1cm4gbV93YXNNYWxmb3JtZWQ7IH0KLQogICAgIHZvaWQgc2V0RGVt b3RlZChib29sIGRlbW90ZWQpIHsgbV93YXNEZW1vdGVkID0gZGVtb3RlZDsgfQogCiAgICAgdm9p ZCBzdWJtaXRJbXBsaWNpdGx5KEV2ZW50KiwgYm9vbCBmcm9tSW1wbGljaXRTdWJtaXNzaW9uVHJp Z2dlcik7CkBAIC0xNjYsNyArMTYxLDYgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgbV9pc0luUmVz ZXRGdW5jdGlvbjsKIAotICAgIGJvb2wgbV93YXNNYWxmb3JtZWQ7CiAgICAgYm9vbCBtX3dhc0Rl bW90ZWQ7CiB9OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAJKHJldmlzaW9uIDEzMDQyNCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NDMsMTQgKzE1NDMsNiBAQCB2b2lkIFJlbmRl ckJsb2NrOjpsYXlvdXRCbG9jayhib29sIHJlbGF5CiAgICAgICAgIAogICAgICAgICBzZXRNYXJn aW5CZWZvcmVRdWlyayhzdHlsZVRvVXNlLT5tYXJnaW5CZWZvcmUoKS5xdWlyaygpKTsKICAgICAg ICAgc2V0TWFyZ2luQWZ0ZXJRdWlyayhzdHlsZVRvVXNlLT5tYXJnaW5BZnRlcigpLnF1aXJrKCkp OwotCi0gICAgICAgIE5vZGUqIG4gPSBub2RlKCk7Ci0gICAgICAgIGlmIChuICYmIG4tPmhhc1Rh Z05hbWUoZm9ybVRhZykgJiYgc3RhdGljX2Nhc3Q8SFRNTEZvcm1FbGVtZW50Kj4obiktPmlzTWFs Zm9ybWVkKCkpIHsKLSAgICAgICAgICAgIC8vIFNlZSBpZiB0aGlzIGZvcm0gaXMgbWFsZm9ybWVk IChpLmUuLCB1bmNsb3NlZCkuIElmIHNvLCBkb24ndCBnaXZlIHRoZSBmb3JtCi0gICAgICAgICAg ICAvLyBhIGJvdHRvbSBtYXJnaW4uCi0gICAgICAgICAgICBzZXRNYXhNYXJnaW5BZnRlclZhbHVl cygwLCAwKTsKLSAgICAgICAgfQotICAgICAgICAKICAgICAgICAgc2V0UGFnaW5hdGlvblN0cnV0 KDApOwogICAgIH0KIAo=