98441 2012-10-04 13:00:47 -0700 FeatureObserver should distinguish between legacy HTML and text notifications 2012-10-04 23:01:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth fishd haraken japhet jonlee ojan webkit.review.bot oldest_to_newest 734942 0 abarth 2012-10-04 13:00:47 -0700 FeatureObserver should distinguish between legacy HTML and text notifications 734944 1 167158 abarth 2012-10-04 13:01:39 -0700 Created attachment 167158 Patch 734949 2 167160 abarth 2012-10-04 13:05:21 -0700 Created attachment 167160 Patch 735016 3 167160 ojan 2012-10-04 14:31:23 -0700 Comment on attachment 167160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167160&action=review > Source/WebCore/Modules/notifications/NotificationCenter.idl:42 > + [V8Custom, V8MeasureAs=LegacyTextNotifications] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException); Are these really legacy? What has replaced them? 735027 4 abarth 2012-10-04 14:39:53 -0700 (In reply to comment #3) > (From update of attachment 167160 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167160&action=review > > > Source/WebCore/Modules/notifications/NotificationCenter.idl:42 > > + [V8Custom, V8MeasureAs=LegacyTextNotifications] Notification createNotification(in DOMString iconUrl, in DOMString title, in DOMString body) raises(DOMException); > > Are these really legacy? What has replaced them? You just create notification using "new Notification" rather than going through the NotificationCenter factory. 735248 5 167231 abarth 2012-10-04 19:23:30 -0700 Created attachment 167231 Patch for landing 735326 6 167231 webkit.review.bot 2012-10-04 21:58:24 -0700 Comment on attachment 167231 Patch for landing Rejecting attachment 167231 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rivedSources03.cpp:66: out/Release/obj/gen/webcore/bindings/V8NotificationCenter.cpp: In function 'v8::Handle<v8::Value> WebCore::NotificationCenterV8Internal::createNotificationCallback(const v8::Arguments&)': out/Release/obj/gen/webcore/bindings/V8NotificationCenter.cpp:70: error: 'LegacyTextNotificiations' is not a member of 'WebCore::FeatureObserver' make: *** [out/Release/obj.target/webcore_bindings/gen/webkit/bindings/V8DerivedSources03.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/14175387 735345 7 167248 abarth 2012-10-04 22:26:46 -0700 Created attachment 167248 Patch for landing 735369 8 167248 webkit.review.bot 2012-10-04 23:01:53 -0700 Comment on attachment 167248 Patch for landing Clearing flags on attachment: 167248 Committed r130463: <http://trac.webkit.org/changeset/130463> 735371 9 webkit.review.bot 2012-10-04 23:01:57 -0700 All reviewed patches have been landed. Closing bug. 167158 2012-10-04 13:01:39 -0700 2012-10-04 13:05:18 -0700 Patch bug-98441-20121004130049.patch text/plain 2690 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVmOWIzZDRhODM2OTI3 MjU1MDA1OWQxZmRkYjg4NTJlZTk5ZDViZi4uOTY4NzMyYjVmMmVmZDg5Y2IzMDZkZmFmY2NlNzdh NjhmYTY0MGZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTA0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRmVhdHVyZU9ic2VydmVyIHNo b3VsZCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGxlZ2FjeSBIVE1MIGFuZCB0ZXh0IG5vdGlmaWNhdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NDQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbWln aHQgYmUgYWJsZSB0byBkcm9wIHN1cHBvcnQgZm9yIGxlZ2FjeSBIVE1MIG5vdGlmaWNhdGlvbnMg YmVmb3JlCisgICAgICAgIHdlIGNhbiBkcm9wIHN1cHBvcnQgZm9yIGxlZ2FjeSB0ZXh0IG5vdGlm aWNhdGlvbnMuIFdlIHNob3VsZCBtZWFzdXJlCisgICAgICAgIGFuZCBmaW5kIG91dC4KKworICAg ICAgICAqIE1vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaWRsOgorICAg ICAgICAqIHBhZ2UvRmVhdHVyZU9ic2VydmVyLmg6CisKIDIwMTItMTAtMDQgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggPGlucHV0IHR5cGU9Im1vbnRoIj4g dGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9O b3RpZmljYXRpb25DZW50ZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKaW5kZXggNjA2NTFkYTRjZDkxZDU0ZjY1ZjAwZTVk ZGE1ZmQwMTMwMjgyYWQ3Yi4uMDg1YmI5N2ExY2RlOGIxMTdkM2JjOTE0ZWUwNmRlM2E1YjI4ZDk1 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlm aWNhdGlvbkNlbnRlci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKQEAgLTM3LDkgKzM3LDkgQEAgbW9kdWxlIHRocmVh ZHMgewogICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIE5vdGlmaWNhdGlvbkNlbnRlciB7 CiAjaWYgIWRlZmluZWQoRU5BQkxFX1RFWFRfTk9USUZJQ0FUSU9OU19PTkxZKSB8fCAhRU5BQkxF X1RFWFRfTk9USUZJQ0FUSU9OU19PTkxZCi0gICAgICAgW1Y4Q3VzdG9tLCBWOEVuYWJsZWRQZXJD b250ZXh0PWh0bWxOb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgdXJsKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKKyAgICAgICBbVjhD dXN0b20sIFY4RW5hYmxlZFBlckNvbnRleHQ9aHRtbE5vdGlmaWNhdGlvbnMsIFY4TWVhc3VyZUFz PUxlZ2FjeUhUTUxOb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgdXJsKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICNlbmRpZgotICAg ICAgIFtWOEN1c3RvbV0gTm90aWZpY2F0aW9uIGNyZWF0ZU5vdGlmaWNhdGlvbihpbiBET01TdHJp bmcgaWNvblVybCwgaW4gRE9NU3RyaW5nIHRpdGxlLCBpbiBET01TdHJpbmcgYm9keSkgcmFpc2Vz KERPTUV4Y2VwdGlvbik7CisgICAgICAgW1Y4Q3VzdG9tLCBWOE1lYXN1cmVBcz1MZWdhY3lUZXh0 Tm90aWZpY2F0aW9uc10gTm90aWZpY2F0aW9uIGNyZWF0ZU5vdGlmaWNhdGlvbihpbiBET01TdHJp bmcgaWNvblVybCwgaW4gRE9NU3RyaW5nIHRpdGxlLCBpbiBET01TdHJpbmcgYm9keSkgcmFpc2Vz KERPTUV4Y2VwdGlvbik7CiAKICAgICAgICBpbnQgY2hlY2tQZXJtaXNzaW9uKCk7CiAgICAgICAg W0N1c3RvbV0gdm9pZCByZXF1ZXN0UGVybWlzc2lvbihpbiBWb2lkQ2FsbGJhY2sgY2FsbGJhY2sp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKaW5kZXggZGVhMGJkOTZkNDQwOTMw ZDE2NDI2MzJhNjFiZTEyODk1YTRlY2FlZS4uZWNhZGQ3YTY2NGIwYTI3MTg0MTI3ZDBhMjE1ZmZh OGIyMGFhYWU0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2 ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCkBAIC01MCw2 ICs1MCw4IEBAIHB1YmxpYzoKICAgICAgICAgUHJlZml4ZWRDb250ZW50U2VjdXJpdHlQb2xpY3ks CiAgICAgICAgIFVucHJlZml4ZWRJbmRleGVkREIsCiAgICAgICAgIE9wZW5XZWJEYXRhYmFzZSwK KyAgICAgICAgTGVnYWN5SFRNTE5vdGlmaWNhdGlvbnMsCisgICAgICAgIExlZ2FjeVRleHROb3Rp ZmljYXRpb25zLAogICAgICAgICAvLyBBZGQgbmV3IGZlYXR1cmVzIGFib3ZlIHRoaXMgbGluZS4K ICAgICAgICAgTnVtYmVyT2ZGZWF0dXJlcywgLy8gVGhpcyBlbnVtIHZhbHVlIG11c3QgYmUgbGFz dC4KICAgICB9Owo= 167160 2012-10-04 13:05:21 -0700 2012-10-04 19:23:27 -0700 Patch bug-98441-20121004130431.patch text/plain 4230 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVmOWIzZDRhODM2OTI3 MjU1MDA1OWQxZmRkYjg4NTJlZTk5ZDViZi4uOTY4NzMyYjVmMmVmZDg5Y2IzMDZkZmFmY2NlNzdh NjhmYTY0MGZiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTA0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRmVhdHVyZU9ic2VydmVyIHNo b3VsZCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGxlZ2FjeSBIVE1MIGFuZCB0ZXh0IG5vdGlmaWNhdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NDQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbWln aHQgYmUgYWJsZSB0byBkcm9wIHN1cHBvcnQgZm9yIGxlZ2FjeSBIVE1MIG5vdGlmaWNhdGlvbnMg YmVmb3JlCisgICAgICAgIHdlIGNhbiBkcm9wIHN1cHBvcnQgZm9yIGxlZ2FjeSB0ZXh0IG5vdGlm aWNhdGlvbnMuIFdlIHNob3VsZCBtZWFzdXJlCisgICAgICAgIGFuZCBmaW5kIG91dC4KKworICAg ICAgICAqIE1vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaWRsOgorICAg ICAgICAqIHBhZ2UvRmVhdHVyZU9ic2VydmVyLmg6CisKIDIwMTItMTAtMDQgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggPGlucHV0IHR5cGU9Im1vbnRoIj4g dGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9O b3RpZmljYXRpb25DZW50ZXIuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKaW5kZXggNjA2NTFkYTRjZDkxZDU0ZjY1ZjAwZTVk ZGE1ZmQwMTMwMjgyYWQ3Yi4uMDg1YmI5N2ExY2RlOGIxMTdkM2JjOTE0ZWUwNmRlM2E1YjI4ZDk1 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlm aWNhdGlvbkNlbnRlci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9ub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKQEAgLTM3LDkgKzM3LDkgQEAgbW9kdWxlIHRocmVh ZHMgewogICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIE5vdGlmaWNhdGlvbkNlbnRlciB7 CiAjaWYgIWRlZmluZWQoRU5BQkxFX1RFWFRfTk9USUZJQ0FUSU9OU19PTkxZKSB8fCAhRU5BQkxF X1RFWFRfTk9USUZJQ0FUSU9OU19PTkxZCi0gICAgICAgW1Y4Q3VzdG9tLCBWOEVuYWJsZWRQZXJD b250ZXh0PWh0bWxOb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgdXJsKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKKyAgICAgICBbVjhD dXN0b20sIFY4RW5hYmxlZFBlckNvbnRleHQ9aHRtbE5vdGlmaWNhdGlvbnMsIFY4TWVhc3VyZUFz PUxlZ2FjeUhUTUxOb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgdXJsKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICNlbmRpZgotICAg ICAgIFtWOEN1c3RvbV0gTm90aWZpY2F0aW9uIGNyZWF0ZU5vdGlmaWNhdGlvbihpbiBET01TdHJp bmcgaWNvblVybCwgaW4gRE9NU3RyaW5nIHRpdGxlLCBpbiBET01TdHJpbmcgYm9keSkgcmFpc2Vz KERPTUV4Y2VwdGlvbik7CisgICAgICAgW1Y4Q3VzdG9tLCBWOE1lYXN1cmVBcz1MZWdhY3lUZXh0 Tm90aWZpY2F0aW9uc10gTm90aWZpY2F0aW9uIGNyZWF0ZU5vdGlmaWNhdGlvbihpbiBET01TdHJp bmcgaWNvblVybCwgaW4gRE9NU3RyaW5nIHRpdGxlLCBpbiBET01TdHJpbmcgYm9keSkgcmFpc2Vz KERPTUV4Y2VwdGlvbik7CiAKICAgICAgICBpbnQgY2hlY2tQZXJtaXNzaW9uKCk7CiAgICAgICAg W0N1c3RvbV0gdm9pZCByZXF1ZXN0UGVybWlzc2lvbihpbiBWb2lkQ2FsbGJhY2sgY2FsbGJhY2sp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm90aWZp Y2F0aW9uQ2VudGVyQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOE5vdGlmaWNhdGlvbkNlbnRlckN1c3RvbS5jcHAKaW5kZXggMDk5MWZiMTg4YmM0NjkwYTY5 NDI5NThhMTJiOTVmOTg2ZmQ4MTFhOC4uY2VkNmVhY2JkNzk3ZjUzY2NjZThiN2Q2ZDNlNTVkY2Iw ZGM0OWQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 Tm90aWZpY2F0aW9uQ2VudGVyQ3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhOb3RpZmljYXRpb25DZW50ZXJDdXN0b20uY3BwCkBAIC0zNCw2ICszNCw3 IEBACiAjaW5jbHVkZSAiVjhOb3RpZmljYXRpb25DZW50ZXIuaCIKIAogI2luY2x1ZGUgIkV4Y2Vw dGlvbkNvZGUuaCIKKyNpbmNsdWRlICJGZWF0dXJlT2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJOb3RJ bXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIk5vdGlmaWNhdGlvbi5oIgogI2luY2x1ZGUgIk5vdGlm aWNhdGlvbkNlbnRlci5oIgpAQCAtNDksNiArNTAsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhOb3RpZmljYXRpb25DZW50ZXI6OmNyZWF0ZUhUTUxOb3Rp ZmljYXRpb25DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogewogICAgIElOQ19T VEFUUygiRE9NLk5vdGlmaWNhdGlvbkNlbnRlci5DcmVhdGVIVE1MTm90aWZpY2F0aW9uKCkiKTsK KyAgICBGZWF0dXJlT2JzZXJ2ZXI6Om9ic2VydmUoYWN0aXZlRE9NV2luZG93KEJpbmRpbmdTdGF0 ZTo6aW5zdGFuY2UoKSksIEZlYXR1cmVPYnNlcnZlcjo6TGVnYWN5SFRNTE5vdGlmaWNhdGlvbnMp OworCiAgICAgTm90aWZpY2F0aW9uQ2VudGVyKiBub3RpZmljYXRpb25DZW50ZXIgPSBWOE5vdGlm aWNhdGlvbkNlbnRlcjo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAKICAgICBFeGNlcHRpb25D b2RlIGVjID0gMDsKQEAgLTY1LDYgKzY4LDggQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4Tm90 aWZpY2F0aW9uQ2VudGVyOjpjcmVhdGVIVE1MTm90aWZpY2F0aW9uQ2FsbGJhY2soY29uc3QKIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBWOE5vdGlmaWNhdGlvbkNlbnRlcjo6Y3JlYXRlTm90aWZpY2F0 aW9uQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKIHsKICAgICBJTkNfU1RBVFMo IkRPTS5Ob3RpZmljYXRpb25DZW50ZXIuQ3JlYXRlTm90aWZpY2F0aW9uKCkiKTsKKyAgICBGZWF0 dXJlT2JzZXJ2ZXI6Om9ic2VydmUoYWN0aXZlRE9NV2luZG93KEJpbmRpbmdTdGF0ZTo6aW5zdGFu Y2UoKSksIEZlYXR1cmVPYnNlcnZlcjo6TGVnYWN5VGV4dE5vdGlmaWNhdGlvbnMpOworCiAgICAg Tm90aWZpY2F0aW9uQ2VudGVyKiBub3RpZmljYXRpb25DZW50ZXIgPSBWOE5vdGlmaWNhdGlvbkNl bnRlcjo6dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAKICAgICBFeGNlcHRpb25Db2RlIGVjID0g MDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5oCmluZGV4IGRlYTBiZDk2ZDQ0MDkz MGQxNjQyNjMyYTYxYmUxMjg5NWE0ZWNhZWUuLmVjYWRkN2E2NjRiMGEyNzE4NDEyN2QwYTIxNWZm YThiMjBhYWFlNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2Vy dmVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaApAQCAtNTAs NiArNTAsOCBAQCBwdWJsaWM6CiAgICAgICAgIFByZWZpeGVkQ29udGVudFNlY3VyaXR5UG9saWN5 LAogICAgICAgICBVbnByZWZpeGVkSW5kZXhlZERCLAogICAgICAgICBPcGVuV2ViRGF0YWJhc2Us CisgICAgICAgIExlZ2FjeUhUTUxOb3RpZmljYXRpb25zLAorICAgICAgICBMZWdhY3lUZXh0Tm90 aWZpY2F0aW9ucywKICAgICAgICAgLy8gQWRkIG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUu CiAgICAgICAgIE51bWJlck9mRmVhdHVyZXMsIC8vIFRoaXMgZW51bSB2YWx1ZSBtdXN0IGJlIGxh c3QuCiAgICAgfTsK 167231 2012-10-04 19:23:30 -0700 2012-10-04 22:26:43 -0700 Patch for landing bug-98441-20121004192239.patch text/plain 2511 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDQ0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTA0ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRmVhdHVyZU9ic2VydmVyIHNob3Vs ZCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGxlZ2FjeSBIVE1MIGFuZCB0ZXh0IG5vdGlmaWNhdGlvbnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NDQxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBXZSBtaWdodCBiZSBh YmxlIHRvIGRyb3Agc3VwcG9ydCBmb3IgbGVnYWN5IEhUTUwgbm90aWZpY2F0aW9ucyBiZWZvcmUK KyAgICAgICAgd2UgY2FuIGRyb3Agc3VwcG9ydCBmb3IgbGVnYWN5IHRleHQgbm90aWZpY2F0aW9u cy4gV2Ugc2hvdWxkIG1lYXN1cmUKKyAgICAgICAgYW5kIGZpbmQgb3V0LgorCisgICAgICAgICog TW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGw6CisgICAgICAgICog cGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaDoKKwogMjAxMi0xMC0wNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtWOF0gTm90aWZpY2F0aW9uQ2VudGVyIGxlYWtzIGJl Y2F1c2UgaXQgdXNlcyBidWdneSBjdXN0b20gYmluZGluZ3MKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50ZXIuaWRsCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50 ZXIuaWRsCShyZXZpc2lvbiAxMzA0NDYpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlm aWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMzcsOSAr MzcsOSBAQCBtb2R1bGUgdGhyZWFkcyB7CiAgICAgICAgIE9taXRDb25zdHJ1Y3RvcgogICAgIF0g Tm90aWZpY2F0aW9uQ2VudGVyIHsKICNpZiAhZGVmaW5lZChFTkFCTEVfVEVYVF9OT1RJRklDQVRJ T05TX09OTFkpIHx8ICFFTkFCTEVfVEVYVF9OT1RJRklDQVRJT05TX09OTFkKLSAgICAgICBbVjhF bmFibGVkUGVyQ29udGV4dD1odG1sTm90aWZpY2F0aW9uc10gTm90aWZpY2F0aW9uIGNyZWF0ZUhU TUxOb3RpZmljYXRpb24oaW4gRE9NU3RyaW5nIHVybCkgcmFpc2VzKERPTUV4Y2VwdGlvbik7Cisg ICAgICAgW1Y4RW5hYmxlZFBlckNvbnRleHQ9aHRtbE5vdGlmaWNhdGlvbnMsIFY4TWVhc3VyZUFz PUxlZ2FjeUhUTUxOb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgdXJsKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICNlbmRpZgotICAg ICAgIE5vdGlmaWNhdGlvbiBjcmVhdGVOb3RpZmljYXRpb24oaW4gRE9NU3RyaW5nIGljb25Vcmws IGluIERPTVN0cmluZyB0aXRsZSwgaW4gRE9NU3RyaW5nIGJvZHkpIHJhaXNlcyhET01FeGNlcHRp b24pOworICAgICAgIFtWOE1lYXN1cmVBcz1MZWdhY3lUZXh0Tm90aWZpY2lhdGlvbnNdIE5vdGlm aWNhdGlvbiBjcmVhdGVOb3RpZmljYXRpb24oaW4gRE9NU3RyaW5nIGljb25VcmwsIGluIERPTVN0 cmluZyB0aXRsZSwgaW4gRE9NU3RyaW5nIGJvZHkpIHJhaXNlcyhET01FeGNlcHRpb24pOwogCiAg ICAgICAgaW50IGNoZWNrUGVybWlzc2lvbigpOwogICAgICAgIFtDdXN0b21dIHZvaWQgcmVxdWVz dFBlcm1pc3Npb24oaW4gVm9pZENhbGxiYWNrIGNhbGxiYWNrKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAkocmV2aXNpb24gMTMwNDQ0KQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsOCBA QCBwdWJsaWM6CiAgICAgICAgIFByZWZpeGVkQ29udGVudFNlY3VyaXR5UG9saWN5LAogICAgICAg ICBVbnByZWZpeGVkSW5kZXhlZERCLAogICAgICAgICBPcGVuV2ViRGF0YWJhc2UsCisgICAgICAg IExlZ2FjeUhUTUxOb3RpZmljYXRpb25zLAorICAgICAgICBMZWdhY3lUZXh0Tm90aWZpY2F0aW9u cywKICAgICAgICAgLy8gQWRkIG5ldyBmZWF0dXJlcyBhYm92ZSB0aGlzIGxpbmUuCiAgICAgICAg IE51bWJlck9mRmVhdHVyZXMsIC8vIFRoaXMgZW51bSB2YWx1ZSBtdXN0IGJlIGxhc3QuCiAgICAg fTsK 167248 2012-10-04 22:26:46 -0700 2012-10-04 23:01:53 -0700 Patch for landing bug-98441-20121004222606.patch text/plain 2695 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFiMTBiOTg4MGFjMjQz NDE1YzRiY2Q4YjZlYjgwYjhhMTIwYjIxOC4uYjY3ZDE1ZGYwYjg0MWU0MjQ4NDVjMmJhZGYyZmJm NGM5NGVlYWViOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTA0ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRmVhdHVyZU9ic2VydmVyIHNo b3VsZCBkaXN0aW5ndWlzaCBiZXR3ZWVuIGxlZ2FjeSBIVE1MIGFuZCB0ZXh0IG5vdGlmaWNhdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4NDQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBXZSBtaWdodCBi ZSBhYmxlIHRvIGRyb3Agc3VwcG9ydCBmb3IgbGVnYWN5IEhUTUwgbm90aWZpY2F0aW9ucyBiZWZv cmUKKyAgICAgICAgd2UgY2FuIGRyb3Agc3VwcG9ydCBmb3IgbGVnYWN5IHRleHQgbm90aWZpY2F0 aW9ucy4gV2Ugc2hvdWxkIG1lYXN1cmUKKyAgICAgICAgYW5kIGZpbmQgb3V0LgorCisgICAgICAg ICogTW9kdWxlcy9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGw6CisgICAgICAg ICogcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaDoKKwogMjAxMi0xMC0wNCAgRXJpYyBTZWlkZWwgIDxl cmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU1ZHQXR0cmlidXRlSGFzaFRyYW5zbGF0b3IgZG9l cyBub3QgbmVlZCB0byBjb3B5IFF1YWxpZmllZE5hbWUgaW4gdGhlIGNvbW1vbiBjYXNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9u Q2VudGVyLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmlj YXRpb25DZW50ZXIuaWRsCmluZGV4IDgzMWJmMjY1OTZmNTM2ZDgwNTA4OGVmZGYwMjlkNjFlODg4 ZjA2NDUuLjk4N2JiMDQ1YzA1MWY3ZWNmNTY0ZDBlMmE0MzQ2ZWU0ZjZiOTBmZDEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50 ZXIuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbm90aWZpY2F0aW9ucy9Ob3RpZmlj YXRpb25DZW50ZXIuaWRsCkBAIC0zNyw5ICszNyw5IEBAIG1vZHVsZSB0aHJlYWRzIHsKICAgICAg ICAgT21pdENvbnN0cnVjdG9yCiAgICAgXSBOb3RpZmljYXRpb25DZW50ZXIgewogI2lmICFkZWZp bmVkKEVOQUJMRV9URVhUX05PVElGSUNBVElPTlNfT05MWSkgfHwgIUVOQUJMRV9URVhUX05PVElG SUNBVElPTlNfT05MWQotICAgICAgIFtWOEVuYWJsZWRQZXJDb250ZXh0PWh0bWxOb3RpZmljYXRp b25zXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNhdGlvbihpbiBET01TdHJpbmcgdXJs KSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKKyAgICAgICBbVjhFbmFibGVkUGVyQ29udGV4dD1odG1s Tm90aWZpY2F0aW9ucywgVjhNZWFzdXJlQXM9TGVnYWN5SFRNTE5vdGlmaWNhdGlvbnNdIE5vdGlm aWNhdGlvbiBjcmVhdGVIVE1MTm90aWZpY2F0aW9uKGluIERPTVN0cmluZyB1cmwpIHJhaXNlcyhE T01FeGNlcHRpb24pOwogI2VuZGlmCi0gICAgICAgTm90aWZpY2F0aW9uIGNyZWF0ZU5vdGlmaWNh dGlvbihpbiBET01TdHJpbmcgaWNvblVybCwgaW4gRE9NU3RyaW5nIHRpdGxlLCBpbiBET01TdHJp bmcgYm9keSkgcmFpc2VzKERPTUV4Y2VwdGlvbik7CisgICAgICAgW1Y4TWVhc3VyZUFzPUxlZ2Fj eVRleHROb3RpZmljYXRpb25zXSBOb3RpZmljYXRpb24gY3JlYXRlTm90aWZpY2F0aW9uKGluIERP TVN0cmluZyBpY29uVXJsLCBpbiBET01TdHJpbmcgdGl0bGUsIGluIERPTVN0cmluZyBib2R5KSBy YWlzZXMoRE9NRXhjZXB0aW9uKTsKIAogICAgICAgIGludCBjaGVja1Blcm1pc3Npb24oKTsKICAg ICAgICBbQ3VzdG9tXSB2b2lkIHJlcXVlc3RQZXJtaXNzaW9uKGluIFZvaWRDYWxsYmFjayBjYWxs YmFjayk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVPYnNlcnZlci5o IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GZWF0dXJlT2JzZXJ2ZXIuaAppbmRleCBkZWEwYmQ5NmQ0 NDA5MzBkMTY0MjYzMmE2MWJlMTI4OTVhNGVjYWVlLi5lY2FkZDdhNjY0YjBhMjcxODQxMjdkMGEy MTVmZmE4YjIwYWFhZTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZlYXR1cmVP YnNlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRmVhdHVyZU9ic2VydmVyLmgKQEAg LTUwLDYgKzUwLDggQEAgcHVibGljOgogICAgICAgICBQcmVmaXhlZENvbnRlbnRTZWN1cml0eVBv bGljeSwKICAgICAgICAgVW5wcmVmaXhlZEluZGV4ZWREQiwKICAgICAgICAgT3BlbldlYkRhdGFi YXNlLAorICAgICAgICBMZWdhY3lIVE1MTm90aWZpY2F0aW9ucywKKyAgICAgICAgTGVnYWN5VGV4 dE5vdGlmaWNhdGlvbnMsCiAgICAgICAgIC8vIEFkZCBuZXcgZmVhdHVyZXMgYWJvdmUgdGhpcyBs aW5lLgogICAgICAgICBOdW1iZXJPZkZlYXR1cmVzLCAvLyBUaGlzIGVudW0gdmFsdWUgbXVzdCBi ZSBsYXN0LgogICAgIH07Cg==