98438 2012-10-04 12:26:59 -0700 MutationRecord attributeName should be null for non attribute changes 2012-10-05 13:13:14 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 arv adamk abarth adamk ojan rafaelw rniwa webkit.review.bot oldest_to_newest 734927 0 arv 2012-10-04 12:26:59 -0700 We return '' instead of null for atributeName when the type is characterData (I didn't try childNodes but I assume we have the same issue there and other places). Steps to reproduce var text = document.createTextNode('abc'); var observer = new WebKitMutationObserver(function() {}); observer.observe(text, { characterData: true }); text.data = 'def'; var records = observer.takeRecords(); shouldBeNull('record[0].attributeName'); 734937 1 arv 2012-10-04 12:50:19 -0700 Also see bug 98439 which is about oldValue not being null when expected 734986 2 adamk 2012-10-04 13:50:59 -0700 I'll take both this and 98439 (will fix them in the same patch). 735041 3 167181 adamk 2012-10-04 14:57:56 -0700 Created attachment 167181 Patch 735201 4 167181 webkit.review.bot 2012-10-04 18:02:20 -0700 Comment on attachment 167181 Patch Clearing flags on attachment: 167181 Committed r130442: <http://trac.webkit.org/changeset/130442> 735202 5 webkit.review.bot 2012-10-04 18:02:25 -0700 All reviewed patches have been landed. Closing bug. 167181 2012-10-04 14:57:56 -0700 2012-10-04 18:02:20 -0700 Patch bug-98438-20121004145706.patch text/plain 5082 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTY2NjY0Njk3YTIxODRk OGJlODEwYTQ1MjExYmMyZDFlODI3NDk3Ni4uOTczMDBmMjU0NDg4ZGYwZDBhMzU0NTQ4NzUxNzYx MjRiNjFiNGI1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTA0ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE11dGF0aW9uUmVjb3JkIGF0 dHJpYnV0ZU5hbWUgc2hvdWxkIGJlIG51bGwgZm9yIG5vbiBhdHRyaWJ1dGUgY2hhbmdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0MzgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L211 dGF0aW9uL211dGF0aW9uLXJlY29yZC1udWxsaXR5Lmh0bWwKKworICAgICAgICAqIGRvbS9NdXRh dGlvblJlY29yZC5pZGw6CisKIDIwMTItMTAtMDQgIFByYXZpbiBEICA8cHJhdmluZC4yazRAZ21h aWwuY29tPgogCiAgICAgICAgIExheW91dCBicm9rZW4gYWZ0ZXIgY2xvbmluZyBhbmQgcmUtaW5z ZXJ0aW5nIGEgdGFibGUgd2l0aCBhIG1pc3BsYWNlZCA8Zm9ybT4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9NdXRhdGlvblJlY29yZC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTXV0 YXRpb25SZWNvcmQuaWRsCmluZGV4IGE3ODgzYzUwZjBlMDBjYWVhOGM5M2IzOGRlYjE0MmRjYzE3 NzFjMDMuLjE4NjI4MDZkMTdhNWQxOGEwNTYyZjIwZmFkN2Y2OGRiNGZmOTE0ZDQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvblJlY29yZC5pZGwKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL011dGF0aW9uUmVjb3JkLmlkbApAQCAtNDAsNyArNDAsNyBAQCBtb2R1bGUgY29y ZSB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBOb2RlIHByZXZpb3VzU2libGluZzsKICAg ICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIE5vZGUgbmV4dFNpYmxpbmc7CiAKLSAgICAgICAgcmVh ZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBhdHRyaWJ1dGVOYW1lOworICAgICAgICByZWFkb25s eSBhdHRyaWJ1dGUgW1RyZWF0UmV0dXJuZWROdWxsU3RyaW5nQXM9TnVsbF0gRE9NU3RyaW5nIGF0 dHJpYnV0ZU5hbWU7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBbVHJlYXRSZXR1cm5lZE51 bGxTdHJpbmdBcz1OdWxsXSBET01TdHJpbmcgYXR0cmlidXRlTmFtZXNwYWNlOwogCiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBbVHJlYXRSZXR1cm5lZE51bGxTdHJpbmdBcz1OdWxsXSBET01T dHJpbmcgb2xkVmFsdWU7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmEwYTdiZGY1NzljMmU2Mzk3ZDgxNDFiODFkNGE2NTk5 Y2ViZjg3MS4uMjY2YzllZjMwMjU4Y2JhNjBhNmNhNzQzZTM0ZWQwMDA1ZjA5ZTg0NSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTA0ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0u b3JnPgorCisgICAgICAgIE11dGF0aW9uUmVjb3JkIGF0dHJpYnV0ZU5hbWUgc2hvdWxkIGJlIG51 bGwgZm9yIG5vbiBhdHRyaWJ1dGUgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg0MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbXV0YXRpb24vbXV0YXRpb24tcmVjb3JkLW51bGxp dHktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L211dGF0aW9uL211dGF0aW9u LXJlY29yZC1udWxsaXR5Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTEwLTA0ICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIENocm9taXVtIHJlYmFzZWxpbmVzIGFmdGVy IHIxMzA0MTEuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211dGF0aW9uL211dGF0aW9u LXJlY29yZC1udWxsaXR5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbXV0YXRpb24v bXV0YXRpb24tcmVjb3JkLW51bGxpdHktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYyOTAyOWQ2 NDVmNjE0OTRlZTY3ODNjMWNmMTVhNDZlMDc4N2QyODkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L211dGF0aW9uL211dGF0aW9uLXJlY29yZC1udWxsaXR5LWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxLDMwIEBACitOb24tcmVsZXZhbnQgcHJvcGVydGllcyBvbiBtdXRhdGlvbiBy ZWNvcmRzIHNob3VsZCBiZSBudWxsCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitj aGFyYWN0ZXJEYXRhIHJlY29yZDoKK1BBU1MgcmVjb3JkLmF0dHJpYnV0ZU5hbWUgaXMgbnVsbAor UEFTUyByZWNvcmQuYXR0cmlidXRlTmFtZXNwYWNlIGlzIG51bGwKK1BBU1MgcmVjb3JkLm9sZFZh bHVlIGlzIG51bGwKK1BBU1MgcmVjb3JkLmFkZGVkTm9kZXMgaXMgbnVsbAorUEFTUyByZWNvcmQu cmVtb3ZlZE5vZGVzIGlzIG51bGwKK1BBU1MgcmVjb3JkLnByZXZpb3VzU2libGluZyBpcyBudWxs CitQQVNTIHJlY29yZC5uZXh0U2libGluZyBpcyBudWxsCisKK2NoaWxkTGlzdCByZWNvcmQ6CitQ QVNTIHJlY29yZC5hdHRyaWJ1dGVOYW1lIGlzIG51bGwKK1BBU1MgcmVjb3JkLmF0dHJpYnV0ZU5h bWVzcGFjZSBpcyBudWxsCitQQVNTIHJlY29yZC5vbGRWYWx1ZSBpcyBudWxsCisKK2F0dHJpYnV0 ZXMgcmVjb3JkOgorUEFTUyByZWNvcmQuYXR0cmlidXRlTmFtZXNwYWNlIGlzIG51bGwKK1BBU1Mg cmVjb3JkLm9sZFZhbHVlIGlzIG51bGwKK1BBU1MgcmVjb3JkLmFkZGVkTm9kZXMgaXMgbnVsbAor UEFTUyByZWNvcmQucmVtb3ZlZE5vZGVzIGlzIG51bGwKK1BBU1MgcmVjb3JkLnByZXZpb3VzU2li bGluZyBpcyBudWxsCitQQVNTIHJlY29yZC5uZXh0U2libGluZyBpcyBudWxsCitQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9tdXRhdGlvbi1yZWNvcmQtbnVsbGl0eS5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9tdXRhdGlvbi9tdXRhdGlvbi1yZWNvcmQtbnVsbGl0eS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjRhYTMwZTNmOTliODIyNWNhNWNlYmNmM2YwZjA0ZDZmMzQ3ZTY2YmIKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L211dGF0aW9uL211dGF0aW9uLXJlY29yZC1udWxs aXR5Lmh0bWwKQEAgLTAsMCArMSw0MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNj cmlwdGlvbignTm9uLXJlbGV2YW50IHByb3BlcnRpZXMgb24gbXV0YXRpb24gcmVjb3JkcyBzaG91 bGQgYmUgbnVsbCcpOwordmFyIG9ic2VydmVyID0gbmV3IFdlYktpdE11dGF0aW9uT2JzZXJ2ZXIo ZnVuY3Rpb24oKSB7fSk7CisKK3ZhciB0ZXh0ID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoJ3Nv bWV0aGluZycpOworb2JzZXJ2ZXIub2JzZXJ2ZSh0ZXh0LCB7Y2hhcmFjdGVyRGF0YTogdHJ1ZX0p OwordGV4dC5kYXRhID0gJ3NvbWV0aGluZyBlbHNlJzsKK3ZhciByZWNvcmQgPSBvYnNlcnZlci50 YWtlUmVjb3JkcygpWzBdOworZGVidWcoJ2NoYXJhY3RlckRhdGEgcmVjb3JkOicpOworc2hvdWxk QmVOdWxsKCdyZWNvcmQuYXR0cmlidXRlTmFtZScpOworc2hvdWxkQmVOdWxsKCdyZWNvcmQuYXR0 cmlidXRlTmFtZXNwYWNlJyk7CitzaG91bGRCZU51bGwoJ3JlY29yZC5vbGRWYWx1ZScpOworc2hv dWxkQmVOdWxsKCdyZWNvcmQuYWRkZWROb2RlcycpOworc2hvdWxkQmVOdWxsKCdyZWNvcmQucmVt b3ZlZE5vZGVzJyk7CitzaG91bGRCZU51bGwoJ3JlY29yZC5wcmV2aW91c1NpYmxpbmcnKTsKK3No b3VsZEJlTnVsbCgncmVjb3JkLm5leHRTaWJsaW5nJyk7CisKK3ZhciBkaXYgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCdkaXYnKTsKK29ic2VydmVyLm9ic2VydmUoZGl2LCB7Y2hpbGRMaXN0OiB0 cnVlfSk7CitkaXYuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc3BhbicpKTsK K3JlY29yZCA9IG9ic2VydmVyLnRha2VSZWNvcmRzKClbMF07CitkZWJ1ZygnXG5jaGlsZExpc3Qg cmVjb3JkOicpOworc2hvdWxkQmVOdWxsKCdyZWNvcmQuYXR0cmlidXRlTmFtZScpOworc2hvdWxk QmVOdWxsKCdyZWNvcmQuYXR0cmlidXRlTmFtZXNwYWNlJyk7CitzaG91bGRCZU51bGwoJ3JlY29y ZC5vbGRWYWx1ZScpOworCitvYnNlcnZlci5vYnNlcnZlKGRpdiwge2F0dHJpYnV0ZXM6IHRydWV9 KTsKK2Rpdi5zZXRBdHRyaWJ1dGUoJ2RhdGEtZm9vJywgJ2JhcicpOworcmVjb3JkID0gb2JzZXJ2 ZXIudGFrZVJlY29yZHMoKVswXTsKK2RlYnVnKCdcbmF0dHJpYnV0ZXMgcmVjb3JkOicpOworc2hv dWxkQmVOdWxsKCdyZWNvcmQuYXR0cmlidXRlTmFtZXNwYWNlJyk7CitzaG91bGRCZU51bGwoJ3Jl Y29yZC5vbGRWYWx1ZScpOworc2hvdWxkQmVOdWxsKCdyZWNvcmQuYWRkZWROb2RlcycpOworc2hv dWxkQmVOdWxsKCdyZWNvcmQucmVtb3ZlZE5vZGVzJyk7CitzaG91bGRCZU51bGwoJ3JlY29yZC5w cmV2aW91c1NpYmxpbmcnKTsKK3Nob3VsZEJlTnVsbCgncmVjb3JkLm5leHRTaWJsaW5nJyk7Cis8 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4K