98433 2012-10-04 11:34:33 -0700 Crash in Safari at com.apple.JavaScriptCore: WTF::StringImpl::is8Bit const + 12 2012-10-10 10:16:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 98300 1 msaboff msaboff oldest_to_newest 734876 0 msaboff 2012-10-04 11:34:33 -0700 Crash running safari extension tests. Looks like is8Bit() is called on a String without a StringImpl. <rdar://problem/12433701> 734896 1 167152 msaboff 2012-10-04 11:48:15 -0700 Created attachment 167152 Patch 734903 2 167152 jberlin 2012-10-04 11:51:15 -0700 Comment on attachment 167152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167152&action=review > Source/JavaScriptCore/ChangeLog:11 > + (JSValueMakeFromJSONString): You should also mention that characters16() does the is8Bit() check, which is why you changed it to characters(). 734965 3 msaboff 2012-10-04 13:27:35 -0700 Committed r130424: <http://trac.webkit.org/changeset/130424> 735186 4 msaboff 2012-10-04 17:42:59 -0700 This is actually fixing the symptom of a problem in <http://trac.webkit.org/changeset/130344> and the follow-on <http://trac.webkit.org/changeset/130413>. It appears that we are turning a null string into an empty string in OpaqueJSString.cpp. See https://bugs.webkit.org/show_bug.cgi?id=98417. 739060 5 msaboff 2012-10-10 10:16:44 -0700 Reopened because https://bugs.webkit.org/show_bug.cgi?id=98417 "After r130344, OpaqueJSString() creates an empty string which should be a null string" was the source of this particular crash. However the change in this patch (r130424) is actually needed. Consider the case: JSStringRef nullJSON = JSStringCreateWithUTF8CString(0); JSValueRef nullJSONObject = JSValueMakeFromJSONString(context, nullJSON); nullJSON will have a null string which would cause the code before this patch to crash. The case above has been added to testapi.c in r130832: <http://trac.webkit.org/changeset/130832>. 167152 2012-10-04 11:48:15 -0700 2012-10-04 11:51:15 -0700 Patch 98433.patch text/plain 1671 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwNDExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTA0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENyYXNoIGluIFNhZmFyaSBhdCBjb20uYXBwbGUuSmF2YVNjcmlwdENvcmU6IFdURjo6U3Ry aW5nSW1wbDo6aXM4Qml0IGNvbnN0ICsgMTIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk4NDMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBsZW5ndGggY2hlY2sgYmVmb3JlIHRoZSBpczhCaXQo KSBjaGVjay4KKworICAgICAgICAqIEFQSS9KU1ZhbHVlUmVmLmNwcDoKKyAgICAgICAgKEpTVmFs dWVNYWtlRnJvbUpTT05TdHJpbmcpOgorCiAyMDEyLTEwLTA0ICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBBZGQgbWlzc2luZyBMTEludCBkZXBl bmRlbmNpZXMgdG8gdGhlIGJ1aWxkIHN5c3RlbQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU1ZhbHVlUmVmLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv QVBJL0pTVmFsdWVSZWYuY3BwCShyZXZpc2lvbiAxMzA0MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQVBJL0pTVmFsdWVSZWYuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzUsMTEgKzIzNSwx MiBAQCBKU1ZhbHVlUmVmIEpTVmFsdWVNYWtlRnJvbUpTT05TdHJpbmcoSlNDCiAgICAgRXhlY1N0 YXRlKiBleGVjID0gdG9KUyhjdHgpOwogICAgIEFQSUVudHJ5U2hpbSBlbnRyeVNoaW0oZXhlYyk7 CiAgICAgU3RyaW5nIHN0ciA9IHN0cmluZy0+c3RyaW5nKCk7Ci0gICAgaWYgKHN0ci5pczhCaXQo KSkgewotICAgICAgICBMaXRlcmFsUGFyc2VyPExDaGFyPiBwYXJzZXIoZXhlYywgc3RyLmNoYXJh Y3RlcnM4KCksIHN0ci5sZW5ndGgoKSwgU3RyaWN0SlNPTik7CisgICAgdW5zaWduZWQgbGVuZ3Ro ID0gc3RyLmxlbmd0aCgpOworICAgIGlmIChsZW5ndGggJiYgc3RyLmlzOEJpdCgpKSB7CisgICAg ICAgIExpdGVyYWxQYXJzZXI8TENoYXI+IHBhcnNlcihleGVjLCBzdHIuY2hhcmFjdGVyczgoKSwg bGVuZ3RoLCBTdHJpY3RKU09OKTsKICAgICAgICAgcmV0dXJuIHRvUmVmKGV4ZWMsIHBhcnNlci50 cnlMaXRlcmFsUGFyc2UoKSk7CiAgICAgfQotICAgIExpdGVyYWxQYXJzZXI8VUNoYXI+IHBhcnNl cihleGVjLCBzdHIuY2hhcmFjdGVyczE2KCksIHN0ci5sZW5ndGgoKSwgU3RyaWN0SlNPTik7Cisg ICAgTGl0ZXJhbFBhcnNlcjxVQ2hhcj4gcGFyc2VyKGV4ZWMsIHN0ci5jaGFyYWN0ZXJzKCksIGxl bmd0aCwgU3RyaWN0SlNPTik7CiAgICAgcmV0dXJuIHRvUmVmKGV4ZWMsIHBhcnNlci50cnlMaXRl cmFsUGFyc2UoKSk7CiB9CiAK