98401 2012-10-04 05:48:27 -0700 Compile PLUGIN_PROCESS code only when NETSCAPE_PLUGIN_API macro is on 2022-07-01 10:45:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 mariusz.g webkit-unassigned aestes bfulgham cdumez cgarcia csaavedra laszlo.gombos mrobinson philip.chimento rakuco oldest_to_newest 734618 0 mariusz.g 2012-10-04 05:48:27 -0700 In webkit2 there are some places where code related with plugin process is guarded by only PLUGIN_PROCESS macro, and in other places with both PLUGIN_PROCESS and NETSCAPE_PLUGIN_API. Following commit tries to make some cleanup: "Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API) https://bugs.webkit.org/show_bug.cgi?id=86496" Files like UIProcess/Plugins/PluginProcessProxy.cpp are being taken to compile always, and inside them at the beginning there is #if ENABLE(PLUGIN_PROCESS) guard. I think that in all places also NETSCAPE_PLUGIN_API check should be added. If plugins are off PLUGIN_PROCESS's code shouldn't be compiled. Other example: PluginProxyQt.cpp has guard #if ENABLE(PLUGIN_PROCESS) && ENABLE(NETSCAPE_PLUGIN_API), while PluginProxy.h only #if ENABLE(PLUGIN_PROCESS) 918319 1 csaavedra 2013-08-17 10:06:39 -0700 This is related to 89451, probably a duplicate. 1059284 2 philip.chimento 2015-01-06 19:16:05 -0800 Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think? 1059381 3 cgarcia 2015-01-07 05:35:06 -0800 (In reply to comment #2) > Duplicate of https://bugs.webkit.org/show_bug.cgi?id=98262 I think? No it's not, if ENABLE_PLUGIN_PROCESS was false when ENABLE_NETSCAPE_PLUGIN_API is false you wouldn't need most of the #ifdefs you are adding in bug #98262 1879840 4 bfulgham 2022-07-01 10:45:25 -0700 WebKit no longer support NPAPI plugins.