<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98398</bug_id>
          
          <creation_ts>2012-10-04 04:46:15 -0700</creation_ts>
          <short_desc>[Qt] ProcessLauncherQt should use QStringLiteral for serviceName.</short_desc>
          <delta_ts>2012-10-10 02:48:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zeno Albisser">zeno</reporter>
          <assigned_to name="Zeno Albisser">zeno</assigned_to>
          <cc>abecsi</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>menard</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zoltan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>734593</commentid>
    <comment_count>0</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2012-10-04 04:46:15 -0700</bug_when>
    <thetext>QString(const char*) is deprecated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735579</commentid>
    <comment_count>1</comment_count>
      <attachid>167310</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2012-10-05 05:06:58 -0700</bug_when>
    <thetext>Created attachment 167310
tiny patch for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738765</commentid>
    <comment_count>2</comment_count>
      <attachid>167310</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2012-10-10 02:48:17 -0700</bug_when>
    <thetext>Comment on attachment 167310
tiny patch for review.

Clearing flags on attachment: 167310

Committed r130876: &lt;http://trac.webkit.org/changeset/130876&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>738766</commentid>
    <comment_count>3</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2012-10-10 02:48:22 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167310</attachid>
            <date>2012-10-05 05:06:58 -0700</date>
            <delta_ts>2012-10-10 02:48:17 -0700</delta_ts>
            <desc>tiny patch for review.</desc>
            <filename>98398_20121005-140544.patch</filename>
            <type>text/plain</type>
            <size>1663</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAxOGY1MTg2Li42NjY3NzQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg
QEAKKzIwMTItMTAtMDUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg
ICAgW1F0XSBQcm9jZXNzTGF1bmNoZXJRdCBzaG91bGQgdXNlIFFTdHJpbmdMaXRlcmFsIGZvciBz
ZXJ2aWNlTmFtZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTk4Mzk4CisKKyAgICAgICAgUVN0cmluZyhjb25zdCBjaGFyKikgaXMgZGVwcmVjYXRlZCwg
d2Ugc2hvdWxkIHVzZSBRU3RyaW5nTGl0ZXJhbCBpbnN0ZWFkLgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1By
b2Nlc3NMYXVuY2hlclF0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0xhdW5jaGVyOjps
YXVuY2hQcm9jZXNzKToKKwogMjAxMi0xMC0wNSAgU3VkYXJzYW5hIE5hZ2luZW5pICA8c3VkYXJz
YW5hLm5hZ2luZW5pQGludGVsLmNvbT4KIAogICAgICAgICBbV0syXVtHVEtdW0VGTF0gc3RhbmRh
cmRfb3V0cHV0IHJldHVybmVkIGJ5IGdfc3Bhd25fc3luYyBtdXN0IGJlIGZyZWVkCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVy
UXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL3F0L1Byb2Nlc3NMYXVu
Y2hlclF0LmNwcAppbmRleCAzY2FjZjA0Li42MGNkZTVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVyUXQuY3BwCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1bmNoZXJRdC5jcHAK
QEAgLTEyOCw3ICsxMjgsNyBAQCB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcygp
CiAgICAgbWFjaF9wb3J0X2luc2VydF9yaWdodChtYWNoX3Rhc2tfc2VsZigpLCBjb25uZWN0b3Is
IGNvbm5lY3RvciwgTUFDSF9NU0dfVFlQRV9NQUtFX1NFTkQpOwogCiAgICAgLy8gUmVnaXN0ZXIg
cG9ydCB3aXRoIGEgc2VydmljZSBuYW1lIHRvIHRoZSBzeXN0ZW0uCi0gICAgUVN0cmluZyBzZXJ2
aWNlTmFtZSA9IFFTdHJpbmcoImNvbS5ub2tpYS5RdC5XZWJLaXQuUXRXZWJQcm9jZXNzLSUxLSUy
Iik7CisgICAgUVN0cmluZyBzZXJ2aWNlTmFtZSA9IFFTdHJpbmdMaXRlcmFsKCJjb20ubm9raWEu
UXQuV2ViS2l0LlF0V2ViUHJvY2Vzcy0lMS0lMiIpOwogICAgIHNlcnZpY2VOYW1lID0gc2Vydmlj
ZU5hbWUuYXJnKFFTdHJpbmcoKS5zZXROdW0oZ2V0cGlkKCkpLCBRU3RyaW5nKCkuc2V0TnVtKChz
aXplX3QpdGhpcykpOwogICAgIGtlcm5fcmV0dXJuX3Qga3IgPSBib290c3RyYXBfcmVnaXN0ZXIy
KGJvb3RzdHJhcF9wb3J0LCBjb25zdF9jYXN0PGNoYXIqPihzZXJ2aWNlTmFtZS50b1V0ZjgoKS5k
YXRhKCkpLCBjb25uZWN0b3IsIDApOwogICAgIEFTU0VSVF9VTlVTRUQoa3IsIGtyID09IEtFUk5f
U1VDQ0VTUyk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>