98389 2012-10-04 02:44:02 -0700 [EFL] Run unit tests with Xvfb 2012-10-05 00:16:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98231 1 cdumez cdumez alexander.shalamov bw80.lee d-r gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco tonikitoo webkit.review.bot oldest_to_newest 734538 0 cdumez 2012-10-04 02:44:02 -0700 We currently unset the DISPLAY environment variable in setup_environ_for_server() if the variable is not set on the system. This is an issue now because XvfbDriver sets the DISPLAY environment variable and we don't want to unset it on the bots (where the system does not have DISPLAY environment variable set). 734543 1 cdumez 2012-10-04 02:49:07 -0700 Our unit tests are failing because of this. We wrongly unset the DISPLAY environment variable and then ecore_x_init() fails on the bots. 734645 2 167095 cdumez 2012-10-04 06:38:10 -0700 Created attachment 167095 Patch This patch fixes unit tests on our build bots by running them with Xvfb. 734669 3 167095 laszlo.gombos 2012-10-04 07:37:48 -0700 Comment on attachment 167095 Patch r=me. 734674 4 167095 webkit.review.bot 2012-10-04 07:45:27 -0700 Comment on attachment 167095 Patch Clearing flags on attachment: 167095 Committed r130390: <http://trac.webkit.org/changeset/130390> 734675 5 webkit.review.bot 2012-10-04 07:45:31 -0700 All reviewed patches have been landed. Closing bug. 735430 6 bw80.lee 2012-10-05 00:16:20 -0700 *** Bug 98414 has been marked as a duplicate of this bug. *** 167095 2012-10-04 06:38:10 -0700 2012-10-04 07:45:27 -0700 Patch 98389_utests_xvfb.patch text/plain 4118 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYzljMzBmLi5kY2VkNjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBSdW4gdW5pdCB0ZXN0cyB3aXRoIFh2ZmIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4Mzg5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2Vm bC9ld2tfbWFpbi5jcHA6CisgICAgICAgIChld2tfaW5pdCk6IENhbGwgZWNvcmVfZXZhc19zaHV0 ZG93bigpIGluc3RlYWQgb2YKKyAgICAgICAgZWRqZV9zaHV0ZG93bigpIHdoZW4gZWNvcmVfeF9p bml0KCkgZmFpbHMuCisgICAgICAgIChld2tfc2h1dGRvd24pOiBSZW1vdmUgZXh0cmEgY2FsbCB0 byBlZGplX3NodXRkb3duKCkuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVz dF9ld2syX3ZpZXcuY3BwOgorICAgICAgICAoVEVTVF9GKTogVGVtcG9yYXJpbHkgZGlzYWJsZSBm dWxsc2NyZWVuIHVuaXQgdGVzdHMKKyAgICAgICAgdW50aWwgd2UgZ2V0IHRoZW0gd29ya2luZyB3 aXRoIFh2ZmIuCisKIDIwMTItMTAtMDQgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNv dHRlQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCB0aGUgdHN0X1FRdWlja1dlYlZpZXc6 OnNjcm9sbFJlcXVlc3QgYXV0byB0ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfbWFpbi5jcHAKaW5kZXggNTY4ODZjYy4uMTdlMmIxZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcApAQCAtOTAsNyArOTAsNyBAQCBp bnQgZXdrX2luaXQodm9pZCkKIAogI2lmZGVmIEhBVkVfRUNPUkVfWAogZXJyb3JfZWNvcmVfeDoK LSAgICBlZGplX3NodXRkb3duKCk7CisgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOwogI2VuZGlm CiBlcnJvcl9lY29yZV9ldmFzOgogICAgIGVjb3JlX3NodXRkb3duKCk7CkBAIC0xMTMsNyArMTEz LDYgQEAgaW50IGV3a19zaHV0ZG93bih2b2lkKQogI2lmZGVmIEhBVkVfRUNPUkVfWAogICAgIGVj b3JlX3hfc2h1dGRvd24oKTsKICNlbmRpZgotICAgIGVkamVfc2h1dGRvd24oKTsKICAgICBlY29y ZV9ldmFzX3NodXRkb3duKCk7CiAgICAgZWNvcmVfc2h1dGRvd24oKTsKICAgICBldmFzX3NodXRk b3duKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90 ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggYmNiYTc1NS4uMzczY2I2NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdr Ml92aWV3LmNwcApAQCAtMzIwLDcgKzMyMCw3IEBAIHN0YXRpYyB2b2lkIGNoZWNrRnVsbFNjcmVl blByb3BlcnR5KEV2YXNfT2JqZWN0KiB3ZWJWaWV3LCBib29sIGV4cGVjdGVkU3RhdGUpCiAgICAg QVNTRVJUX1RSVUUoZXhwZWN0ZWRTdGF0ZSA9PSB3aW5kb3dTdGF0ZSk7CiB9CiAKLVRFU1RfRihF V0syVW5pdFRlc3RCYXNlLCBld2tfdmlld19mdWxsX3NjcmVlbl9lbnRlcikKK1RFU1RfRihFV0sy VW5pdFRlc3RCYXNlLCBESVNBQkxFRF9ld2tfdmlld19mdWxsX3NjcmVlbl9lbnRlcikKIHsKICAg ICBjb25zdCBjaGFyIGZ1bGxzY3JlZW5IVE1MW10gPQogICAgICAgICAiPCFkb2N0eXBlIGh0bWw+ PGhlYWQ+PHNjcmlwdD5mdW5jdGlvbiBtYWtlRnVsbFNjcmVlbigpeyIKQEAgLTM0MCw3ICszNDAs NyBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfZnVsbF9zY3JlZW5fZW50ZXIp CiAgICAgY2hlY2tGdWxsU2NyZWVuUHJvcGVydHkod2ViVmlldygpLCB0cnVlKTsKIH0KIAotVEVT VF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X2Z1bGxfc2NyZWVuX2V4aXQpCitURVNUX0Yo RVdLMlVuaXRUZXN0QmFzZSwgRElTQUJMRURfZXdrX3ZpZXdfZnVsbF9zY3JlZW5fZXhpdCkKIHsK ICAgICBjb25zdCBjaGFyIGZ1bGxzY3JlZW5IVE1MW10gPQogICAgICAgICAiPCFkb2N0eXBlIGh0 bWw+PGhlYWQ+PHNjcmlwdD5mdW5jdGlvbiBtYWtlRnVsbFNjcmVlbkFuZEV4aXQoKXsiCmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTgzNGZiYi4u NjI5YmJkNSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTA0ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0 b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gUnVuIHVuaXQgdGVzdHMgd2l0 aCBYdmZiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODM4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJ1 biBFRkwgdW5pdCB0ZXN0cyB3aXRoIFh2ZmIsIHNpbWlsYXJseSB0byBHVEsgcG9ydC4KKworICAg ICAgICAqIFNjcmlwdHMvcnVuLWVmbC10ZXN0czoKKwogMjAxMi0xMC0wNCAgSGFyYWxkIEFsdmVz dHJhbmQgIDxodGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgUlRDUGVlckNvbm5lY3Rp b24gR2V0U3RhdHMgdG8gdXNlIERhdGUgdGltZXN0YW1wIGZvcm1hdApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tZWZsLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZWZsLXRlc3RzCmlu ZGV4IDRhOTVmNTAuLjUyZDExOWEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWVmbC10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1lZmwtdGVzdHMKQEAgLTMyLDkgKzMyLDMwIEBA IHVzZSBGaW5kQmluOwogdXNlIGxpYiAkRmluZEJpbjo6QmluOwogdXNlIHdlYmtpdGRpcnM7CiAK LXNldENvbmZpZ3VyYXRpb24oKTsKK215ICR4dmZiX2Rpc3BsYXkgPSAiOjU1IjsKKworbXkgJHh2 ZmJfcGlkID0gZm9yaygpOworZXhpdCgxKSBpZiBub3QgZGVmaW5lZCAkeHZmYl9waWQ7CiAKICMg VGVsbCBDVGVzdCB0byBkdW1wIGd0ZXN0IG91dHB1dCBpbiBjYXNlIG9mIGZhaWx1cmUuCiAkRU5W e0NURVNUX09VVFBVVF9PTl9GQUlMVVJFfSA9ICIxIjsKKyRFTlZ7RElTUExBWX0gPSAkeHZmYl9k aXNwbGF5OworCitpZiAoJHh2ZmJfcGlkID09IDApIHsKKyAgICAjIFN0YXJ0IFh2ZmIKKyAgICBt eSBAeHZmYl9hcmdzID0gKCAiWHZmYiAkeHZmYl9kaXNwbGF5IC1zY3JlZW4gMCA4MDB4NjAweDI0 IC1ub2xpc3RlbiB0Y3AgPiAvZGV2L251bGwgMj4mMSIgKTsKKyAgICBleGVjKEB4dmZiX2FyZ3Mp OworfSBlbHNlIHsKKyAgICBzZXRDb25maWd1cmF0aW9uKCk7CisKKyAgICBteSAkcmV0dXJuQ29k ZSA9IGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoIkVmbCIs IHVuZGVmLCBjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpKSk7CisgICAgZXhpdCgkcmV0dXJuQ29k ZSkgaWYgJHJldHVybkNvZGU7CisKKyAgICAkcmV0dXJuQ29kZSA9IGV4aXRTdGF0dXMoYnVpbGRD TWFrZUdlbmVyYXRlZFByb2plY3QoInRlc3QiKSk7CisKKyAgICAjIEtpbGwgWHZmYgorICAgIGtp bGwoMTUsICR4dmZiX3BpZCk7CisKKyAgICBleGl0KCRyZXR1cm5Db2RlKTsKK30KIAotYnVpbGRD TWFrZVByb2plY3RPckV4aXQoMCwgIkVmbCIsIHVuZGVmLCAidGVzdCIsIGNtYWtlQmFzZWRQb3J0 QXJndW1lbnRzKCkpOwo=