98387 2012-10-04 02:26:14 -0700 [Qt] GL_ARB_texture_rectangle must be activated when using ANGLE on Mac. 2012-10-10 03:38:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno dino noam webkit.review.bot oldest_to_newest 734530 0 zeno 2012-10-04 02:26:14 -0700 The GraphicsSurface implementation on Mac is based on an IOSurface. And IOSurface requires this extension. So this change is necessary to enable WebGL again after r127063. 734533 1 167059 zeno 2012-10-04 02:37:38 -0700 Created attachment 167059 patch for review. 734662 2 167059 noam 2012-10-04 07:14:24 -0700 Comment on attachment 167059 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=167059&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:211 > + if (m_platformContext->hasExtension(QByteArrayLiteral("GL_ARB_texture_rectangle"))) > + ANGLEResources.ARB_texture_rectangle = 1; Please use Extensions3D 735577 3 167309 zeno 2012-10-05 04:58:27 -0700 Created attachment 167309 patch for review. - using Extensions3D. 738793 4 167309 zeno 2012-10-10 03:38:36 -0700 Comment on attachment 167309 patch for review. - using Extensions3D. Clearing flags on attachment: 167309 Committed r130880: <http://trac.webkit.org/changeset/130880> 738794 5 zeno 2012-10-10 03:38:42 -0700 All reviewed patches have been landed. Closing bug. 167059 2012-10-04 02:37:38 -0700 2012-10-05 04:58:27 -0700 patch for review. 98387_20121004-113549.patch text/plain 1579 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWY3YTk4Li4zN2Y2OTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDQgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtNYWNdIEdMX0FSQl90ZXh0dXJlX3JlY3RhbmdsZSBtdXN0IGJlIGFjdGl2YXRlZCB3 aGVuIHVzaW5nIEFOR0xFLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTgzODcKKworICAgICAgICBDaGVjayBmb3IgdGhlIGF2YWlsYWJpbGl0eSBvZiBH TF9BUkJfdGV4dHVyZV9yZWN0YW5nbGUgZXh0ZW5zaW9uLgorICAgICAgICBJbiBjYXNlIGl0IGlz IGF2YWlsYWJsZSwgd2UgYWN0aXZhdGUgdGhlIGV4dGVuc2lvbiBmb3IgQU5HTEUuCisgICAgICAg IFRoaXMgaXMgbmVjZXNzYXJ5IGZvciBXZWJHTCBvbiBtYWMsIGJlY2F1c2UgdGhlIEdyYXBoaWNz U3VyZmFjZQorICAgICAgICBvbiB0aGlzIHBsYXRmb3JtIGlzIGJhc2VkIG9uIGFuIElPU3VyZmFj ZSwgd2hpY2ggcmVxdWlyZXMgdGhpcyBleHRlbnNpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6aW5pdGlhbGl6ZUFOR0xFKToKKwogMjAxMi0wOS0yOCAgWW9zaGlmdW1pIElub3VlICA8 eW9zaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtGb3Jtc10gTXVsdGlwbGUgZmllbGRzIG1v bnRoIGlucHV0IFVJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCmluZGV4IDE2NzhjNDkuLjU0OGQwMTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNz Q29udGV4dDNEUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCkBAIC0yMDYsNiArMjA2LDEwIEBAIHZvaWQgR3JhcGhp Y3NDb250ZXh0M0RQcml2YXRlOjppbml0aWFsaXplQU5HTEUoKQogCiAgICAgLy8gQWx3YXlzIHNl dCB0byAxIGZvciBPcGVuR0wgRVMuCiAgICAgQU5HTEVSZXNvdXJjZXMuTWF4RHJhd0J1ZmZlcnMg PSAxOworCisgICAgaWYgKG1fcGxhdGZvcm1Db250ZXh0LT5oYXNFeHRlbnNpb24oUUJ5dGVBcnJh eUxpdGVyYWwoIkdMX0FSQl90ZXh0dXJlX3JlY3RhbmdsZSIpKSkKKyAgICAgICAgQU5HTEVSZXNv dXJjZXMuQVJCX3RleHR1cmVfcmVjdGFuZ2xlID0gMTsKKwogICAgIG1fY29udGV4dC0+bV9jb21w aWxlci5zZXRSZXNvdXJjZXMoQU5HTEVSZXNvdXJjZXMpOwogfQogCg== 167309 2012-10-05 04:58:27 -0700 2012-10-10 03:38:36 -0700 patch for review. - using Extensions3D. 98387_20121005-135622.patch text/plain 1640 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NGI3NDVjLi41YzlhZDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDQgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtNYWNdIEdMX0FSQl90ZXh0dXJlX3JlY3RhbmdsZSBtdXN0IGJlIGFjdGl2YXRlZCB3 aGVuIHVzaW5nIEFOR0xFLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTgzODcKKworICAgICAgICBDaGVjayBmb3IgdGhlIGF2YWlsYWJpbGl0eSBvZiBH TF9BUkJfdGV4dHVyZV9yZWN0YW5nbGUgZXh0ZW5zaW9uLgorICAgICAgICBJbiBjYXNlIGl0IGlz IGF2YWlsYWJsZSwgd2UgYWN0aXZhdGUgdGhlIGV4dGVuc2lvbiBmb3IgQU5HTEUuCisgICAgICAg IFRoaXMgaXMgbmVjZXNzYXJ5IGZvciBXZWJHTCBvbiBtYWMsIGJlY2F1c2UgdGhlIEdyYXBoaWNz U3VyZmFjZQorICAgICAgICBvbiB0aGlzIHBsYXRmb3JtIGlzIGJhc2VkIG9uIGFuIElPU3VyZmFj ZSwgd2hpY2ggcmVxdWlyZXMgdGhpcyBleHRlbnNpb24uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGlj c0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6aW5pdGlhbGl6ZUFOR0xFKToKKwogMjAxMi0xMC0wNSAgQW5kcmVpIEJ1Y3VyICA8YWJ1 Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBJbmNvbXBsZXRlIHJlcGFpbnQgb2YgYm94ZXMgd2l0 aCBpbnNldCBib3gtc2hhZG93IGFuZCBwYWRkaW5nIHdoZW4gcmVzaXplZApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQz RFF0LmNwcAppbmRleCAxNjc4YzQ5Li5kOGMxYTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcApA QCAtMjA2LDYgKzIwNiwxMSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6aW5pdGlh bGl6ZUFOR0xFKCkKIAogICAgIC8vIEFsd2F5cyBzZXQgdG8gMSBmb3IgT3BlbkdMIEVTLgogICAg IEFOR0xFUmVzb3VyY2VzLk1heERyYXdCdWZmZXJzID0gMTsKKworICAgIEV4dGVuc2lvbnMzRCog ZXh0ZW5zaW9ucyA9IG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpOworICAgIGlmIChleHRlbnNp b25zLT5zdXBwb3J0cygiR0xfQVJCX3RleHR1cmVfcmVjdGFuZ2xlIikpCisgICAgICAgIEFOR0xF UmVzb3VyY2VzLkFSQl90ZXh0dXJlX3JlY3RhbmdsZSA9IDE7CisKICAgICBtX2NvbnRleHQtPm1f Y29tcGlsZXIuc2V0UmVzb3VyY2VzKEFOR0xFUmVzb3VyY2VzKTsKIH0KIAo=