98384 2012-10-04 01:06:57 -0700 [WK2][GTK][EFL] standard_output returned by g_spawn_sync must be freed 2012-10-05 02:19:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim laszlo.gombos lucas.de.marchi mariusz.g webkit.review.bot oldest_to_newest 734477 0 naginenis 2012-10-04 01:06:57 -0700 standard_output returned by g_spawn_sync() leaks here if we return early after evaluating the exit status. http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp#L68 64 if (!g_spawn_sync(0, argv, 0, G_SPAWN_STDERR_TO_DEV_NULL, 0, 0, &stdOut, 0, &status, 0)) 65 return false; 66 67 if (!WIFEXITED(status) || WEXITSTATUS(status) != EXIT_SUCCESS) 68 return false; 734482 1 167044 naginenis 2012-10-04 01:11:20 -0700 Created attachment 167044 Patch 735459 2 167044 gyuyoung.kim 2012-10-05 00:50:12 -0700 Comment on attachment 167044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review > Source/WebKit2/ChangeLog:3 > + [WK2] [EFL] standard_output returned by g_spawn_sync must be freed This is not EFL port patch. Please remove [EFL] keyword. > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68 > + free(stdOut); Don't we need to check if stdOut is null once more? 735477 3 167044 naginenis 2012-10-05 01:12:55 -0700 Comment on attachment 167044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167044&action=review >> Source/WebKit2/ChangeLog:3 >> + [WK2] [EFL] standard_output returned by g_spawn_sync must be freed > > This is not EFL port patch. Please remove [EFL] keyword. This code is under GTK/EFL ifdef guards. I think make sense to add GTK too, instead of removing EFL. >> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:68 >> + free(stdOut); > > Don't we need to check if stdOut is null once more? free is NULL-safe, no need to check. 735481 4 167278 naginenis 2012-10-05 01:20:06 -0700 Created attachment 167278 Patch Updated changelog. 735483 5 167278 gyuyoung.kim 2012-10-05 01:24:52 -0700 Comment on attachment 167278 Patch Looks make sense. 735518 6 167278 webkit.review.bot 2012-10-05 02:19:25 -0700 Comment on attachment 167278 Patch Clearing flags on attachment: 167278 Committed r130490: <http://trac.webkit.org/changeset/130490> 735519 7 webkit.review.bot 2012-10-05 02:19:29 -0700 All reviewed patches have been landed. Closing bug. 167044 2012-10-04 01:11:20 -0700 2012-10-05 01:20:06 -0700 Patch 98384.patch text/plain 1565 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwYzQ0ZDQ0Li5lYjA1OWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMDQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW1dLMl0gW0VGTF0gc3RhbmRhcmRfb3V0cHV0IHJldHVybmVk IGJ5IGdfc3Bhd25fc3luYyBtdXN0IGJlIGZyZWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODM4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZyZWUgdGhlIHN0YW5kYXJkX291dHB1dCByZXR1cm5lZCBi eSBnX3NwYXduX3N5bmMoKSB0byBhdm9pZAorICAgICAgICBhIG1lbW9yeSBsZWFrLgorCisgICAg ICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcDoK KyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1Z2luKToKKwogMjAx Mi0xMC0wMyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgog CiAgICAgICAgIFtFRkxdIEVuYWJsZSB1c2Ugb2YgWDExIGluIER1bXBSZW5kZXJUcmVlIC8gV2Vi S2l0VGVzdFJ1bm5lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdp bnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKaW5kZXggMTA4MGNi OC4uM2ZlYmIwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMv dW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCkBAIC02NCw4ICs2 NCwxMCBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcm IHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRhJgogICAgIGlmICghZ19zcGF3bl9zeW5jKDAs IGFyZ3YsIDAsIEdfU1BBV05fU1RERVJSX1RPX0RFVl9OVUxMLCAwLCAwLCAmc3RkT3V0LCAwLCAm c3RhdHVzLCAwKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFXSUZFWElURUQo c3RhdHVzKSB8fCBXRVhJVFNUQVRVUyhzdGF0dXMpICE9IEVYSVRfU1VDQ0VTUykKKyAgICBpZiAo IVdJRkVYSVRFRChzdGF0dXMpIHx8IFdFWElUU1RBVFVTKHN0YXR1cykgIT0gRVhJVF9TVUNDRVNT KSB7CisgICAgICAgIGZyZWUoc3RkT3V0KTsKICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0K IAogICAgIGNvbnN0IHVuc2lnbmVkIGtOdW1MaW5lc0V4cGVjdGVkID0gMzsKICAgICBTdHJpbmcg bGluZXNba051bUxpbmVzRXhwZWN0ZWRdOwo= 167278 2012-10-05 01:20:06 -0700 2012-10-05 02:19:25 -0700 Patch 98384.patch text/plain 1539 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyY2QzODQwLi5mYmE2YWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMDUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW1dLMl1bR1RLXVtFRkxdIHN0YW5kYXJkX291dHB1dCByZXR1 cm5lZCBieSBnX3NwYXduX3N5bmMgbXVzdCBiZSBmcmVlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgzODQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGcmVlIHRoZSBzdGFuZGFyZF9vdXRwdXQgcmV0dXJu ZWQgYnkgZ19zcGF3bl9zeW5jKCkgdG8gYXZvaWQKKyAgICAgICAgYSBtZW1vcnkgbGVhay4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5j cHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NQcm94eTo6c2NhblBsdWdpbik6CisK IDIwMTItMTAtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KIAogICAgICAgICBbRUZMXSBSdW4gdW5pdCB0ZXN0cyB3aXRoIFh2ZmIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5 VW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblBy b2Nlc3NQcm94eVVuaXguY3BwCmluZGV4IDEwODBjYjguLjNmZWJiMDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5p eC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Q cm9jZXNzUHJveHlVbml4LmNwcApAQCAtNjQsOCArNjQsMTAgQEAgYm9vbCBQbHVnaW5Qcm9jZXNz UHJveHk6OnNjYW5QbHVnaW4oY29uc3QgU3RyaW5nJiBwbHVnaW5QYXRoLCBSYXdQbHVnaW5NZXRh RGF0YSYKICAgICBpZiAoIWdfc3Bhd25fc3luYygwLCBhcmd2LCAwLCBHX1NQQVdOX1NUREVSUl9U T19ERVZfTlVMTCwgMCwgMCwgJnN0ZE91dCwgMCwgJnN0YXR1cywgMCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAotICAgIGlmICghV0lGRVhJVEVEKHN0YXR1cykgfHwgV0VYSVRTVEFUVVMoc3Rh dHVzKSAhPSBFWElUX1NVQ0NFU1MpCisgICAgaWYgKCFXSUZFWElURUQoc3RhdHVzKSB8fCBXRVhJ VFNUQVRVUyhzdGF0dXMpICE9IEVYSVRfU1VDQ0VTUykgeworICAgICAgICBmcmVlKHN0ZE91dCk7 CiAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBjb25zdCB1bnNpZ25lZCBrTnVt TGluZXNFeHBlY3RlZCA9IDM7CiAgICAgU3RyaW5nIGxpbmVzW2tOdW1MaW5lc0V4cGVjdGVkXTsK