9838 2006-07-10 13:20:46 -0700 REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache 2006-07-10 16:51:56 -0700 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz sullivan ddkilzer mjs sullivan oldest_to_newest 49129 0 mitz 2006-07-10 13:20:46 -0700 Summary: When using shipping Safari 2.0.4 (419.3) with ToT WebKit, View Source brings up an empty window for pages loaded from the back/forward cache. To reproduce: go to http://webkit.opendarwin.org/ and wait for it to finish loading, then go to about:blank, go back, and choose View > View Source. Expected: source of webkit home page. Actual: blank source window. This is a regression that occurred between r14968 and r14977. A likely suspect in that range is r14976 - start moving loading logic to new WebFrameLoader class; move management of WebLoaders there. 49130 1 sullivan 2006-07-10 13:40:53 -0700 This also occurs with tip of tree Safari, so it's not a mismatch between WebKit and WebBrowser. View Source uses the WebDocumentRepresentation protocol method -(NSString *)documentSource, so that method isn't returning the right result in this case. 49132 2 9347 mitz 2006-07-10 14:09:16 -0700 Created attachment 9347 Proposed patch 49133 3 9347 sullivan 2006-07-10 14:26:47 -0700 Comment on attachment 9347 Proposed patch Looks good. 49139 4 sullivan 2006-07-10 16:38:22 -0700 I'll land this 49140 5 sullivan 2006-07-10 16:51:56 -0700 checked in as svn revision 15315 9347 2006-07-10 14:09:16 -0700 2006-07-10 14:26:47 -0700 Proposed patch 9838_r1.patch text/plain 1424 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTUzMDkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMDYtMDctIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0 enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9p ZD05ODM4CisgICAgICAgICAgUkVHUkVTU0lPTiAocjE0OTY4LXIxNDk3Nyk6IFZpZXcgU291cmNl IGRvZXNuJ3Qgd29yayBmb3IgcGFnZXMgZnJvbSB0aGUgYmFjay9mb3J3YXJkIGNhY2hlCisKKyAg ICAgICAgKiBXZWJWaWV3L1dlYkRhdGFTb3VyY2UubToKKyAgICAgICAgKC1bV2ViRGF0YVNvdXJj ZSBfc2V0UHJpbWFyeUxvYWRDb21wbGV0ZTpdKTogU2V0IG91ciBkYXRhIG9ubHkgaWYgdGhlIGZy YW1lIGxvYWRlciBpcworICAgICAgICBoYXMganVzdCBsb2FkZWQgaXQgKHdoZW4gY29taW5nIGZy b20gdGhlIGJhY2svZm9yd2FyZCBjYWNoZSwgaXQgaGFzbid0KS4KKwogMjAwNi0wNy0xMCAgQnJh ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxl eGV5CkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJEYXRhU291cmNlLm0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L1dlYlZpZXcvV2ViRGF0YVNvdXJjZS5tCShyZXZpc2lvbiAxNTMwOCkKKysrIFdlYktp dC9XZWJWaWV3L1dlYkRhdGFTb3VyY2UubQkod29ya2luZyBjb3B5KQpAQCAtMzY4LDggKzM2OCwx MCBAQAogICAgICAgICAvLyB0aGVyZSdzIG5vIGNhbGxiYWNrIGZvciB0aGF0LgogICAgICAgICBb c2VsZiBfbG9hZEljb25dOwogCi0gICAgICAgIFtzZWxmIF9zZXREYXRhOltfcHJpdmF0ZS0+ZnJh bWVMb2FkZXIgbWFpblJlc291cmNlRGF0YV1dOwotICAgICAgICBbX3ByaXZhdGUtPmZyYW1lTG9h ZGVyIHJlbGVhc2VNYWluUmVzb3VyY2VMb2FkZXJdOworICAgICAgICBpZiAoW19wcml2YXRlLT5m cmFtZUxvYWRlciBpc0xvYWRpbmdNYWluUmVzb3VyY2VdKSB7CisgICAgICAgICAgICBbc2VsZiBf c2V0RGF0YTpbX3ByaXZhdGUtPmZyYW1lTG9hZGVyIG1haW5SZXNvdXJjZURhdGFdXTsKKyAgICAg ICAgICAgIFtfcHJpdmF0ZS0+ZnJhbWVMb2FkZXIgcmVsZWFzZU1haW5SZXNvdXJjZUxvYWRlcl07 CisgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIFtzZWxmIF91cGRhdGVMb2FkaW5nXTsKIAo=