98349 2012-10-04 00:21:10 -0700 [EFL] webintents/web-intents-failure.html is failing 2012-10-04 01:58:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco tonikitoo webkit.review.bot oldest_to_newest 734423 0 cdumez 2012-10-04 00:21:10 -0700 Due to the change in http://trac.webkit.org/changeset/130344, webintents/web-intents-failure.html started failing. This is because OpaqueJSString().string().isNull() no longer returns true. OpaqueJSString().string() now returns an empty string instead of a NULL string. 734427 1 167042 cdumez 2012-10-04 00:23:11 -0700 Created attachment 167042 Patch 734515 2 167042 webkit.review.bot 2012-10-04 01:58:15 -0700 Comment on attachment 167042 Patch Clearing flags on attachment: 167042 Committed r130374: <http://trac.webkit.org/changeset/130374> 734516 3 webkit.review.bot 2012-10-04 01:58:19 -0700 All reviewed patches have been landed. Closing bug. 167042 2012-10-04 00:23:11 -0700 2012-10-04 01:58:14 -0700 Patch 98349_intent_fix.patch text/plain 1676 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjODc4MGM4Li4zZmI3MjUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMTAtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRz LWZhaWx1cmUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05ODM0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFmdGVyIHIxMzAzNDQsIE9wYXF1ZUpTU3RyaW5nKCkuc3RyaW5nKCkg cmV0dXJucworICAgICAgICBhbiBlbXB0eSBzdHJpbmcgaW5zdGVhZCBvZiBhIG51bGwgb25lLiBU aGVyZWZvcmUsCisgICAgICAgIHdlIG5lZWQgdG8gdXBkYXRlIHRoZSBjaGVjayBpbgorICAgICAg ICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNlbmRXZWJJbnRlbnRSZXNwb25zZSgpLgorCisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcDoKKyAg ICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbDo6c2VuZFdlYkludGVudFJlc3BvbnNlKToK KwogMjAxMi0xMC0wMyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF0gRGVmYXVsdC5lZGogc2hvdWxkIGJlIGdlbmVyYXRlZCBhbHRob3VnaCBFTkFC TEVfV0VCS0lUIGRpc2FibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZs L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEVmbC5jcHAKaW5kZXggYjAxMGIz OS4uYzRhNzNmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQv RHVtcFJlbmRlclRyZWVTdXBwb3J0RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJD b3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmwuY3BwCkBAIC01NzcsNyArNTc3LDcg QEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNlbmRXZWJJbnRlbnRSZXNwb25zZShF d2tfSW50ZW50X1JlcXVlc3QqIHJlcXVlc3QKIHsKICNpZiBFTkFCTEUoV0VCX0lOVEVOVFMpCiAg ICAgU3RyaW5nIHJlc3BvbnNlU3RyaW5nID0gcmVzcG9uc2UtPnN0cmluZygpOwotICAgIGlmIChy ZXNwb25zZVN0cmluZy5pc051bGwoKSkKKyAgICBpZiAocmVzcG9uc2VTdHJpbmcuaXNFbXB0eSgp KQogICAgICAgICBld2tfaW50ZW50X3JlcXVlc3RfZmFpbHVyZV9wb3N0KHJlcXVlc3QsIFdlYkNv cmU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6Y3JlYXRlKFN0cmluZzo6ZnJvbVVURjgoIkVSUk9S IikpKTsKICAgICBlbHNlCiAgICAgICAgIGV3a19pbnRlbnRfcmVxdWVzdF9yZXN1bHRfcG9zdChy ZXF1ZXN0LCBXZWJDb3JlOjpTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZShTdHJpbmcocmVz cG9uc2VTdHJpbmcuaW1wbCgpKSkpOwo=