98335 2012-10-03 18:03:44 -0700 Use copyLCharsFromUCharSource() for IdentifierLCharFromUCharTranslator translation 2012-10-04 14:37:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin darin msaboff oldest_to_newest 734280 0 benjamin 2012-10-03 18:03:44 -0700 Let's use the optimized version :) 734284 1 167014 benjamin 2012-10-03 18:11:42 -0700 Created attachment 167014 Patch 734930 2 167014 benjamin 2012-10-04 12:34:13 -0700 Comment on attachment 167014 Patch Clearing flags on attachment: 167014 Committed r130418: <http://trac.webkit.org/changeset/130418> 734931 3 benjamin 2012-10-04 12:34:15 -0700 All reviewed patches have been landed. Closing bug. 735022 4 darin 2012-10-04 14:37:32 -0700 It’s kind of bad that copyLCharsFromUCharSource is in ASCIIFastPath.h, because LChar allows non-ASCII characters. The header may need a new name or something. 735024 5 167014 darin 2012-10-04 14:37:58 -0700 Comment on attachment 167014 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167014&action=review > Source/JavaScriptCore/runtime/Identifier.cpp:84 > + WTF::copyLCharsFromUCharSource(d, buf.s, buf.length); The explicit WTF here is strange, and should not be needed if ASCIIFastPath follows the normal using model we use for WTF headers. 167014 2012-10-03 18:11:42 -0700 2012-10-04 14:37:58 -0700 Patch bug-98335-20121003181054.patch text/plain 1874 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MjBkMmY1NDM0MmE4YmExMDI2ZjMwYjM3ZGY5NDFhYzI1OWQxMTc0Li5iY2YzZjQ3ZmU4NzIzNmMz NzIxZTMzMTRiN2IwZjg5Mjg3N2ExNGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0xMC0wMyAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBVc2UgY29weUxDaGFyc0Zyb21VQ2hhclNvdXJjZSgpIGZvciBJZGVu dGlmaWVyTENoYXJGcm9tVUNoYXJUcmFuc2xhdG9yIHRyYW5zbGF0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODMzNQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1pY2hhZWwgU2Fib2ZmIGFkZGVkIGFu IG9wdGltaXplZCB2ZXJzaW9uIG9mIFVDaGFyLT5MQ2hhciBjb252ZXJzaW9uIGluIHIxMjU4NDYu CisgICAgICAgIFVzZSB0aGlzIGZ1bmN0aW9uIGluIEpTQzo6SWRlbnRpZmllci4KKworICAgICAg ICAqIHJ1bnRpbWUvSWRlbnRpZmllci5jcHA6CisgICAgICAgIChKU0M6OklkZW50aWZpZXJMQ2hh ckZyb21VQ2hhclRyYW5zbGF0b3I6OnRyYW5zbGF0ZSk6CisKIDIwMTItMTAtMDMgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBBcnJheS5zcGxpY2Ugc2hvdWxkIGJl IGZhc3Qgd2hlbiBpdCBpcyB1c2VkIHRvIHJlbW92ZSBlbGVtZW50cyBvdGhlciB0aGFuIHRoZSB2 ZXJ5IGZpcnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JZGVu dGlmaWVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3Bw CmluZGV4IGE5YTJhNjZiZjgwMzgxMDljZWRlZTQ4OTU3ZTUxNzkyYzM5NGJlZDEuLjMyMDA5NTY2 Nzg2NDYzZDI2ZDNiOWFkZDI5NDFmM2Q5NTlmMjVjZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSA8 d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgogI2luY2x1ZGUg PHd0Zi9IYXNoU2V0Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvQVNDSUlGYXN0UGF0aC5oPgogI2lu Y2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0hhc2guaD4KIAogdXNpbmcgV1RGOjpUaHJlYWRTcGVjaWZp YzsKQEAgLTgwLDExICs4MSw3IEBAIHN0cnVjdCBJZGVudGlmaWVyTENoYXJGcm9tVUNoYXJUcmFu c2xhdG9yIHsKICAgICB7CiAgICAgICAgIExDaGFyKiBkOwogICAgICAgICBTdHJpbmdJbXBsKiBy ID0gU3RyaW5nSW1wbDo6Y3JlYXRlVW5pbml0aWFsaXplZChidWYubGVuZ3RoLCBkKS5sZWFrUmVm KCk7Ci0gICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgIT0gYnVmLmxlbmd0aDsgaSsrKSB7 Ci0gICAgICAgICAgICBVQ2hhciBjID0gYnVmLnNbaV07Ci0gICAgICAgICAgICBBU1NFUlQoYyA8 PSAweGZmKTsKLSAgICAgICAgICAgIGRbaV0gPSBjOwotICAgICAgICB9CisgICAgICAgIFdURjo6 Y29weUxDaGFyc0Zyb21VQ2hhclNvdXJjZShkLCBidWYucywgYnVmLmxlbmd0aCk7CiAgICAgICAg IHItPnNldEhhc2goaGFzaCk7CiAgICAgICAgIGxvY2F0aW9uID0gcjsgCiAgICAgfQo=