98333 2012-10-03 17:35:58 -0700 [GTK] Enable inspector by default in GtkLauncher/MiniBrowser 2012-10-04 05:23:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98310 0 aperez webkit-unassigned berto cgarcia mrobinson webkit.review.bot xan.lopez oldest_to_newest 734254 0 aperez 2012-10-03 17:35:58 -0700 [GTK] Enable inspector by default in GtkLauncher/MiniBrowser 734258 1 aperez 2012-10-03 17:38:44 -0700 Both MiniBrowser and GtkLauncher are tools for testing, so in the end every time we want to test the inspector we have to manually enable enable the “developer extras” setting when using them. It would make sense to have this setting enabled by default. 734272 2 167011 aperez 2012-10-03 17:55:24 -0700 Created attachment 167011 Patch 734584 3 berto 2012-10-04 04:23:22 -0700 > Tools/GtkLauncher/main.c:492 > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); You don't really need the cast here, g_object_set() receives a gpointer. Otherwise it looks fine :) 734586 4 167011 xan.lopez 2012-10-04 04:34:00 -0700 Comment on attachment 167011 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review > Tools/GtkLauncher/main.c:492 > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise I guess we should try to use the same when thing possible. r- because you need cq to land this, so please re-upload. 734592 5 aperez 2012-10-04 04:45:17 -0700 (In reply to comment #4) > (From update of attachment 167011 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167011&action=review > > > Tools/GtkLauncher/main.c:492 > > + g_object_set(G_OBJECT(webkitSettings), "enable-developer-extras", TRUE, NULL); > > Yeah, what Berto said. Also I guess the WK1 and WK2 APIs differ here, otherwise I guess we should try to use the same when thing possible. WK1 API exposes only the GObject properties, the WK2 API has also the convenience setter/getter functions, so it seemed natural to use them. Would it be better to use also g_object_set when using the WK2 API? (IMHO using the setter is easier on the eyes). > r- because you need cq to land this, so please re-upload. Will do. 734602 6 167077 aperez 2012-10-04 04:57:38 -0700 Created attachment 167077 Patch Updated patch, and requested commit-queue flag for it 734603 7 167077 xan.lopez 2012-10-04 04:59:03 -0700 Comment on attachment 167077 Patch Looks good! 734611 8 167077 webkit.review.bot 2012-10-04 05:23:55 -0700 Comment on attachment 167077 Patch Clearing flags on attachment: 167077 Committed r130386: <http://trac.webkit.org/changeset/130386> 734612 9 webkit.review.bot 2012-10-04 05:23:58 -0700 All reviewed patches have been landed. Closing bug. 167011 2012-10-03 17:55:24 -0700 2012-10-04 04:57:31 -0700 Patch bug-98333-20121004035525.patch text/plain 2245 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2I3ZWY1NjcwMzNlNzE3MTc4NzNlMjc2MDY4MzMyNTA1 MTVhYmQzMi4uZjk5NzMxMGIxMmMzOWQ2NDU4ODI0ZDExYjNiMjRhOTg1ZWM2YzZiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTEwLTAzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIGluc3BlY3RvciBieSBkZWZhdWx0IGluIEd0a0xh dW5jaGVyL01pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODMzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJvdGggTWluaUJyb3dzZXIgYW5kIEd0a0xhdW5jaGVyIGFyZSB0b29scyBmb3Ig dGVzdGluZywgc28gaW4KKyAgICAgICAgdGhlIGVuZCBldmVyeSB0aW1lIHdlIHdhbnQgdG8gdGVz dCB0aGUgaW5zcGVjdG9yIHdlIGhhdmUgdG8KKyAgICAgICAgbWFudWFsbHkgZW5hYmxlIGVuYWJs ZSB0aGUg4oCcZGV2ZWxvcGVyIGV4dHJhc+KAnSBzZXR0aW5nIHdoZW4gdXNpbmcKKyAgICAgICAg dGhlbS4gSXQgbWFrZSBzZW5zZSB0byBoYXZlIHRoaXMgc2V0dGluZyBlbmFibGVkIGJ5IGRlZmF1 bHQuCisKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChtYWluKToKKyAg ICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvbWFpbi5jOgorICAgICAgICAobWFpbik6CisKIDIwMTIt MTAtMDMgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IEdlb2xvY2F0aW9uL3dpbmRvdy1jbG9zZS1jcmFzaC5odG1sIGFuZCBoYXJkZW4gV2ViS2l0 VGVzdFJ1bm5lciBmb3IgR2VvbG9jYXRpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL0d0a0xhdW5jaGVy L21haW4uYyBiL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYwppbmRleCAyYmE3OTI0NzIxZDA2YzBm MTYzZGVlYzlhMmNiZTgzZmMzOTIyYjE1Li43MDllNjYxNWZkYzg0Njk3NzRiOGFjYjA3OTIxMjM3 MzJiZDg0NTU3IDEwMDY0NAotLS0gYS9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMKKysrIGIvVG9v bHMvR3RrTGF1bmNoZXIvbWFpbi5jCkBAIC00ODksNiArNDg5LDcgQEAgaW50IG1haW4oaW50IGFy Z2MsIGNoYXIqIGFyZ3ZbXSkKICAgICBnX29wdGlvbl9jb250ZXh0X2FkZF9ncm91cChjb250ZXh0 LCBndGtfZ2V0X29wdGlvbl9ncm91cChUUlVFKSk7CiAKICAgICB3ZWJraXRTZXR0aW5ncyA9IHdl YmtpdF93ZWJfc2V0dGluZ3NfbmV3KCk7CisgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHdlYmtp dFNldHRpbmdzKSwgImVuYWJsZS1kZXZlbG9wZXItZXh0cmFzIiwgVFJVRSwgTlVMTCk7CiAgICAg aWYgKCFhZGRXZWJTZXR0aW5nc0dyb3VwVG9Db250ZXh0KGNvbnRleHQsIHdlYmtpdFNldHRpbmdz KSkgewogICAgICAgICBnX29iamVjdF91bnJlZih3ZWJraXRTZXR0aW5ncyk7CiAgICAgICAgIHdl YmtpdFNldHRpbmdzID0gMDsKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWlu LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCmluZGV4IDk4OGUzOTY5NjQ2Y2ZjMzQw OTg3NDRhZTAxODJiNDNjM2MzYjFkNmYuLjhjNmMwOGQ2ZWIwMWE1MjgyYzIzNTE0NzliMTNmNDE0 M2FmZGU3NGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKKysrIGIv VG9vbHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYwpAQCAtMjA3LDYgKzIwNyw3IEBAIGludCBtYWlu KGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgZ19vcHRpb25fY29udGV4dF9hZGRfZ3JvdXAo Y29udGV4dCwgZ3RrX2dldF9vcHRpb25fZ3JvdXAoVFJVRSkpOwogCiAgICAgV2ViS2l0U2V0dGlu Z3MgKndlYmtpdFNldHRpbmdzID0gd2Via2l0X3NldHRpbmdzX25ldygpOworICAgIHdlYmtpdF9z ZXR0aW5nc19zZXRfZW5hYmxlX2RldmVsb3Blcl9leHRyYXMod2Via2l0U2V0dGluZ3MsIFRSVUUp OwogICAgIGlmICghYWRkU2V0dGluZ3NHcm91cFRvQ29udGV4dChjb250ZXh0LCB3ZWJraXRTZXR0 aW5ncykpIHsKICAgICAgICAgZ19vYmplY3RfdW5yZWYod2Via2l0U2V0dGluZ3MpOwogICAgICAg ICB3ZWJraXRTZXR0aW5ncyA9IDA7Cg== 167077 2012-10-04 04:57:38 -0700 2012-10-04 05:23:55 -0700 Patch bug-98333-20121004145737.patch text/plain 2211 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTgzNGZiYjFjNDAwYWFhNDY3OTFiNWNiOGJmYjQ0MDY3 M2UzZGEzNC4uOWI4ZjMwMDY1NTA0MjU3NDUwOWQzZGQ3M2ViMTcyNjBhODRjOTgyZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTEwLTAzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIGluc3BlY3RvciBieSBkZWZhdWx0IGluIEd0a0xh dW5jaGVyL01pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODMzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJvdGggTWluaUJyb3dzZXIgYW5kIEd0a0xhdW5jaGVyIGFyZSB0b29scyBmb3Ig dGVzdGluZywgc28gaW4KKyAgICAgICAgdGhlIGVuZCBldmVyeSB0aW1lIHdlIHdhbnQgdG8gdGVz dCB0aGUgaW5zcGVjdG9yIHdlIGhhdmUgdG8KKyAgICAgICAgbWFudWFsbHkgZW5hYmxlIGVuYWJs ZSB0aGUg4oCcZGV2ZWxvcGVyIGV4dHJhc+KAnSBzZXR0aW5nIHdoZW4gdXNpbmcKKyAgICAgICAg dGhlbS4gSXQgbWFrZSBzZW5zZSB0byBoYXZlIHRoaXMgc2V0dGluZyBlbmFibGVkIGJ5IGRlZmF1 bHQuCisKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChtYWluKToKKyAg ICAgICAgKiBNaW5pQnJvd3Nlci9ndGsvbWFpbi5jOgorICAgICAgICAobWFpbik6CisKIDIwMTIt MTAtMDQgIEhhcmFsZCBBbHZlc3RyYW5kICA8aHRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgQ2hh bmdlIFJUQ1BlZXJDb25uZWN0aW9uIEdldFN0YXRzIHRvIHVzZSBEYXRlIHRpbWVzdGFtcCBmb3Jt YXQKZGlmZiAtLWdpdCBhL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYyBiL1Rvb2xzL0d0a0xhdW5j aGVyL21haW4uYwppbmRleCA5YzE3ZjdkYzM0MjA1NzY1MDM2NDAxNDM4OTY4NmM1M2RmYzM5MzNk Li45NDJhMjBiMGZjMGI5MWVlZGFhZTc1YzA2OTdjMjg2NWNjYzg1ZDViIDEwMDY0NAotLS0gYS9U b29scy9HdGtMYXVuY2hlci9tYWluLmMKKysrIGIvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCkBA IC00ODksNiArNDg5LDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqIGFyZ3ZbXSkKICAgICBn X29wdGlvbl9jb250ZXh0X2FkZF9ncm91cChjb250ZXh0LCBndGtfZ2V0X29wdGlvbl9ncm91cChU UlVFKSk7CiAKICAgICB3ZWJraXRTZXR0aW5ncyA9IHdlYmtpdF93ZWJfc2V0dGluZ3NfbmV3KCk7 CisgICAgZ19vYmplY3Rfc2V0KHdlYmtpdFNldHRpbmdzLCAiZW5hYmxlLWRldmVsb3Blci1leHRy YXMiLCBUUlVFLCBOVUxMKTsKICAgICBpZiAoIWFkZFdlYlNldHRpbmdzR3JvdXBUb0NvbnRleHQo Y29udGV4dCwgd2Via2l0U2V0dGluZ3MpKSB7CiAgICAgICAgIGdfb2JqZWN0X3VucmVmKHdlYmtp dFNldHRpbmdzKTsKICAgICAgICAgd2Via2l0U2V0dGluZ3MgPSAwOwpkaWZmIC0tZ2l0IGEvVG9v bHMvTWluaUJyb3dzZXIvZ3RrL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMK aW5kZXggMWE1NWIxOGY4ZGJkNjFiNGQ3NDFlMjEzOTg1MmNjZGRiZWUyYzZkZS4uNGE5ZDhhNWZj MzNjMTQ3MmYzMTEwMGFiNjFmNmIyOWVmNmFmODY2ZSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJy b3dzZXIvZ3RrL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCkBAIC0y MDcsNiArMjA3LDcgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKICAgICBnX29w dGlvbl9jb250ZXh0X2FkZF9ncm91cChjb250ZXh0LCBndGtfZ2V0X29wdGlvbl9ncm91cChUUlVF KSk7CiAKICAgICBXZWJLaXRTZXR0aW5ncyAqd2Via2l0U2V0dGluZ3MgPSB3ZWJraXRfc2V0dGlu Z3NfbmV3KCk7CisgICAgd2Via2l0X3NldHRpbmdzX3NldF9lbmFibGVfZGV2ZWxvcGVyX2V4dHJh cyh3ZWJraXRTZXR0aW5ncywgVFJVRSk7CiAgICAgaWYgKCFhZGRTZXR0aW5nc0dyb3VwVG9Db250 ZXh0KGNvbnRleHQsIHdlYmtpdFNldHRpbmdzKSkgewogICAgICAgICBnX29iamVjdF91bnJlZih3 ZWJraXRTZXR0aW5ncyk7CiAgICAgICAgIHdlYmtpdFNldHRpbmdzID0gMDsK