98327 2012-10-03 16:43:48 -0700 Simplify attribute access in Element::computeInheritedLanguage 2012-10-03 18:53:13 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo dglazkov gustavo philn webkit.review.bot xan.lopez oldest_to_newest 734196 0 benjamin 2012-10-03 16:43:48 -0700 Small optimization. 734205 1 166993 benjamin 2012-10-03 16:49:51 -0700 Created attachment 166993 Patch 734212 2 166993 kling 2012-10-03 16:53:41 -0700 Comment on attachment 166993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166993&action=review r=me, though I suspect you could save a couple more cycles here by doing a custom loop over the attributeData->attributeItem()s. > Source/WebCore/dom/Element.cpp:1762 > + ElementAttributeData* attributeData = static_cast<const Element*>(n)->attributeData(); > + if (attributeData) { Scope 'attributeData' to the if. 734223 3 166993 gyuyoung.kim 2012-10-03 17:03:17 -0700 Comment on attachment 166993 Patch Attachment 166993 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14123896 734225 4 166993 buildbot 2012-10-03 17:06:21 -0700 Comment on attachment 166993 Patch Attachment 166993 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14126975 734227 5 166993 webkit-ews 2012-10-03 17:07:16 -0700 Comment on attachment 166993 Patch Attachment 166993 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14125978 734240 6 166993 webkit.review.bot 2012-10-03 17:17:46 -0700 Comment on attachment 166993 Patch Attachment 166993 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14129849 734246 7 166993 webkit-ews 2012-10-03 17:28:43 -0700 Comment on attachment 166993 Patch Attachment 166993 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14138773 734252 8 167006 benjamin 2012-10-03 17:32:19 -0700 Created attachment 167006 Patch 734298 9 167006 benjamin 2012-10-03 18:53:10 -0700 Comment on attachment 167006 Patch Clearing flags on attachment: 167006 Committed r130354: <http://trac.webkit.org/changeset/130354> 734299 10 benjamin 2012-10-03 18:53:13 -0700 All reviewed patches have been landed. Closing bug. 166993 2012-10-03 16:49:51 -0700 2012-10-03 17:32:17 -0700 Patch bug-98327-20121003164903.patch text/plain 2451 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYzMmFhNjc5OWU2NGVh YzNiZjUxYzEwNjVhMDg3MTBiZjQzY2U1MC4uN2QyNjlkOWI3N2NkNWVmMWY5OGQxYjNkOTI5N2Zm Y2UxNGIzYzBkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTAzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFNpbXBsaWZ5IGF0 dHJpYnV0ZSBhY2Nlc3MgaW4gRWxlbWVudDo6Y29tcHV0ZUluaGVyaXRlZExhbmd1YWdlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODMyNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0VsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Y29tcHV0ZUluaGVyaXRlZExhbmd1YWdl KToKKyAgICAgICAgQnkgdXNpbmcgRWxlbWVudDo6ZmFzdEdldEF0dHJpYnV0ZSgpLCB3ZSBjaGVj ayBmb3IgdGhlIGV4aXN0ZW5jZSBvZiBhdHRyaWJ1dGVEYXRhIHR3aWNlCisgICAgICAgIGFuZCBk byBhIGJ1bmNoIG9mIHVzZWxlc3Mgb3BlcmF0aW9uIG9uIEF0b21pY1N0cmluZy4KKworICAgICAg ICBCeSB1c2luZyBFbGVtZW50QXR0cmlidXRlRGF0YSBkaXJlY3RseSwgd2UgY2FuIGN1dCBpdCB0 byB0aGUgdHdvIGltcG9ydGFudCBicmFuY2guCisKIDIwMTItMTAtMDMgIExldmkgV2VpbnRyYXVi ICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtTdWItcGl4ZWwgbGF5b3V0XSBpbmNv cnJlY3QgcmVuZGVyaW5nIHdoZW4gcGFpbnRpbmcgc3ViLWxheWVycyBhcyB0aGVpciBvd24gcm9v dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IGMwMDU5OTI2YzQ1NTY0ZTdkYjFjNjk4NWFmZDI3 NzhkZjNkOTMzNzAuLjg2NWI0MGE3NTg2ODhiYjBmZGViNTdmNjU5ZmQ1MmEzY2UxMjVlMmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTE3NTgsMTAgKzE3NTgsMTQgQEAgQXRvbWljU3RyaW5n IEVsZW1lbnQ6OmNvbXB1dGVJbmhlcml0ZWRMYW5ndWFnZSgpIGNvbnN0CiAgICAgLy8gVGhlIGxh bmd1YWdlIHByb3BlcnR5IGlzIGluaGVyaXRlZCwgc28gd2UgaXRlcmF0ZSBvdmVyIHRoZSBwYXJl bnRzIHRvIGZpbmQgdGhlIGZpcnN0IGxhbmd1YWdlLgogICAgIGRvIHsKICAgICAgICAgaWYgKG4t PmlzRWxlbWVudE5vZGUoKSkgewotICAgICAgICAgICAgLy8gU3BlYzogeG1sOmxhbmcgdGFrZXMg cHJlY2VkZW5jZSAtLSBodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvI0NfNwotICAgICAgICAg ICAgdmFsdWUgPSBzdGF0aWNfY2FzdDxjb25zdCBFbGVtZW50Kj4obiktPmZhc3RHZXRBdHRyaWJ1 dGUoWE1MTmFtZXM6OmxhbmdBdHRyKTsKLSAgICAgICAgICAgIGlmICh2YWx1ZS5pc051bGwoKSkK LSAgICAgICAgICAgICAgICB2YWx1ZSA9IHN0YXRpY19jYXN0PGNvbnN0IEVsZW1lbnQqPihuKS0+ ZmFzdEdldEF0dHJpYnV0ZShIVE1MTmFtZXM6OmxhbmdBdHRyKTsKKyAgICAgICAgICAgIEVsZW1l bnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhID0gc3RhdGljX2Nhc3Q8Y29uc3QgRWxlbWVu dCo+KG4pLT5hdHRyaWJ1dGVEYXRhKCk7CisgICAgICAgICAgICBpZiAoYXR0cmlidXRlRGF0YSkg eworICAgICAgICAgICAgICAgIC8vIFNwZWM6IHhtbDpsYW5nIHRha2VzIHByZWNlZGVuY2UgLS0g aHR0cDovL3d3dy53My5vcmcvVFIveGh0bWwxLyNDXzcKKyAgICAgICAgICAgICAgICBpZiAoQXR0 cmlidXRlKiBhdHRyaWJ1dGUgPSBhdHRyaWJ1dGVEYXRhLT5nZXRBdHRyaWJ1dGVJdGVtKFhNTE5h bWVzOjpsYW5nQXR0cikpCisgICAgICAgICAgICAgICAgICAgIHZhbHVlID0gYXR0cmlidXRlLT52 YWx1ZSgpOworICAgICAgICAgICAgICAgIGVsc2UgaWYgKEF0dHJpYnV0ZSogYXR0cmlidXRlID0g YXR0cmlidXRlRGF0YS0+Z2V0QXR0cmlidXRlSXRlbShIVE1MTmFtZXM6OmxhbmdBdHRyKSkKKyAg ICAgICAgICAgICAgICAgICAgdmFsdWUgPSBhdHRyaWJ1dGUtPnZhbHVlKCk7CisgICAgICAgICAg ICB9CiAgICAgICAgIH0gZWxzZSBpZiAobi0+aXNEb2N1bWVudE5vZGUoKSkgewogICAgICAgICAg ICAgLy8gY2hlY2tpbmcgdGhlIE1JTUUgY29udGVudC1sYW5ndWFnZQogICAgICAgICAgICAgdmFs dWUgPSBzdGF0aWNfY2FzdDxjb25zdCBEb2N1bWVudCo+KG4pLT5jb250ZW50TGFuZ3VhZ2UoKTsK 167006 2012-10-03 17:32:19 -0700 2012-10-03 18:53:10 -0700 Patch bug-98327-20121003173130.patch text/plain 2440 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYzMmFhNjc5OWU2NGVh YzNiZjUxYzEwNjVhMDg3MTBiZjQzY2U1MC4uZjhmMWJlZGMzYWRjZWFmYzAzNGM1NDA0N2NlOWU4 MGI4YzQ0MjNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTAzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFNpbXBsaWZ5IGF0 dHJpYnV0ZSBhY2Nlc3MgaW4gRWxlbWVudDo6Y29tcHV0ZUluaGVyaXRlZExhbmd1YWdlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODMyNworCisgICAg ICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCisKKyAgICAgICAgKiBkb20vRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpjb21wdXRlSW5oZXJpdGVkTGFuZ3VhZ2Up OgorICAgICAgICBCeSB1c2luZyBFbGVtZW50OjpmYXN0R2V0QXR0cmlidXRlKCksIHdlIGNoZWNr IGZvciB0aGUgZXhpc3RlbmNlIG9mIGF0dHJpYnV0ZURhdGEgdHdpY2UKKyAgICAgICAgYW5kIGRv IGEgYnVuY2ggb2YgdXNlbGVzcyBvcGVyYXRpb24gb24gQXRvbWljU3RyaW5nLgorCisgICAgICAg IEJ5IHVzaW5nIEVsZW1lbnRBdHRyaWJ1dGVEYXRhIGRpcmVjdGx5LCB3ZSBjYW4gY3V0IGl0IHRv IHRoZSB0d28gaW1wb3J0YW50IGJyYW5jaC4KKwogMjAxMi0xMC0wMyAgTGV2aSBXZWludHJhdWIg IDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1N1Yi1waXhlbCBsYXlvdXRdIGluY29y cmVjdCByZW5kZXJpbmcgd2hlbiBwYWludGluZyBzdWItbGF5ZXJzIGFzIHRoZWlyIG93biByb290 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggYzAwNTk5MjZjNDU1NjRlN2RiMWM2OTg1YWZkMjc3 OGRmM2Q5MzM3MC4uZGQxMzE2OGQ5YzZkMjU5NGVmNzg0ZWM3YzMyYmNmNGUzYTM4ODdmYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMTc1OCwxMCArMTc1OCwxMyBAQCBBdG9taWNTdHJpbmcg RWxlbWVudDo6Y29tcHV0ZUluaGVyaXRlZExhbmd1YWdlKCkgY29uc3QKICAgICAvLyBUaGUgbGFu Z3VhZ2UgcHJvcGVydHkgaXMgaW5oZXJpdGVkLCBzbyB3ZSBpdGVyYXRlIG92ZXIgdGhlIHBhcmVu dHMgdG8gZmluZCB0aGUgZmlyc3QgbGFuZ3VhZ2UuCiAgICAgZG8gewogICAgICAgICBpZiAobi0+ aXNFbGVtZW50Tm9kZSgpKSB7Ci0gICAgICAgICAgICAvLyBTcGVjOiB4bWw6bGFuZyB0YWtlcyBw cmVjZWRlbmNlIC0tIGh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS8jQ183Ci0gICAgICAgICAg ICB2YWx1ZSA9IHN0YXRpY19jYXN0PGNvbnN0IEVsZW1lbnQqPihuKS0+ZmFzdEdldEF0dHJpYnV0 ZShYTUxOYW1lczo6bGFuZ0F0dHIpOwotICAgICAgICAgICAgaWYgKHZhbHVlLmlzTnVsbCgpKQot ICAgICAgICAgICAgICAgIHZhbHVlID0gc3RhdGljX2Nhc3Q8Y29uc3QgRWxlbWVudCo+KG4pLT5m YXN0R2V0QXR0cmlidXRlKEhUTUxOYW1lczo6bGFuZ0F0dHIpOworICAgICAgICAgICAgaWYgKGNv bnN0IEVsZW1lbnRBdHRyaWJ1dGVEYXRhKiBhdHRyaWJ1dGVEYXRhID0gc3RhdGljX2Nhc3Q8Y29u c3QgRWxlbWVudCo+KG4pLT5hdHRyaWJ1dGVEYXRhKCkpIHsKKyAgICAgICAgICAgICAgICAvLyBT cGVjOiB4bWw6bGFuZyB0YWtlcyBwcmVjZWRlbmNlIC0tIGh0dHA6Ly93d3cudzMub3JnL1RSL3ho dG1sMS8jQ183CisgICAgICAgICAgICAgICAgaWYgKGNvbnN0IEF0dHJpYnV0ZSogYXR0cmlidXRl ID0gYXR0cmlidXRlRGF0YS0+Z2V0QXR0cmlidXRlSXRlbShYTUxOYW1lczo6bGFuZ0F0dHIpKQor ICAgICAgICAgICAgICAgICAgICB2YWx1ZSA9IGF0dHJpYnV0ZS0+dmFsdWUoKTsKKyAgICAgICAg ICAgICAgICBlbHNlIGlmIChjb25zdCBBdHRyaWJ1dGUqIGF0dHJpYnV0ZSA9IGF0dHJpYnV0ZURh dGEtPmdldEF0dHJpYnV0ZUl0ZW0oSFRNTE5hbWVzOjpsYW5nQXR0cikpCisgICAgICAgICAgICAg ICAgICAgIHZhbHVlID0gYXR0cmlidXRlLT52YWx1ZSgpOworICAgICAgICAgICAgfQogICAgICAg ICB9IGVsc2UgaWYgKG4tPmlzRG9jdW1lbnROb2RlKCkpIHsKICAgICAgICAgICAgIC8vIGNoZWNr aW5nIHRoZSBNSU1FIGNvbnRlbnQtbGFuZ3VhZ2UKICAgICAgICAgICAgIHZhbHVlID0gc3RhdGlj X2Nhc3Q8Y29uc3QgRG9jdW1lbnQqPihuKS0+Y29udGVudExhbmd1YWdlKCk7Cg==