98303 2012-10-03 14:36:16 -0700 Parsing of media queries: 'all and(color)' should be invalid 2022-07-13 11:10:14 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED http://dabblet.com/gist/3829879 P2 Normal --- 0 simon-webkit webkit-unassigned bfulgham karl+webkit simon-webkit oldest_to_newest 734047 0 simon-webkit 2012-10-03 14:36:16 -0700 Example 20 of the Media Queries gives this invalid media query: @media all and(color) { … } The lack of space in 'and(' makes it tokenize as a FUNCTION, and thus the query should parse as invalid. http://www.w3.org/TR/css3-mediaqueries/#error-handling A test case: /* The body should not be red */ @media all and(color) { body { background: red } } Or see it in action: http://dabblet.com/gist/3829879 I have this bug in Chromium 22 on Archlinux x86_64, but smfr just confirmed on IRC that it had been fixed in Safari 6.0.1 but regressed in the current trunk. 734049 1 simon-webkit 2012-10-03 14:43:01 -0700 If the User-Agent string is to be trusted, my Chromium build uses WebKit 537.4. 734060 2 166964 simon-webkit 2012-10-03 14:55:06 -0700 Created attachment 166964 Require some whitespace after 'and' in a media query. Sorry, untested patch. (I have yet to manage a build.) Other files might need to be changed, but this looks like the right area of the code. 734127 3 simon-webkit 2012-10-03 15:59:18 -0700 The patch is wrong, white space is not actually required. This is valid: "all and/*wooo!*/(color)". http://lists.w3.org/Archives/Public/www-style/2012Oct/0099.html 1019269 4 karl+webkit 2014-06-29 19:28:24 -0700 David Baron in https://bugzilla.mozilla.org/show_bug.cgi?id=1031966#c7 > The CSSWG has had multiple extensive discussions > of this issue; in the last one we actually resolved > to require the whitespace (i.e., disallow "and/**/("): > > http://lists.w3.org/Archives/Public/www-style/2013Jul/0082.html And in > MQ4 says, in http://dev.w3.org/csswg/mediaqueries/#mq-syntax : > > Whitespace must be present between a ')' character and > a not, and, or or keyword, and between a not, and, or > or keyword and a '(' character. The parsing of "and(" fails in Opera (blink), IE11, Chrome, and Firefox. Safari (to the best of my knowledge is the only one to parse it). 1019271 5 karl+webkit 2014-06-29 19:43:51 -0700 Related to this bug https://bugs.webkit.org/show_bug.cgi?id=45017 1883196 6 bfulgham 2022-07-13 11:10:14 -0700 Safari, Chrome, and Firefox all agree on rendering for this test case. I don't believe there is any remaining compatibility issue. 166964 2012-10-03 14:55:06 -0700 2012-10-03 14:55:06 -0700 Require some whitespace after 'and' in a media query. media_query_and_whitespace.patch text/plain 863 simon-webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTR3JhbW1hci55CmluZGV4IDJiNDI3NGEuLmMzNTE0MGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFtbWFyLnkKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU0dyYW1tYXIueQpAQCAtNTQ1LDcgKzU0NSw3IEBAIG1lZGlhX3F1ZXJ5X2V4cF9saXN0Ogog ICAgICAgICAkJCA9IHBhcnNlci0+Y3JlYXRlRmxvYXRpbmdNZWRpYVF1ZXJ5RXhwTGlzdCgpOwog ICAgICAgICAkJC0+YXBwZW5kKHBhcnNlci0+c2lua0Zsb2F0aW5nTWVkaWFRdWVyeUV4cCgkMSkp OwogICAgIH0KLSAgICB8IG1lZGlhX3F1ZXJ5X2V4cF9saXN0IG1heWJlX3NwYWNlIE1FRElBX0FO RCBtYXliZV9zcGFjZSBtZWRpYV9xdWVyeV9leHAgeworICAgIHwgbWVkaWFfcXVlcnlfZXhwX2xp c3QgbWF5YmVfc3BhY2UgTUVESUFfQU5EIFdISVRFU1BBQ0UgbWVkaWFfcXVlcnlfZXhwIHsKICAg ICAgICAgJCQgPSAkMTsKICAgICAgICAgJCQtPmFwcGVuZChwYXJzZXItPnNpbmtGbG9hdGluZ01l ZGlhUXVlcnlFeHAoJDUpKTsKICAgICB9CkBAIC01NTUsNyArNTU1LDcgQEAgbWF5YmVfYW5kX21l ZGlhX3F1ZXJ5X2V4cF9saXN0OgogICAgIC8qZW1wdHkqLyB7CiAgICAgICAgICQkID0gcGFyc2Vy LT5jcmVhdGVGbG9hdGluZ01lZGlhUXVlcnlFeHBMaXN0KCk7CiAgICAgfQotICAgIHwgTUVESUFf QU5EIG1heWJlX3NwYWNlIG1lZGlhX3F1ZXJ5X2V4cF9saXN0IHsKKyAgICB8IE1FRElBX0FORCBX SElURVNQQUNFIG1lZGlhX3F1ZXJ5X2V4cF9saXN0IHsKICAgICAgICAgJCQgPSAkMzsKICAgICB9 CiAgICAgOwo=