98281 2012-10-03 10:48:49 -0700 Add a performance test for subtree detaching 2012-10-03 16:28:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 92697 1 jchaffraix jchaffraix eric rniwa simon.fraser webkit.review.bot oldest_to_newest 733835 0 jchaffraix 2012-10-03 10:48:49 -0700 Currently we don't have a test stressing only detaching. When tested, it is usually done in combination with other phases such as layout without thinking about the interactions. This is important as our current detaching algorithm is inefficient, leading to several traversal to the root as we generate multiple repaints. See bug 92697 for example where Eric came to the same conclusion. I would like to change how we detach thus the need for some performance coverage. 733846 1 166923 jchaffraix 2012-10-03 11:01:22 -0700 Created attachment 166923 Proposed test, welcome suggestions on how to better stress detaching. 733974 2 166923 eric 2012-10-03 13:18:56 -0700 Comment on attachment 166923 Proposed test, welcome suggestions on how to better stress detaching. SGTM. Might make more sense to add this with your first perf fix though. :) 734153 3 166923 jchaffraix 2012-10-03 16:22:06 -0700 Comment on attachment 166923 Proposed test, welcome suggestions on how to better stress detaching. > SGTM. Might make more sense to add this with your first perf fix though. :) Thanks Eric, the idea is to see the improvements as we go. Also it increases our coverage regardless of whether we follow the optimizations to their end. 734162 4 166923 webkit.review.bot 2012-10-03 16:28:38 -0700 Comment on attachment 166923 Proposed test, welcome suggestions on how to better stress detaching. Clearing flags on attachment: 166923 Committed r130341: <http://trac.webkit.org/changeset/130341> 734163 5 webkit.review.bot 2012-10-03 16:28:41 -0700 All reviewed patches have been landed. Closing bug. 166923 2012-10-03 11:01:22 -0700 2012-10-03 16:28:38 -0700 Proposed test, welcome suggestions on how to better stress detaching. bug-98281-20121003110034.patch text/plain 2296 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMzAwCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEyNzRhOTU3ZmYx ZDM4OGIwNTcxMmU2NzIzNmY3ZDZkZDlmMzhlZWIuLjBmZjViZDIyZTNmODYyYWYzZDE4NThiNTY1 MzY1MmEyNDQxM2FiMWQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAt MDMgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAg QWRkIGEgcGVyZm9ybWFuY2UgdGVzdCBmb3Igc3VidHJlZSBkZXRhY2hpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjgxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG5ldyB0ZXN0IHRyaWVzIHRv IHN0cmVzcyBkZXRhY2hpbmcgb24gYSBoZWF2eSBzdWJ0cmVlICgyIGxldmVscyBkZWVwIGJ1dCB3 aXRoIDEsMDAwIG5vZGVzIHBlciBsZXZlbCkuCisgICAgICAgIFdlIHNldCBkaXNwbGF5OiBub25l IG9uIHRoZSByb290IGFuZCBtZWFzdXJlIHRoZSB0aW1lIGl0IHRha2VzIHRvIHVwZGF0ZSB0aGUg dHJlZS4gTm90ZSB0aGF0IHdlIHdpbGwgYWxzbworICAgICAgICBtZWFzdXJlIHRoZSB0aW1lIHRh a2VuIGJ5IHJlY2FsY1N0eWxlIGFuZCByZWxheW91dCBidXQgSSBkb24ndCB0aGluayB3ZSBjYW4g YXZvaWQgdGhhdC4KKworICAgICAgICAqIExheW91dC9zdWJ0cmVlLWRldGFjaGluZy5odG1sOiBB ZGRlZC4KKwogMjAxMi0xMC0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBCdWlsZCBmaXggYWZ0ZXIgcjEzMDEzNS4gRHJvbWFlbyB0ZXN0cyBvbmx5IHJlcG9y dCBzaW5nbGUgbWVtb3J5IHZhbHVlLApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9MYXlv dXQvc3VidHJlZS1kZXRhY2hpbmcuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvTGF5b3V0L3N1YnRy ZWUtZGV0YWNoaW5nLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzVkZWY1MTIyZWY0YmE2MThiNTAyNGRkMTY1 MmVjMzkwOWRmMWI3ZAotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvTGF5b3V0 L3N1YnRyZWUtZGV0YWNoaW5nLmh0bWwKQEAgLTAsMCArMSw0MiBAQAorPCFET0NUWVBFIGh0bWw+ Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9ydW5uZXIuanMiPjwv c2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGJ1aWxkVHJlZSgpCit7CisgICAgd3JhcHBlciA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgIGZvciAoaSA9IDA7IGkgPCAxMDAw OyArK2kpIHsKKyAgICAgICAgdmFyIGNoaWxkID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2 Iik7CisgICAgICAgIGZvciAoaiA9IDA7IGogPCAxMDAwOyArK2opIHsKKyAgICAgICAgICAgIHZh ciBncmFuZENoaWxkID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgICAg ICBjaGlsZC5hcHBlbmRDaGlsZChncmFuZENoaWxkKTsKKyAgICAgICAgfQorICAgICAgICB3cmFw cGVyLmFwcGVuZENoaWxkKGNoaWxkKTsKKyAgICB9CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRD aGlsZCh3cmFwcGVyKTsKK30KKworZnVuY3Rpb24gc2V0dXAoKSB7CisgICAgd3JhcHBlci5zdHls ZS5kaXNwbGF5ID0gImJsb2NrIjsKKyAgICAvLyBGb3JjZSBhIGxheW91dCBzbyB0aGF0IGV2ZXJ5 dGhpbmcgaXMgdXAtdG8tZGF0ZS4KKyAgICB3cmFwcGVyLm9mZnNldFRvcDsKK30KKworZnVuY3Rp b24gcnVuVGVzdCgpIHsKKyAgICBzZXR1cCgpOworCisgICAgdmFyIG5vdyA9IFBlcmZUZXN0UnVu bmVyLm5vdygpOworCisgICAgd3JhcHBlci5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOworICAgIHdy YXBwZXIub2Zmc2V0VG9wOworCisgICAgcmV0dXJuIFBlcmZUZXN0UnVubmVyLm5vdygpIC0gbm93 OworfQorCitidWlsZFRyZWUoKTsKKworUGVyZlRlc3RSdW5uZXIubWVhc3VyZVRpbWUoe3J1bjog cnVuVGVzdCwgcnVuQ291bnQ6IDIwLCBkZXNjcmlwdGlvbjogIlRoaXMgYmVuY2htYXJrIGNoZWNr cyB0aGUgdGltZSBzcGVuZCBpbiBkZXRhY2hpbmcgYW4gdHJlZS4iIH0pOworPC9zY3JpcHQ+Cis8 L2JvZHk+Cis8L2h0bWw+Cg==