<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98280</bug_id>
          
          <creation_ts>2012-10-03 10:35:38 -0700</creation_ts>
          <short_desc>[EFL][WK2] Implement window frame callbacks in UIClient</short_desc>
          <delta_ts>2012-10-04 23:11:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>hausmann</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>733826</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-03 10:35:38 -0700</bug_when>
    <thetext>We need to implement the following callbacks in EwkView&apos;s UIClients:
  getWindowFrame()
  setWindowFrame()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733829</commentid>
    <comment_count>1</comment_count>
      <attachid>166917</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-03 10:38:12 -0700</bug_when>
    <thetext>Created attachment 166917
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733837</commentid>
    <comment_count>2</comment_count>
      <attachid>166920</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-03 10:49:59 -0700</bug_when>
    <thetext>Created attachment 166920
Patch

Use ecore_evas_move_resize() to avoid 2 separate calls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>733898</commentid>
    <comment_count>3</comment_count>
      <attachid>166932</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-03 11:59:24 -0700</bug_when>
    <thetext>Created attachment 166932
Patch

Use Evas object API to match corresponding WKTR implementation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>734370</commentid>
    <comment_count>4</comment_count>
      <attachid>166932</attachid>
    <who name="Ryuan Choi">ryuan.choi</who>
    <bug_when>2012-10-03 22:38:50 -0700</bug_when>
    <thetext>Comment on attachment 166932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166932&amp;action=review

&gt; Source/WebKit2/ChangeLog:10
&gt; +        Implement getWindowFrame and setWindowFrame callbacks
&gt; +        in EwkView&apos;s UIClient so that the window frame
&gt; +        geometry can be queried / set.

Can we have test case for this?

&gt; Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:111
&gt; +    evas_object_move(view, frame.origin.x, frame.origin.y);
&gt; +    evas_object_resize(view, frame.size.width, frame.size.height);

I am not sure whether we should move evas object or ecore_evas.

Can I know when this is called?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>734377</commentid>
    <comment_count>5</comment_count>
      <attachid>166932</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-03 22:47:42 -0700</bug_when>
    <thetext>Comment on attachment 166932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166932&amp;action=review

&gt;&gt; Source/WebKit2/ChangeLog:10
&gt;&gt; +        geometry can be queried / set.
&gt; 
&gt; Can we have test case for this?

Hmm. I&apos;m not adding any new API here. I guess it should be possible to test this though, I&apos;ll take a look.

&gt;&gt; Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:111
&gt;&gt; +    evas_object_resize(view, frame.size.width, frame.size.height);
&gt; 
&gt; I am not sure whether we should move evas object or ecore_evas.
&gt; 
&gt; Can I know when this is called?

We need evas_object. There is corresponding code in WebKitTestRunner (PlatformWebView::windowFrame). I tried both (evas_object and ecore_evas) in WKTR, with ecore_evas, the corresponding LayoutTests are failing. However, with evas_object, they are passing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>734444</commentid>
    <comment_count>6</comment_count>
      <attachid>166932</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-04 00:37:10 -0700</bug_when>
    <thetext>Comment on attachment 166932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166932&amp;action=review

&gt;&gt;&gt; Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:111
&gt;&gt;&gt; +    evas_object_resize(view, frame.size.width, frame.size.height);
&gt;&gt; 
&gt;&gt; I am not sure whether we should move evas object or ecore_evas.
&gt;&gt; 
&gt;&gt; Can I know when this is called?
&gt; 
&gt; We need evas_object. There is corresponding code in WebKitTestRunner (PlatformWebView::windowFrame). I tried both (evas_object and ecore_evas) in WKTR, with ecore_evas, the corresponding LayoutTests are failing. However, with evas_object, they are passing.

Actually, you&apos;re right that it needs be ecore_evas, I have tested. I will update the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>734891</commentid>
    <comment_count>7</comment_count>
      <attachid>167150</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-04 11:41:30 -0700</bug_when>
    <thetext>Created attachment 167150
Patch

- Use Ecore_Evas API
- Add unit test</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735106</commentid>
    <comment_count>8</comment_count>
      <attachid>167150</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-04 16:22:30 -0700</bug_when>
    <thetext>Comment on attachment 167150
Patch

Rejecting attachment 167150 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;
51&gt;At revision 154708.

________ running &apos;/usr/bin/python tools/clang/scripts/update.py --mac-only&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;

________ running &apos;/usr/bin/python gyp_webkit&apos; in &apos;/mnt/git/webkit-commit-queue/Source/WebKit/chromium&apos;
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14173341</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735349</commentid>
    <comment_count>9</comment_count>
      <attachid>167251</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-04 22:33:13 -0700</bug_when>
    <thetext>Created attachment 167251
Patch for landing

Rebased on master. Could someone please cq+ ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735378</commentid>
    <comment_count>10</comment_count>
      <attachid>167251</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-04 23:11:50 -0700</bug_when>
    <thetext>Comment on attachment 167251
Patch for landing

Clearing flags on attachment: 167251

Committed r130464: &lt;http://trac.webkit.org/changeset/130464&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>735379</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-04 23:11:55 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166917</attachid>
            <date>2012-10-03 10:38:12 -0700</date>
            <delta_ts>2012-10-03 10:49:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98280_ewk_view_windowFrame.patch</filename>
            <type>text/plain</type>
            <size>2616</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAyNTVlMTZlLi5kNDI2ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg
QEAKIDIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCB3aW5kb3cgZnJhbWUgY2FsbGJh
Y2tzIGluIFVJQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD05ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEltcGxlbWVudCBnZXRXaW5kb3dGcmFtZSBhbmQgc2V0V2luZG93RnJhbWUgY2FsbGJh
Y2tzCisgICAgICAgIGluIEV3a1ZpZXcncyBVSUNsaWVudCBzbyB0aGF0IHRoZSB3aW5kb3cgZnJh
bWUKKyAgICAgICAgZ2VvbWV0cnkgY2FuIGJlIHF1ZXJpZWQgLyBzZXQuCisKKyAgICAgICAgKiBV
SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwOgorICAgICAgICAoZ2V0V2lu
ZG93RnJhbWUpOgorICAgICAgICAoc2V0V2luZG93RnJhbWUpOgorICAgICAgICAoZXdrX3ZpZXdf
dWlfY2xpZW50X2F0dGFjaCk6CisKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJp
c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBm
b2N1cy91bmZvY3VzIGluIFVJQ2xpZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD05ODI1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAppbmRleCBlOWFlMzEyLi40YmI5
ZjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll
d191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJXS1N0cmlu
Zy5oIgogI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIKICNpbmNsdWRlICJld2tfdmlld191
aV9jbGllbnRfcHJpdmF0ZS5oIgorI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KIAogc3RhdGljIGlu
bGluZSBFdmFzX09iamVjdCogdG9Fd2tWaWV3KGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CkBA
IC05Niw2ICs5NywyMyBAQCBzdGF0aWMgdm9pZCB0YWtlRm9jdXMoV0tQYWdlUmVmLCBXS0ZvY3Vz
RGlyZWN0aW9uLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogICAgIGV2YXNfb2JqZWN0X2ZvY3Vz
X3NldCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIGZhbHNlKTsKIH0KIAorc3RhdGljIFdLUmVjdCBn
ZXRXaW5kb3dGcmFtZShXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCit7CisgICAg
aW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2
YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pKSk7CisgICAgZWNvcmVfZXZhc19nZW9tZXRyeV9nZXQoZWUsICZ4LCAmeSwgJndpZHRoLCAm
aGVpZ2h0KTsKKworICAgIHJldHVybiBXS1JlY3RNYWtlKHgsIHksIHdpZHRoLCBoZWlnaHQpOwor
fQorCitzdGF0aWMgdm9pZCBzZXRXaW5kb3dGcmFtZShXS1BhZ2VSZWYsIFdLUmVjdCBmcmFtZSwg
Y29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2
YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pKSk7CisgICAgZWNvcmVfZXZhc19tb3ZlKGVlLCBmcmFtZS5vcmlnaW4ueCwgZnJhbWUub3Jp
Z2luLnkpOworICAgIGVjb3JlX2V2YXNfcmVzaXplKGVlLCBmcmFtZS5zaXplLndpZHRoLCBmcmFt
ZS5zaXplLmhlaWdodCk7Cit9CisKIHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaChXS1Bh
Z2VSZWYgcGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgV0tQYWdlVUlDbGll
bnQgdWlDbGllbnQ7CkBAIC0xMTAsNiArMTI4LDggQEAgdm9pZCBld2tfdmlld191aV9jbGllbnRf
YXR0YWNoKFdLUGFnZVJlZiBwYWdlUmVmLCBFdmFzX09iamVjdCogZXdrVmlldykKICAgICB1aUNs
aWVudC50YWtlRm9jdXMgPSB0YWtlRm9jdXM7CiAgICAgdWlDbGllbnQuZm9jdXMgPSBmb2N1czsK
ICAgICB1aUNsaWVudC51bmZvY3VzID0gdW5mb2N1czsKKyAgICB1aUNsaWVudC5nZXRXaW5kb3dG
cmFtZSA9IGdldFdpbmRvd0ZyYW1lOworICAgIHVpQ2xpZW50LnNldFdpbmRvd0ZyYW1lID0gc2V0
V2luZG93RnJhbWU7CiAjaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKICAgICB1aUNsaWVudC5leGNl
ZWRlZERhdGFiYXNlUXVvdGEgPSBleGNlZWRlZERhdGFiYXNlUXVvdGE7CiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166920</attachid>
            <date>2012-10-03 10:49:59 -0700</date>
            <delta_ts>2012-10-03 11:59:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98280_ewk_view_windowFrame.patch</filename>
            <type>text/plain</type>
            <size>2595</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAyNTVlMTZlLi5kNDI2ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg
QEAKIDIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCB3aW5kb3cgZnJhbWUgY2FsbGJh
Y2tzIGluIFVJQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD05ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEltcGxlbWVudCBnZXRXaW5kb3dGcmFtZSBhbmQgc2V0V2luZG93RnJhbWUgY2FsbGJh
Y2tzCisgICAgICAgIGluIEV3a1ZpZXcncyBVSUNsaWVudCBzbyB0aGF0IHRoZSB3aW5kb3cgZnJh
bWUKKyAgICAgICAgZ2VvbWV0cnkgY2FuIGJlIHF1ZXJpZWQgLyBzZXQuCisKKyAgICAgICAgKiBV
SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwOgorICAgICAgICAoZ2V0V2lu
ZG93RnJhbWUpOgorICAgICAgICAoc2V0V2luZG93RnJhbWUpOgorICAgICAgICAoZXdrX3ZpZXdf
dWlfY2xpZW50X2F0dGFjaCk6CisKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJp
c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBm
b2N1cy91bmZvY3VzIGluIFVJQ2xpZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD05ODI1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAppbmRleCBlOWFlMzEyLi42ZDI5
MTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll
d191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJXS1N0cmlu
Zy5oIgogI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIKICNpbmNsdWRlICJld2tfdmlld191
aV9jbGllbnRfcHJpdmF0ZS5oIgorI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KIAogc3RhdGljIGlu
bGluZSBFdmFzX09iamVjdCogdG9Fd2tWaWV3KGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CkBA
IC05Niw2ICs5NywyMiBAQCBzdGF0aWMgdm9pZCB0YWtlRm9jdXMoV0tQYWdlUmVmLCBXS0ZvY3Vz
RGlyZWN0aW9uLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogICAgIGV2YXNfb2JqZWN0X2ZvY3Vz
X3NldCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIGZhbHNlKTsKIH0KIAorc3RhdGljIFdLUmVjdCBn
ZXRXaW5kb3dGcmFtZShXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCit7CisgICAg
aW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2
YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pKSk7CisgICAgZWNvcmVfZXZhc19nZW9tZXRyeV9nZXQoZWUsICZ4LCAmeSwgJndpZHRoLCAm
aGVpZ2h0KTsKKworICAgIHJldHVybiBXS1JlY3RNYWtlKHgsIHksIHdpZHRoLCBoZWlnaHQpOwor
fQorCitzdGF0aWMgdm9pZCBzZXRXaW5kb3dGcmFtZShXS1BhZ2VSZWYsIFdLUmVjdCBmcmFtZSwg
Y29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2
YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pKSk7CisgICAgZWNvcmVfZXZhc19tb3ZlX3Jlc2l6ZShlZSwgZnJhbWUub3JpZ2luLngsIGZy
YW1lLm9yaWdpbi55LCBmcmFtZS5zaXplLndpZHRoLCBmcmFtZS5zaXplLmhlaWdodCk7Cit9CisK
IHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaChXS1BhZ2VSZWYgcGFnZVJlZiwgRXZhc19P
YmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgV0tQYWdlVUlDbGllbnQgdWlDbGllbnQ7CkBAIC0xMTAs
NiArMTI3LDggQEAgdm9pZCBld2tfdmlld191aV9jbGllbnRfYXR0YWNoKFdLUGFnZVJlZiBwYWdl
UmVmLCBFdmFzX09iamVjdCogZXdrVmlldykKICAgICB1aUNsaWVudC50YWtlRm9jdXMgPSB0YWtl
Rm9jdXM7CiAgICAgdWlDbGllbnQuZm9jdXMgPSBmb2N1czsKICAgICB1aUNsaWVudC51bmZvY3Vz
ID0gdW5mb2N1czsKKyAgICB1aUNsaWVudC5nZXRXaW5kb3dGcmFtZSA9IGdldFdpbmRvd0ZyYW1l
OworICAgIHVpQ2xpZW50LnNldFdpbmRvd0ZyYW1lID0gc2V0V2luZG93RnJhbWU7CiAjaWYgRU5B
QkxFKFNRTF9EQVRBQkFTRSkKICAgICB1aUNsaWVudC5leGNlZWRlZERhdGFiYXNlUXVvdGEgPSBl
eGNlZWRlZERhdGFiYXNlUXVvdGE7CiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166932</attachid>
            <date>2012-10-03 11:59:24 -0700</date>
            <delta_ts>2012-10-04 11:41:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98280_ewk_view_windowFrame.patch</filename>
            <type>text/plain</type>
            <size>2302</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAyNTVlMTZlLi5kNDI2ZWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg
QEAKIDIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCB3aW5kb3cgZnJhbWUgY2FsbGJh
Y2tzIGluIFVJQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD05ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEltcGxlbWVudCBnZXRXaW5kb3dGcmFtZSBhbmQgc2V0V2luZG93RnJhbWUgY2FsbGJh
Y2tzCisgICAgICAgIGluIEV3a1ZpZXcncyBVSUNsaWVudCBzbyB0aGF0IHRoZSB3aW5kb3cgZnJh
bWUKKyAgICAgICAgZ2VvbWV0cnkgY2FuIGJlIHF1ZXJpZWQgLyBzZXQuCisKKyAgICAgICAgKiBV
SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwOgorICAgICAgICAoZ2V0V2lu
ZG93RnJhbWUpOgorICAgICAgICAoc2V0V2luZG93RnJhbWUpOgorICAgICAgICAoZXdrX3ZpZXdf
dWlfY2xpZW50X2F0dGFjaCk6CisKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJp
c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKwogICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBm
b2N1cy91bmZvY3VzIGluIFVJQ2xpZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD05ODI1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAppbmRleCBlOWFlMzEyLi5kNTZh
NmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll
d191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTk2LDYgKzk2LDIxIEBAIHN0YXRpYyB2b2lkIHRha2VG
b2N1cyhXS1BhZ2VSZWYsIFdLRm9jdXNEaXJlY3Rpb24sIGNvbnN0IHZvaWQqIGNsaWVudEluZm8p
CiAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHRvRXdrVmlldyhjbGllbnRJbmZvKSwgZmFsc2Up
OwogfQogCitzdGF0aWMgV0tSZWN0IGdldFdpbmRvd0ZyYW1lKFdLUGFnZVJlZiwgY29uc3Qgdm9p
ZCogY2xpZW50SW5mbykKK3sKKyAgICBFdmFzX0Nvb3JkIHgsIHksIHdpZHRoLCBoZWlnaHQ7Cisg
ICAgZXZhc19vYmplY3RfZ2VvbWV0cnlfZ2V0KHRvRXdrVmlldyhjbGllbnRJbmZvKSwgJngsICZ5
LCAmd2lkdGgsICZoZWlnaHQpOworCisgICAgcmV0dXJuIFdLUmVjdE1ha2UoeCwgeSwgd2lkdGgs
IGhlaWdodCk7Cit9CisKK3N0YXRpYyB2b2lkIHNldFdpbmRvd0ZyYW1lKFdLUGFnZVJlZiwgV0tS
ZWN0IGZyYW1lLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIEV2YXNfT2JqZWN0KiB2
aWV3ID0gdG9Fd2tWaWV3KGNsaWVudEluZm8pOworICAgIGV2YXNfb2JqZWN0X21vdmUodmlldywg
ZnJhbWUub3JpZ2luLngsIGZyYW1lLm9yaWdpbi55KTsKKyAgICBldmFzX29iamVjdF9yZXNpemUo
dmlldywgZnJhbWUuc2l6ZS53aWR0aCwgZnJhbWUuc2l6ZS5oZWlnaHQpOworfQorCiB2b2lkIGV3
a192aWV3X3VpX2NsaWVudF9hdHRhY2goV0tQYWdlUmVmIHBhZ2VSZWYsIEV2YXNfT2JqZWN0KiBl
d2tWaWV3KQogewogICAgIFdLUGFnZVVJQ2xpZW50IHVpQ2xpZW50OwpAQCAtMTEwLDYgKzEyNSw4
IEBAIHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaChXS1BhZ2VSZWYgcGFnZVJlZiwgRXZh
c19PYmplY3QqIGV3a1ZpZXcpCiAgICAgdWlDbGllbnQudGFrZUZvY3VzID0gdGFrZUZvY3VzOwog
ICAgIHVpQ2xpZW50LmZvY3VzID0gZm9jdXM7CiAgICAgdWlDbGllbnQudW5mb2N1cyA9IHVuZm9j
dXM7CisgICAgdWlDbGllbnQuZ2V0V2luZG93RnJhbWUgPSBnZXRXaW5kb3dGcmFtZTsKKyAgICB1
aUNsaWVudC5zZXRXaW5kb3dGcmFtZSA9IHNldFdpbmRvd0ZyYW1lOwogI2lmIEVOQUJMRShTUUxf
REFUQUJBU0UpCiAgICAgdWlDbGllbnQuZXhjZWVkZWREYXRhYmFzZVF1b3RhID0gZXhjZWVkZWRE
YXRhYmFzZVF1b3RhOwogI2VuZGlmCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167150</attachid>
            <date>2012-10-04 11:41:30 -0700</date>
            <delta_ts>2012-10-04 22:33:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98280_ewk_view_windowFrame2.patch</filename>
            <type>text/plain</type>
            <size>4569</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCBmNTc4NWI5Li5jMjFjYjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMTAtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCB3aW5kb3cgZnJhbWUgY2FsbGJh
Y2tzIGluIFVJQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD05ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEltcGxlbWVudCBjYWxsYmFja3MgdG8gc2V0IGFuZCBxdWVyeSB3aW5kb3cgZ2VvbWV0
cnkKKyAgICAgICAgaW4gRXdrVmlldydzIFVJQ2xpZW50LgorCisgICAgICAgICogVUlQcm9jZXNz
L0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcDoKKyAgICAgICAgKGdldFdpbmRvd0ZyYW1l
KToKKyAgICAgICAgKHNldFdpbmRvd0ZyYW1lKToKKyAgICAgICAgKGV3a192aWV3X3VpX2NsaWVu
dF9hdHRhY2gpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Jlc291cmNlcy93
aW5kb3dfbW92ZV9yZXNpemUuaHRtbDogQWRkZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l
ZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOgorICAgICAgICAod2luZG93TW92ZVJlc2l6ZVRp
bWVkT3V0KToKKyAgICAgICAgKFRFU1RfRik6IEFkZCBjb3JyZXNwb25kaW5nIHVuaXQgdGVzdC4K
KwogMjAxMi0xMC0wNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog
ICAgICAgICBTdGFuZGFyZGl6ZSBvbiAiZmx1c2giIHRlcm1pbm9sb2d5IGZvciBjb21wb3NpdGlu
ZyBsYXllciBmbHVzaGluZy9zeW5jaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAppbmRleCBlOWFlMzEyLi4wZjdi
ZDkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll
d191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3
a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJXS1N0cmlu
Zy5oIgogI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIKICNpbmNsdWRlICJld2tfdmlld191
aV9jbGllbnRfcHJpdmF0ZS5oIgorI2luY2x1ZGUgPEVjb3JlX0V2YXMuaD4KIAogc3RhdGljIGlu
bGluZSBFdmFzX09iamVjdCogdG9Fd2tWaWV3KGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CkBA
IC05Niw2ICs5NywyMiBAQCBzdGF0aWMgdm9pZCB0YWtlRm9jdXMoV0tQYWdlUmVmLCBXS0ZvY3Vz
RGlyZWN0aW9uLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogICAgIGV2YXNfb2JqZWN0X2ZvY3Vz
X3NldCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIGZhbHNlKTsKIH0KIAorc3RhdGljIFdLUmVjdCBn
ZXRXaW5kb3dGcmFtZShXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCit7CisgICAg
aW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2
YXNfZWNvcmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pKSk7CisgICAgZWNvcmVfZXZhc19yZXF1ZXN0X2dlb21ldHJ5X2dldChlZSwgJngsICZ5LCAm
d2lkdGgsICZoZWlnaHQpOworCisgICAgcmV0dXJuIFdLUmVjdE1ha2UoeCwgeSwgd2lkdGgsIGhl
aWdodCk7Cit9CisKK3N0YXRpYyB2b2lkIHNldFdpbmRvd0ZyYW1lKFdLUGFnZVJlZiwgV0tSZWN0
IGZyYW1lLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIEVjb3JlX0V2YXMqIGVlID0g
ZWNvcmVfZXZhc19lY29yZV9ldmFzX2dldChldmFzX29iamVjdF9ldmFzX2dldCh0b0V3a1ZpZXco
Y2xpZW50SW5mbykpKTsKKyAgICBlY29yZV9ldmFzX21vdmVfcmVzaXplKGVlLCBmcmFtZS5vcmln
aW4ueCwgZnJhbWUub3JpZ2luLnksIGZyYW1lLnNpemUud2lkdGgsIGZyYW1lLnNpemUuaGVpZ2h0
KTsKK30KKwogdm9pZCBld2tfdmlld191aV9jbGllbnRfYXR0YWNoKFdLUGFnZVJlZiBwYWdlUmVm
LCBFdmFzX09iamVjdCogZXdrVmlldykKIHsKICAgICBXS1BhZ2VVSUNsaWVudCB1aUNsaWVudDsK
QEAgLTExMCw2ICsxMjcsOCBAQCB2b2lkIGV3a192aWV3X3VpX2NsaWVudF9hdHRhY2goV0tQYWdl
UmVmIHBhZ2VSZWYsIEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHVpQ2xpZW50LnRha2VGb2N1
cyA9IHRha2VGb2N1czsKICAgICB1aUNsaWVudC5mb2N1cyA9IGZvY3VzOwogICAgIHVpQ2xpZW50
LnVuZm9jdXMgPSB1bmZvY3VzOworICAgIHVpQ2xpZW50LmdldFdpbmRvd0ZyYW1lID0gZ2V0V2lu
ZG93RnJhbWU7CisgICAgdWlDbGllbnQuc2V0V2luZG93RnJhbWUgPSBzZXRXaW5kb3dGcmFtZTsK
ICNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQogICAgIHVpQ2xpZW50LmV4Y2VlZGVkRGF0YWJhc2VR
dW90YSA9IGV4Y2VlZGVkRGF0YWJhc2VRdW90YTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvcmVzb3VyY2VzL3dpbmRvd19tb3ZlX3Jl
c2l6ZS5odG1sIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvcmVzb3Vy
Y2VzL3dpbmRvd19tb3ZlX3Jlc2l6ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw
MDAwMDAuLjY5M2FjMmUKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL2VmbC90ZXN0cy9yZXNvdXJjZXMvd2luZG93X21vdmVfcmVzaXplLmh0bWwKQEAgLTAs
MCArMSwxNSBAQAorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5XaW5kb3cgbW92ZSBhbmQgcmVzaXpl
IHRlc3Q8L3RpdGxlPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIHdpbmRvdy5y
ZXNpemVUbygyMDAsIDEwMCk7CisgICAgd2luZG93Lm1vdmVUbygxNTAsIDIwMCk7CisgICAgZG9j
dW1lbnQudGl0bGUgPSAiTW92ZWQgYW5kIHJlc2l6ZWQiOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+
Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5j
cHAKaW5kZXggMzczY2I2Ni4uYjE1Njc0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtODY0LDMg
Kzg2NCwyOCBAQCBURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfdG91Y2hfZXZlbnRz
X2VuYWJsZWQpCiAgICAgQVNTRVJUX1RSVUUoZXdrX3ZpZXdfdG91Y2hfZXZlbnRzX2VuYWJsZWRf
c2V0KHdlYlZpZXcoKSwgZmFsc2UpKTsKICAgICBBU1NFUlRfRkFMU0UoZXdrX3ZpZXdfdG91Y2hf
ZXZlbnRzX2VuYWJsZWRfZ2V0KHdlYlZpZXcoKSkpOwogfQorCitFaW5hX0Jvb2wgd2luZG93TW92
ZVJlc2l6ZVRpbWVkT3V0KHZvaWQqIGRhdGEpCit7CisgICAgKnN0YXRpY19jYXN0PGJvb2wqPihk
YXRhKSA9IHRydWU7Cit9CisKK1RFU1RfRihFV0syVW5pdFRlc3RCYXNlLCB3aW5kb3dfbW92ZV9y
ZXNpemUpCit7CisgICAgaW50IHgsIHksIHdpZHRoLCBoZWlnaHQ7CisgICAgRWNvcmVfRXZhcyog
ZWUgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KHdlYlZp
ZXcoKSkpOworICAgIGVjb3JlX2V2YXNfZ2VvbWV0cnlfZ2V0KGVlLCAwLCAwLCAmd2lkdGgsICZo
ZWlnaHQpOworCisgICAgRVhQRUNUX0VRKDgwMCwgd2lkdGgpOworICAgIEVYUEVDVF9FUSg2MDAs
IGhlaWdodCk7CisKKyAgICBld2tfdmlld191cmlfc2V0KHdlYlZpZXcoKSwgZW52aXJvbm1lbnQt
PnVybEZvclJlc291cmNlKCJ3aW5kb3dfbW92ZV9yZXNpemUuaHRtbCIpLmRhdGEoKSk7CisgICAg
QVNTRVJUX1RSVUUod2FpdFVudGlsVGl0bGVDaGFuZ2VkVG8oIk1vdmVkIGFuZCByZXNpemVkIikp
OworCisgICAgLy8gQ2hlY2sgdGhhdCB0aGUgd2luZG93IGhhcyBiZWVuIG1vdmVkIGFuZCByZXNp
emVkLgorICAgIGVjb3JlX2V2YXNfcmVxdWVzdF9nZW9tZXRyeV9nZXQoZWUsICZ4LCAmeSwgJndp
ZHRoLCAmaGVpZ2h0KTsKKyAgICBFWFBFQ1RfRVEoMTUwLCB4KTsKKyAgICBFWFBFQ1RfRVEoMjAw
LCB5KTsKKyAgICBFWFBFQ1RfRVEoMjAwLCB3aWR0aCk7CisgICAgRVhQRUNUX0VRKDEwMCwgaGVp
Z2h0KTsKK30K
</data>
<flag name="review"
          id="179722"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="179723"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>167251</attachid>
            <date>2012-10-04 22:33:13 -0700</date>
            <delta_ts>2012-10-04 23:11:50 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>98280_ewk_view_windowFrame2.patch</filename>
            <type>text/plain</type>
            <size>4550</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCBjNTUxZWUyLi43ZmExNmRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMTAtMDQgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCB3aW5kb3cgZnJhbWUgY2FsbGJh
Y2tzIGluIFVJQ2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD05ODI4MAorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0
aWFuc2VuLgorCisgICAgICAgIEltcGxlbWVudCBjYWxsYmFja3MgdG8gc2V0IGFuZCBxdWVyeSB3
aW5kb3cgZ2VvbWV0cnkKKyAgICAgICAgaW4gRXdrVmlldydzIFVJQ2xpZW50LgorCisgICAgICAg
ICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcDoKKyAgICAgICAgKGdl
dFdpbmRvd0ZyYW1lKToKKyAgICAgICAgKHNldFdpbmRvd0ZyYW1lKToKKyAgICAgICAgKGV3a192
aWV3X3VpX2NsaWVudF9hdHRhY2gpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz
L3Jlc291cmNlcy93aW5kb3dfbW92ZV9yZXNpemUuaHRtbDogQWRkZWQuCisgICAgICAgICogVUlQ
cm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwOgorICAgICAgICAod2luZG93
TW92ZVJlc2l6ZVRpbWVkT3V0KToKKyAgICAgICAgKFRFU1RfRik6IEFkZCBjb3JyZXNwb25kaW5n
IHVuaXQgdGVzdC4KKwogMjAxMi0xMC0wNCAgUmlrIENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUu
Y29tPgogCiAgICAgICAgIFR1cm4gQ29tcG9zaXRpbmcgb24gYnkgZGVmYXVsdCBpbiBXZWJLaXQg
YnVpbGQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192
aWV3X3VpX2NsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf
dmlld191aV9jbGllbnQuY3BwCmluZGV4IGU5YWUzMTIuLjBmN2JkOTIgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKKysr
IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNw
cApAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUgIldLU3RyaW5nLmgiCiAjaW5jbHVkZSAiZXdr
X3ZpZXdfcHJpdmF0ZS5oIgogI2luY2x1ZGUgImV3a192aWV3X3VpX2NsaWVudF9wcml2YXRlLmgi
CisjaW5jbHVkZSA8RWNvcmVfRXZhcy5oPgogCiBzdGF0aWMgaW5saW5lIEV2YXNfT2JqZWN0KiB0
b0V3a1ZpZXcoY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKQEAgLTk2LDYgKzk3LDIyIEBAIHN0
YXRpYyB2b2lkIHRha2VGb2N1cyhXS1BhZ2VSZWYsIFdLRm9jdXNEaXJlY3Rpb24sIGNvbnN0IHZv
aWQqIGNsaWVudEluZm8pCiAgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHRvRXdrVmlldyhjbGll
bnRJbmZvKSwgZmFsc2UpOwogfQogCitzdGF0aWMgV0tSZWN0IGdldFdpbmRvd0ZyYW1lKFdLUGFn
ZVJlZiwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBpbnQgeCwgeSwgd2lkdGgsIGhl
aWdodDsKKworICAgIEVjb3JlX0V2YXMqIGVlID0gZWNvcmVfZXZhc19lY29yZV9ldmFzX2dldChl
dmFzX29iamVjdF9ldmFzX2dldCh0b0V3a1ZpZXcoY2xpZW50SW5mbykpKTsKKyAgICBlY29yZV9l
dmFzX3JlcXVlc3RfZ2VvbWV0cnlfZ2V0KGVlLCAmeCwgJnksICZ3aWR0aCwgJmhlaWdodCk7CisK
KyAgICByZXR1cm4gV0tSZWN0TWFrZSh4LCB5LCB3aWR0aCwgaGVpZ2h0KTsKK30KKworc3RhdGlj
IHZvaWQgc2V0V2luZG93RnJhbWUoV0tQYWdlUmVmLCBXS1JlY3QgZnJhbWUsIGNvbnN0IHZvaWQq
IGNsaWVudEluZm8pCit7CisgICAgRWNvcmVfRXZhcyogZWUgPSBlY29yZV9ldmFzX2Vjb3JlX2V2
YXNfZ2V0KGV2YXNfb2JqZWN0X2V2YXNfZ2V0KHRvRXdrVmlldyhjbGllbnRJbmZvKSkpOworICAg
IGVjb3JlX2V2YXNfbW92ZV9yZXNpemUoZWUsIGZyYW1lLm9yaWdpbi54LCBmcmFtZS5vcmlnaW4u
eSwgZnJhbWUuc2l6ZS53aWR0aCwgZnJhbWUuc2l6ZS5oZWlnaHQpOworfQorCiB2b2lkIGV3a192
aWV3X3VpX2NsaWVudF9hdHRhY2goV0tQYWdlUmVmIHBhZ2VSZWYsIEV2YXNfT2JqZWN0KiBld2tW
aWV3KQogewogICAgIFdLUGFnZVVJQ2xpZW50IHVpQ2xpZW50OwpAQCAtMTEwLDYgKzEyNyw4IEBA
IHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaChXS1BhZ2VSZWYgcGFnZVJlZiwgRXZhc19P
YmplY3QqIGV3a1ZpZXcpCiAgICAgdWlDbGllbnQudGFrZUZvY3VzID0gdGFrZUZvY3VzOwogICAg
IHVpQ2xpZW50LmZvY3VzID0gZm9jdXM7CiAgICAgdWlDbGllbnQudW5mb2N1cyA9IHVuZm9jdXM7
CisgICAgdWlDbGllbnQuZ2V0V2luZG93RnJhbWUgPSBnZXRXaW5kb3dGcmFtZTsKKyAgICB1aUNs
aWVudC5zZXRXaW5kb3dGcmFtZSA9IHNldFdpbmRvd0ZyYW1lOwogI2lmIEVOQUJMRShTUUxfREFU
QUJBU0UpCiAgICAgdWlDbGllbnQuZXhjZWVkZWREYXRhYmFzZVF1b3RhID0gZXhjZWVkZWREYXRh
YmFzZVF1b3RhOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv
QVBJL2VmbC90ZXN0cy9yZXNvdXJjZXMvd2luZG93X21vdmVfcmVzaXplLmh0bWwgYi9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9yZXNvdXJjZXMvd2luZG93X21vdmVfcmVz
aXplLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNjkzYWMyZQotLS0g
L2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Jl
c291cmNlcy93aW5kb3dfbW92ZV9yZXNpemUuaHRtbApAQCAtMCwwICsxLDE1IEBACis8aHRtbD4K
KzxoZWFkPgorPHRpdGxlPldpbmRvdyBtb3ZlIGFuZCByZXNpemUgdGVzdDwvdGl0bGU+Cis8c2Ny
aXB0PgorZnVuY3Rpb24gdGVzdCgpCit7CisgICAgd2luZG93LnJlc2l6ZVRvKDIwMCwgMTAwKTsK
KyAgICB3aW5kb3cubW92ZVRvKDE1MCwgMjAwKTsKKyAgICBkb2N1bWVudC50aXRsZSA9ICJNb3Zl
ZCBhbmQgcmVzaXplZCI7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVz
dCgpIj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcAppbmRleCAzNzNjYjY2Li5i
MTU2NzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0
cy90ZXN0X2V3azJfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCkBAIC04NjQsMyArODY0LDI4IEBAIFRFU1RfRihF
V0syVW5pdFRlc3RCYXNlLCBld2tfdmlld190b3VjaF9ldmVudHNfZW5hYmxlZCkKICAgICBBU1NF
UlRfVFJVRShld2tfdmlld190b3VjaF9ldmVudHNfZW5hYmxlZF9zZXQod2ViVmlldygpLCBmYWxz
ZSkpOwogICAgIEFTU0VSVF9GQUxTRShld2tfdmlld190b3VjaF9ldmVudHNfZW5hYmxlZF9nZXQo
d2ViVmlldygpKSk7CiB9CisKK0VpbmFfQm9vbCB3aW5kb3dNb3ZlUmVzaXplVGltZWRPdXQodm9p
ZCogZGF0YSkKK3sKKyAgICAqc3RhdGljX2Nhc3Q8Ym9vbCo+KGRhdGEpID0gdHJ1ZTsKK30KKwor
VEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIHdpbmRvd19tb3ZlX3Jlc2l6ZSkKK3sKKyAgICBpbnQg
eCwgeSwgd2lkdGgsIGhlaWdodDsKKyAgICBFY29yZV9FdmFzKiBlZSA9IGVjb3JlX2V2YXNfZWNv
cmVfZXZhc19nZXQoZXZhc19vYmplY3RfZXZhc19nZXQod2ViVmlldygpKSk7CisgICAgZWNvcmVf
ZXZhc19nZW9tZXRyeV9nZXQoZWUsIDAsIDAsICZ3aWR0aCwgJmhlaWdodCk7CisKKyAgICBFWFBF
Q1RfRVEoODAwLCB3aWR0aCk7CisgICAgRVhQRUNUX0VRKDYwMCwgaGVpZ2h0KTsKKworICAgIGV3
a192aWV3X3VyaV9zZXQod2ViVmlldygpLCBlbnZpcm9ubWVudC0+dXJsRm9yUmVzb3VyY2UoIndp
bmRvd19tb3ZlX3Jlc2l6ZS5odG1sIikuZGF0YSgpKTsKKyAgICBBU1NFUlRfVFJVRSh3YWl0VW50
aWxUaXRsZUNoYW5nZWRUbygiTW92ZWQgYW5kIHJlc2l6ZWQiKSk7CisKKyAgICAvLyBDaGVjayB0
aGF0IHRoZSB3aW5kb3cgaGFzIGJlZW4gbW92ZWQgYW5kIHJlc2l6ZWQuCisgICAgZWNvcmVfZXZh
c19yZXF1ZXN0X2dlb21ldHJ5X2dldChlZSwgJngsICZ5LCAmd2lkdGgsICZoZWlnaHQpOworICAg
IEVYUEVDVF9FUSgxNTAsIHgpOworICAgIEVYUEVDVF9FUSgyMDAsIHkpOworICAgIEVYUEVDVF9F
USgyMDAsIHdpZHRoKTsKKyAgICBFWFBFQ1RfRVEoMTAwLCBoZWlnaHQpOworfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>