98271 2012-10-03 08:34:11 -0700 [GTK] [WK2] Unused variable in webkitWebViewLoadChanged 2012-10-03 09:18:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 733727 0 berto 2012-10-03 08:34:11 -0700 r130279 added a new 'priv' variable to webkitWebViewLoadChanged but forgot to use it. 733743 1 166904 berto 2012-10-03 08:44:44 -0700 Created attachment 166904 Patch 733744 2 berto 2012-10-03 08:46:09 -0700 This was caused by this commit btw: http://trac.webkit.org/changeset/130279 733747 3 webkit.review.bot 2012-10-03 08:47:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 733770 4 166904 webkit.review.bot 2012-10-03 09:18:43 -0700 Comment on attachment 166904 Patch Clearing flags on attachment: 166904 Committed r130295: <http://trac.webkit.org/changeset/130295> 733771 5 webkit.review.bot 2012-10-03 09:18:46 -0700 All reviewed patches have been landed. Closing bug. 166904 2012-10-03 08:44:44 -0700 2012-10-03 09:18:43 -0700 Patch unused.diff text/plain 2634 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4OWJmOWRmLi45YmUzZDc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTAtMDMgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIFtXSzJdIFVudXNlZCB2YXJpYWJsZSBpbiB3ZWJraXRXZWJWaWV3TG9hZENo YW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 MjcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHRoZSBwcml2IHZhcmlhYmxlIHRvIGRpcmVjdGx5IGFjY2VzcyBwcml2YXRlIGF0dHJpYnV0ZXMK KyAgICAgICAgaW5zdGVhZCBvZiBkZXJlZmVyZW5jaW5nIHdlYlZpZXctPnByaXYgYWxsIHRoZSB0 aW1lLgorICAgICAgICBGaXhlcyAtV3VudXNlZC12YXJpYWJsZS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0xv YWRDaGFuZ2VkKToKKwogMjAxMi0xMC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gV2ViS2l0V2ViVmlldyBkb2Vzbid0IGVtaXQg bm90aWZ5OmZhdmljb24gd2hlbiBpdCBjaGFuZ2VzIGluIHNvbWUgY2FzZXMgaW4gV2ViS2l0Mgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNw cAppbmRleCBkYmRhOThhLi4zMjU4YTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcApAQCAtMTI4OCwyNSArMTI4OCwyNSBAQCB2 b2lkIHdlYmtpdFdlYlZpZXdMb2FkQ2hhbmdlZChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJL aXRMb2FkRXZlbnQgbG9hZEV2ZW50KQogICAgICAgICB3ZWJraXRXZWJWaWV3RW1pdERlbGF5ZWRM b2FkRXZlbnRzKHdlYlZpZXcpOwogCiAgICAgICAgIHdlYmtpdFdlYlZpZXdDYW5jZWxGYXZpY29u UmVxdWVzdCh3ZWJWaWV3KTsKLSAgICAgICAgd2ViVmlldy0+cHJpdi0+bG9hZGluZ1Jlc291cmNl c01hcC5jbGVhcigpOwotICAgICAgICB3ZWJWaWV3LT5wcml2LT5tYWluUmVzb3VyY2UgPSAwOwot ICAgICAgICB3ZWJWaWV3LT5wcml2LT53YWl0aW5nRm9yTWFpblJlc291cmNlID0gZmFsc2U7Cisg ICAgICAgIHByaXYtPmxvYWRpbmdSZXNvdXJjZXNNYXAuY2xlYXIoKTsKKyAgICAgICAgcHJpdi0+ bWFpblJlc291cmNlID0gMDsKKyAgICAgICAgcHJpdi0+d2FpdGluZ0Zvck1haW5SZXNvdXJjZSA9 IGZhbHNlOwogICAgIH0gZWxzZSBpZiAobG9hZEV2ZW50ID09IFdFQktJVF9MT0FEX0NPTU1JVFRF RCkgewogICAgICAgICB3ZWJraXRXZWJWaWV3UmVxdWVzdEZhdmljb24od2ViVmlldyk7CiAKLSAg ICAgICAgd2ViVmlldy0+cHJpdi0+c3VicmVzb3VyY2VzTWFwLmNsZWFyKCk7Ci0gICAgICAgIGlm ICghd2ViVmlldy0+cHJpdi0+bWFpblJlc291cmNlKSB7CisgICAgICAgIHByaXYtPnN1YnJlc291 cmNlc01hcC5jbGVhcigpOworICAgICAgICBpZiAoIXByaXYtPm1haW5SZXNvdXJjZSkgewogICAg ICAgICAgICAgLy8gV2hlbiBhIHBhZ2UgaXMgbG9hZGVkIGZyb20gdGhlIGhpc3RvcnkgY2FjaGUs IHRoZSBtYWluIHJlc291cmNlIGxvYWQgY2FsbGJhY2tzCiAgICAgICAgICAgICAvLyBhcmUgY2Fs bGVkIHdoZW4gdGhlIG1haW4gZnJhbWUgbG9hZCBpcyBmaW5pc2hlZC4gV2Ugd2FudCB0byBtYWtl IHN1cmUgdGhlcmUncyBhCiAgICAgICAgICAgICAvLyBtYWluIHJlc291cmNlIGF2YWlsYWJsZSB3 aGVuIGxvYWQgaGFzIGJlZW4gY29tbWl0dGVkLCBzbyB3ZSBkZWxheSB0aGUgZW1pc3Npb24gb2YK ICAgICAgICAgICAgIC8vIGxvYWQtY2hhbmdlZCBzaWduYWwgdW50aWwgbWFpbiByZXNvdXJjZSBv YmplY3QgaGFzIGJlZW4gY3JlYXRlZC4KLSAgICAgICAgICAgIHdlYlZpZXctPnByaXYtPndhaXRp bmdGb3JNYWluUmVzb3VyY2UgPSB0cnVlOworICAgICAgICAgICAgcHJpdi0+d2FpdGluZ0Zvck1h aW5SZXNvdXJjZSA9IHRydWU7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgc2V0Q2VydGlm aWNhdGVUb01haW5SZXNvdXJjZSh3ZWJWaWV3KTsKICAgICB9CiAKLSAgICBpZiAod2ViVmlldy0+ cHJpdi0+d2FpdGluZ0Zvck1haW5SZXNvdXJjZSkKLSAgICAgICAgd2ViVmlldy0+cHJpdi0+bGFz dERlbGF5ZWRFdmVudCA9IGxvYWRFdmVudDsKKyAgICBpZiAocHJpdi0+d2FpdGluZ0Zvck1haW5S ZXNvdXJjZSkKKyAgICAgICAgcHJpdi0+bGFzdERlbGF5ZWRFdmVudCA9IGxvYWRFdmVudDsKICAg ICBlbHNlCiAgICAgICAgIHdlYmtpdFdlYlZpZXdFbWl0TG9hZENoYW5nZWQod2ViVmlldywgbG9h ZEV2ZW50KTsKIH0K