98262 2012-10-03 07:03:07 -0700 [GTK] Build break when NETSCAPE_PLUGIN_API macro is off 2020-08-17 06:51:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 mariusz.g webkit-unassigned berto bugs-noreply cgarcia commit-queue gustavo kbalazs mrobinson philip.chimento oldest_to_newest 733657 0 mariusz.g 2012-10-03 07:03:07 -0700 When trying to build webkit gtk with plugin's support off build break occurs: CXX Source/WebCore/plugins/libWebCore_la-PluginPackage.lo ../../Source/WebCore/plugins/npapi.cpp: In function ‘NPError NPN_GetURLNotify(NPP, const char*, const char*, void*)’: ../../Source/WebCore/plugins/npapi.cpp:74:45: error: ‘class WebCore::PluginView’ has no member named ‘getURLNotify’ ../../Source/WebCore/plugins/npapi.cpp: In function ‘NPError NPN_GetURL(NPP, const char*, const char*)’: ../../Source/WebCore/plugins/npapi.cpp:79:45: error: ‘class WebCore::PluginView’ has no member named ‘getURL’ also --no-netscape-plugin-api option to build-webkit doesn't make any effect. 735543 1 mariusz.g 2012-10-05 03:28:18 -0700 Qt and ports that use cmake, don't compile npapi.cpp when NETSCAPE_PLUGIN_API is off(check in Target.pri and CMakeLists.txt). What policy should be applied to Gtk? 1. Have all files added to sources(like now) and make checks in them 2. Make check in GNUMakefile.list.am and don't take inappropriate files to build(e.g. in this case npapi.cpp) 744206 2 kbalazs 2012-10-17 06:34:43 -0700 (In reply to comment #1) > Qt and ports that use cmake, don't compile npapi.cpp when NETSCAPE_PLUGIN_API is off(check in Target.pri and CMakeLists.txt). What policy should be applied to Gtk? > 1. Have all files added to sources(like now) and make checks in them > 2. Make check in GNUMakefile.list.am and don't take inappropriate files to build(e.g. in this case npapi.cpp) I think 1. is the more generally accepted. 1059281 3 244122 philip.chimento 2015-01-06 19:12:15 -0800 Created attachment 244122 Patch 1059283 4 commit-queue 2015-01-06 19:15:25 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1059380 5 244122 cgarcia 2015-01-07 05:33:09 -0800 Comment on attachment 244122 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244122&action=review > Source/WebKit2/PluginProcess/unix/PluginControllerProxyUnix.cpp:30 > #if ENABLE(PLUGIN_PROCESS) > +#if ENABLE(NETSCAPE_PLUGIN_API) I don't think this is correct, why using NETSCAPE_PLUGIN_API here? ENABLE_PLUGIN_PROCESS is what it should be false, I guess. > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:32 > #if ENABLE(PLUGIN_PROCESS) > +#if ENABLE(NETSCAPE_PLUGIN_API) Ditto. > Source/WebKit2/PluginProcess/unix/PluginProcessUnix.cpp:30 > #if ENABLE(PLUGIN_PROCESS) > +#if ENABLE(NETSCAPE_PLUGIN_API) Ditto. > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:690 > +#if ENABLE(NETSCAPE_PLUGIN_API) > Vector<PluginModuleInfo> plugins = WEBKIT_WEB_CONTEXT(object)->priv->context->pluginInfoStore().plugins(); > GList* returnValue = 0; > for (size_t i = 0; i < plugins.size(); ++i) > returnValue = g_list_prepend(returnValue, webkitPluginCreate(plugins[i])); > g_task_return_pointer(task, returnValue, reinterpret_cast<GDestroyNotify>(destroyPluginList)); > +#else > + g_task_return_pointer(task, NULL, NULL); > +#endif Why doing this in the thread body? If NETSCAPE_PLUGIN_API is not enabled we should call g_task_return_pointer before spawning the thread. > Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:68 > +#if ENABLE(NETSCAPE_PLUGIN_API) I guess this should be #if ENABLE(PLUGIN_PROCESS) > Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:32 > #if ENABLE(PLUGIN_PROCESS) > +#if ENABLE(NETSCAPE_PLUGIN_API) Same here about duplicated if > Source/WebKit2/WebProcess/Plugins/Netscape/unix/PluginProxyUnix.cpp:30 > #if ENABLE(PLUGIN_PROCESS) > +#if ENABLE(NETSCAPE_PLUGIN_API) Ditto. 1059756 6 philip.chimento 2015-01-08 00:05:10 -0800 So what you're saying is that we should never compile with -DENABLE_NETSCAPE_PLUGIN_API=OFF and instead use -DENABLE_PLUGIN_PROCESS=OFF? Or, in other words, having PLUGIN_PROCESS enabled without the NETSCAPE_PLUGIN_API doesn't make sense? In that case, can I just remove the extra cmake configuration parameter for the Netscape API? 1059762 7 cgarcia 2015-01-08 00:50:51 -0800 (In reply to comment #6) > So what you're saying is that we should never compile with > -DENABLE_NETSCAPE_PLUGIN_API=OFF and instead use -DENABLE_PLUGIN_PROCESS=OFF? > > Or, in other words, having PLUGIN_PROCESS enabled without the > NETSCAPE_PLUGIN_API doesn't make sense? It doesn't make sense for us, because the only plugins supported by the GTK port are the NPAPI plugins. > In that case, can I just remove the > extra cmake configuration parameter for the Netscape API? Yes, we could probably remove the cmake option, or ensure that it's OFF when the plugin process option is OFF 1680802 8 cgarcia 2020-08-17 06:51:25 -0700 Plugins are no longer supported. 244122 2015-01-06 19:12:15 -0800 2015-01-07 05:33:09 -0800 Patch bug-98262-20150106191219.patch text/plain 7362 philip.chimento U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3ODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNmQ1MzgyY2E2OTI3MmNk Mjg3ZTFiZjg0MDc2N2M3ZTVkYzVlMTlmZi4uYTQ4NmEyNWQxMDU1OTllM2MwNmI4OWZhOTYwZjRl MmRhN2E5MTQ3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAxLTA2ICBQaGls aXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIFtHVEtd IEJ1aWxkIGJyZWFrIHdoZW4gTkVUU0NBUEVfUExVR0lOX0FQSSBtYWNybyBpcyBvZmYKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjYyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNz L3VuaXgvUGx1Z2luQ29udHJvbGxlclByb3h5VW5peC5jcHA6IEFkZCAjaWYgZ3VhcmRzLgorICAg ICAgICAqIFBsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Qcm9jZXNzTWFpblVuaXguY3BwOiBBZGQg I2lmIGd1YXJkcy4KKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc1Vu aXguY3BwOiBBZGQgI2lmIGd1YXJkcy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfY29udGV4dF9zZXRfYWRkaXRp b25hbF9wbHVnaW5zX2RpcmVjdG9yeSk6IEFkZCAjaWYgZ3VhcmRzLgorICAgICAgICAod2Via2l0 V2ViQ29udGV4dEdldFBsdWdpblRocmVhZCk6IEFkZCAjaWYgZ3VhcmRzIGFuZCByZXR1cm4gTlVM TCBwb2ludGVyIGlmIG5vdCB1c2luZyBORVRTQ0FQRV9QTFVHSU5fQVBJLgorICAgICAgICAqIFVJ UHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcDogQWRkICNpZiBndWFy ZHMuCisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6Cisg ICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNw cDogQWRkICNpZiBndWFyZHMuCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L3VuaXgvUGx1Z2luUHJveHlVbml4LmNwcDogQWRkICNpZiBndWFyZHMuCisKIDIwMTUtMDEtMDEg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgR3JvdXBTZXR0 aW5ncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdp bkNvbnRyb2xsZXJQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91 bml4L1BsdWdpbkNvbnRyb2xsZXJQcm94eVVuaXguY3BwCmluZGV4IGNiY2MxZDczMDc1ZjIzYWQw NWYyOGJkODgwMDRlNjdiZjY4YWQ2NTMuLjFiNmY2NjlmNmYyZjZiYjdlYTY0MjljYmFmMTI5YTI2 ZjZhNDA2ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9Q bHVnaW5Db250cm9sbGVyUHJveHlVbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Q cm9jZXNzL3VuaXgvUGx1Z2luQ29udHJvbGxlclByb3h5VW5peC5jcHAKQEAgLTI3LDYgKzI3LDcg QEAKICNpbmNsdWRlICJQbHVnaW5Db250cm9sbGVyUHJveHkuaCIKIAogI2lmIEVOQUJMRShQTFVH SU5fUFJPQ0VTUykKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIAogI2luY2x1ZGUg PFdlYkNvcmUvTm90SW1wbGVtZW50ZWQuaD4KIApAQCAtNTEsNCArNTIsNSBAQCB2b2lkIFBsdWdp bkNvbnRyb2xsZXJQcm94eTo6cGxhdGZvcm1HZW9tZXRyeURpZENoYW5nZSgpCiAKIH0gLy8gbmFt ZXNwYWNlIFdlYktpdAogCisjZW5kaWYgLy8gRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAj ZW5kaWYgLy8gRU5BQkxFKFBMVUdJTl9QUk9DRVNTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWluVW5peC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01haW5Vbml4LmNwcAppbmRl eCA5OGIxZGJmNTJlYjVmZTMyMDcyMzQ2ZjE3MGM2M2MxZDc1N2M4MjJjLi4yNDYyMzE5ODQ1MjA0 ZDI4ZjRhYWE2MDg2NGIxOWE1NTEzZTNkYmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9Q bHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01haW5Vbml4LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vzc01haW5Vbml4LmNwcApAQCAt MjksNiArMjksNyBAQAogI2luY2x1ZGUgIlBsdWdpblByb2Nlc3NNYWluVW5peC5oIgogCiAjaWYg RU5BQkxFKFBMVUdJTl9QUk9DRVNTKQorI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQog CiAjaW5jbHVkZSAiQ2hpbGRQcm9jZXNzTWFpbi5oIgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKQEAg LTExNCw0ICsxMTUsNSBAQCBpbnQgUGx1Z2luUHJvY2Vzc01haW5Vbml4KGludCBhcmdjLCBjaGFy KiogYXJndikKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKLSNlbmRpZgorI2VuZGlmIC8vIEVO QUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQorI2VuZGlmIC8vIEVOQUJMRShQTFVHSU5fUFJPQ0VT UykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Q cm9jZXNzVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2lu UHJvY2Vzc1VuaXguY3BwCmluZGV4IGM2ZWI0OWRmNGIyM2EwZDI1YjNlNTgzMTExODU2NGEzMzI4 MDJlYTUuLjk5N2I2YTlhNmFiZjA5ZjllNGJlMzc3MzNhZWU1MjE2YjU3YjQxZmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Qcm9jZXNzVW5peC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NV bml4LmNwcApAQCAtMjcsNiArMjcsNyBAQAogI2luY2x1ZGUgIlBsdWdpblByb2Nlc3MuaCIKIAog I2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQ SSkKIAogI2luY2x1ZGUgIlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKICNpbmNs dWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CkBAIC00NCw0ICs0NSw1IEBAIHZvaWQgUGx1 Z2luUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2VzcyhQbHVnaW5Qcm9jZXNz Q3JlYXRpb25QYXJhbWV0CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCisjZW5kaWYgLy8gRU5B QkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAjZW5kaWYgLy8gRU5BQkxFKFBMVUdJTl9QUk9DRVNT KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJD b250ZXh0LmNwcAppbmRleCAwY2EyZDZjNGMzMmU0MDM1MGVlNmJjMjJkMTc2NzI2YWYyZGQzNWQz Li5mODM0ZDBhNjBjYzQxNDEyODFhOTI2MjBmNWEyZjViNmU5OTdmOThkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcApA QCAtNjY3LDcgKzY2Nyw5IEBAIHZvaWQgd2Via2l0X3dlYl9jb250ZXh0X3NldF9hZGRpdGlvbmFs X3BsdWdpbnNfZGlyZWN0b3J5KFdlYktpdFdlYkNvbnRleHQqIGNvbnRlCiAgICAgZ19yZXR1cm5f aWZfZmFpbChXRUJLSVRfSVNfV0VCX0NPTlRFWFQoY29udGV4dCkpOwogICAgIGdfcmV0dXJuX2lm X2ZhaWwoZGlyZWN0b3J5KTsKIAorI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogICAg IGNvbnRleHQtPnByaXYtPmNvbnRleHQtPnNldEFkZGl0aW9uYWxQbHVnaW5zRGlyZWN0b3J5KFdl YkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoZGlyZWN0b3J5KSk7CisjZW5kaWYKIH0KIAogc3RhdGlj IHZvaWQgZGVzdHJveVBsdWdpbkxpc3QoR0xpc3QqIHBsdWdpbnMpCkBAIC02NzcsMTEgKzY3OSwx NSBAQCBzdGF0aWMgdm9pZCBkZXN0cm95UGx1Z2luTGlzdChHTGlzdCogcGx1Z2lucykKIAogc3Rh dGljIHZvaWQgd2Via2l0V2ViQ29udGV4dEdldFBsdWdpblRocmVhZChHVGFzayogdGFzaywgZ3Bv aW50ZXIgb2JqZWN0LCBncG9pbnRlciAvKiB0YXNrRGF0YSAqLywgR0NhbmNlbGxhYmxlKikKIHsK KyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBWZWN0b3I8UGx1Z2luTW9kdWxl SW5mbz4gcGx1Z2lucyA9IFdFQktJVF9XRUJfQ09OVEVYVChvYmplY3QpLT5wcml2LT5jb250ZXh0 LT5wbHVnaW5JbmZvU3RvcmUoKS5wbHVnaW5zKCk7CiAgICAgR0xpc3QqIHJldHVyblZhbHVlID0g MDsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHBsdWdpbnMuc2l6ZSgpOyArK2kpCiAgICAg ICAgIHJldHVyblZhbHVlID0gZ19saXN0X3ByZXBlbmQocmV0dXJuVmFsdWUsIHdlYmtpdFBsdWdp bkNyZWF0ZShwbHVnaW5zW2ldKSk7CiAgICAgZ190YXNrX3JldHVybl9wb2ludGVyKHRhc2ssIHJl dHVyblZhbHVlLCByZWludGVycHJldF9jYXN0PEdEZXN0cm95Tm90aWZ5PihkZXN0cm95UGx1Z2lu TGlzdCkpOworI2Vsc2UKKyAgICBnX3Rhc2tfcmV0dXJuX3BvaW50ZXIodGFzaywgTlVMTCwgTlVM TCk7CisjZW5kaWYKIH0KIAogLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAKaW5kZXggMzYyMzY1 Y2NhYWI2ZmVmY2I4YjVhNjEwNzAyZWY4MTQxZGNjNDQxNy4uMjFjODAzZmYxODRlZTBiYWU4ZmMz M2U0MDJhMmQzZTUzNGY0MmQ5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcApAQCAtNjUsNiAr NjUsNyBAQCB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2VzcygpCiAgICAgY2FzZSBX ZWJQcm9jZXNzOgogICAgICAgICBleGVjdXRhYmxlUGF0aCA9IGV4ZWN1dGFibGVQYXRoT2ZXZWJQ cm9jZXNzKCk7CiAgICAgICAgIGJyZWFrOworI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJ KQogICAgIGNhc2UgUGx1Z2luUHJvY2VzczoKICAgICAgICAgZXhlY3V0YWJsZVBhdGggPSBleGVj dXRhYmxlUGF0aE9mUGx1Z2luUHJvY2VzcygpOwogI2lmIEVOQUJMRShQTFVHSU5fUFJPQ0VTU19H VEsyKQpAQCAtNzQsNiArNzUsNyBAQCB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vz cygpCiAgICAgICAgIHBsdWdpblBhdGggPSBtX2xhdW5jaE9wdGlvbnMuZXh0cmFJbml0aWFsaXph dGlvbkRhdGEuZ2V0KCJwbHVnaW4tcGF0aCIpOwogICAgICAgICByZWFsUGx1Z2luUGF0aCA9IGZp bGVTeXN0ZW1SZXByZXNlbnRhdGlvbihwbHVnaW5QYXRoKTsKICAgICAgICAgYnJlYWs7CisjZW5k aWYKICNpZiBFTkFCTEUoTkVUV09SS19QUk9DRVNTKQogICAgIGNhc2UgTmV0d29ya1Byb2Nlc3M6 CiAgICAgICAgIGV4ZWN1dGFibGVQYXRoID0gZXhlY3V0YWJsZVBhdGhPZk5ldHdvcmtQcm9jZXNz KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1Bs dWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdp bnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRleCA3MGQ4NzNkYmEzZGQ5ZDhi M2ViNTkyOTUzMWI2ZTk4ODk0ZTY5ODcxLi5lM2FiODFkNWIzYjQ1ZDQ1YmViMzdlNmNmMWFhYTE0 YzAxMTI5YTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91 bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKQEAgLTI5LDYgKzI5 LDcgQEAKICNpbmNsdWRlICJQbHVnaW5Qcm9jZXNzUHJveHkuaCIKIAogI2lmIEVOQUJMRShQTFVH SU5fUFJPQ0VTUykKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIAogI2luY2x1ZGUg IlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKICNpbmNsdWRlICJQcm9jZXNzRXhl Y3V0YWJsZVBhdGguaCIKQEAgLTE1OCw0ICsxNTksNSBAQCBib29sIFBsdWdpblByb2Nlc3NQcm94 eTo6c2NhblBsdWdpbihjb25zdCBTdHJpbmcmIHBsdWdpblBhdGgsIFJhd1BsdWdpbk1ldGFEYXRh JgogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAorI2VuZGlmIC8vIEVOQUJMRShORVRTQ0FQRV9Q TFVHSU5fQVBJKQogI2VuZGlmIC8vIEVOQUJMRShQTFVHSU5fUFJPQ0VTUykKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS91bml4L1BsdWdpblBy b3h5VW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUv dW5peC9QbHVnaW5Qcm94eVVuaXguY3BwCmluZGV4IDk5NmFmMjBjYTQ2ZmYxZGMwNGU2NmQxOTNj ZGU4ZTAxZjFlMmE4ZGYuLmNjM2I5NTVjZDAyMTNkOGJiYWIyMjQxZWI1MzM0OGVlZmU4NjM5M2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS91 bml4L1BsdWdpblByb3h5VW5peC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL3VuaXgvUGx1Z2luUHJveHlVbml4LmNwcApAQCAtMjcsNiArMjcsNyBA QAogI2luY2x1ZGUgIlBsdWdpblByb3h5LmgiCiAKICNpZiBFTkFCTEUoUExVR0lOX1BST0NFU1Mp CisjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAKICNpbmNsdWRlIDxXZWJDb3JlL05v dEltcGxlbWVudGVkLmg+CiAKQEAgLTQwLDQgKzQxLDUgQEAgYm9vbCBQbHVnaW5Qcm94eTo6bmVl ZHNCYWNraW5nU3RvcmUoKSBjb25zdAogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIAorI2VuZGlm IC8vIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogI2VuZGlmIC8vIEVOQUJMRShQTFVHSU5f UFJPQ0VTUykK