98253 2012-10-03 03:41:00 -0700 [EFL][WK2] Implement focus/unfocus in UIClient 2012-10-03 07:32:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim hausmann kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 733536 0 cdumez 2012-10-03 03:41:00 -0700 We currently don't implement focus/unfocus callbacks in EwkView UIClient. We should provide an implementation for those. 733575 1 166860 cdumez 2012-10-03 05:05:52 -0700 Created attachment 166860 Patch 733607 2 166860 rakuco 2012-10-03 05:56:36 -0700 Comment on attachment 166860 Patch LGTM. 733625 3 166860 gyuyoung.kim 2012-10-03 06:22:17 -0700 Comment on attachment 166860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95 > + evas_object_focus_set(toEwkView(clientInfo), false); BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way. 733627 4 166860 cdumez 2012-10-03 06:24:14 -0700 Comment on attachment 166860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95 >> + evas_object_focus_set(toEwkView(clientInfo), false); > > BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way. Yes, takeFocus() implementation is not complete but we do the same in WebKit1. 733649 5 gyuyoung.kim 2012-10-03 06:52:45 -0700 (In reply to comment #4) > (From update of attachment 166860 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166860&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:95 > >> + evas_object_focus_set(toEwkView(clientInfo), false); > > > > BTW, I wonder why we support *takeFocus* as *unfocus* functionality. In mac port and qt port, they process this with other way. > > Yes, takeFocus() implementation is not complete but we do the same in WebKit1. Ok. IMO, it would be good if you say this using "FIXME: bla bla". 733654 6 166885 cdumez 2012-10-03 06:59:10 -0700 Created attachment 166885 Patch for landing Take Gyuyoung's feedback into consideration. 733678 7 166885 webkit.review.bot 2012-10-03 07:32:22 -0700 Comment on attachment 166885 Patch for landing Clearing flags on attachment: 166885 Committed r130285: <http://trac.webkit.org/changeset/130285> 733679 8 webkit.review.bot 2012-10-03 07:32:27 -0700 All reviewed patches have been landed. Closing bug. 166860 2012-10-03 05:05:52 -0700 2012-10-03 06:59:10 -0700 Patch 98253_uiclient_focus.patch text/plain 2116 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNmUyZWYyLi5mN2JmZjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBmb2N1cy91bmZvY3VzIGluIFVJ Q2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODI1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElt cGxlbWVudCBmb2N1cy1yZWxhdGVkIGZ1bmN0aW9uYWxpdHkgaW4KKyAgICAgICAgV2ViS2l0RUZM J3MgVUlDbGllbnQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9j bGllbnQuY3BwOgorICAgICAgICAoZm9jdXMpOgorICAgICAgICAodW5mb2N1cyk6CisgICAgICAg ICh0YWtlRm9jdXMpOgorICAgICAgICAoZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaCk6CisKIDIw MTItMTAtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIEFkZCBBUEkgdG8gZ2V0IHRoZSB3ZWIgdmlldyB0aGF0IGluaXRpYXRlZCBh IGN1c3RvbSBVUkkgcmVxdWVzdCB0byBXZWJLaXQyIEdUSysKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCmluZGV4IDBi ODQ5ZmEuLmYwZjA1MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcApAQCAtODAsNiArODAsMjEgQEAgc3RhdGlj IHVuc2lnbmVkIGxvbmcgbG9uZyBleGNlZWRlZERhdGFiYXNlUXVvdGEoV0tQYWdlUmVmLCBXS0Zy YW1lUmVmLCBXS1NlY3VyaXQKIH0KICNlbmRpZgogCitzdGF0aWMgdm9pZCBmb2N1cyhXS1BhZ2VS ZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCit7CisgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0 KHRvRXdrVmlldyhjbGllbnRJbmZvKSwgdHJ1ZSk7Cit9CisKK3N0YXRpYyB2b2lkIHVuZm9jdXMo V0tQYWdlUmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIGV2YXNfb2JqZWN0X2Zv Y3VzX3NldCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIGZhbHNlKTsKK30KKworc3RhdGljIHZvaWQg dGFrZUZvY3VzKFdLUGFnZVJlZiwgV0tGb2N1c0RpcmVjdGlvbiwgY29uc3Qgdm9pZCogY2xpZW50 SW5mbykKK3sKKyAgICBldmFzX29iamVjdF9mb2N1c19zZXQodG9Fd2tWaWV3KGNsaWVudEluZm8p LCBmYWxzZSk7Cit9CisKIHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50X2F0dGFjaChXS1BhZ2VSZWYg cGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgV0tQYWdlVUlDbGllbnQgdWlD bGllbnQ7CkBAIC05MSw2ICsxMDYsOSBAQCB2b2lkIGV3a192aWV3X3VpX2NsaWVudF9hdHRhY2go V0tQYWdlUmVmIHBhZ2VSZWYsIEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHVpQ2xpZW50LnJ1 bkphdmFTY3JpcHRBbGVydCA9IHJ1bkphdmFTY3JpcHRBbGVydDsKICAgICB1aUNsaWVudC5ydW5K YXZhU2NyaXB0Q29uZmlybSA9IHJ1bkphdmFTY3JpcHRDb25maXJtOwogICAgIHVpQ2xpZW50LnJ1 bkphdmFTY3JpcHRQcm9tcHQgPSBydW5KYXZhU2NyaXB0UHJvbXB0OworICAgIHVpQ2xpZW50LnRh a2VGb2N1cyA9IHRha2VGb2N1czsKKyAgICB1aUNsaWVudC5mb2N1cyA9IGZvY3VzOworICAgIHVp Q2xpZW50LnVuZm9jdXMgPSB1bmZvY3VzOwogI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCiAgICAg dWlDbGllbnQuZXhjZWVkZWREYXRhYmFzZVF1b3RhID0gZXhjZWVkZWREYXRhYmFzZVF1b3RhOwog I2VuZGlmCg== 166885 2012-10-03 06:59:10 -0700 2012-10-03 07:32:22 -0700 Patch for landing 98253_uiclient_focus.patch text/plain 2171 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4OWJmOWRmLi4yNTVlMTZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBmb2N1cy91bmZvY3VzIGluIFVJ Q2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODI1MworCisgICAgICAgIFJldmlld2VkIGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBJbXBs ZW1lbnQgZm9jdXMtcmVsYXRlZCBmdW5jdGlvbmFsaXR5IGluCisgICAgICAgIFdlYktpdEVGTCdz IFVJQ2xpZW50LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xp ZW50LmNwcDoKKyAgICAgICAgKGZvY3VzKToKKyAgICAgICAgKHVuZm9jdXMpOgorICAgICAgICAo dGFrZUZvY3VzKToKKyAgICAgICAgKGV3a192aWV3X3VpX2NsaWVudF9hdHRhY2gpOgorCiAyMDEy LTEwLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBXZWJLaXRXZWJWaWV3IGRvZXNuJ3QgZW1pdCBub3RpZnk6ZmF2aWNvbiB3aGVu IGl0IGNoYW5nZXMgaW4gc29tZSBjYXNlcyBpbiBXZWJLaXQyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAppbmRleCAw Yjg0OWZhLi5lOWFlMzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTgwLDYgKzgwLDIyIEBAIHN0YXRp YyB1bnNpZ25lZCBsb25nIGxvbmcgZXhjZWVkZWREYXRhYmFzZVF1b3RhKFdLUGFnZVJlZiwgV0tG cmFtZVJlZiwgV0tTZWN1cml0CiB9CiAjZW5kaWYKIAorc3RhdGljIHZvaWQgZm9jdXMoV0tQYWdl UmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIGV2YXNfb2JqZWN0X2ZvY3VzX3Nl dCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIHRydWUpOworfQorCitzdGF0aWMgdm9pZCB1bmZvY3Vz KFdLUGFnZVJlZiwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBldmFzX29iamVjdF9m b2N1c19zZXQodG9Fd2tWaWV3KGNsaWVudEluZm8pLCBmYWxzZSk7Cit9CisKK3N0YXRpYyB2b2lk IHRha2VGb2N1cyhXS1BhZ2VSZWYsIFdLRm9jdXNEaXJlY3Rpb24sIGNvbnN0IHZvaWQqIGNsaWVu dEluZm8pCit7CisgICAgLy8gRklYTUU6IHRoaXMgaXMgb25seSBhIHBhcnRpYWwgaW1wbGVtZW50 YXRpb24uCisgICAgZXZhc19vYmplY3RfZm9jdXNfc2V0KHRvRXdrVmlldyhjbGllbnRJbmZvKSwg ZmFsc2UpOworfQorCiB2b2lkIGV3a192aWV3X3VpX2NsaWVudF9hdHRhY2goV0tQYWdlUmVmIHBh Z2VSZWYsIEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIFdLUGFnZVVJQ2xpZW50IHVpQ2xp ZW50OwpAQCAtOTEsNiArMTA3LDkgQEAgdm9pZCBld2tfdmlld191aV9jbGllbnRfYXR0YWNoKFdL UGFnZVJlZiBwYWdlUmVmLCBFdmFzX09iamVjdCogZXdrVmlldykKICAgICB1aUNsaWVudC5ydW5K YXZhU2NyaXB0QWxlcnQgPSBydW5KYXZhU2NyaXB0QWxlcnQ7CiAgICAgdWlDbGllbnQucnVuSmF2 YVNjcmlwdENvbmZpcm0gPSBydW5KYXZhU2NyaXB0Q29uZmlybTsKICAgICB1aUNsaWVudC5ydW5K YXZhU2NyaXB0UHJvbXB0ID0gcnVuSmF2YVNjcmlwdFByb21wdDsKKyAgICB1aUNsaWVudC50YWtl Rm9jdXMgPSB0YWtlRm9jdXM7CisgICAgdWlDbGllbnQuZm9jdXMgPSBmb2N1czsKKyAgICB1aUNs aWVudC51bmZvY3VzID0gdW5mb2N1czsKICNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQogICAgIHVp Q2xpZW50LmV4Y2VlZGVkRGF0YWJhc2VRdW90YSA9IGV4Y2VlZGVkRGF0YWJhc2VRdW90YTsKICNl bmRpZgo=