98249 2012-10-03 02:56:56 -0700 [EFL][WK2] Implement PageClientImpl::isViewVisible() 2012-10-04 16:51:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim hausmann kenneth laszlo.gombos lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 733512 0 cdumez 2012-10-03 02:56:56 -0700 PageClientImpl::isViewVisible() is currently unimplemented for EFL port. We should implement it as it allows for some painting optimizations. 733513 1 166840 cdumez 2012-10-03 02:58:58 -0700 Created attachment 166840 Patch 733530 2 166840 rakuco 2012-10-03 03:29:58 -0700 Comment on attachment 166840 Patch LGTM, I guess. Do we just want to reflect whether evas_object_{show,hide} has been called indeed? 733537 3 cdumez 2012-10-03 03:43:06 -0700 (In reply to comment #2) > (From update of attachment 166840 [details]) > LGTM, I guess. Do we just want to reflect whether evas_object_{show,hide} has been called indeed? Yes. 735128 4 166840 webkit.review.bot 2012-10-04 16:51:25 -0700 Comment on attachment 166840 Patch Clearing flags on attachment: 166840 Committed r130434: <http://trac.webkit.org/changeset/130434> 735129 5 webkit.review.bot 2012-10-04 16:51:29 -0700 All reviewed patches have been landed. Closing bug. 166840 2012-10-03 02:58:58 -0700 2012-10-04 16:51:24 -0700 Patch 98249_isViewVisible.patch text/plain 1272 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNmUyZWYyLi5mYjY5MjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMDMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBQYWdlQ2xpZW50SW1wbDo6aXNW aWV3VmlzaWJsZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05ODI0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEltcGxlbWVudCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3VmlzaWJsZSgpIGZvciBFRkwgcG9y dAorICAgICAgICBieSBjYWxsaW5nIGV2YXNfb2JqZWN0X3Zpc2libGVfZ2V0KCkgb24gdGhlIHZp ZXcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xpZW50SW1wbC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjppc1ZpZXdWaXNpYmxlKToKKwogMjAxMi0x MC0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0dUS10gQWRkIEFQSSB0byBnZXQgdGhlIHdlYiB2aWV3IHRoYXQgaW5pdGlhdGVkIGEgY3Vz dG9tIFVSSSByZXF1ZXN0IHRvIFdlYktpdDIgR1RLKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvUGFnZUNsaWVudEltcGwuY3BwCmluZGV4IGVmMmNlNjAuLjNiZjE5 NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL1BhZ2VDbGll bnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9QYWdlQ2xp ZW50SW1wbC5jcHAKQEAgLTk0LDggKzk0LDcgQEAgYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3 Rm9jdXNlZCgpCiAKIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld1Zpc2libGUoKQogewotICAg IG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuIGV2YXNfb2Jq ZWN0X3Zpc2libGVfZ2V0KG1fdmlld1dpZGdldCk7CiB9CiAKIGJvb2wgUGFnZUNsaWVudEltcGw6 OmlzVmlld0luV2luZG93KCkK