98238 2012-10-03 01:05:39 -0700 [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness 2012-10-03 01:43:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez d-r gyuyoung.kim hausmann kenneth laszlo.gombos ossy tonikitoo webkit.review.bot oldest_to_newest 733420 0 cdumez 2012-10-03 01:05:39 -0700 TestRunner.setAlwaysAcceptCookies() can be called by tests to temporarily force acceptation of all cookies. However, we don't reset this setting in InjectedBundle::beginTesting() so it causes flakiness. 733421 1 166823 cdumez 2012-10-03 01:08:05 -0700 Created attachment 166823 Patch 733424 2 166823 ossy 2012-10-03 01:10:43 -0700 Comment on attachment 166823 Patch r=me 733445 3 166823 webkit.review.bot 2012-10-03 01:43:30 -0700 Comment on attachment 166823 Patch Clearing flags on attachment: 166823 Committed r130262: <http://trac.webkit.org/changeset/130262> 733446 4 webkit.review.bot 2012-10-03 01:43:34 -0700 All reviewed patches have been landed. Closing bug. 166823 2012-10-03 01:08:05 -0700 2012-10-03 01:43:30 -0700 Patch 98238_cookies_flakiness.patch text/plain 1337 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiYzRk NmYwLi5iOTgyMmY2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xICsxLDE0IEBACisyMDEyLTEwLTAzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hy aXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW1dLMl1bV0tUUl0gVGVzdFJ1bm5l ci5zZXRBbHdheXNBY2NlcHRDb29raWVzKCkgY2F1c2VzIGZsYWtpbmVzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgyMzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldCBBbHdheXNBY2NlcHRDb29r aWVzIHNldHRpbmcgYmV0d2VlbiB0ZXN0cyB0byBhdm9pZAorICAgICAgICBmbGFraW5lc3MgZHVl IHRvIFRlc3RSdW5uZXIuc2V0QWx3YXlzQWNjZXB0Q29va2llcygpLgorCisgICAgICAgICogV2Vi S2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisgICAgICAg IChXVFI6OkluamVjdGVkQnVuZGxlOjpiZWdpblRlc3RpbmcpOgorCiA9PSBSb2xsZWQgb3ZlciB0 byBDaGFuZ2VMb2ctMjAxMi0xMC0wMiA9PQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAppbmRleCBmMmIxNzRkLi40 YjAxMmM4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L0luamVjdGVkQnVuZGxlLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVk QnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcApAQCAtMjQ1LDYgKzI0NSw3IEBAIHZvaWQgSW5qZWN0 ZWRCdW5kbGU6OmJlZ2luVGVzdGluZyhXS0RpY3Rpb25hcnlSZWYgc2V0dGluZ3MpCiAgICAgV0tC dW5kbGVTZXRBbGxvd0ZpbGVBY2Nlc3NGcm9tRmlsZVVSTHMobV9idW5kbGUsIG1fcGFnZUdyb3Vw LCB0cnVlKTsKICAgICBXS0J1bmRsZVNldFBsdWdpbnNFbmFibGVkKG1fYnVuZGxlLCBtX3BhZ2VH cm91cCwgdHJ1ZSk7CiAgICAgV0tCdW5kbGVTZXRQb3B1cEJsb2NraW5nRW5hYmxlZChtX2J1bmRs ZSwgbV9wYWdlR3JvdXAsIGZhbHNlKTsKKyAgICBXS0J1bmRsZVNldEFsd2F5c0FjY2VwdENvb2tp ZXMobV9idW5kbGUsIGZhbHNlKTsKIAogICAgIFdLQnVuZGxlUmVtb3ZlQWxsVXNlckNvbnRlbnQo bV9idW5kbGUsIG1fcGFnZUdyb3VwKTsKIAo=