98229 2012-10-02 21:21:02 -0700 Introduce Localizer::dateTimeFormatWithSecond and dateTimeFormatWithoutSecond 2012-10-04 23:25:05 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98485 1 tkent tkent haraken keishi mifenton webkit.review.bot yutak oldest_to_newest 733346 0 tkent 2012-10-02 21:21:02 -0700 Introduce Localizer::dateTimeFormatWithSecond and dateTimeFormatWithoutSecond 733347 1 166805 tkent 2012-10-02 21:28:07 -0700 Created attachment 166805 Patch 733349 2 166805 haraken 2012-10-02 21:31:54 -0700 Comment on attachment 166805 Patch OK 733353 3 166805 webkit.review.bot 2012-10-02 21:54:31 -0700 Comment on attachment 166805 Patch Clearing flags on attachment: 166805 Committed r130247: <http://trac.webkit.org/changeset/130247> 733354 4 webkit.review.bot 2012-10-02 21:54:34 -0700 All reviewed patches have been landed. Closing bug. 733763 5 166805 darin 2012-10-03 09:10:27 -0700 Comment on attachment 166805 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166805&action=review > Source/WebCore/platform/text/Localizer.cpp:210 > +String Localizer::dateTimeFormatWithSecond() Should be “with seconds” rather than “with second” > Source/WebCore/platform/text/Localizer.cpp:212 > + // FIXME: We should retreive the separator and the order from the system. Spelling is retrieve, not retreive. > Source/WebCore/platform/text/Localizer.cpp:217 > + return builder.toString(); Seems inefficient to create a new string every time. Other functions in this class have caching to avoid recomputing strings. Is the performance of this going to be OK? > Source/WebCore/platform/text/Localizer.cpp:220 > +String Localizer::dateTimeFormatWithoutSecond() Should be “without seconds” rather than “with second” > Source/WebCore/platform/text/Localizer.cpp:222 > + // FIXME: We should retreive the separator and the order from the system. Spelling is retrieve, not retreive. > Source/WebCore/platform/text/Localizer.cpp:227 > + return builder.toString(); Same “create a new string every time” question. 735392 6 tkent 2012-10-04 23:25:05 -0700 (In reply to comment #5) > (From update of attachment 166805 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166805&action=review > > > Source/WebCore/platform/text/Localizer.cpp:210 > > +String Localizer::dateTimeFormatWithSecond() > > Should be “with seconds” rather than “with second” > > > Source/WebCore/platform/text/Localizer.cpp:212 > > + // FIXME: We should retreive the separator and the order from the system. > > Spelling is retrieve, not retreive. > > > Source/WebCore/platform/text/Localizer.cpp:217 > > + return builder.toString(); > > Seems inefficient to create a new string every time. Other functions in this class have caching to avoid recomputing strings. Is the performance of this going to be OK? > > > Source/WebCore/platform/text/Localizer.cpp:220 > > +String Localizer::dateTimeFormatWithoutSecond() > > Should be “without seconds” rather than “with second” > > > Source/WebCore/platform/text/Localizer.cpp:222 > > + // FIXME: We should retreive the separator and the order from the system. > > Spelling is retrieve, not retreive. > > > Source/WebCore/platform/text/Localizer.cpp:227 > > + return builder.toString(); > > Same “create a new string every time” question. Thank you for the comments. I filed Bug 98485 and uploaded a patch. 166805 2012-10-02 21:28:07 -0700 2012-10-03 09:10:27 -0700 Patch bug-98229-20121003132719.patch text/plain 6793 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU0ZmE5NjQ4ZTFiYTYx NjRhYmM1YTgxMDdkNzlmMTVkMzExODU5Zi4uNGJhZGU3NDdhMjNmZmZhYjE3MDBlNWM0NjI5NDU2 M2IxNjMyZDA2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTEwLTAzICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnRyb2R1Y2UgTG9jYWxp emVyOjpkYXRlVGltZUZvcm1hdFdpdGhTZWNvbmQgYW5kIGRhdGVUaW1lRm9ybWF0V2l0aG91dFNl Y29uZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgy MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbmlm eSBpZGVudGljYWwgY29kZSBpbiBEYXRlVGltZUlucHV0VHlwZSBhbmQgRGF0ZVRpbWVMb2NhbElu cHV0VHlwZSBhcworICAgICAgICBMb2NhbGl6ZXIgbWVtYmVyIGZ1bmN0aW9ucy4KKyAgICAgICAg VGhleSBzdGlsbCBoYXZlIHNvbWUgY29tbW9uIGNvZGUuIFdlJ2xsIGFkZHJlc3MgaXQgbGF0ZXIu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIGRvZXNuJ3QgY2hhbmdlIGFueSBiZWhhdmlv ci4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxpemVyLmg6CisgICAgICAgIChMb2Nh bGl6ZXIpOiBBZGQgZGF0ZVRpbWVGb3JtYXRXaXRoU2Vjb25kIGFuZCBkYXRlVGltZUZvcm1hdFdp dGhvdXRTZWNvbmQuCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TG9jYWxpemVyOjpkYXRlVGltZUZvcm1hdFdpdGhTZWNvbmQpOgorICAg ICAgICBJbXBsZW1lbnRlZC4gSnVzdCBjb25jYXRlbmF0aW5nIGRhdGVGb3JtYXQsIGEgc3BhY2Us IGFuZCB0aW1lRm9ybWF0LgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxpemVyOjpkYXRlVGltZUZv cm1hdFdpdGhvdXRTZWNvbmQpOgorICAgICAgICBJbXBsZW1lbnRlZC4gSnVzdCBjb25jYXRlbmF0 aW5nIGRhdGVGb3JtYXQsIGEgc3BhY2UsIGFuZCBzaG9ydFRpbWVGb3JtYXQuCisKKyAgICAgICAg KiBodG1sL0RhdGVUaW1lSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1l SW5wdXRUeXBlOjpzZXR1cExheW91dFBhcmFtZXRlcnMpOgorICAgICAgICBVc2UgZGF0ZVRpbWVG b3JtYXRXaXRoU2Vjb25kIGFuZCBkYXRlVGltZUZvcm1hdFdpdGhvdXRTZWNvbmQuCisgICAgICAg ICogaHRtbC9EYXRlVGltZUxvY2FsSW5wdXRUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRh dGVUaW1lTG9jYWxJbnB1dFR5cGU6OnNldHVwTGF5b3V0UGFyYW1ldGVycyk6IGRpdHRvLgorCiAy MDEyLTEwLTAyICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJ bXBsZW1lbnQgTG9jYWxlSUNVOjpkYXRlRm9ybWF0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0RhdGVUaW1lSW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZVRp bWVJbnB1dFR5cGUuY3BwCmluZGV4IDM3MGMyNzVhYTExZDVhNmJkMGEwZDMxMDA1N2YxZTBkMDY0 M2QyMmEuLmI5OWE1ODBmYmM5ZGYzZGQwMzcwN2YyNjZkMDM2OGY5NDM3MjAxM2IgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZVRpbWVJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvRGF0ZVRpbWVJbnB1dFR5cGUuY3BwCkBAIC0xNDUsMjAgKzE0NSwxMyBA QCBTdHJpbmcgRGF0ZVRpbWVJbnB1dFR5cGU6OmZvcm1hdERhdGVUaW1lRmllbGRzU3RhdGUoY29u c3QgRGF0ZVRpbWVGaWVsZHNTdGF0ZSYgZAogCiB2b2lkIERhdGVUaW1lSW5wdXRUeXBlOjpzZXR1 cExheW91dFBhcmFtZXRlcnMoRGF0ZVRpbWVFZGl0RWxlbWVudDo6TGF5b3V0UGFyYW1ldGVycyYg bGF5b3V0UGFyYW1ldGVycywgY29uc3QgRGF0ZUNvbXBvbmVudHMmIGRhdGUpIGNvbnN0CiB7Ci0g ICAgLy8gRklYTUU6IEl0IGlzIGJldHRlciB0byBoYXZlIExvY2FsaXplcjo6ZGF0ZVRpbWVGb3Jt YXQoKSBhbmQgdXNlIGl0Ci0gICAgLy8gaGVyZSByYXRoZXIgdGhhbiBjb25zdHJ1Y3RpbmcgZnJv bSBkYXRlRm9ybWF0KCkgYW5kIHRpbWVGb3JtYXQoKS4KLSAgICBTdHJpbmdCdWlsZGVyIGJ1aWxk ZXI7Ci0gICAgYnVpbGRlci5hcHBlbmQobGF5b3V0UGFyYW1ldGVycy5sb2NhbGl6ZXIuZGF0ZUZv cm1hdCgpKTsKLSAgICBidWlsZGVyLmFwcGVuZCgnICcpOwogICAgIGlmIChkYXRlLnNlY29uZCgp IHx8IGxheW91dFBhcmFtZXRlcnMuc2hvdWxkSGF2ZVNlY29uZEZpZWxkKCkpIHsKLSAgICAgICAg YnVpbGRlci5hcHBlbmQobGF5b3V0UGFyYW1ldGVycy5sb2NhbGl6ZXIudGltZUZvcm1hdCgpKTsK KyAgICAgICAgbGF5b3V0UGFyYW1ldGVycy5kYXRlVGltZUZvcm1hdCA9IGxheW91dFBhcmFtZXRl cnMubG9jYWxpemVyLmRhdGVUaW1lRm9ybWF0V2l0aFNlY29uZCgpOwogICAgICAgICBsYXlvdXRQ YXJhbWV0ZXJzLmZhbGxiYWNrRGF0ZVRpbWVGb3JtYXQgPSAiZGQvTU0veXl5eSBISDptbTpzcyI7 CiAgICAgfSBlbHNlIHsKLSAgICAgICAgYnVpbGRlci5hcHBlbmQobGF5b3V0UGFyYW1ldGVycy5s b2NhbGl6ZXIuc2hvcnRUaW1lRm9ybWF0KCkpOworICAgICAgICBsYXlvdXRQYXJhbWV0ZXJzLmRh dGVUaW1lRm9ybWF0ID0gbGF5b3V0UGFyYW1ldGVycy5sb2NhbGl6ZXIuZGF0ZVRpbWVGb3JtYXRX aXRob3V0U2Vjb25kKCk7CiAgICAgICAgIGxheW91dFBhcmFtZXRlcnMuZmFsbGJhY2tEYXRlVGlt ZUZvcm1hdCA9ICJkZC9NTS95eXl5IEhIOm1tIjsKICAgICB9Ci0KLSAgICBsYXlvdXRQYXJhbWV0 ZXJzLmRhdGVUaW1lRm9ybWF0ID0gYnVpbGRlci50b1N0cmluZygpOwogICAgIGxheW91dFBhcmFt ZXRlcnMucGxhY2Vob2xkZXJGb3JEYXkgPSBwbGFjZWhvbGRlckZvckRheU9mTW9udGhGaWVsZCgp OwogICAgIGxheW91dFBhcmFtZXRlcnMucGxhY2Vob2xkZXJGb3JNb250aCA9IHBsYWNlaG9sZGVy Rm9yTW9udGhGaWVsZCgpOwogICAgIGxheW91dFBhcmFtZXRlcnMucGxhY2Vob2xkZXJGb3JZZWFy ID0gcGxhY2Vob2xkZXJGb3JZZWFyRmllbGQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvRGF0ZVRpbWVMb2NhbElucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0Rh dGVUaW1lTG9jYWxJbnB1dFR5cGUuY3BwCmluZGV4IDQxNmMxYzlmOWIzZmRmNDNhODM0NmVkOGNk YjI0NjA1NWNiZTM4M2MuLmUyM2VmODE4Mzc2MzYwZmJmNjY1ODU5MTFhMTQ4NjVmYjU4ZGJmNjYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZVRpbWVMb2NhbElucHV0VHlwZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9EYXRlVGltZUxvY2FsSW5wdXRUeXBlLmNwcApA QCAtMTUxLDIwICsxNTEsMTMgQEAgU3RyaW5nIERhdGVUaW1lTG9jYWxJbnB1dFR5cGU6OmZvcm1h dERhdGVUaW1lRmllbGRzU3RhdGUoY29uc3QgRGF0ZVRpbWVGaWVsZHNTdGEKIAogdm9pZCBEYXRl VGltZUxvY2FsSW5wdXRUeXBlOjpzZXR1cExheW91dFBhcmFtZXRlcnMoRGF0ZVRpbWVFZGl0RWxl bWVudDo6TGF5b3V0UGFyYW1ldGVycyYgbGF5b3V0UGFyYW1ldGVycywgY29uc3QgRGF0ZUNvbXBv bmVudHMmIGRhdGUpIGNvbnN0CiB7Ci0gICAgLy8gRklYTUU6IEl0IGlzIGJldHRlciB0byBoYXZl IExvY2FsaXplcjo6ZGF0ZVRpbWVGb3JtYXQoKSBhbmQgdXNlIGl0Ci0gICAgLy8gaGVyZSByYXRo ZXIgdGhhbiBjb25zdHJ1Y3RpbmcgZnJvbSBkYXRlRm9ybWF0KCkgYW5kIHRpbWVGb3JtYXQoKS4K LSAgICBTdHJpbmdCdWlsZGVyIGJ1aWxkZXI7Ci0gICAgYnVpbGRlci5hcHBlbmQobGF5b3V0UGFy YW1ldGVycy5sb2NhbGl6ZXIuZGF0ZUZvcm1hdCgpKTsKLSAgICBidWlsZGVyLmFwcGVuZCgnICcp OwogICAgIGlmIChkYXRlLnNlY29uZCgpIHx8IGxheW91dFBhcmFtZXRlcnMuc2hvdWxkSGF2ZVNl Y29uZEZpZWxkKCkpIHsKLSAgICAgICAgYnVpbGRlci5hcHBlbmQobGF5b3V0UGFyYW1ldGVycy5s b2NhbGl6ZXIudGltZUZvcm1hdCgpKTsKKyAgICAgICAgbGF5b3V0UGFyYW1ldGVycy5kYXRlVGlt ZUZvcm1hdCA9IGxheW91dFBhcmFtZXRlcnMubG9jYWxpemVyLmRhdGVUaW1lRm9ybWF0V2l0aFNl Y29uZCgpOwogICAgICAgICBsYXlvdXRQYXJhbWV0ZXJzLmZhbGxiYWNrRGF0ZVRpbWVGb3JtYXQg PSAiZGQvTU0veXl5eSBISDptbTpzcyI7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgYnVpbGRlci5h cHBlbmQobGF5b3V0UGFyYW1ldGVycy5sb2NhbGl6ZXIuc2hvcnRUaW1lRm9ybWF0KCkpOworICAg ICAgICBsYXlvdXRQYXJhbWV0ZXJzLmRhdGVUaW1lRm9ybWF0ID0gbGF5b3V0UGFyYW1ldGVycy5s b2NhbGl6ZXIuZGF0ZVRpbWVGb3JtYXRXaXRob3V0U2Vjb25kKCk7CiAgICAgICAgIGxheW91dFBh cmFtZXRlcnMuZmFsbGJhY2tEYXRlVGltZUZvcm1hdCA9ICJkZC9NTS95eXl5IEhIOm1tIjsKICAg ICB9Ci0KLSAgICBsYXlvdXRQYXJhbWV0ZXJzLmRhdGVUaW1lRm9ybWF0ID0gYnVpbGRlci50b1N0 cmluZygpOwogICAgIGxheW91dFBhcmFtZXRlcnMucGxhY2Vob2xkZXJGb3JEYXkgPSBwbGFjZWhv bGRlckZvckRheU9mTW9udGhGaWVsZCgpOwogICAgIGxheW91dFBhcmFtZXRlcnMucGxhY2Vob2xk ZXJGb3JNb250aCA9IHBsYWNlaG9sZGVyRm9yTW9udGhGaWVsZCgpOwogICAgIGxheW91dFBhcmFt ZXRlcnMucGxhY2Vob2xkZXJGb3JZZWFyID0gcGxhY2Vob2xkZXJGb3JZZWFyRmllbGQoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVyLmNwcAppbmRleCBkMjU3NWIyNTc4 N2NlNDFlNTU2NmQ5NWE5NTFiYWQwZWI4YTUxYTU2Li42Yzk1N2U1NTM5ZWUyMDA3YWQ3MmI4YTQ0 OTQ3MmYxYzJmZDdmM2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0xvY2FsaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGl6 ZXIuY3BwCkBAIC0yMDcsNiArMjA3LDI2IEBAIFN0cmluZyBMb2NhbGl6ZXI6OnNob3J0VGltZUZv cm1hdCgpCiAgICAgcmV0dXJuIG1fbG9jYWxpemVkU2hvcnRUaW1lRm9ybWF0VGV4dDsKIH0KIAor U3RyaW5nIExvY2FsaXplcjo6ZGF0ZVRpbWVGb3JtYXRXaXRoU2Vjb25kKCkKK3sKKyAgICAvLyBG SVhNRTogV2Ugc2hvdWxkIHJldHJlaXZlIHRoZSBzZXBhcmF0b3IgYW5kIHRoZSBvcmRlciBmcm9t IHRoZSBzeXN0ZW0uCisgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOworICAgIGJ1aWxkZXIuYXBw ZW5kKGRhdGVGb3JtYXQoKSk7CisgICAgYnVpbGRlci5hcHBlbmQoJyAnKTsKKyAgICBidWlsZGVy LmFwcGVuZCh0aW1lRm9ybWF0KCkpOworICAgIHJldHVybiBidWlsZGVyLnRvU3RyaW5nKCk7Cit9 CisKK1N0cmluZyBMb2NhbGl6ZXI6OmRhdGVUaW1lRm9ybWF0V2l0aG91dFNlY29uZCgpCit7Cisg ICAgLy8gRklYTUU6IFdlIHNob3VsZCByZXRyZWl2ZSB0aGUgc2VwYXJhdG9yIGFuZCB0aGUgb3Jk ZXIgZnJvbSB0aGUgc3lzdGVtLgorICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICBidWls ZGVyLmFwcGVuZChkYXRlRm9ybWF0KCkpOworICAgIGJ1aWxkZXIuYXBwZW5kKCcgJyk7CisgICAg YnVpbGRlci5hcHBlbmQoc2hvcnRUaW1lRm9ybWF0KCkpOworICAgIHJldHVybiBidWlsZGVyLnRv U3RyaW5nKCk7Cit9CisKIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBMb2NhbGl6ZXI6OnRpbWVBTVBN TGFiZWxzKCkKIHsKICAgICBpZiAoIW1fdGltZUFNUE1MYWJlbHMuaXNFbXB0eSgpKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGl6ZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxpemVyLmgKaW5kZXggYjAxNWMyODllZGUxMzI2ODZm N2RmNGUyYmJmM2M1ZmY1OTVjYjc2YS4uOWUxNGQ4MjQ0MDQ5MGI0OGYyZjRjZWZmMzRhNjQ1ZmE4 NzUzMTk2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGl6 ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsaXplci5oCkBAIC03 Miw2ICs3MiwxNCBAQCBwdWJsaWM6CiAgICAgLy8gTm90ZTogU29tZSBwbGF0Zm9ybXMgcmV0dXJu IHNhbWUgdmFsdWUgYXMgdGltZUZvcm1hdCgpLgogICAgIHZpcnR1YWwgU3RyaW5nIHNob3J0VGlt ZUZvcm1hdCgpOwogCisgICAgLy8gUmV0dXJucyBhIGRhdGUtdGltZSBmb3JtYXQgaW4gVW5pY29k ZSBUUjM1IExETUwuIEl0IHNob3VsZCBoYXZlIGEgc2Vjb25kCisgICAgLy8gZmllbGQuCisgICAg U3RyaW5nIGRhdGVUaW1lRm9ybWF0V2l0aFNlY29uZCgpOworCisgICAgLy8gUmV0dXJucyBhIGRh dGUtdGltZSBmb3JtYXQgaW4gVW5pY29kZSBUUjM1IExETUwuIEl0IHNob3VsZCBoYXZlIG5vIHNl Y29uZAorICAgIC8vIGZpZWxkLgorICAgIFN0cmluZyBkYXRlVGltZUZvcm1hdFdpdGhvdXRTZWNv bmQoKTsKKwogICAgIC8vIFJldHVybnMgbG9jYWxpemVkIHBlcmlvZCBmaWVsZChBTS9QTSkgc3Ry aW5ncy4KICAgICB2aXJ0dWFsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiB0aW1lQU1QTUxhYmVscygp OwogI2VuZGlmCg==