98214 2012-10-02 16:57:00 -0700 WebImage::framesFromData should skip corrupted frames 2012-10-03 02:48:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pkotwicz webkit-unassigned abarth pkotwicz thakis webkit.review.bot oldest_to_newest 733228 0 pkotwicz 2012-10-02 16:57:00 -0700 WebImage::framesFromData should skip corrupted frames 733231 1 166780 pkotwicz 2012-10-02 17:01:17 -0700 Created attachment 166780 Patch 733235 2 webkit.review.bot 2012-10-02 17:04:50 -0700 Attachment 166780 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 733237 3 166781 pkotwicz 2012-10-02 17:08:38 -0700 Created attachment 166781 Patch 733326 4 thakis 2012-10-02 20:19:17 -0700 lgtm, but I'm not a reviewer. 733484 5 166781 abarth 2012-10-03 02:28:04 -0700 Comment on attachment 166781 Patch ok 733503 6 166781 webkit.review.bot 2012-10-03 02:48:28 -0700 Comment on attachment 166781 Patch Clearing flags on attachment: 166781 Committed r130268: <http://trac.webkit.org/changeset/130268> 733504 7 webkit.review.bot 2012-10-03 02:48:31 -0700 All reviewed patches have been landed. Closing bug. 166780 2012-10-02 17:01:17 -0700 2012-10-02 17:08:34 -0700 Patch bug-98214-20121002200030.patch text/plain 2762 pkotwicz U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRiMDUwYzI4YTJmY2E2YTdlOThlZjBkYTYwZjdhOWIxYTg3MTRhNGMuLmZhZWM5MjE2ZWJhZmYw YmNlZTk3MjQ0MmIxNGUxZDhmYWU2NzdmZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTAtMDIgIFBldGVyIEtvdHdpY3ogIDxwa290d2ljekBnb29n bGUuY29tPgorCisgICAgICAgIFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0YSBzaG91bGQgc2tpcCBj b3JydXB0ZWQgZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODIxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0YSgpIHNob3VsZCBvbmx5IHJldHVybiBiaXRt YXBzIGZvciB2YWxpZCBmcmFtZXMKKwlvZiBhIC5pY28gZmlsZS4KKworICAgICAgICAqIHNyYy9X ZWJJbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbWFnZTo6ZnJhbWVzRnJvbURh dGEpOgorICAgICAgICAqIHRlc3RzL1dlYkltYWdlVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlRFU1QpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiB0ZXN0cy9kYXRhL3ZhbGlkX2hl YWRlcl9taXNzaW5nX2JpdG1hcC5pY286IEFkZGVkLgorCiAyMDEyLTEwLTAyICBTYWRydWwgSGFi aWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1d IE1ha2Ugc3VyZSB0aGUgdG91Y2gtcG9pbnRzIGluIHRoZSB0b3VjaC1ldmVudHMgaGF2ZSB0aGUg Y29ycmVjdCBzdGF0ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkltYWdlU2tpYS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbWFnZVNraWEu Y3BwCmluZGV4IDAxOThhNjgwNjJkYWY4ODE1OTc3Y2FiOTkyZDU3YWViOGVmZmYwMDUuLjljMzMz NDVmNzM4M2JjNWJhOTRlMzE5YTI3MWFmYTZmODY3N2ExZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlU2tpYS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViSW1hZ2VTa2lhLmNwcApAQCAtMTI1LDcgKzEyNSw3IEBAIFdlYlZlY3Rv cjxXZWJJbWFnZT4gV2ViSW1hZ2U6OmZyYW1lc0Zyb21EYXRhKGNvbnN0IFdlYkRhdGEmIGRhdGEp CiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBPd25QdHI8TmF0aXZlSW1hZ2VTa2lh PiBpbWFnZSA9IGFkb3B0UHRyKGZyYW1lLT5hc05ld05hdGl2ZUltYWdlKCkpOwotICAgICAgICBp ZiAoaW1hZ2UuZ2V0KCkpCisgICAgICAgIGlmIChpbWFnZS5nZXQoKSAmJiBpbWFnZS0+aXNEYXRh Q29tcGxldGUoKSkKICAgICAgICAgICAgIGZyYW1lcy5hcHBlbmQoV2ViSW1hZ2UoaW1hZ2UtPmJp dG1hcCgpKSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL1dlYkltYWdlVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYklt YWdlVGVzdC5jcHAKaW5kZXggZjk2ODE3NmNmNjk2N2MzYTcyNTYzN2U5MzY4Yjk4MTQ0ZTUyNzcw YS4uMmY0NGUzNGIzMmJmMTY0OGRlNGI0OGYyODM2NTcyNDRkYmNlNzEyZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9XZWJJbWFnZVRlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViSW1hZ2VUZXN0LmNwcApAQCAtODgsNiArODgsMTUg QEAgVEVTVChXZWJJbWFnZVRlc3QsIElDT0ltYWdlKQogICAgIEVYUEVDVF9FUShTa0NvbG9yU2V0 QVJHQigyNTUsIDAsIDAsIDApLCBpbWFnZXNbMV0uZ2V0U2tCaXRtYXAoKS5nZXRDb2xvcigwLCAw KSk7CiB9CiAKK1RFU1QoV2ViSW1hZ2VUZXN0LCBJQ09WYWxpZEhlYWRlck1pc3NpbmdCaXRtYXAp Cit7CisgICAgUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gZGF0YSA9IHJlYWRGaWxlKCJ2YWxpZF9oZWFk ZXJfbWlzc2luZ19iaXRtYXAuaWNvIik7CisgICAgQVNTRVJUX1RSVUUoZGF0YS5nZXQoKSk7CisK KyAgICBXZWJWZWN0b3I8V2ViSW1hZ2U+IGltYWdlcyA9IFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0 YShXZWJEYXRhKGRhdGEpKTsKKyAgICBBU1NFUlRfVFJVRShpbWFnZXMuaXNFbXB0eSgpKTsKK30K KwogVEVTVChXZWJJbWFnZVRlc3QsIEJhZEltYWdlKQogewogICAgIGNvbnN0IGNoYXIgYmFkSW1h Z2VbXSA9ICJoZWxsbyB3b3JsZCI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL2RhdGEvdmFsaWRfaGVhZGVyX21pc3NpbmdfYml0bWFwLmljbyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vdGVzdHMvZGF0YS92YWxpZF9oZWFkZXJfbWlzc2luZ19iaXRtYXAuaWNvCm5l dyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjVlNGNmY2VjNWNkM2Y1NDhjYTcyYTM0YmFmY2ZkMWI0ZDEyOWFjZGUKR0lUIGJp bmFyeSBwYXRjaApsaXRlcmFsIDIzClpjbVpRelU8NSh8MFJ8dllWOH4hJFVAIXgreEJ2KWAwUGc/ KgoKbGl0ZXJhbCAwCkhjbVY/ZDAwMDAxCgo= 166781 2012-10-02 17:08:38 -0700 2012-10-03 02:48:28 -0700 Patch bug-98214-20121002200751.patch text/plain 2769 pkotwicz U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRiMDUwYzI4YTJmY2E2YTdlOThlZjBkYTYwZjdhOWIxYTg3MTRhNGMuLjNlNjFiYzI2YjdiMzM4 YTc4ZjhkMTY4MTRhODNmODUwMmRmNTFiYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTAtMDIgIFBldGVyIEtvdHdpY3ogIDxwa290d2ljekBnb29n bGUuY29tPgorCisgICAgICAgIFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0YSBzaG91bGQgc2tpcCBj b3JydXB0ZWQgZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODIxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0YSgpIHNob3VsZCBvbmx5IHJldHVybiBiaXRt YXBzIGZvciB2YWxpZCBmcmFtZXMKKyAgICAgICAgb2YgYSAuaWNvIGZpbGUuCisKKyAgICAgICAg KiBzcmMvV2ViSW1hZ2VTa2lhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW1hZ2U6OmZyYW1l c0Zyb21EYXRhKToKKyAgICAgICAgKiB0ZXN0cy9XZWJJbWFnZVRlc3QuY3BwOgorICAgICAgICAo V2ViS2l0OjpURVNUKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogdGVzdHMvZGF0YS92 YWxpZF9oZWFkZXJfbWlzc2luZ19iaXRtYXAuaWNvOiBBZGRlZC4KKwogMjAxMi0xMC0wMiAgU2Fk cnVsIEhhYmliIENob3dkaHVyeSAgPHNhZHJ1bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBNYWtlIHN1cmUgdGhlIHRvdWNoLXBvaW50cyBpbiB0aGUgdG91Y2gtZXZlbnRzIGhh dmUgdGhlIGNvcnJlY3Qgc3RhdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJJbWFnZVNraWEuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW1h Z2VTa2lhLmNwcAppbmRleCAwMTk4YTY4MDYyZGFmODgxNTk3N2NhYjk5MmQ1N2FlYjhlZmZmMDA1 Li45YzMzMzQ1ZjczODNiYzViYTk0ZTMxOWEyNzFhZmE2Zjg2NzdhMWQ3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbWFnZVNraWEuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkltYWdlU2tpYS5jcHAKQEAgLTEyNSw3ICsxMjUsNyBAQCBX ZWJWZWN0b3I8V2ViSW1hZ2U+IFdlYkltYWdlOjpmcmFtZXNGcm9tRGF0YShjb25zdCBXZWJEYXRh JiBkYXRhKQogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgT3duUHRyPE5hdGl2ZUlt YWdlU2tpYT4gaW1hZ2UgPSBhZG9wdFB0cihmcmFtZS0+YXNOZXdOYXRpdmVJbWFnZSgpKTsKLSAg ICAgICAgaWYgKGltYWdlLmdldCgpKQorICAgICAgICBpZiAoaW1hZ2UuZ2V0KCkgJiYgaW1hZ2Ut PmlzRGF0YUNvbXBsZXRlKCkpCiAgICAgICAgICAgICBmcmFtZXMuYXBwZW5kKFdlYkltYWdlKGlt YWdlLT5iaXRtYXAoKSkpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9XZWJJbWFnZVRlc3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9XZWJJbWFnZVRlc3QuY3BwCmluZGV4IGY5NjgxNzZjZjY5NjdjM2E3MjU2MzdlOTM2OGI5ODE0 NGU1Mjc3MGEuLjJmNDRlMzRiMzJiZjE2NDhkZTRiNDhmMjgzNjU3MjQ0ZGJjZTcxMmUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViSW1hZ2VUZXN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYkltYWdlVGVzdC5jcHAKQEAgLTg4LDYg Kzg4LDE1IEBAIFRFU1QoV2ViSW1hZ2VUZXN0LCBJQ09JbWFnZSkKICAgICBFWFBFQ1RfRVEoU2tD b2xvclNldEFSR0IoMjU1LCAwLCAwLCAwKSwgaW1hZ2VzWzFdLmdldFNrQml0bWFwKCkuZ2V0Q29s b3IoMCwgMCkpOwogfQogCitURVNUKFdlYkltYWdlVGVzdCwgSUNPVmFsaWRIZWFkZXJNaXNzaW5n Qml0bWFwKQoreworICAgIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGRhdGEgPSByZWFkRmlsZSgidmFs aWRfaGVhZGVyX21pc3NpbmdfYml0bWFwLmljbyIpOworICAgIEFTU0VSVF9UUlVFKGRhdGEuZ2V0 KCkpOworCisgICAgV2ViVmVjdG9yPFdlYkltYWdlPiBpbWFnZXMgPSBXZWJJbWFnZTo6ZnJhbWVz RnJvbURhdGEoV2ViRGF0YShkYXRhKSk7CisgICAgQVNTRVJUX1RSVUUoaW1hZ2VzLmlzRW1wdHko KSk7Cit9CisKIFRFU1QoV2ViSW1hZ2VUZXN0LCBCYWRJbWFnZSkKIHsKICAgICBjb25zdCBjaGFy IGJhZEltYWdlW10gPSAiaGVsbG8gd29ybGQiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9kYXRhL3ZhbGlkX2hlYWRlcl9taXNzaW5nX2JpdG1hcC5pY28gYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL2RhdGEvdmFsaWRfaGVhZGVyX21pc3NpbmdfYml0bWFw LmljbwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi41ZTRjZmNlYzVjZDNmNTQ4Y2E3MmEzNGJhZmNmZDFiNGQxMjlhY2Rl CkdJVCBiaW5hcnkgcGF0Y2gKbGl0ZXJhbCAyMwpaY21aUXpVPDUofDBSfHZZVjh+ISRVQCF4K3hC dilgMFBnPyoKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoK