98211 2012-10-02 16:36:47 -0700 Do not swallow fatal messages in qt/DumpRenderTree 2012-10-08 16:33:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned ossy vsevik webkit.review.bot oldest_to_newest 733206 0 prybin 2012-10-02 16:36:47 -0700 Qt version of DumpRenderTree installs qt message handler that swallows fatal messages. Those messages might be highly valuable for basic troubleshooting. 733227 1 166778 prybin 2012-10-02 16:56:46 -0700 Created attachment 166778 Patch 733775 2 vsevik 2012-10-03 09:27:09 -0700 Ossy, could you please have a look? 733794 3 166913 prybin 2012-10-03 09:50:22 -0700 Created attachment 166913 Patch 737178 4 166913 eric 2012-10-08 16:13:35 -0700 Comment on attachment 166913 Patch rs=me. 737212 5 166913 webkit.review.bot 2012-10-08 16:33:51 -0700 Comment on attachment 166913 Patch Clearing flags on attachment: 166913 Committed r130703: <http://trac.webkit.org/changeset/130703> 737213 6 webkit.review.bot 2012-10-08 16:33:53 -0700 All reviewed patches have been landed. Closing bug. 166778 2012-10-02 16:56:46 -0700 2012-10-03 09:50:16 -0700 Patch bug-98211-20121003035558.patch text/plain 1246 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NDk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmQ1OGIxODVkNzdlZjE5YjliMmY1Zjk0NDhiNWFiYzg5 YzQxYjA2YS4uMDVjNmY3OWY0MWQxYjA0NTljY2E1YzY5OTYwMTAxYzI2NWQ3YjFhNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTAyICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKwor ICAgICAgICBEbyBub3Qgc3dhbGxvdyBmYXRhbCBtZXNzYWdlcyBpbiBxdC9EdW1wUmVuZGVyVHJl ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgyMTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29u ZGl0aW9uIGluIG1lc3NhZ2UgdHlwZSBmaWx0ZXJpbmcuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9xdC9EdW1wUmVuZGVyVHJlZU1haW4uY3BwOgorICAgICAgICAobWVzc2FnZUhhbmRsZXIp OgorCiAyMDEyLTA5LTI1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEu Y29zdGFAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIERvIG5vdCBkdW1wIGluc3BlY3RvciBv dXRwdXQgaW4gRFJUCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVu ZGVyVHJlZU1haW4uY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVN YWluLmNwcAppbmRleCBmNWU3ZmMxNTllMDFlZjEwZDc2NzgzMGUyZWI5OTZjOWNkODkzOWU5Li4x M2RlY2JiNzFkNDM1ZGNkZDA0NWI5ZTQ2NmQzYTI3ZWRhZGZkNzMxIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZU1haW4uY3BwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlTWFpbi5jcHAKQEAgLTU5LDcgKzU5LDcgQEAK IAogdm9pZCBtZXNzYWdlSGFuZGxlcihRdE1zZ1R5cGUgdHlwZSwgY29uc3QgY2hhciAqbWVzc2Fn ZSkKIHsKLSAgICBpZiAodHlwZSA9PSBRdENyaXRpY2FsTXNnKSB7CisgICAgaWYgKHR5cGUgPT0g UXRDcml0aWNhbE1zZyB8fCB0eXBlID09IFF0RmF0YWxNc2cpIHsKICAgICAgICAgZnByaW50Zihz dGRlcnIsICIlc1xuIiwgbWVzc2FnZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg== 166913 2012-10-03 09:50:22 -0700 2012-10-08 16:33:50 -0700 Patch bug-98211-20121003204933.patch text/plain 1254 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMjk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWQxYTc4NzZlNGNmNWJjNTI4ODNlMDM5ZWM5YTJhNTMz MTkwZjVjZC4uYTAwMjlkZGYzZDRlODI0ZGJlYzY1YTcxZDU2N2I5Y2YzZWZkZjdhMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTAyICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KKwor ICAgICAgICBEbyBub3Qgc3dhbGxvdyBmYXRhbCBtZXNzYWdlcyBpbiBxdC9EdW1wUmVuZGVyVHJl ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgyMTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29u ZGl0aW9uIGluIG1lc3NhZ2UgdHlwZSBmaWx0ZXJpbmcuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9xdC9EdW1wUmVuZGVyVHJlZU1haW4uY3BwOgorICAgICAgICAobWVzc2FnZUhhbmRsZXIp OgorCiAyMDEyLTEwLTAzICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBbUXRdIEVuYWJsZSBtb2NrIHNjcm9sbGJhcnMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlTWFpbi5jcHAgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9xdC9EdW1wUmVuZGVyVHJlZU1haW4uY3BwCmluZGV4IDFiYWFlN2NiOGUxYTQ2MTFhMjU3 ZjhiZmI3N2NkYjg0NWZhOTYwZGMuLjI2MDM2MDE0MmI4NjBkMzViMzI1MjBhNTQxM2RmOWNhYjhk MmM5ZTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVl TWFpbi5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVNYWlu LmNwcApAQCAtNTksNyArNTksNyBAQAogCiB2b2lkIG1lc3NhZ2VIYW5kbGVyKFF0TXNnVHlwZSB0 eXBlLCBjb25zdCBRTWVzc2FnZUxvZ0NvbnRleHQmLCBjb25zdCBRU3RyaW5nICZtZXNzYWdlKQog ewotICAgIGlmICh0eXBlID09IFF0Q3JpdGljYWxNc2cpIHsKKyAgICBpZiAodHlwZSA9PSBRdENy aXRpY2FsTXNnIHx8IHR5cGUgPT0gUXRGYXRhbE1zZykgewogICAgICAgICBmcHJpbnRmKHN0ZGVy ciwgIiVzXG4iLCBxUHJpbnRhYmxlKG1lc3NhZ2UpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K