98207 2012-10-02 15:42:07 -0700 treeScopeOfParent doesn't return the TreeScope of the parent 2012-10-18 06:22:45 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni morrita cmarcelo dglazkov hayato morrita rniwa shinyak webkit.review.bot oldest_to_newest 733153 0 dmazzoni 2012-10-02 15:42:07 -0700 I think it should say "return parent->treeScope()", right? Looks like this should be better covered by tests. static inline TreeScope* treeScopeOfParent(Node* node, ContainerNode* insertionPoint) { if (Node* parent = node->parentNode()) parent->treeScope(); return insertionPoint->treeScope(); } 745036 1 169358 hayato 2012-10-18 00:21:41 -0700 Created attachment 169358 Refactor. 745041 2 169358 webkit.review.bot 2012-10-18 00:35:55 -0700 Comment on attachment 169358 Refactor. Rejecting attachment 169358 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14384890 745067 3 169358 webkit.review.bot 2012-10-18 01:08:44 -0700 Comment on attachment 169358 Refactor. Attachment 169358 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14392954 New failing tests: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html 745098 4 169374 hayato 2012-10-18 02:22:59 -0700 Created attachment 169374 Patch for landing 745161 5 169374 webkit.review.bot 2012-10-18 04:54:33 -0700 Comment on attachment 169374 Patch for landing Rejecting attachment 169374 from commit-queue. New failing tests: fast/dom/shadow/get-element-by-id-in-shadow-mutation.html Full output: http://queues.webkit.org/results/14459002 745190 6 169400 hayato 2012-10-18 06:02:55 -0700 Created attachment 169400 Patch for landing 745192 7 hayato 2012-10-18 06:04:42 -0700 Let me retry. I've removed a treeScopeOfParent(), which we don't need to call. (In reply to comment #6) > Created an attachment (id=169400) [details] > Patch for landing 745203 8 169400 webkit.review.bot 2012-10-18 06:22:41 -0700 Comment on attachment 169400 Patch for landing Clearing flags on attachment: 169400 Committed r131739: <http://trac.webkit.org/changeset/131739> 745204 9 webkit.review.bot 2012-10-18 06:22:45 -0700 All reviewed patches have been landed. Closing bug. 169358 2012-10-18 00:21:41 -0700 2012-10-18 02:22:56 -0700 Refactor. bug-98207-20121018162026.patch text/plain 2191 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRiNDJiM2QzZDY1ZmI4 YWJlYWYzNGY0NGVmZjE3YzZmOTg1N2RlNy4uZjZlNWQzM2U0OTgzMjdiZWMwOTViMGZhOGRhYmIw ZWUyMzg2ZWU2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICB0cmVlU2NvcGVPZlBhcmVu dCBkb2Vzbid0IHJldHVybiB0aGUgVHJlZVNjb3BlIG9mIHRoZSBwYXJlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjA3CisKKyAgICAgICAgQSBt aW5vciByZWZhY3RvcmluZyBmb3IgdHJlZVNjb3BlT2ZQYXJlbnQgZGVmaW5lZCBpbiBFbGVtZW50 LmNwcC4KKworICAgICAgICBObyB0ZXN0cyBuZWVkZWQsIHRoaXMgaXMganVzdCBhIHJlZmFjdG9y LgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dHJlZVNj b3BlT2YpOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlZEZyb20pOgorCiAyMDEy LTEwLTE3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRv IGZpeCB0aGUgYnVpbGQgYWZ0ZXIgcjEzMTcwMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA3 Y2JhNTFmMGRmOGMyMDRlZTY5NTc0NTkwNTg1NjdmNmJhMTFhNDc3Li44NmUyNzg2OWUzZTg5MWE3 NDFhNTM1YzAxN2RjMjg2MjZhMjc0OTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC05NjIs MTQgKzk2MiwxNCBAQCBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IEVsZW1lbnQ6 Omluc2VydGVkSW50byhDb250YWluZXJOb2RlKiBpbnNlcnRpbwogICAgIHJldHVybiBJbnNlcnRp b25Eb25lOwogfQogCi1zdGF0aWMgaW5saW5lIFRyZWVTY29wZSogdHJlZVNjb3BlT2ZQYXJlbnQo Tm9kZSogbm9kZSwgQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCitzdGF0aWMgaW5saW5l IFRyZWVTY29wZSogdHJlZVNjb3BlT2YoTm9kZSogcGFyZW50Tm9kZSwgQ29udGFpbmVyTm9kZSog ZmFsbGJhY2tJbnNlcnRpb25Qb2ludCkKIHsKLSAgICBpZiAoTm9kZSogcGFyZW50ID0gbm9kZS0+ cGFyZW50Tm9kZSgpKQotICAgICAgICBwYXJlbnQtPnRyZWVTY29wZSgpOwotICAgIHJldHVybiBp bnNlcnRpb25Qb2ludC0+dHJlZVNjb3BlKCk7CisgICAgaWYgKHBhcmVudE5vZGUpCisgICAgICAg IHJldHVybiBwYXJlbnROb2RlLT50cmVlU2NvcGUoKTsKKyAgICBBU1NFUlQoZmFsbGJhY2tJbnNl cnRpb25Qb2ludCk7CisgICAgcmV0dXJuIGZhbGxiYWNrSW5zZXJ0aW9uUG9pbnQtPnRyZWVTY29w ZSgpOwogfQogCi0KIHZvaWQgRWxlbWVudDo6cmVtb3ZlZEZyb20oQ29udGFpbmVyTm9kZSogaW5z ZXJ0aW9uUG9pbnQpCiB7CiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQpAQCAtOTg2LDcgKzk4 Niw3IEBAIHZvaWQgRWxlbWVudDo6cmVtb3ZlZEZyb20oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9u UG9pbnQpCiAgICAgaWYgKGluc2VydGlvblBvaW50LT5pbkRvY3VtZW50KCkpIHsKICAgICAgICAg Y29uc3QgQXRvbWljU3RyaW5nJiBpZFZhbHVlID0gZ2V0SWRBdHRyaWJ1dGUoKTsKICAgICAgICAg aWYgKCFpZFZhbHVlLmlzTnVsbCgpICYmIGluRG9jdW1lbnQoKSkKLSAgICAgICAgICAgIHVwZGF0 ZUlkKHRyZWVTY29wZU9mUGFyZW50KHRoaXMsIGluc2VydGlvblBvaW50KSwgaWRWYWx1ZSwgbnVs bEF0b20pOworICAgICAgICAgICAgdXBkYXRlSWQodHJlZVNjb3BlT2YodGhpcy0+cGFyZW50Tm9k ZSgpLCBpbnNlcnRpb25Qb2ludCksIGlkVmFsdWUsIG51bGxBdG9tKTsKIAogICAgICAgICBjb25z dCBBdG9taWNTdHJpbmcmIG5hbWVWYWx1ZSA9IGdldE5hbWVBdHRyaWJ1dGUoKTsKICAgICAgICAg aWYgKCFuYW1lVmFsdWUuaXNOdWxsKCkpCg== 169374 2012-10-18 02:22:59 -0700 2012-10-18 06:02:18 -0700 Patch for landing bug-98207-20121018182145.patch text/plain 2229 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRiNDJiM2QzZDY1ZmI4 YWJlYWYzNGY0NGVmZjE3YzZmOTg1N2RlNy4uMmQ1ZjdiNzk2ZTM2MzI0NTMxNjA4ODU0NmU1Yzg2 ODk3YzA3YzVkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTE4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICB0cmVlU2NvcGVPZlBhcmVu dCBkb2Vzbid0IHJldHVybiB0aGUgVHJlZVNjb3BlIG9mIHRoZSBwYXJlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgSGFqaW1lIE1vcml0YS4KKworICAgICAgICBBIG1pbm9yIHJlZmFjdG9yaW5nIGZv ciB0cmVlU2NvcGVPZlBhcmVudCBkZWZpbmVkIGluIEVsZW1lbnQuY3BwLgorCisgICAgICAgIE5v IHRlc3RzIG5lZWRlZCwgdGhpcyBpcyBqdXN0IGEgcmVmYWN0b3IuCisKKyAgICAgICAgKiBkb20v RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0cmVlU2NvcGVPZik6CisgICAgICAgIChX ZWJDb3JlOjpFbGVtZW50OjpyZW1vdmVkRnJvbSk6CisKIDIwMTItMTAtMTcgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBidWlsZCBhZnRl ciByMTMxNzAxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDdjYmE1MWYwZGY4YzIwNGVlNjk1 NzQ1OTA1ODU2N2Y2YmExMWE0NzcuLjg2ZTI3ODY5ZTNlODkxYTc0MWE1MzVjMDE3ZGMyODYyNmEy NzQ5NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAgLTk2MiwxNCArOTYyLDE0IEBAIE5vZGU6 Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgRWxlbWVudDo6aW5zZXJ0ZWRJbnRvKENvbnRh aW5lck5vZGUqIGluc2VydGlvCiAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7CiB9CiAKLXN0YXRp YyBpbmxpbmUgVHJlZVNjb3BlKiB0cmVlU2NvcGVPZlBhcmVudChOb2RlKiBub2RlLCBDb250YWlu ZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKK3N0YXRpYyBpbmxpbmUgVHJlZVNjb3BlKiB0cmVlU2Nv cGVPZihOb2RlKiBwYXJlbnROb2RlLCBDb250YWluZXJOb2RlKiBmYWxsYmFja0luc2VydGlvblBv aW50KQogewotICAgIGlmIChOb2RlKiBwYXJlbnQgPSBub2RlLT5wYXJlbnROb2RlKCkpCi0gICAg ICAgIHBhcmVudC0+dHJlZVNjb3BlKCk7Ci0gICAgcmV0dXJuIGluc2VydGlvblBvaW50LT50cmVl U2NvcGUoKTsKKyAgICBpZiAocGFyZW50Tm9kZSkKKyAgICAgICAgcmV0dXJuIHBhcmVudE5vZGUt PnRyZWVTY29wZSgpOworICAgIEFTU0VSVChmYWxsYmFja0luc2VydGlvblBvaW50KTsKKyAgICBy ZXR1cm4gZmFsbGJhY2tJbnNlcnRpb25Qb2ludC0+dHJlZVNjb3BlKCk7CiB9CiAKLQogdm9pZCBF bGVtZW50OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKIHsKICNp ZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCkBAIC05ODYsNyArOTg2LDcgQEAgdm9pZCBFbGVtZW50 OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKICAgICBpZiAoaW5z ZXJ0aW9uUG9pbnQtPmluRG9jdW1lbnQoKSkgewogICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcm IGlkVmFsdWUgPSBnZXRJZEF0dHJpYnV0ZSgpOwogICAgICAgICBpZiAoIWlkVmFsdWUuaXNOdWxs KCkgJiYgaW5Eb2N1bWVudCgpKQotICAgICAgICAgICAgdXBkYXRlSWQodHJlZVNjb3BlT2ZQYXJl bnQodGhpcywgaW5zZXJ0aW9uUG9pbnQpLCBpZFZhbHVlLCBudWxsQXRvbSk7CisgICAgICAgICAg ICB1cGRhdGVJZCh0cmVlU2NvcGVPZih0aGlzLT5wYXJlbnROb2RlKCksIGluc2VydGlvblBvaW50 KSwgaWRWYWx1ZSwgbnVsbEF0b20pOwogCiAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgbmFt ZVZhbHVlID0gZ2V0TmFtZUF0dHJpYnV0ZSgpOwogICAgICAgICBpZiAoIW5hbWVWYWx1ZS5pc051 bGwoKSkK 169400 2012-10-18 06:02:55 -0700 2012-10-18 06:22:41 -0700 Patch for landing bug-98207-20121018220140.patch text/plain 1927 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRiNDJiM2QzZDY1ZmI4 YWJlYWYzNGY0NGVmZjE3YzZmOTg1N2RlNy4uYjAwOTJiMjAwOWVkMWYxNDA5YWVjZDVmZTIwOTY1 ODY4MWViNWQ0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE4ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICB0cmVlU2NvcGVPZlBhcmVu dCBkb2Vzbid0IHJldHVybiB0aGUgVHJlZVNjb3BlIG9mIHRoZSBwYXJlbnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgSGFqaW1lIE1vcml0YS4KKworICAgICAgICBBIG1pbm9yIGNsZWFuIHVwLiBSZW1v dmUgdHJlZVNjb3BlT2ZQYXJlbnQoKSBpbiBFbGVtZW50LmNwcC4KKworICAgICAgICBObyB0ZXN0 cyBuZWVkZWQsIHRoaXMgaXMganVzdCBhIGNsZWFuIHVwLgorCisgICAgICAgICogZG9tL0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6cmVtb3ZlZEZyb20pOgorCiAyMDEy LTEwLTE3ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgVHJ5IHRv IGZpeCB0aGUgYnVpbGQgYWZ0ZXIgcjEzMTcwMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA3 Y2JhNTFmMGRmOGMyMDRlZTY5NTc0NTkwNTg1NjdmNmJhMTFhNDc3Li4yYWJjZWFlOWIzN2IyZjU4 MDUwOGQ5MDg5M2E3ZjQwNWUwNjI5ODIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC05NjIs MTQgKzk2Miw2IEBAIE5vZGU6Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgRWxlbWVudDo6 aW5zZXJ0ZWRJbnRvKENvbnRhaW5lck5vZGUqIGluc2VydGlvCiAgICAgcmV0dXJuIEluc2VydGlv bkRvbmU7CiB9CiAKLXN0YXRpYyBpbmxpbmUgVHJlZVNjb3BlKiB0cmVlU2NvcGVPZlBhcmVudChO b2RlKiBub2RlLCBDb250YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKLXsKLSAgICBpZiAoTm9k ZSogcGFyZW50ID0gbm9kZS0+cGFyZW50Tm9kZSgpKQotICAgICAgICBwYXJlbnQtPnRyZWVTY29w ZSgpOwotICAgIHJldHVybiBpbnNlcnRpb25Qb2ludC0+dHJlZVNjb3BlKCk7Ci19Ci0KLQogdm9p ZCBFbGVtZW50OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKIHsK ICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCkBAIC05ODYsNyArOTc4LDcgQEAgdm9pZCBFbGVt ZW50OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKICAgICBpZiAo aW5zZXJ0aW9uUG9pbnQtPmluRG9jdW1lbnQoKSkgewogICAgICAgICBjb25zdCBBdG9taWNTdHJp bmcmIGlkVmFsdWUgPSBnZXRJZEF0dHJpYnV0ZSgpOwogICAgICAgICBpZiAoIWlkVmFsdWUuaXNO dWxsKCkgJiYgaW5Eb2N1bWVudCgpKQotICAgICAgICAgICAgdXBkYXRlSWQodHJlZVNjb3BlT2ZQ YXJlbnQodGhpcywgaW5zZXJ0aW9uUG9pbnQpLCBpZFZhbHVlLCBudWxsQXRvbSk7CisgICAgICAg ICAgICB1cGRhdGVJZChpbnNlcnRpb25Qb2ludC0+dHJlZVNjb3BlKCksIGlkVmFsdWUsIG51bGxB dG9tKTsKIAogICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWVWYWx1ZSA9IGdldE5hbWVB dHRyaWJ1dGUoKTsKICAgICAgICAgaWYgKCFuYW1lVmFsdWUuaXNOdWxsKCkpCg==