98200 2012-10-02 14:21:59 -0700 [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference. 2012-10-03 02:52:51 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98083 1 rakuco rakuco hausmann kenneth ossy webkit.review.bot oldest_to_newest 733070 0 rakuco 2012-10-02 14:21:59 -0700 [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference. 733071 1 166750 rakuco 2012-10-02 14:23:18 -0700 Created attachment 166750 Patch 733077 2 rakuco 2012-10-02 14:25:07 -0700 Please note that I have not checked if those tests which were skipped before r130211 pass, I just trusted Ossy's description :-) 733495 3 166750 ossy 2012-10-03 02:44:18 -0700 Comment on attachment 166750 Patch LGTM, r=me. 733508 4 166750 webkit.review.bot 2012-10-03 02:52:47 -0700 Comment on attachment 166750 Patch Clearing flags on attachment: 166750 Committed r130271: <http://trac.webkit.org/changeset/130271> 733509 5 webkit.review.bot 2012-10-03 02:52:51 -0700 All reviewed patches have been landed. Closing bug. 166750 2012-10-02 14:23:18 -0700 2012-10-03 02:52:47 -0700 Patch bug-98200-20121003002049.patch text/plain 3140 rakuco SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDIxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTEwLTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1 Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFtRdF1bRFJUXSBBZGQgc3VwcG9ydCBm b3Igb3ZlcnJpZGluZyB0aGUgIldlYktpdERpc3BsYXlJbWFnZXNLZXkiIHByZWZlcmVuY2UuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODIwMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcDoKKyAgICAgICAgKFRlc3RSdW5uZXI6Om92ZXJyaWRl UHJlZmVyZW5jZSk6CisKIDIwMTItMTAtMDIgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPHJhcGhh ZWwua3Viby5kYS5jb3N0YUBpbnRlbC5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBsYXN0IGJp dHMgb2YgTVNZUyBzdXBwb3J0IGZyb20gd2Via2l0cGVybC4KSW5kZXg6IFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L1Rlc3RSdW5uZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcAkocmV2aXNpb24gMTMwMjA3KQorKysgVG9vbHMvRHVt cFJlbmRlclRyZWUvcXQvVGVzdFJ1bm5lclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjc3LDYg KzY3Nyw4IEBAIHZvaWQgVGVzdFJ1bm5lcjo6b3ZlcnJpZGVQcmVmZXJlbmNlKGNvbnMKICAgICAg ICAgc2V0dGluZ3MtPnNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6Okh5cGVybGlua0F1ZGl0aW5n RW5hYmxlZCwgdmFsdWUudG9Cb29sKCkpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0gIldlYktpdEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkIikKICAgICAgICAgc2V0dGluZ3MtPnNldEF0dHJp YnV0ZShRV2ViU2V0dGluZ3M6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkLCB2YWx1ZS50 b0Jvb2woKSk7CisgICAgZWxzZSBpZiAobmFtZSA9PSAiV2ViS2l0RGlzcGxheUltYWdlc0tleSIp CisgICAgICAgIHNldHRpbmdzLT5zZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpBdXRvTG9hZElt YWdlcywgdmFsdWUudG9Cb29sKCkpOwogICAgIGVsc2UKICAgICAgICAgcHJpbnRmKCJFUlJPUjog VGVzdFJ1bm5lcjo6b3ZlcnJpZGVQcmVmZXJlbmNlKCkgZG9lcyBub3Qgc3VwcG9ydCB0aGUgJyVz JyBwcmVmZXJlbmNlXG4iLAogICAgICAgICAgICAgbmFtZS50b0xhdGluMSgpLmRhdGEoKSk7Cklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzAyMTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0xMC0wMiAgUmFwaGFlbCBLdWJvIGRhIENv c3RhICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KKworICAgICAgICBbUXRdW0RS VF0gQWRkIHN1cHBvcnQgZm9yIG92ZXJyaWRpbmcgdGhlICJXZWJLaXREaXNwbGF5SW1hZ2VzS2V5 IiBwcmVmZXJlbmNlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTgyMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL3F0L1Rlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcCBhIGZldyB0ZXN0cyB0 aGF0IGRlcGVuZGVkCisgICAgICAgIG9uIHRoaXMgZmVhdHVyZS4KKwogMjAxMi0xMC0wMiAgQ3Nh YmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZp ZXdlZCBnYXJkZW5pbmcsIHNraXAgb25lIG1vcmUgZmFpbGluZyB0ZXN0LgpJbmRleDogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCShyZXZpc2lvbiAxMzAyMTEpCisrKyBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBA IC0xMzI3LDEzICsxMzI3LDYgQEAgY3NzMy9maWx0ZXJzL2N1c3RvbS9maWx0ZXItcmVwYWludC1j dXN0bwogY3NzMy9maWx0ZXJzL2N1c3RvbS9maWx0ZXItcmVwYWludC1jdXN0b20tcm90YXRlZC5o dG1sCiBjc3MzL2ZpbHRlcnMvY3VzdG9tL2ZpbHRlci1yZXBhaW50LWN1c3RvbS5odG1sCiAKLSMg RVJST1I6IFRlc3RSdW5uZXI6Om92ZXJyaWRlUHJlZmVyZW5jZSgpIGRvZXMgbm90IHN1cHBvcnQg dGhlICdXZWJLaXREaXNwbGF5SW1hZ2VzS2V5JyBwcmVmZXJlbmNlCi0jIGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzEyOTQ2MgotZmFzdC9sb2FkZXIvZGlzcGxheS1pbWFnZS11bnNl dC1hbGxvd3MtY2FjaGVkLWltYWdlLWxvYWQuaHRtbAotZmFzdC9sb2FkZXIvZGlzcGxheS1pbWFn ZS11bnNldC1jYW4tYmxvY2staW1hZ2UtYW5kLWNhbi1yZWxvYWQtaW4tcGxhY2UuaHRtbAotZmFz dC9sb2FkZXIvaW1hZ2VzLWVuYWJsZWQtdW5zZXQtY2FuLWJsb2NrLWltYWdlLWFuZC1jYW4tcmVs b2FkLWluLXBsYWNlLmh0bWwKLWh0dHAvdGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaW1h Z2VzLWRpc2FibGVkLmh0bWwKLQogIyBSZWZlcmVuY2VFcnJvcjogQ2FuJ3QgZmluZCB2YXJpYWJs ZTogTWVkaWFLZXlFcnJvcgogIyBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMTQw NjcKIGZhc3QvZXZlbnRzL2NvbnN0cnVjdG9ycy9tZWRpYS1rZXktZXZlbnQtY29uc3RydWN0b3Iu aHRtbAo=