98196 2012-10-02 13:43:01 -0700 executive_unittest fails on Apple Windows bots but not when run locally 2017-07-18 08:29:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 REOPENED https://bugs.webkit.org/show_bug.cgi?id=155367 P2 Normal --- 1 roger_fong webkit-unassigned abarth dpranke eric roger_fong webkit.review.bot oldest_to_newest 733039 0 roger_fong 2012-10-02 13:43:01 -0700 py test fails on Apple Windows port. [167/1585] webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process failed: Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/system/executive_unittest.py", line 167, in serial_test_kill_process self.assertEqual(process.wait(), expected_exit_code) AssertionError: -6 != -9 Test fails only on bots but not when run locally. Unclear why. In addition, sys.platform is "cygwin" not "win32" Creating patch to make test more flexible to handle different behaviors from cygwin. 733118 1 166759 roger_fong 2012-10-02 15:06:45 -0700 Created attachment 166759 patch 733139 2 166759 eric 2012-10-02 15:19:12 -0700 Comment on attachment 166759 patch LGTM. 733166 3 166759 webkit.review.bot 2012-10-02 15:58:58 -0700 Comment on attachment 166759 patch Clearing flags on attachment: 166759 Committed r130223: <http://trac.webkit.org/changeset/130223> 733167 4 webkit.review.bot 2012-10-02 15:59:01 -0700 All reviewed patches have been landed. Closing bug. 733168 5 roger_fong 2012-10-02 15:59:47 -0700 reopening to keep track of bug 166759 2012-10-02 15:06:45 -0700 2012-10-02 15:58:58 -0700 patch 98196_patch.txt text/plain 1705 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDIxNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTEwLTAyICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgZXhlY3V0aXZlX3VuaXR0ZXN0LnB5IGZhaWxzIG9uIEFwcGxlIFdpbmRvd3Mg Ym90cyBidXQgbm90IHdoZW4gcnVuIGxvY2FsbHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODE5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1ha2luZyB0aGUgdGVzdCBtb3JlIGZsZXhpYmxlIHRvIGNo ZWNrIGZvciBjeWd3aW4gYW5kIGFsbG93IGRpZmZlcmVudCBvdXRwdXRzIGZyb20gcHJvY2Vzcy53 YWl0KCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0 aXZlX3VuaXR0ZXN0LnB5OgorICAgICAgICAoRXhlY3V0aXZlVGVzdC5zZXJpYWxfdGVzdF9raWxs X3Byb2Nlc3MpOgorCiAyMDEyLTEwLTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVs Lmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUgbGFzdCBiaXRz IG9mIE1TWVMgc3VwcG9ydCBmcm9tIHdlYmtpdHBlcmwuCkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmVfdW5pdHRlc3Qu cHkJKHJldmlzaW9uIDEzMDE5NCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmVfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2Miw2ICsxNjIs MTAgQEAgY2xhc3MgRXhlY3V0aXZlVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAg ICAjIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3OTAK ICAgICAgICAgICAgICMgV2Ugc2VlbSB0byBnZXQgZWl0aGVyIDAgb3IgMSBoZXJlIGZvciBzb21l IHJlYXNvbi4KICAgICAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwcm9jZXNzLndhaXQoKSBpbiAo MCwgMSkpCisgICAgICAgIGVsaWYgc3lzLnBsYXRmb3JtID09ICJjeWd3aW4iOgorICAgICAgICAg ICAgIyBGSVhNRTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MTk2 CisgICAgICAgICAgICAjIGN5Z3dpbiBzZWVtcyB0byBnaXZlIHVzIGVpdGhlciBTSUdBQlJUIG9y IFNJR0tJTEwKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwcm9jZXNzLndhaXQoKSBpbiAo LXNpZ25hbC5TSUdBQlJULCAtc2lnbmFsLlNJR0tJTEwpKQogICAgICAgICBlbHNlOgogICAgICAg ICAgICAgZXhwZWN0ZWRfZXhpdF9jb2RlID0gLXNpZ25hbC5TSUdLSUxMCiAgICAgICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKHByb2Nlc3Mud2FpdCgpLCBleHBlY3RlZF9leGl0X2NvZGUpCg==