98195 2012-10-02 13:39:18 -0700 Remove the last bits of MSYS support from webkitperl. 2012-10-02 15:45:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco dpranke eric webkit.review.bot oldest_to_newest 733029 0 rakuco 2012-10-02 13:39:18 -0700 Remove the last bits of MSYS support from webkitperl. 733032 1 166742 rakuco 2012-10-02 13:40:37 -0700 Created attachment 166742 Patch 733043 2 166742 eric 2012-10-02 13:45:48 -0700 Comment on attachment 166742 Patch LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :) 733051 3 rakuco 2012-10-02 13:57:00 -0700 (In reply to comment #2) > (From update of attachment 166742 [details]) > LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :) Hmm, MinGW support in Source/ consists mainly in compiler ifdefs; killing that would probably make at least Dirk unhappy. 733058 4 166742 webkit.review.bot 2012-10-02 14:09:01 -0700 Comment on attachment 166742 Patch Clearing flags on attachment: 166742 Committed r130210: <http://trac.webkit.org/changeset/130210> 733059 5 webkit.review.bot 2012-10-02 14:09:04 -0700 All reviewed patches have been landed. Closing bug. 733069 6 dpranke 2012-10-02 14:21:02 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 166742 [details] [details]) > > LGTM. Thanks. We should also consider killing any support in Source/ in later patches. :) > > Hmm, MinGW support in Source/ consists mainly in compiler ifdefs; killing that would probably make at least Dirk unhappy. Dirk == me? I only do win32 builds. 733082 7 rakuco 2012-10-02 14:29:50 -0700 (In reply to comment #6) > Dirk == me? Yep. > I only do win32 builds. Oh, I thought you meant you also built with mingw in https://bugs.webkit.org/show_bug.cgi?id=98183#c6 733156 8 dpranke 2012-10-02 15:45:30 -0700 (In reply to comment #7) > (In reply to comment #6) > > Dirk == me? > Yep. > > > I only do win32 builds. > Oh, I thought you meant you also built with mingw in https://bugs.webkit.org/show_bug.cgi?id=98183#c6 No, I meant that I often run the tests from under a mingw/msysgit bash environment. However, I think I've mostly used the stock win32 python in this case. 166742 2012-10-02 13:40:37 -0700 2012-10-02 14:09:00 -0700 Patch bug-98195-20121002233808.patch text/plain 3187 rakuco SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDIwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDEyLTEwLTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1 Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFJlbW92ZSB0aGUgbGFzdCBiaXRzIG9m IE1TWVMgc3VwcG9ydCBmcm9tIHdlYmtpdHBlcmwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODE5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIHBvcnRzIGN1cnJlbnRseSBuZWVkIE1pbkdXL01TWVMg c3VwcG9ydCwgc28gcmVtb3ZlIHRoZSBsYXN0CisgICAgICAgIGhhY2tpc2ggYml0cyByZWxhdGVk IHRvIGl0IGZyb20gb3VyIFBlcmwgY29kZS4KKworICAgICAgICAqIFNjcmlwdHMvY29tbWl0LWxv Zy1lZGl0b3I6CisgICAgICAgIChjcmVhdGVDb21taXRNZXNzYWdlKToKKyAgICAgICAgKiBTY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKGlzQW55V2luZG93cyk6CisgICAgICAgIChpc1dpbmRvd3MpOgorCiAyMDEy LTEwLTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50 ZWwuY29tPgogCiAgICAgICAgIFJlbW92ZSBNU1lTLXJlbGF0ZWQgY2hhbmdlcyB0byB0aGUgaHR0 cCB0ZXN0aW5nIGluZnJhc3RydWN0dXJlLgpJbmRleDogVG9vbHMvU2NyaXB0cy9jb21taXQtbG9n LWVkaXRvcgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCShy ZXZpc2lvbiAxMzAyMDIpCisrKyBUb29scy9TY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yCSh3b3Jr aW5nIGNvcHkpCkBAIC0zOSw3ICszOSw2IEBAIHVzZSBWQ1NVdGlsczsKIHVzZSB3ZWJraXRkaXJz OwogCiBzdWIgY3JlYXRlQ29tbWl0TWVzc2FnZShAKTsKLXN1YiBmaXhFbnZpcm9ubWVudCgpOwog c3ViIGxvYWRUZXJtUmVhZEtleSgpOwogc3ViIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCQkKTsKIHN1 YiBwYXRjaEF1dGhvcnNoaXBTdHJpbmcoJCQkKTsKQEAgLTg2LDggKzg1LDYgQEAgaWYgKCEkbG9n KSB7CiAgICAgcHJpbnRVc2FnZUFuZEV4aXQoKTsKIH0KIAotZml4RW52aXJvbm1lbnQoKTsKLQog bXkgJGJhc2VEaXIgPSBiYXNlUHJvZHVjdERpcigpOwogCiBteSAkZWRpdG9yID0gJEVOVntTVk5f TE9HX0VESVRPUn07CkBAIC0zMTcsMjEgKzMxNCw2IEBAIHN1YiBjcmVhdGVDb21taXRNZXNzYWdl KEApCiAgICAgcmV0dXJuIGpvaW4gJycsIEByZXN1bHQ7CiB9CiAKLXN1YiBmaXhFbnZpcm9ubWVu dCgpCi17Ci0gICAgcmV0dXJuIHVubGVzcyBpc01zeXMoKSAmJiBpc0dpdCgpOwotCi0gICAgIyBX aGVuIHRoaXMgc2NyaXB0IGdldHMgcnVuIGZyb20gaW5zaWRlIGdpdCBjb21taXQsIG1zeXMtc3R5 bGUgcGF0aHMgaW4gdGhlCi0gICAgIyBlbnZpcm9ubWVudCB3aWxsIGhhdmUgYmVlbiB0dXJuZWQg aW50byBXaW5kb3dzLXN0eWxlIHBhdGhzIHdpdGggZm9yd2FyZAotICAgICMgc2xhc2hlcy4gVGhp cyBzY3Jld3MgdXAgZnVuY3Rpb25zIGxpa2UgRmlsZTo6U3BlYy0+cmVsMmFicywgd2hpY2ggc2Vl bSB0bwotICAgICMgcmVseSBvbiAkUFdEIGhhdmluZyBhbiBtc3lzLXN0eWxlIHBhdGguIFdlIGNv bnZlcnQgdGhlIHBhdGhzIGJhY2sgdG8KLSAgICAjIG1zeXMtc3R5bGUgaGVyZSBieSB0cmFuc2Zv cm1pbmcgImM6L2ZvbyIgdG8gIi9jL2ZvbyIgKGUuZy4pLiBTZWUKLSAgICAjIDxodHRwOi8vd2Vi a2l0Lm9yZy9iLzQ4NTI3Pi4KLSAgICBmb3JlYWNoIG15ICRrZXkgKGtleXMgJUVOVikgewotICAg ICAgICAkRU5WeyRrZXl9ID1+IHMjXihbWzphbHBoYTpdXSk6LyMvJDEvIzsKLSAgICB9Ci19Ci0K IHN1YiBsb2FkVGVybVJlYWRLZXkoKQogewogICAgIGV2YWwgeyByZXF1aXJlIFRlcm06OlJlYWRL ZXk7IH07CkluZGV4OiBUb29scy9TY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDEzMDIw MikKKysrIFRvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcgY29weSkK QEAgLTE4OSw3ICsxODksNyBAQCBteSAkdGVzdFJlc3VsdHNTZXJ2ZXIgPSAnJzsKIAogbXkgQGxl YWtzRmlsZW5hbWVzOwogCi1pZiAoaXNXaW5kb3dzKCkgfHwgaXNNc3lzKCkpIHsKK2lmIChpc1dp bmRvd3MoKSkgewogICAgIHByaW50ICJUaGlzIHNjcmlwdCBoYXMgdG8gYmUgcnVuIHVuZGVyIEN5 Z3dpbiB0byBmdW5jdGlvbiBjb3JyZWN0bHkuXG4iOwogICAgIGV4aXQgMTsKIH0KSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0JKHJldmlzaW9uIDEzMDIwMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQkod29ya2luZyBjb3B5KQpAQCAtMTIzNyw3ICsxMjM3LDcgQEAgc3ViIGlzQ3lnd2luKCkK IAogc3ViIGlzQW55V2luZG93cygpCiB7Ci0gICAgcmV0dXJuIGlzV2luZG93cygpIHx8IGlzQ3ln d2luKCkgfHwgaXNNc3lzKCk7CisgICAgcmV0dXJuIGlzV2luZG93cygpIHx8IGlzQ3lnd2luKCk7 CiB9CiAKIHN1YiBkZXRlcm1pbmVXaW5WZXJzaW9uKCkKQEAgLTEyOTAsMTEgKzEyOTAsNiBAQCBz dWIgaXNXaW5kb3dzKCkKICAgICByZXR1cm4gKCReTyBlcSAiTVNXaW4zMiIpIHx8IDA7CiB9CiAK LXN1YiBpc01zeXMoKQotewotICAgIHJldHVybiAoJF5PIGVxICJtc3lzIikgfHwgMDsKLX0KLQog c3ViIGlzTGludXgoKQogewogICAgIHJldHVybiAoJF5PIGVxICJsaW51eCIpIHx8IDA7Cg==