98187 2012-10-02 12:15:56 -0700 Remove cases of testRunner.disableImageLoading() from the layout tests. 2012-10-02 13:19:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98083 1 rakuco rakuco abarth eric simon.fraser oldest_to_newest 732930 0 rakuco 2012-10-02 12:15:56 -0700 Remove cases of testRunner.disableImageLoading() from the layout tests. 732936 1 166729 rakuco 2012-10-02 12:19:24 -0700 Created attachment 166729 Patch 732966 2 166729 simon.fraser 2012-10-02 12:46:04 -0700 Comment on attachment 166729 Patch Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests? 733003 3 rakuco 2012-10-02 13:16:51 -0700 (In reply to comment #2) > (From update of attachment 166729 [details]) > Does the WebKitDisplayImagesKey get reset by WTR/DRT between tests? The behavior seems to be port-dependent -- at least the Mac (and thus probably win), EFL, GTK+ and Chromium TestRunners reset that value between each test. WTR seems to do that as well by calling WKPreferencesResetTestRunnerOverrides(). 733006 4 166729 rakuco 2012-10-02 13:19:37 -0700 Comment on attachment 166729 Patch Clearing flags on attachment: 166729 Committed r130201: <http://trac.webkit.org/changeset/130201> 733007 5 rakuco 2012-10-02 13:19:48 -0700 All reviewed patches have been landed. Closing bug. 166729 2012-10-02 12:19:24 -0700 2012-10-02 13:19:37 -0700 Patch bug-98187-20121002221655.patch text/plain 2743 rakuco SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzMDE5MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDEyLTEwLTAyICBSYXBoYWVsIEt1Ym8gZGEg Q29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwuY29tPgorCisgICAgICAgIFJlbW92 ZSBjYXNlcyBvZiB0ZXN0UnVubmVyLmRpc2FibGVJbWFnZUxvYWRpbmcoKSBmcm9tIHRoZSBsYXlv dXQgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05ODE4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFjY29yZGluZyB0byB0aGUgZGlzY3Vzc2lvbiBzdGFydGVkIGluIFsxXSwgaXQgZG9lcyBub3Qg bWFrZSBtdWNoCisgICAgICAgIHNlbnNlIHRvIGtlZXAgZGlzYWJsZUxvYWRpbmdJbWFnZXMoKSBh cm91bmQgd2hlbgorICAgICAgICBvdmVycmlkZVByZWZlcmVuY2VzKCJXZWJLaXREaXNwbGF5SW1h Z2VzS2V5IiwgMCkgYWNoaWV2ZXMgdGhlIHNhbWUKKyAgICAgICAgZWZmZWN0LgorCisgICAgICAg IFRoZXJlIHdlcmUgb25seSB0d28gY2FzZXMgb2YgZGlzYWJsZUxvYWRpbmdJbWFnZXMoKSBpbiB0 aGUgdGVzdHM7CisgICAgICAgIG9uZSBvZiB0aGUgdGVzdHMgaXMgZGlzYWJsZWQgYW5kIHRoZSBv dGhlciBpcyBjdXJyZW50bHkgc2tpcHBlZCBieQorICAgICAgICBhbGwgcG9ydHMsIHNvIHRoZXJl IHNob3VsZCBiZSBubyByZWdyZXNzaW9ucywgc3VjaCBhcyBwcm9ibGVtcworICAgICAgICB3aXRo IHBvcnRzIHRoYXQgbWF5IGltcGxlbWVudCB0ZXN0UnVubmVyLmRpc2FibGVMb2FkaW5nSW1hZ2Vz KCkKKyAgICAgICAgYnV0IG5vdCBvdmVycmlkZVByZWZlcmVuY2VzKCJXZWJLaXREaXNwbGF5SW1h Z2VzS2V5IikuCisKKyAgICAgICAgWzFdIGh0dHA6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFp bC93ZWJraXQtZGV2LzIwMTItU2VwdGVtYmVyLzAyMjMyMy5odG1sCisKKyAgICAgICAgKiBodHRw L3Rlc3RzL21pc2MvZmF2aWNvbi1sb2Fkcy13aXRoLWljb24tbG9hZGluZy1vdmVycmlkZS5odG1s OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaW1hZ2VzLWRp c2FibGVkLmh0bWw6CisKIDIwMTItMTAtMDIgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVcGRhdGUgc29tZSBleHBlY3RhdGlvbnMgdG8gZ3JlZW4gdGhlIHRyZWUu CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZmF2aWNvbi1sb2Fkcy13aXRoLWlj b24tbG9hZGluZy1vdmVycmlkZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaWNvbi1sb2FkaW5nLW92ZXJyaWRlLmh0bWwJ KHJldmlzaW9uIDEzMDE4OSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mYXZpY29u LWxvYWRzLXdpdGgtaWNvbi1sb2FkaW5nLW92ZXJyaWRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAg LTcsNyArNyw3IEBAIGZ1bmN0aW9uIHJ1blRlc3QoKQogICAgICAgICB0ZXN0UnVubmVyLmR1bXBB c1RleHQoKTsKICAgICAgICAgdGVzdFJ1bm5lci5kdW1wUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCk7 CiAgICAgICAgIHRlc3RSdW5uZXIuc2V0SWNvbkRhdGFiYXNlRW5hYmxlZCh0cnVlKTsKLSAgICAg ICAgdGVzdFJ1bm5lci5kaXNhYmxlSW1hZ2VMb2FkaW5nKCk7CisgICAgICAgIHRlc3RSdW5uZXIu b3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXREaXNwbGF5SW1hZ2VzS2V5IiwgMCk7CiAgICAgICAg IHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXRMb2FkU2l0ZUljb25zS2V5Iiwg MSk7CiAgICAgICAgIHRlc3RSdW5uZXIucXVldWVSZWxvYWQoKTsKICAgICB9CkluZGV4OiBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZmF2aWNvbi1sb2Fkcy13aXRoLWltYWdlcy1kaXNhYmxl ZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mYXZpY29u LWxvYWRzLXdpdGgtaW1hZ2VzLWRpc2FibGVkLmh0bWwJKHJldmlzaW9uIDEzMDE4OSkKKysrIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mYXZpY29uLWxvYWRzLXdpdGgtaW1hZ2VzLWRpc2Fi bGVkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcsNyArNyw3IEBAIGZ1bmN0aW9uIHJ1blRlc3Qo KQogICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgdGVzdFJ1bm5lci5k dW1wUmVzb3VyY2VMb2FkQ2FsbGJhY2tzKCk7CiAgICAgICAgIHRlc3RSdW5uZXIuc2V0SWNvbkRh dGFiYXNlRW5hYmxlZCh0cnVlKTsKLSAgICAgICAgdGVzdFJ1bm5lci5kaXNhYmxlSW1hZ2VMb2Fk aW5nKCk7CisgICAgICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJXZWJLaXREaXNw bGF5SW1hZ2VzS2V5IiwgMCk7CiAgICAgICAgIHRlc3RSdW5uZXIucXVldWVSZWxvYWQoKTsKICAg ICB9CiB9Cg==