98176 2012-10-02 11:12:39 -0700 [GTK] Programs/WebKit2APITests/TestCookieManager fails 2012-10-02 12:31:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo mario mrobinson webkit.review.bot oldest_to_newest 732839 0 cgarcia 2012-10-02 11:12:39 -0700 The problem is that the soup server has a g_assert_not_reached() for unknown paths, but know /favicon.icon might be requested. We could simply ignore unknown paths. 732844 1 166717 cgarcia 2012-10-02 11:15:02 -0700 Created attachment 166717 Patch 732849 2 webkit.review.bot 2012-10-02 11:16:41 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 732950 3 166717 webkit.review.bot 2012-10-02 12:30:58 -0700 Comment on attachment 166717 Patch Clearing flags on attachment: 166717 Committed r130196: <http://trac.webkit.org/changeset/130196> 732951 4 webkit.review.bot 2012-10-02 12:31:01 -0700 All reviewed patches have been landed. Closing bug. 166717 2012-10-02 11:15:02 -0700 2012-10-02 12:30:57 -0700 Patch wk2-cokkies-test.diff text/plain 1531 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjYjczNzhhLi4xNGY3NDVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFByb2dyYW1zL1dlYktpdDJBUElUZXN0cy9UZXN0Q29va2llTWFu YWdlciBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTgxNzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZSBzb3VwIHNlcnZlciBoYXMgYSBnX2Fzc2VydF9ub3Rf cmVhY2hlZCgpCisgICAgICAgIGZvciB1bmtub3duIHBhdGhzLCBidXQga25vdyAvZmF2aWNvbi5p Y29uIG1pZ2h0IGJlIHJlcXVlc3RlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL3Rl c3RzL1Rlc3RDb29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKHNlcnZlckNhbGxiYWNrKTogSWdu b3JlIHVua25vd24gcGF0aHMuCisKIDIwMTItMTAtMDEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUgU2FmYXJpIDIgLT4gU2FmYXJpIDMgaWNv biBkYXRhYmFzZSBpbXBvcnQgY29kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RDb29raWVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RDb29raWVNYW5hZ2VyLmNwcAppbmRleCAyZmU4 OTk4Li4yOWYyMzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay90ZXN0cy9UZXN0Q29va2llTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvdGVzdHMvVGVzdENvb2tpZU1hbmFnZXIuY3BwCkBAIC0yOTQsOCArMjk0LDYg QEAgc3RhdGljIHZvaWQgc2VydmVyQ2FsbGJhY2soU291cFNlcnZlciogc2VydmVyLCBTb3VwTWVz c2FnZSogbWVzc2FnZSwgY29uc3QgY2hhcioKICAgICAgICAgc291cF9tZXNzYWdlX2JvZHlfYXBw ZW5kKG1lc3NhZ2UtPnJlc3BvbnNlX2JvZHksIFNPVVBfTUVNT1JZX1RBS0UsIGluZGV4SHRtbCwg c3RybGVuKGluZGV4SHRtbCkpOwogICAgIH0gZWxzZSBpZiAoZ19zdHJfZXF1YWwocGF0aCwgIi9p bWFnZS5wbmciKSkKICAgICAgICAgc291cF9tZXNzYWdlX2hlYWRlcnNfcmVwbGFjZShtZXNzYWdl LT5yZXNwb25zZV9oZWFkZXJzLCAiU2V0LUNvb2tpZSIsICJiYXo9cXV4OyBNYXgtQWdlPTYwIik7 Ci0gICAgZWxzZQotICAgICAgICBnX2Fzc2VydF9ub3RfcmVhY2hlZCgpOwogICAgIHNvdXBfbWVz c2FnZV9ib2R5X2NvbXBsZXRlKG1lc3NhZ2UtPnJlc3BvbnNlX2JvZHkpOwogfQogCg==