98174 2012-10-02 10:20:47 -0700 Unix plugin process: xErrorString does not need to be defined in release builds 2012-10-02 22:58:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98232 0 aperez webkit-unassigned cdumez webkit.review.bot oldest_to_newest 732785 0 aperez 2012-10-02 10:20:47 -0700 Unix plugin process: xErrorString does not need to be defined in release builds 732788 1 166707 aperez 2012-10-02 10:23:45 -0700 Created attachment 166707 Patch 732789 2 aperez 2012-10-02 10:25:18 -0700 The patch fixes this warning in release mode (well, in general whenever LOG_DISABLE is defined): ../../Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:48:20: warning: ‘WebKit::xErrorString’ defined but not used [-Wunused-variable] 732791 3 166707 darin 2012-10-02 10:25:26 -0700 Comment on attachment 166707 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166707&action=review > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:54 > +#ifndef LOG_DISABLED > static const char* xErrorString = "The program '%s' received an X Window System error.\n" > "This probably reflects a bug in a browser plugin.\n" > "The error was '%s'.\n" > " (Details: serial %ld error_code %d request_code %d minor_code %d)\n"; > +#endif /* !LOG_DISABLED */ Could also make this a bit more const. Either const char[] or const char* const. 732793 4 aperez 2012-10-02 10:27:15 -0700 (In reply to comment #3) > (From update of attachment 166707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=166707&action=review > > > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:54 > > +#ifndef LOG_DISABLED > > static const char* xErrorString = "The program '%s' received an X Window System error.\n" > > "This probably reflects a bug in a browser plugin.\n" > > "The error was '%s'.\n" > > " (Details: serial %ld error_code %d request_code %d minor_code %d)\n"; > > +#endif /* !LOG_DISABLED */ > > Could also make this a bit more const. Either const char[] or const char* const. Sure, thanks. Will make it “const char[]” and re-upload the patch. Thanks! 732803 5 166712 aperez 2012-10-02 10:39:57 -0700 Created attachment 166712 Patch 733177 6 166712 webkit.review.bot 2012-10-02 16:13:41 -0700 Comment on attachment 166712 Patch Clearing flags on attachment: 166712 Committed r130225: <http://trac.webkit.org/changeset/130225> 733178 7 webkit.review.bot 2012-10-02 16:13:44 -0700 All reviewed patches have been landed. Closing bug. 733365 8 cdumez 2012-10-02 22:45:54 -0700 This patch broke debug build on EFL port it seems: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp: In function ‘int WebKit::webkitXError(Display*, XErrorEvent*)’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:63:7: error: ‘xErrorString’ was not declared in this scope make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/PluginProcess/unix/PluginProcessMainUnix.cpp.o] Error 1 733366 9 166712 cdumez 2012-10-02 22:46:51 -0700 Comment on attachment 166712 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166712&action=review > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:50 > +static const char xErrorString[] = "The program '%s' received an X Window System error.\n" xErrorString is used in webkitXError() which is not protected by #ifndef LOG_DISABLED 733370 10 166712 cdumez 2012-10-02 22:58:35 -0700 Comment on attachment 166712 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166712&action=review > Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:49 > +#ifndef LOG_DISABLED This should be: #if !LOG_DISABLED I'm fixing it in Bug 98232. 166707 2012-10-02 10:23:45 -0700 2012-10-02 10:39:49 -0700 Patch bug-98174-20121002202355.patch text/plain 1825 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2I3Mzc4YTRmNjYxMDli MmYzOGI5NGNiYjBiYjI0YzZlM2NlY2ZjMS4uMjkyNjlmZjAxMTFkMmQ2ODA2NWY1ZGQ0YzBlYjVh MDZlMGJjMzJlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTAyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgVW5peCBw bHVnaW4gcHJvY2VzczogeEVycm9yU3RyaW5nIGRvZXMgbm90IG5lZWQgdG8gYmUgZGVmaW5lZCBp biByZWxlYXNlIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTgxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgc3RhdGljIHhFcnJvclN0cmluZyB2YXJpYWJsZSBpcyB1c2VkIG9ubHkgZm9y IGxvZ2dpbmcgcHVycG9zZXMsCisgICAgICAgIHNvIGl0IGNhdXNlcyBhIHdhcm5pbmcgd2hlbiBk b2luZyByZWxlc2UgYnVpbGRzIChvciwgaW4gZ2VuZXJhbCwKKyAgICAgICAgd2hlbiBsb2dnaW5n IGlzIGVuYWJsZWQpLiBUaGlzIGRpc2FibGVzIGJ1aWxkaW5nIGluIHRoZSBzdHJpbmcKKyAgICAg ICAgd2hlbiBMT0dfRElTQUJMRUQgaXMgZGVmaW5lZC4KKworICAgICAgICAqIFBsdWdpblByb2Nl c3MvdW5peC9QbHVnaW5Qcm9jZXNzTWFpblVuaXguY3BwOgorICAgICAgICAoV2ViS2l0KToKKwog MjAxMi0xMC0wMSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIHRoZSBTYWZhcmkgMiAtPiBTYWZhcmkgMyBpY29uIGRhdGFiYXNlIGltcG9ydCBjb2Rl LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblBy b2Nlc3NNYWluVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1 Z2luUHJvY2Vzc01haW5Vbml4LmNwcAppbmRleCAxMTVmMTVmMjdjZjRhMmRiYWNhZDE5MjIxMjZj ZTcxZWYwNTRkY2NlLi5kYTJlYTdmYWIyYTgwYzViOGUzOWYzMzZiNDI2NzFmMWJmMDhjZTFiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1Z2luUHJvY2Vz c01haW5Vbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL3VuaXgvUGx1 Z2luUHJvY2Vzc01haW5Vbml4LmNwcApAQCAtNDUsMTAgKzQ1LDE0IEBAIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwogbmFtZXNwYWNlIFdlYktpdCB7CiAKICNpZmRlZiBYUF9VTklYCisKKyNpZm5k ZWYgTE9HX0RJU0FCTEVECiBzdGF0aWMgY29uc3QgY2hhciogeEVycm9yU3RyaW5nID0gIlRoZSBw cm9ncmFtICclcycgcmVjZWl2ZWQgYW4gWCBXaW5kb3cgU3lzdGVtIGVycm9yLlxuIgogICAgICJU aGlzIHByb2JhYmx5IHJlZmxlY3RzIGEgYnVnIGluIGEgYnJvd3NlciBwbHVnaW4uXG4iCiAgICAg IlRoZSBlcnJvciB3YXMgJyVzJy5cbiIKICAgICAiICAoRGV0YWlsczogc2VyaWFsICVsZCBlcnJv cl9jb2RlICVkIHJlcXVlc3RfY29kZSAlZCBtaW5vcl9jb2RlICVkKVxuIjsKKyNlbmRpZiAvKiAh TE9HX0RJU0FCTEVEICovCisKIHN0YXRpYyBjaGFyKiBwcm9ncmFtTmFtZSA9IDA7CiAKIHN0YXRp YyBpbnQgd2Via2l0WEVycm9yKERpc3BsYXkqIHhkaXNwbGF5LCBYRXJyb3JFdmVudCogZXJyb3Ip Cg== 166712 2012-10-02 10:39:57 -0700 2012-10-02 22:58:35 -0700 Patch bug-98174-20121002204006.patch text/plain 2020 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2I3Mzc4YTRmNjYxMDli MmYzOGI5NGNiYjBiYjI0YzZlM2NlY2ZjMS4uZGU5MGEyMDY5NDYxYWYxZDc3MjI1YjFkZGQyNzJi MzY1MDliZTU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTAyICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgVW5peCBw bHVnaW4gcHJvY2VzczogeEVycm9yU3RyaW5nIGRvZXMgbm90IG5lZWQgdG8gYmUgZGVmaW5lZCBp biByZWxlYXNlIGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTgxNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgc3RhdGljIHhFcnJvclN0cmluZyB2YXJpYWJsZSBpcyB1c2VkIG9ubHkgZm9y IGxvZ2dpbmcgcHVycG9zZXMsCisgICAgICAgIHNvIGl0IGNhdXNlcyBhIHdhcm5pbmcgd2hlbiBk b2luZyByZWxlc2UgYnVpbGRzIChvciwgaW4gZ2VuZXJhbCwKKyAgICAgICAgd2hlbiBsb2dnaW5n IGlzIGVuYWJsZWQpLiBUaGlzIGRpc2FibGVzIGJ1aWxkaW5nIGluIHRoZSBzdHJpbmcKKyAgICAg ICAgd2hlbiBMT0dfRElTQUJMRUQgaXMgZGVmaW5lZC4KKworICAgICAgICBBbHNvLCBtYWRlIHRo ZSBtb3JlIGNvbnN0YW50IGJ5IGNoYW5naW5nIHRoZSAiY29uc3QgY2hhcioiIHR5cGUKKyAgICAg ICAgdG8gImNvbnN0IGNoYXJbXSIuCisKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNzL3VuaXgvUGx1 Z2luUHJvY2Vzc01haW5Vbml4LmNwcDoKKyAgICAgICAgKFdlYktpdCk6CisKIDIwMTItMTAtMDEg IEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUg U2FmYXJpIDIgLT4gU2FmYXJpIDMgaWNvbiBkYXRhYmFzZSBpbXBvcnQgY29kZS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvdW5peC9QbHVnaW5Qcm9jZXNzTWFpblVu aXguY3BwIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NN YWluVW5peC5jcHAKaW5kZXggMTE1ZjE1ZjI3Y2Y0YTJkYmFjYWQxOTIyMTI2Y2U3MWVmMDU0ZGNj ZS4uZDQ2MGU4ZjE2ZDMzNTRiYzU4OTQwZmYwYWRiMWZlMzYwYmRmZjRiMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NNYWluVW5peC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy91bml4L1BsdWdpblByb2Nlc3NN YWluVW5peC5jcHAKQEAgLTQ1LDEwICs0NSwxNCBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK IG5hbWVzcGFjZSBXZWJLaXQgewogCiAjaWZkZWYgWFBfVU5JWAotc3RhdGljIGNvbnN0IGNoYXIq IHhFcnJvclN0cmluZyA9ICJUaGUgcHJvZ3JhbSAnJXMnIHJlY2VpdmVkIGFuIFggV2luZG93IFN5 c3RlbSBlcnJvci5cbiIKKworI2lmbmRlZiBMT0dfRElTQUJMRUQKK3N0YXRpYyBjb25zdCBjaGFy IHhFcnJvclN0cmluZ1tdID0gIlRoZSBwcm9ncmFtICclcycgcmVjZWl2ZWQgYW4gWCBXaW5kb3cg U3lzdGVtIGVycm9yLlxuIgogICAgICJUaGlzIHByb2JhYmx5IHJlZmxlY3RzIGEgYnVnIGluIGEg YnJvd3NlciBwbHVnaW4uXG4iCiAgICAgIlRoZSBlcnJvciB3YXMgJyVzJy5cbiIKICAgICAiICAo RGV0YWlsczogc2VyaWFsICVsZCBlcnJvcl9jb2RlICVkIHJlcXVlc3RfY29kZSAlZCBtaW5vcl9j b2RlICVkKVxuIjsKKyNlbmRpZiAvKiAhTE9HX0RJU0FCTEVEICovCisKIHN0YXRpYyBjaGFyKiBw cm9ncmFtTmFtZSA9IDA7CiAKIHN0YXRpYyBpbnQgd2Via2l0WEVycm9yKERpc3BsYXkqIHhkaXNw bGF5LCBYRXJyb3JFdmVudCogZXJyb3IpCg==