98157 2012-10-02 07:31:27 -0700 [soup] Timeout support crashes if request already sent 2012-10-03 02:21:35 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 98055 P2 Normal --- 74802 1 d-r d-r alex cgarcia danw gustavo mrobinson rakuco webkit.review.bot oldest_to_newest 732637 0 d-r 2012-10-02 07:31:27 -0700 After writing more tests in bug 74802 I found an issue with cleanup for timeouts in ResourceHandleSoup. If a request was already sent out, then the timeout timer expires we start clearing the ResourceHandle - which leads to a RefPtr !m_deletionHasBegun failure when the sendRequestCallback is called. As a solution, I propose to reuse the d->m_cancelled flag for that purpose, and only destroy the handle when one of the progress callbacks is called - as before. 732944 1 166732 d-r 2012-10-02 12:26:25 -0700 Created attachment 166732 Patch 732954 2 mrobinson 2012-10-02 12:33:51 -0700 See also: https://bugs.webkit.org/show_bug.cgi?id=98055 Is this bug a duplicate? 733012 3 d-r 2012-10-02 13:27:36 -0700 (In reply to comment #2) > See also: https://bugs.webkit.org/show_bug.cgi?id=98055 > > Is this bug a duplicate? Good catch, thanks. *** This bug has been marked as a duplicate of bug 98055 *** 166732 2012-10-02 12:26:25 -0700 2012-10-03 02:21:35 -0700 Patch bug-98157-20121002212537.patch text/plain 2178 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ1ZGY2YTQyN2U4OTkw OTk2ZTVlYjBjYzBjODBjYTZkMmFiMGU2Ni4uMGQ4ODVmMzFhOTUyMDhhM2Y0NjhjMTFmNGFlNGNk MzkwZWY5MmQyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTAyICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg W3NvdXBdIFRpbWVvdXQgc3VwcG9ydCBjcmFzaGVzIGlmIHJlcXVlc3QgYWxyZWFkeSBzZW50Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODE1NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFmdGVyIGFkZGl0 aW9uYWwgdGVzdGluZyBpbiBidWcgNzQ4MDIgdGhlcmUgaXMgYW4gaXNzdWUgd2l0aCBjbGVhbnVw IGZvciB0aW1lb3V0cyBpbiBSZXNvdXJjZUhhbmRsZVNvdXAuCisgICAgICAgIElmIGEgcmVxdWVz dCB3YXMgYWxyZWFkeSBzZW50IG91dCwgYW5kIHRoZW4gdGhlIHRpbWVvdXQgdGltZXIgZXhwaXJl cyB3ZSBzdGFydCBjbGVhcmluZyB0aGUgUmVzb3VyY2VIYW5kbGUgLQorICAgICAgICB3aGljaCBs ZWFkcyB0byBhIFJlZlB0ciAhbV9kZWxldGlvbkhhc0JlZ3VuIGFzc2VydGlvbiBmYWlsdXJlCisg ICAgICAgIHdoZW4gdGhlIHNlbmRSZXF1ZXN0Q2FsbGJhY2sgaXMgY2FsbGVkLgorICAgICAgICBB cyBhIHNvbHV0aW9uLCBJIHByb3Bvc2UgdG8gcmV1c2UgdGhlIGQtPm1fY2FuY2VsbGVkIGZsYWcg Zm9yIHRoYXQgcHVycG9zZSwKKyAgICAgICAgYW5kIG9ubHkgZGVzdHJveSB0aGUgaGFuZGxlIHdo ZW4gb25lIG9mIHRoZSBwcm9ncmVzcyBjYWxsYmFja3MgaXMgY2FsbGVkIC0gYXMgdXN1YWwgZm9y IHRoZSBjYW5jZWxsZWQgY2FzZS4KKworICAgICAgICBUZXN0cyB3aWxsIGJlIHByb3ZpZGVkIGlu IGJ1ZyA3NDgwMi4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhh bmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVxdWVzdFRpbWVvdXRDYWxsYmFjayk6 CisKIDIwMTItMTAtMDIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW1dJTkNFXSBSZW1vdmUgRm9udFBsYXRmb3JtRGF0YTo6YXZlcmFnZUNoYXJXaWR0 aCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291 cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IGEzZmM0NDNmZGZhNmY1NzQ3ZjRjYTg2ZTQ5 M2Q5YTBlODI2YzVlOTkuLjk4NWRlZGUzNThhMDc2YzcxZjE0ZDI0ODk0ZDc1ZjlkYWE3YjhmOTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJj ZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291 cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0xMDAwLDEwICsxMDAwLDExIEBAIHN0YXRpYyBn Ym9vbGVhbiByZXF1ZXN0VGltZW91dENhbGxiYWNrKGdwb2ludGVyIGRhdGEpCiAgICAgUmVzb3Vy Y2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJuYWwoKTsKICAgICBSZXNvdXJj ZUhhbmRsZUNsaWVudCogY2xpZW50ID0gaGFuZGxlLT5jbGllbnQoKTsKIAorICAgIGhhbmRsZS0+ Y2FuY2VsKCk7CisKICAgICBSZXNvdXJjZUVycm9yIHRpbWVvdXRFcnJvcigiV2ViS2l0TmV0d29y a0Vycm9yIiwgZ1RpbWVvdXRFcnJvciwgZC0+bV9maXJzdFJlcXVlc3QudXJsKCkuc3RyaW5nKCks ICJSZXF1ZXN0IHRpbWVkIG91dCIpOwogICAgIHRpbWVvdXRFcnJvci5zZXRJc1RpbWVvdXQodHJ1 ZSk7CiAgICAgY2xpZW50LT5kaWRGYWlsKGhhbmRsZS5nZXQoKSwgdGltZW91dEVycm9yKTsKLSAg ICBjbGVhbnVwU291cFJlcXVlc3RPcGVyYXRpb24oaGFuZGxlLmdldCgpKTsKIAogICAgIHJldHVy biBGQUxTRTsKIH0K