<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>9815</bug_id>
          
          <creation_ts>2006-07-09 17:29:24 -0700</creation_ts>
          <short_desc>JavaScript TypeError loading Dean Edwards&apos; JS compressor/obfuscator</short_desc>
          <delta_ts>2007-01-28 18:50:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>418.x</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://dean.edwards.name/packer/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>HasReduction</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David Kilzer (:ddkilzer)">ddkilzer</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>allan28</cc>
    
    <cc>ggaren</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>48990</commentid>
    <comment_count>0</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2006-07-09 17:29:24 -0700</bug_when>
    <thetext>I got a type error when loading Dean Edwards&apos; JavaScript Compressor/Obfuscator (see URL).  This error needs to be reduced.

[22954] http://dean.edwards.name/packer/packer-p.js line 1: TypeError: Value undefined (result of expression c.valueOf.prototype.specialize) is not object.

Using Safari 2.0.4 (419.3) with locally-built WebKit r15267 with a WIP patch for Bug 9179 on Mac OS X 10.4.7 (8J135/PowerPC).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>56661</commentid>
    <comment_count>1</comment_count>
      <attachid>10808</attachid>
    <who name="">allan28</who>
    <bug_when>2006-09-27 14:51:02 -0700</bug_when>
    <thetext>Created attachment 10808
JS snippet demonstrating js bug

Looks to be problem with creating new from &quot;reference&quot;? &quot;new this.valueOf&quot; causes new object in Firefox but not Safari.
Reduced code from Dean Edwards ie7.js, which looks to use the same OO routines (the packer is obfuscated).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>36411</commentid>
    <comment_count>2</comment_count>
      <attachid>12291</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-07 20:38:30 -0800</bug_when>
    <thetext>Created attachment 12291
Test case

Wrapped Attachment 10808 in &lt;script&gt;&lt;/script&gt; tags.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>32263</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-26 16:01:47 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; Created an attachment (id=12291) [edit]
&gt; Test case
&gt; 
&gt; Wrapped Attachment 10808 [edit] in &lt;script&gt;&lt;/script&gt; tags.

Incorrect behavior prints &quot;undefined&quot; in the alert.

Correct behavior prints &quot;function() { }&quot; (on multiple lines) in the alert.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31493</commentid>
    <comment_count>4</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-28 08:32:43 -0800</bug_when>
    <thetext>It appears that assigning new Function() to a variable does not set it&apos;s prototype, while assigning an anonymous function does.  Thus if you change this line:

  ICommon.valueOf = new Function(&quot;return this&quot;);

to this:

  ICommon.valueOf = function(){ return this; };

the test case will work.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31466</commentid>
    <comment_count>5</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-28 11:07:42 -0800</bug_when>
    <thetext>This bug is in JavaScriptCore, and exists in shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037).

I also have a patch to fix it.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31467</commentid>
    <comment_count>6</comment_count>
      <attachid>12727</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-28 11:08:44 -0800</bug_when>
    <thetext>Created attachment 12727
Patch v1

Proposed fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31463</commentid>
    <comment_count>7</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-28 11:23:33 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; Created an attachment (id=12727) [edit]
&gt; Patch v1
&gt; Proposed fix.

Note that all JavaScriptCore tests and all layout tests pass with this change.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31285</commentid>
    <comment_count>8</comment_count>
      <attachid>12727</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-01-28 18:30:05 -0800</bug_when>
    <thetext>Comment on attachment 12727
Patch v1

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>31274</commentid>
    <comment_count>9</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-01-28 18:50:20 -0800</bug_when>
    <thetext>Committed revision 19203.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>10808</attachid>
            <date>2006-09-27 14:51:02 -0700</date>
            <delta_ts>2007-01-07 20:38:30 -0800</delta_ts>
            <desc>JS snippet demonstrating js bug</desc>
            <filename>oo.js</filename>
            <type>application/x-javascript</type>
            <size>361</size>
            <attacher>allan28</attacher>
            
              <data encoding="base64">ZnVuY3Rpb24gSUNvbW1vbigpIAp7Cn0KCklDb21tb24uc3BlY2lhbGl6ZSA9IGZ1bmN0aW9uKCkg
CnsKCXZhciBvYmpUZXN0ID0gbmV3IHRoaXMudmFsdWVPZjsKCS8vVGhpcyBkaWRuJ3QgY2F1c2Ug
YSBuZXcgSUNvbW1vbi4gV29ya3MgaW4gRmlyZWZveCwgbm90IFNhZmFyaQoJYWxlcnQob2JqVGVz
dC5zcGVjaWFsaXplKTsKfQoKSUNvbW1vbi52YWx1ZU9mID0gbmV3IEZ1bmN0aW9uKCJyZXR1cm4g
dGhpcyIpOwpJQ29tbW9uLnZhbHVlT2YucHJvdG90eXBlID0gCnsKCXNwZWNpYWxpemU6IGZ1bmN0
aW9uKCkgCgl7Cgl9Cn0KCmZ1bmN0aW9uIENvbW1vbigpIAp7Cn0KCnRoaXMuQ29tbW9uID0gSUNv
bW1vbi5zcGVjaWFsaXplKCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>12291</attachid>
            <date>2007-01-07 20:38:30 -0800</date>
            <delta_ts>2007-01-07 20:38:30 -0800</delta_ts>
            <desc>Test case</desc>
            <filename>bug-9815-test.html</filename>
            <type>text/html</type>
            <size>380</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">PHNjcmlwdD4KZnVuY3Rpb24gSUNvbW1vbigpIAp7Cn0KCklDb21tb24uc3BlY2lhbGl6ZSA9IGZ1
bmN0aW9uKCkgCnsKCXZhciBvYmpUZXN0ID0gbmV3IHRoaXMudmFsdWVPZjsKCS8vVGhpcyBkaWRu
J3QgY2F1c2UgYSBuZXcgSUNvbW1vbi4gV29ya3MgaW4gRmlyZWZveCwgbm90IFNhZmFyaQoJYWxl
cnQob2JqVGVzdC5zcGVjaWFsaXplKTsKfQoKSUNvbW1vbi52YWx1ZU9mID0gbmV3IEZ1bmN0aW9u
KCJyZXR1cm4gdGhpcyIpOwpJQ29tbW9uLnZhbHVlT2YucHJvdG90eXBlID0gCnsKCXNwZWNpYWxp
emU6IGZ1bmN0aW9uKCkgCgl7Cgl9Cn0KCmZ1bmN0aW9uIENvbW1vbigpIAp7Cn0KCnRoaXMuQ29t
bW9uID0gSUNvbW1vbi5zcGVjaWFsaXplKCk7Cjwvc2NyaXB0Pgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>12727</attachid>
            <date>2007-01-28 11:08:44 -0800</date>
            <delta_ts>2007-01-28 18:30:05 -0800</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-9815-v1.diff</filename>
            <type>text/plain</type>
            <size>4137</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTk4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDctMDEtMjggIERhdmlkIEtp
bHplciAgPGRka2lsemVyQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9OTgxNQorICAgICAgICAgIEphdmFTY3JpcHQgVHlwZUVycm9yIGxvYWRpbmcgRGVh
biBFZHdhcmRzJyBKUyBjb21wcmVzc29yL29iZnVzY2F0b3IKKworICAgICAgICBDcmVhdGluZyBh
IGZ1bmN0aW9uIHVzaW5nICduZXcgRnVuY3Rpb24oKScgd2FzIG5vdCBzZXR0aW5nIGl0cyBwcm90
b3R5cGUgd2l0aCB0aGUKKyAgICAgICAgc2FtZSBmbGFncyBhcyAnZnVuY3Rpb24oKSB7IH0nLgor
CisgICAgICAgIFRlc3Q6IGZhc3QvanMvZnVuY3Rpb24tcHJvdG90eXBlLmh0bWwKKworICAgICAg
ICAqIGtqcy9mdW5jdGlvbl9vYmplY3QuY3BwOgorICAgICAgICAoRnVuY3Rpb25PYmplY3RJbXA6
OmNvbnN0cnVjdCk6IENoYW5nZSBmbGFncyBmcm9tIERvbnRFbnVtfERvbnREZWxldGV8UmVhZE9u
bHkgdG8KKyAgICAgICAgSW50ZXJuYWx8RG9udERlbGV0ZSB0byBtYXRjaCBGdW5jRGVjbE5vZGU6
OnByb2Nlc3NGdW5jRGVjbCgpIGFuZAorICAgICAgICBGdW5jRXhwck5vZGU6OmV2YWx1YXRlKCkg
aW4ga2pzL25vZGVzLmNwcC4KKwogMjAwNy0wMS0yNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5A
YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCkluZGV4OiBKYXZh
U2NyaXB0Q29yZS9ranMvZnVuY3Rpb25fb2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny
aXB0Q29yZS9ranMvZnVuY3Rpb25fb2JqZWN0LmNwcAkocmV2aXNpb24gMTkxOTcpCisrKyBKYXZh
U2NyaXB0Q29yZS9ranMvZnVuY3Rpb25fb2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ1
LDcgKzI0NSw3IEBAIEpTT2JqZWN0KiBGdW5jdGlvbk9iamVjdEltcDo6Y29uc3RydWN0KEUKICAg
SlNPYmplY3QgKm9iakNvbnMgPSBleGVjLT5sZXhpY2FsSW50ZXJwcmV0ZXIoKS0+YnVpbHRpbk9i
amVjdCgpOwogICBKU09iamVjdCAqcHJvdG90eXBlID0gb2JqQ29ucy0+Y29uc3RydWN0KGV4ZWMs
TGlzdDo6ZW1wdHkoKSk7CiAgIHByb3RvdHlwZS0+cHV0KGV4ZWMsIGNvbnN0cnVjdG9yUHJvcGVy
dHlOYW1lLCBmaW1wLCBEb250RW51bXxEb250RGVsZXRlfFJlYWRPbmx5KTsKLSAgZmltcC0+cHV0
KGV4ZWMsIHByb3RvdHlwZVByb3BlcnR5TmFtZSwgcHJvdG90eXBlLCBEb250RW51bXxEb250RGVs
ZXRlfFJlYWRPbmx5KTsKKyAgZmltcC0+cHV0KGV4ZWMsIHByb3RvdHlwZVByb3BlcnR5TmFtZSwg
cHJvdG90eXBlLCBJbnRlcm5hbHxEb250RGVsZXRlKTsKICAgcmV0dXJuIGZpbXA7CiB9CiAKSW5k
ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu
Z2VMb2cJKHJldmlzaW9uIDE5MTk4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDEtMjggIERhdmlkIEtpbHplciAgPGRka2ls
emVyQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgLSBUZXN0IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05ODE1CisgICAgICAgICAgSmF2YVNjcmlwdCBUeXBlRXJyb3IgbG9hZGluZyBEZWFuIEVkd2Fy
ZHMnIEpTIGNvbXByZXNzb3Ivb2JmdXNjYXRvcgorCisgICAgICAgICogZmFzdC9qcy9mdW5jdGlv
bi1wcm90b3R5cGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2pzL2Z1bmN0
aW9uLXByb3RvdHlwZS5odG1sOiBBZGRlZC4KKwogMjAwNy0wMS0yNyAgRGF2aWQgS2lsemVyICA8
ZGRraWx6ZXJAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKG1pc3Np
bmcgcGl4ZWwgdGVzdCByZXN1bHRzKS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rp
b24tcHJvdG90eXBlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0
L2pzL2Z1bmN0aW9uLXByb3RvdHlwZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv
dXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLXByb3RvdHlwZS1leHBlY3RlZC50eHQJKHJldmlzaW9u
IDApCkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3RzIEJ1Z3ppbGxhIEJ1ZyA5ODE1OiBKYXZhU2NyaXB0
IFR5cGVFcnJvciBsb2FkaW5nIERlYW4gRWR3YXJkcycgSlMgY29tcHJlc3Nvci9vYmZ1c2NhdG9y
CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs
IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGFjdHVhbCBpcyAnZnVuY3Rp
b24gKCkgXG57XG59JworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP
TVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tcHJvdG90eXBlLmh0
bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi1wcm90b3R5cGUu
aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tcHJvdG90
eXBlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDYgQEAKKzxodG1sPgorPGhlYWQ+Cis8
bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxl
LmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj
cmlwdD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAg
bGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIGxheW91dFRlc3RDb250
cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBp
ZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4K
K2Rlc2NyaXB0aW9uKCJUZXN0cyBCdWd6aWxsYSBCdWcgOTgxNTogSmF2YVNjcmlwdCBUeXBlRXJy
b3IgbG9hZGluZyBEZWFuIEVkd2FyZHMnIEpTIGNvbXByZXNzb3Ivb2JmdXNjYXRvciIpOworCitm
dW5jdGlvbiBNeUNsYXNzKCkgCit7Cit9CisKK015Q2xhc3MucnVuVGVzdCA9IGZ1bmN0aW9uKCkg
Cit7CisgICAgdmFyIG9ialRlc3QgPSBuZXcgdGhpcy5mdW5jOworICAgIHJldHVybiBvYmpUZXN0
LmludGVybmFsRnVuYzsKK30KKworTXlDbGFzcy5mdW5jID0gbmV3IEZ1bmN0aW9uKCJyZXR1cm4g
dGhpcyIpOworCitNeUNsYXNzLmZ1bmMucHJvdG90eXBlID0gCit7CisgICAgaW50ZXJuYWxGdW5j
OiBmdW5jdGlvbigpIHsgfQorfQorCit2YXIgYWN0dWFsID0gIiIgKyBNeUNsYXNzLnJ1blRlc3Qo
KTsKK3Nob3VsZEJlKCJhY3R1YWwiLCAiJ2Z1bmN0aW9uICgpIFxcbntcXG59JyIpOworCitzdWNj
ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVz
b3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5s
YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l
KCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K
</data>
<flag name="review"
          id="4851"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>