98124 2012-10-02 01:03:24 -0700 Remove anonymous namespace from StyleBuilder.cpp for better debugging experience 2012-10-02 13:15:13 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov ap bweinstein cmarcelo darin joepeck keishi loislo macpherson menard pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 732390 0 yurys 2012-10-02 01:03:24 -0700 As Alexey and Darin pointed out in wkbug.com/98028 we should avoid anonymous namespaces as they complicate debugging and break some IDE's code assistance. Original problem is already resolved by picking more specific name that doesn't collide with other type names and the code can continue to reside in the WebCore namespace. 732407 1 166638 yurys 2012-10-02 01:14:52 -0700 Created attachment 166638 Patch 732445 2 166638 webkit.review.bot 2012-10-02 02:29:06 -0700 Comment on attachment 166638 Patch Clearing flags on attachment: 166638 Committed r130142: <http://trac.webkit.org/changeset/130142> 732446 3 webkit.review.bot 2012-10-02 02:29:10 -0700 All reviewed patches have been landed. Closing bug. 733002 4 ap 2012-10-02 13:15:13 -0700 Thank you! 166638 2012-10-02 01:14:52 -0700 2012-10-02 02:29:06 -0700 Patch bug-98124-20121002121404.patch text/plain 1577 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY4MzlmNmFlZWZiOTMz MzRkYWZkNGM5OWZmZTA0ZjNiZDNhZGNmZi4uNjM5MzI1NDVmYzk4ZWNiOWU0ZDljN2M2NDAxMzY1 NTdjNGMzN2JhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTAyICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBhbm9u eW1vdXMgbmFtZXNwYWNlIGZyb20gU3R5bGVCdWlsZGVyLmNwcCBmb3IgYmV0dGVyIGRlYnVnZ2lu ZyBleHBlcmllbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05ODEyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogY3NzL1N0eWxlQnVpbGRlci5jcHA6IHJlbW92ZWQgYW5vbnltb3VzIG5hbWVzcGFjZS4K KyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTEwLTAxICBHbGVubiBBZGFtcyAgPGdsZW5uQHNr eW5hdi5jb20+CiAKICAgICAgICAgQWRkIG90aGVyIDxzdHJpbmc+IHR5cGVkIHRva2VucyB0byBZ WURFQlVHIHRva2VuIG91dHB1dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl QnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVCdWlsZGVyLmNwcAppbmRleCAz YTI5MmQxYWQzOWZlODMxOTdiODJkNDI3YjI3NmMzNTA0NGRiYmYwLi5iZDA4NTcwMDhhZTA2YzAy M2Q1MDE3NzllMmQ0ODI2MDNjZDk0NWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv U3R5bGVCdWlsZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVCdWlsZGVyLmNw cApAQCAtNTEsOCArNTEsNiBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLW5hbWVzcGFjZSB7Ci0KIGVudW0gRXhwYW5kVmFsdWVCZWhhdmlvciB7U3VwcHJl c3NWYWx1ZSA9IDAsIEV4cGFuZFZhbHVlfTsKIHRlbXBsYXRlIDxFeHBhbmRWYWx1ZUJlaGF2aW9y IGV4cGFuZFZhbHVlLCBDU1NQcm9wZXJ0eUlEIG9uZSA9IENTU1Byb3BlcnR5SW52YWxpZCwgQ1NT UHJvcGVydHlJRCB0d28gPSBDU1NQcm9wZXJ0eUludmFsaWQsIENTU1Byb3BlcnR5SUQgdGhyZWUg PSBDU1NQcm9wZXJ0eUludmFsaWQsIENTU1Byb3BlcnR5SUQgZm91ciA9IENTU1Byb3BlcnR5SW52 YWxpZCwgQ1NTUHJvcGVydHlJRCBmaXZlID0gQ1NTUHJvcGVydHlJbnZhbGlkPgogY2xhc3MgQXBw bHlQcm9wZXJ0eUV4cGFuZGluZyB7CkBAIC0xNzgzLDggKzE3ODEsNiBAQCBwdWJsaWM6CiB9Owog I2VuZGlmCiAKLX0gLy8gbmFtZXNwYWNlCi0KIGNvbnN0IFN0eWxlQnVpbGRlciYgU3R5bGVCdWls ZGVyOjpzaGFyZWRTdHlsZUJ1aWxkZXIoKQogewogICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3R5 bGVCdWlsZGVyLCBzdHlsZUJ1aWxkZXJJbnN0YW5jZSwgKCkpOwo=