98111 2012-10-01 21:31:41 -0700 [chromium] Remove call to FinishAllRendering when in force-compositing-mode 2012-10-02 09:45:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vangelis vangelis jamesr webkit.review.bot oldest_to_newest 732252 0 vangelis 2012-10-01 21:31:41 -0700 Calling FinishAllRendering when setIsAcceleratedCompositingActive(false) is called is not necessary when we don't switch between accelerated and software compositing. FinishAllRendering make a synchronous glFinish call that blocks the renderer for tens of milliseconds and should be avoided when possible. 732265 1 166604 vangelis 2012-10-01 22:01:43 -0700 Created attachment 166604 Patch 732729 2 166604 webkit.review.bot 2012-10-02 09:45:12 -0700 Comment on attachment 166604 Patch Clearing flags on attachment: 166604 Committed r130178: <http://trac.webkit.org/changeset/130178> 732730 3 webkit.review.bot 2012-10-02 09:45:14 -0700 All reviewed patches have been landed. Closing bug. 166604 2012-10-01 22:01:43 -0700 2012-10-02 09:45:11 -0700 Patch bug-98111-20121001220041.patch text/plain 1833 vangelis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDRhM2VkZWM5ZTU2NDIyZGEzNjE2ZWI5M2Q3MWE1MWVkN2ViZDA5NmMuLjdkMzM4OGQ1ZjBhMmEw OTRkNjgyOWU4ZWU2YmY5ZTdkZGIyNTM5ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMTAtMDEgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBjYWxsIHRvIEZpbmlzaEFsbFJlbmRlcmlu ZyB3aGVuIGluIGZvcmNlLWNvbXBvc2l0aW5nLW1vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODExMQorCisgICAgICAgIEl0J3Mgbm90IG5lZWRl ZCBhbmQgbWFrZXMgdGhlIHJlbmRlcmVyIHN5bmNocm9ub3VzbHkgd2FpdCBmb3IgYSBnbEZpbmlz aAorICAgICAgICB0byBoYXBwZW4gaW4gdGhlIGdwdSBwcm9jZXNzLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnNldElzQWNjZWxlcmF0ZWRDb21wb3NpdGlu Z0FjdGl2ZSk6CisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA5LTI1ICBBbHBoYSBMYW0gIDxo Y2xhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUm9sbCBERVBTIGZvciBD aHJvbWl1bS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJ bXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRl eCAyNjFmN2MzNTdlOWE3OGI5MWYyYTdkM2FiZmQ5NGRiMmUyOGE5OGE1Li5lNzQzNWRhODUwZmY5 ZmFlNjQ5YzExMDAwZmFlN2E3OWQ5OGNlYjYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCkBAIC0zNzc2LDggKzM3NzYsOSBAQCB2b2lkIFdlYlZpZXdJbXBs OjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUoYm9vbCBhY3RpdmUpCiAgICAgaWYg KCFhY3RpdmUpIHsKICAgICAgICAgbV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUgPSBm YWxzZTsKICAgICAgICAgLy8gV2UgbmVlZCB0byBmaW5pc2ggYWxsIEdMIHJlbmRlcmluZyBiZWZv cmUgc2VuZGluZyBkaWREZWFjdGl2YXRlQ29tcG9zaXRvcigpIHRvIHByZXZlbnQKLSAgICAgICAg Ly8gZmxpY2tlcmluZyB3aGVuIGNvbXBvc2l0aW5nIHR1cm5zIG9mZi4KLSAgICAgICAgaWYgKG1f bGF5ZXJUcmVlVmlldykKKyAgICAgICAgLy8gZmxpY2tlcmluZyB3aGVuIGNvbXBvc2l0aW5nIHR1 cm5zIG9mZi4gVGhpcyBpcyBvbmx5IG5lY2Vzc2FyeSBpZiB3ZSdyZSBub3QgaW4KKyAgICAgICAg Ly8gZm9yY2UtY29tcG9zaXRpbmctbW9kZS4KKyAgICAgICAgaWYgKG1fbGF5ZXJUcmVlVmlldyAm JiAhcGFnZSgpLT5zZXR0aW5ncygpLT5mb3JjZUNvbXBvc2l0aW5nTW9kZSgpKQogICAgICAgICAg ICAgbV9sYXllclRyZWVWaWV3LT5maW5pc2hBbGxSZW5kZXJpbmcoKTsKICAgICAgICAgbV9jbGll bnQtPmRpZERlYWN0aXZhdGVDb21wb3NpdG9yKCk7CiAgICAgfSBlbHNlIGlmIChtX2xheWVyVHJl ZVZpZXcpIHsK