98106 2012-10-01 19:55:06 -0700 The static function 'deleteFileSystem' in the LocalFileSystem.cpp should have another name. 2012-10-01 21:42:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 91187 0 dw.im webkit-unassigned donggwan.kim gyuyoung.kim webkit.review.bot yutak oldest_to_newest 732225 0 dw.im 2012-10-01 19:55:06 -0700 The static function 'deleteFileSystem' in the LocalFilesystem.cpp should have another name, because there is a member function which has same name. That is the reason of the compile error. I'm preparing the patch now. 732244 1 166598 dw.im 2012-10-01 21:15:37 -0700 Created attachment 166598 patch 732256 2 166598 yutak 2012-10-01 21:37:37 -0700 Comment on attachment 166598 patch Looks legit. 732258 3 166598 webkit.review.bot 2012-10-01 21:42:01 -0700 Comment on attachment 166598 patch Clearing flags on attachment: 166598 Committed r130117: <http://trac.webkit.org/changeset/130117> 732259 4 webkit.review.bot 2012-10-01 21:42:05 -0700 All reviewed patches have been landed. Closing bug. 166598 2012-10-01 21:15:37 -0700 2012-10-01 21:42:01 -0700 patch patch_98106_1002.patch text/plain 3419 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODhkNjg3Li43NGRiYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTAtMDEgIERvbmd3b28gSm9zaHVhIEltICA8ZHcuaW1Ac2Ftc3VuZy5jb20+CisK KyAgICAgICAgVGhlIHN0YXRpYyBmdW5jdGlvbiAnZGVsZXRlRmlsZVN5c3RlbScgaW4gdGhlIExv Y2FsRmlsZVN5c3RlbS5jcHAgc2hvdWxkIGhhdmUgYW5vdGhlciBuYW1lLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgxMDYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGJ1aWxkIGVycm9yIG9jY3VycyBi ZWNhdXNlIHRoZXJlIGFyZSB0d28gZnVuY3Rpb25zIHdoaWNoIGhhdmUgc2FtZSBuYW1lIGluIHRo ZSBMb2NhbEZpbGVTeXN0ZW0uY3BwIGZpbGUuCisgICAgICAgIE9uZSBpcyBtZW1iZXIgZnVuY3Rp b24gb2YgdGhlIGNsYXNzLCBhbmQgdGhlIG90aGVyIGlzIGEgc3RhdGljIGZ1bmN0aW9uIHdoaWNo IGlzIGNhbGxlZCBieSB0aGUgbWVtYmVyIGZ1bmN0aW9uLgorICAgICAgICBTbywgSSd2ZSB0cmll ZCB0byBjaGFuZ2UgdGhlIG5hbWUgb2YgdGhlIHN0YXRpYyBmdW5jdGlvbiBmcm9tICdkZWxldGVG aWxlU3lzdGVtJyB0byAncGVyZm9ybURlbGV0ZUZpbGVTeXN0ZW0nLgorCisgICAgICAgIE5vIG5l dyBmdW5jdGlvbmFsaXR5LCBubyBuZXcgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMvZmlsZXN5 c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGVyZm9ybURlbGV0 ZUZpbGVTeXN0ZW0pOiBUaGUgbmFtZSBvZiBmdW5jdGlvbiBpcyBjaGFuZ2VkIGZyb20gJ2RlbGV0 ZUZpbGVTeXN0ZW0nLgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxGaWxlU3lzdGVtOjpyZXF1ZXN0 RmlsZVN5c3RlbSk6CisgICAgICAgIChXZWJDb3JlOjpMb2NhbEZpbGVTeXN0ZW06OmRlbGV0ZUZp bGVTeXN0ZW0pOgorCiAyMDEyLTEwLTAxICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJlbmFtZSBDYWxlbmRhclBpY2tlckVsZW1lbnQgdG8gUGlja2VySW5k aWNhdG9yRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lz dGVtL0xvY2FsRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0 ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcAppbmRleCBlMWM2ZjI4Li5kNTM0YjIwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNw cApAQCAtODIsNyArODIsNyBAQCBzdGF0aWMgdm9pZCBvcGVuRmlsZVN5c3RlbShTY3JpcHRFeGVj dXRpb25Db250ZXh0KiwgY29uc3QgU3RyaW5nJiBiYXNlUGF0aCwgY29ucwogICAgIEFzeW5jRmls ZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0oYmFzZVBhdGgsIGlkZW50aWZpZXIsIHR5cGUsIGNyZWF0 ZSwgY2FsbGJhY2tzKTsKIH0KIAotc3RhdGljIHZvaWQgZGVsZXRlRmlsZVN5c3RlbShTY3JpcHRF eGVjdXRpb25Db250ZXh0KiwgY29uc3QgU3RyaW5nJiBiYXNlUGF0aCwgY29uc3QgU3RyaW5nJiBp ZGVudGlmaWVyLCBGaWxlU3lzdGVtVHlwZSB0eXBlLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3Rl bUNhbGxiYWNrcz4gY2FsbGJhY2tzKQorc3RhdGljIHZvaWQgcGVyZm9ybURlbGV0ZUZpbGVTeXN0 ZW0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIGNvbnN0IFN0cmluZyYgYmFzZVBhdGgsIGNvbnN0 IFN0cmluZyYgaWRlbnRpZmllciwgRmlsZVN5c3RlbVR5cGUgdHlwZSwgUGFzc093blB0cjxBc3lu Y0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNhbGxiYWNrcykKIHsKICAgICBBc3luY0ZpbGVTeXN0ZW06 OmRlbGV0ZUZpbGVTeXN0ZW0oYmFzZVBhdGgsIGlkZW50aWZpZXIsIHR5cGUsIGNhbGxiYWNrcyk7 CiB9CkBAIC05NSw3ICs5NSw2IEBAIHZvaWQgTG9jYWxGaWxlU3lzdGVtOjpyZWFkRmlsZVN5c3Rl bShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBGaWxlU3lzdGVtCiAKIHZvaWQgTG9j YWxGaWxlU3lzdGVtOjpyZXF1ZXN0RmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBj b250ZXh0LCBGaWxlU3lzdGVtVHlwZSB0eXBlLCBsb25nIGxvbmcsIFBhc3NPd25QdHI8QXN5bmNG aWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MsIEZpbGVTeXN0ZW1TeW5jaHJvbm91c1R5cGUp CiB7Ci0gICAgLy8gRklYTUU6IFBhc3MgRmlsZVN5c3RlbVR5cGUgcGFyYW1ldGVyLgogICAgIC8v IEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0gY2FsbHMgY2FsbGJhY2tzIHN5bmNocm9u b3VzbHksIHNvIHRoZSBtZXRob2QgbmVlZHMgdG8gYmUgY2FsbGVkIGFzeW5jaHJvbm91c2x5Lgog ICAgIGNvbnRleHQtPnBvc3RUYXNrKGNyZWF0ZUNhbGxiYWNrVGFzaygmb3BlbkZpbGVTeXN0ZW0s IGZpbGVTeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5kYXRhYmFz ZUlkZW50aWZpZXIoKSwgdHlwZSwgdHJ1ZSwgY2FsbGJhY2tzKSk7CiB9CkBAIC0xMDMsNyArMTAy LDcgQEAgdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJlcXVlc3RGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXMKIHZvaWQgTG9jYWxGaWxlU3lzdGVtOjpkZWxl dGVGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEZpbGVTeXN0ZW1U eXBlIHR5cGUsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3Mp CiB7CiAgICAgLy8gQXN5bmNGaWxlU3lzdGVtOjpkZWxldGVGaWxlU3lzdGVtIGNhbGxzIGNhbGxi YWNrcyBzeW5jaHJvbm91c2x5LCBzbyB0aGUgbWV0aG9kIG5lZWRzIHRvIGJlIGNhbGxlZCBhc3lu Y2hyb25vdXNseS4KLSAgICBjb250ZXh0LT5wb3N0VGFzayhjcmVhdGVDYWxsYmFja1Rhc2soJmRl bGV0ZUZpbGVTeXN0ZW0sIGZpbGVzeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9y aWdpbigpLT5kYXRhYmFzZUlkZW50aWZpZXIoKSwgdHlwZSwgY2FsbGJhY2tzKTsKKyAgICBjb250 ZXh0LT5wb3N0VGFzayhjcmVhdGVDYWxsYmFja1Rhc2soJnBlcmZvcm1EZWxldGVGaWxlU3lzdGVt LCBmaWxlU3lzdGVtQmFzZVBhdGgoKSwgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ZGF0YWJh c2VJZGVudGlmaWVyKCksIHR5cGUsIGNhbGxiYWNrcykpOwogfQogCiB9IC8vIG5hbWVzcGFjZQo=