98101 2012-10-01 17:20:04 -0700 JSArray::unshiftCountSlowCase needs to clear array slots when adding space to end of array 2012-10-01 18:21:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 732153 0 msaboff 2012-10-01 17:20:04 -0700 The change made in r129676: <http://trac.webkit.org/changeset/129676> from https://bugs.webkit.org/show_bug.cgi?id=97691 needs to clear array slots between length and vectorLength when new slots are added to the end of an array. 732159 1 166580 msaboff 2012-10-01 17:26:48 -0700 Created attachment 166580 Patch 732184 2 166580 webkit.review.bot 2012-10-01 18:21:05 -0700 Comment on attachment 166580 Patch Clearing flags on attachment: 166580 Committed r130109: <http://trac.webkit.org/changeset/130109> 732185 3 webkit.review.bot 2012-10-01 18:21:07 -0700 All reviewed patches have been landed. Closing bug. 166580 2012-10-01 17:26:48 -0700 2012-10-01 18:21:05 -0700 Patch 98101.patch text/plain 4054 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMTAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEyLTEwLTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEpTQXJyYXk6OnVuc2hpZnRDb3VudFNsb3dDYXNlIG5lZWRzIHRvIGNsZWFyIGFycmF5IHNs b3RzIHdoZW4gYWRkaW5nIHNwYWNlIHRvIGVuZCBvZiBhcnJheQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgxMDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhcmVkIG5ldyBhcnJheSBlbnRyaWVzIHdo ZW4gYWRkaW5nIHRvIGVuZCBkdWUgdG8gc2hpZnRpbmcgY29udGVudHMgdG8gbG93ZXIgbWVtb3J5 LiAgQWxzbworICAgICAgICBjaGVjbmFnZWQgdGhlIG9yZGVyIG9mIG1vdmluZyBhcnJheSBjb250 ZW50cyBhbmQgbWV0YWRhdGEgaW4gdGhlIHNoaWZ0IGxlZnQgY2FzZSB0byBhdm9pZAorICAgICAg ICBjbG9iYmVyaW5nIHRoZSBtZXRhZGF0YSB3aXRoIGFycmF5IGNvbnRlbnRzLiAgT3B0aW1pemVk IHRoZSB0byBvbmx5IG1ha2UgYSBtZW1tb3ZlIGlmIHRoZQorICAgICAgICBjb3VudCBpcyBub24t emVyby4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBcnJheS5jcHA6CisgICAgICAgIChKU0M6OkpT QXJyYXk6OnVuc2hpZnRDb3VudFNsb3dDYXNlKToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6dW5z aGlmdENvdW50KToKKwogMjAxMi0xMC0wMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIEFkZHJlc3MgYSBGSVhNRSBpbiBKU0FycmF5Ojpzb3J0CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNpb24gMTI5ODE1KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMxMCwyMiArMzEwLDI4IEBAIGJvb2wgSlNBcnJheTo6dW5zaGlmdENvdW50U2xvd0Nh c2UoSlNHbG8KICAgICAgICAgLy8gSWYgd2UncmUgbW92aW5nIGNvbnRlbnRzIHdpdGhpbiB0aGUg c2FtZSBhbGxvY2F0aW9uLCB0aGUgcG9zdC1jYXBhY2l0eSBpcyBiZWluZyByZWR1Y2VkLgogICAg ICAgICBBU1NFUlQobmV3QWxsb2NCYXNlICE9IGJ1dHRlcmZseS0+YmFzZShzdHJ1Y3R1cmUoKSkg fHwgcG9zdENhcGFjaXR5IDwgc3RvcmFnZS0+dmVjdG9yTGVuZ3RoKCkgLSBsZW5ndGgpOwogICAg IH0KLSAgICAKKwogICAgIHVuc2lnbmVkIG5ld1ZlY3Rvckxlbmd0aCA9IHJlcXVpcmVkVmVjdG9y TGVuZ3RoICsgcG9zdENhcGFjaXR5OwogICAgIHVuc2lnbmVkIG5ld0luZGV4QmlhcyA9IG5ld1N0 b3JhZ2VDYXBhY2l0eSAtIG5ld1ZlY3Rvckxlbmd0aDsKIAogICAgIEJ1dHRlcmZseSogbmV3QnV0 dGVyZmx5ID0gQnV0dGVyZmx5Ojpmcm9tQmFzZShuZXdBbGxvY0Jhc2UsIG5ld0luZGV4Qmlhcywg cHJvcGVydHlDYXBhY2l0eSk7CiAKLSAgICBpZiAoYWRkVG9Gcm9udCkKKyAgICBpZiAoYWRkVG9G cm9udCkgeworICAgICAgICBBU1NFUlQoY291bnQgKyB1c2VkVmVjdG9yTGVuZ3RoIDw9IG5ld1Zl Y3Rvckxlbmd0aCk7CiAgICAgICAgIG1lbW1vdmUobmV3QnV0dGVyZmx5LT5hcnJheVN0b3JhZ2Uo KS0+bV92ZWN0b3IgKyBjb3VudCwgc3RvcmFnZS0+bV92ZWN0b3IsIHNpemVvZihKU1ZhbHVlKSAq IHVzZWRWZWN0b3JMZW5ndGgpOwotICAgIGVsc2UgaWYgKG5ld0FsbG9jQmFzZSAhPSBidXR0ZXJm bHktPmJhc2Uoc3RydWN0dXJlKCkpKQorICAgICAgICBtZW1tb3ZlKG5ld0J1dHRlcmZseS0+cHJv cGVydHlTdG9yYWdlKCkgLSBwcm9wZXJ0eVNpemUsIGJ1dHRlcmZseS0+cHJvcGVydHlTdG9yYWdl KCkgLSBwcm9wZXJ0eVNpemUsIHNpemVvZihKU1ZhbHVlKSAqIHByb3BlcnR5U2l6ZSArIHNpemVv ZihJbmRleGluZ0hlYWRlcikgKyBBcnJheVN0b3JhZ2U6OnNpemVGb3IoMCkpOworICAgIH0gZWxz ZSBpZiAoKG5ld0FsbG9jQmFzZSAhPSBidXR0ZXJmbHktPmJhc2Uoc3RydWN0dXJlKCkpKSB8fCAo bmV3SW5kZXhCaWFzICE9IHN0b3JhZ2UtPm1faW5kZXhCaWFzKSkgeworICAgICAgICBtZW1tb3Zl KG5ld0J1dHRlcmZseS0+cHJvcGVydHlTdG9yYWdlKCkgLSBwcm9wZXJ0eVNpemUsIGJ1dHRlcmZs eS0+cHJvcGVydHlTdG9yYWdlKCkgLSBwcm9wZXJ0eVNpemUsIHNpemVvZihKU1ZhbHVlKSAqIHBy b3BlcnR5U2l6ZSArIHNpemVvZihJbmRleGluZ0hlYWRlcikgKyBBcnJheVN0b3JhZ2U6OnNpemVG b3IoMCkpOwogICAgICAgICBtZW1tb3ZlKG5ld0J1dHRlcmZseS0+YXJyYXlTdG9yYWdlKCktPm1f dmVjdG9yLCBzdG9yYWdlLT5tX3ZlY3Rvciwgc2l6ZW9mKEpTVmFsdWUpICogdXNlZFZlY3Rvckxl bmd0aCk7CiAKLSAgICBtZW1tb3ZlKG5ld0J1dHRlcmZseS0+cHJvcGVydHlTdG9yYWdlKCkgLSBw cm9wZXJ0eVNpemUsIGJ1dHRlcmZseS0+cHJvcGVydHlTdG9yYWdlKCkgLSBwcm9wZXJ0eVNpemUs IHNpemVvZihKU1ZhbHVlKSAqIHByb3BlcnR5U2l6ZSArIHNpemVvZihJbmRleGluZ0hlYWRlcikg KyBBcnJheVN0b3JhZ2U6OnNpemVGb3IoMCkpOwotICAgIAorICAgICAgICBXcml0ZUJhcnJpZXI8 VW5rbm93bj4qIG5ld1ZlY3RvciA9IG5ld0J1dHRlcmZseS0+YXJyYXlTdG9yYWdlKCktPm1fdmVj dG9yOworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSByZXF1aXJlZFZlY3Rvckxlbmd0aDsgaSA8 IG5ld1ZlY3Rvckxlbmd0aDsgaSsrKQorICAgICAgICAgICAgbmV3VmVjdG9yW2ldLmNsZWFyKCk7 CisgICAgfQorCiAgICAgbmV3QnV0dGVyZmx5LT5hcnJheVN0b3JhZ2UoKS0+c2V0VmVjdG9yTGVu Z3RoKG5ld1ZlY3Rvckxlbmd0aCk7CiAgICAgbmV3QnV0dGVyZmx5LT5hcnJheVN0b3JhZ2UoKS0+ bV9pbmRleEJpYXMgPSBuZXdJbmRleEJpYXM7Ci0gICAgCisKICAgICBtX2J1dHRlcmZseSA9IG5l d0J1dHRlcmZseTsKIAogICAgIHJldHVybiB0cnVlOwpAQCAtNTQxLDYgKzU0Nyw4IEBAIGJvb2wg SlNBcnJheTo6dW5zaGlmdENvdW50KEV4ZWNTdGF0ZSogZXgKICAgICBBcnJheVN0b3JhZ2UqIHN0 b3JhZ2UgPSBlbnN1cmVBcnJheVN0b3JhZ2UoZXhlYy0+Z2xvYmFsRGF0YSgpKTsKICAgICB1bnNp Z25lZCBsZW5ndGggPSBzdG9yYWdlLT5sZW5ndGgoKTsKIAorICAgIEFTU0VSVChzdGFydEluZGV4 IDw9IGxlbmd0aCk7CisKICAgICAvLyBJZiB0aGUgYXJyYXkgY29udGFpbnMgaG9sZXMgb3IgaXMg b3RoZXJ3aXNlIGluIGFuIGFibm9ybWFsIHN0YXRlLAogICAgIC8vIHVzZSB0aGUgZ2VuZXJpYyBh bGdvcml0aG0gaW4gQXJyYXlQcm90b3R5cGUuCiAgICAgaWYgKGxlbmd0aCAhPSBzdG9yYWdlLT5t X251bVZhbHVlc0luVmVjdG9yIHx8IHN0b3JhZ2UtPmluU3BhcnNlTW9kZSgpKQpAQCAtNTY5LDcg KzU3Nyw3IEBAIGJvb2wgSlNBcnJheTo6dW5zaGlmdENvdW50KEV4ZWNTdGF0ZSogZXgKICAgICBp ZiAoc3RhcnRJbmRleCkgewogICAgICAgICBpZiAobW92ZUZyb250KQogICAgICAgICAgICAgbWVt bW92ZSh2ZWN0b3IsIHZlY3RvciArIGNvdW50LCBzdGFydEluZGV4ICogc2l6ZW9mKEpTVmFsdWUp KTsKLSAgICAgICAgZWxzZQorICAgICAgICBlbHNlIGlmIChsZW5ndGggLSBzdGFydEluZGV4KQog ICAgICAgICAgICAgbWVtbW92ZSh2ZWN0b3IgKyBzdGFydEluZGV4ICsgY291bnQsIHZlY3RvciAr IHN0YXJ0SW5kZXgsIChsZW5ndGggLSBzdGFydEluZGV4KSAqIHNpemVvZihKU1ZhbHVlKSk7CiAg ICAgfQogCg==